[10] RFR : JDK-8187074 : [TabPane] Support reordering of Tabs within a TabPane

Hi, Request you to review the following fix, Issue: https://bugs.openjdk.java.net/browse/JDK-8187074 Webrev: http://cr.openjdk.java.net/~arapte/fx/8187074/webrev.04/ Regards, Ambarish

Re: [OpenJDK 2D-Dev] RFR JDK-8184429: Path clipper added in Marlin2D & MarlinFX 0.8.0

And once we are happy with the 2D webrev, it should be pretty straight-forward to review it for FX. -- Kevin Phil Race wrote: I think they should be separate webrevs sent to the separate lists and you should start with 2D as I can then run the JDK regression tests on it. I know you can theor

Re: [10] RFR 8188062: Use Marlin renderer in JavaFX BasicStroke

OK, I'll do it tomorrow. -- Kevin Phil Race wrote: I am fine for Kevin to push this as is. -phil. On 11/08/2017 01:36 PM, Laurent Bourgès wrote: Kevin & Phil, Here is the updated webrev: http://cr.openjdk.java.net/~lbourges/marlinFX/marlinFX-8188062.1/

Re: [OpenJDK 2D-Dev] RFR JDK-8184429: Path clipper added in Marlin2D & MarlinFX 0.8.0

I think they should be separate webrevs sent to the separate lists and you should start with 2D as I can then run the JDK regression tests on it. I know you can theoretically run the open regression tests too (are you ?) but there are some random scattered closed regression tests that so far as

Re: [10] RFR 8188062: Use Marlin renderer in JavaFX BasicStroke

I am fine for Kevin to push this as is. -phil. On 11/08/2017 01:36 PM, Laurent Bourgès wrote: Kevin & Phil, Here is the updated webrev: http://cr.openjdk.java.net/~lbourges/marlinFX/marlinFX-8188062.1/ Changes: - wrapPath

Re: [OpenJDK 2D-Dev] RFR JDK-8184429: Path clipper added in Marlin2D & MarlinFX 0.8.0

Kevin & Phil, Some news on that issue: I successfully managed to finish the Path clipping support in Marlin 0.8.2 (release last week): https://github.com/bourgesl/marlin-renderer/releases/tag/v0.8.2 I fixed few remaining bugs in either Stroker (1) and in PathClipFilter (2) to have proper & tested

Re: [10] RFR 8188062: Use Marlin renderer in JavaFX BasicStroke

Kevin & Phil, Here is the updated webrev: http://cr.openjdk.java.net/~lbourges/marlinFX/marlinFX-8188062.1/ Changes: - wrapPath2d typo => wrapPath2D() - whitespace / braces in (D)TransformingPathConsumer2D As mentioned in my answer to Phil's review, I moved the CAP/JOIN constants into BasicStrok

Re: [10] Review request for 8185634, 8185634: Java Fx-Swing dialogs appearing behind main stage

Looks good. --Semyon On 11/07/2017 06:59 PM, Alexander Zvegintsev wrote: HI Semyon, Please see my answer to Dmitry Hi Dmitry, From my understanding JavaFX stage can't be easily integrated in JDK to support orderWindow() approach, addChildWindow() is a native(and the simplest) way to ma

Re: [10] Review request for 8185634, 8185634: Java Fx-Swing dialogs appearing behind main stage

The latest webrev, version 06, looks good to me now. Approved (although I am not a "R"eviewer for AWT). -- Kevin Alexander Zvegintsev wrote: HI Semyon, Please see my answer to Dmitry Hi Dmitry, From my understanding JavaFX stage can't be easily integrated in JDK to support orderWindow()