Re: RFR: 8211308: Support HTTP/2 in WebView

On Fri, 11 Oct 2019 06:18:38 GMT, Arunprasad Rajkumar wrote: > On Fri, 11 Oct 2019 06:07:14 GMT, Arunprasad Rajkumar > wrote: > >> The goal of this enhancement is to use new [HttpClient >> APIs](https://docs.oracle.com/en/java/javase/11/docs/api/java.net.http/java/net/http/HttpClient.html) >

Re: [Approved] RFR: 8226754: FX build fails using gradle 5.6+ or 6

On Tue, 8 Oct 2019 13:54:22 GMT, Kevin Rushforth wrote: > JBS issue: [JDK-8226754](https://bugs.openjdk.java.net/browse/JDK-8226754) > > As noted in the JBS bug, the JavaFX build fails with gradle 6 (as well as not > building correctly with 5.6 or later). > > The existing JavaFX build uses two

Re: RFR: 8211308: Support HTTP/2 in WebView

On Fri, 11 Oct 2019 06:07:14 GMT, Arunprasad Rajkumar wrote: > The goal of this enhancement is to use new [HttpClient > APIs](https://docs.oracle.com/en/java/javase/11/docs/api/java.net.http/java/net/http/HttpClient.html) > available from JDK 11. > > Reference: > [1] https://openjdk.java.net/

Re: [Rev 01] RFR: 8232158: [macOS] Fallback to command line tools if xcode is missing

The pull request has been updated with additional changes. Added commits: - 9b1f7286: 8232158: [macOS] Fallback to command line tools if xcode is missing Changes: - all: https://git.openjdk.java.net/jfx/pull/13/files - new: https://git.openjdk.java.net/jfx/pull/13/files/063

RFR: 8211308: Support HTTP/2 in WebView

The goal of this enhancement is to use new [HttpClient APIs](https://docs.oracle.com/en/java/javase/11/docs/api/java.net.http/java/net/http/HttpClient.html) available from JDK 11. Reference: [1] https://openjdk.java.net/groups/net/httpclient/intro.html [2] https://docs.oracle.com/en/java/javase

RFR: 8232158: [macOS] Fallback to command line tools if xcode is missing

8232158: [macOS] Fallback to command line tools if xcode is missing Commits: - 063d2f38: JDK-8232158: [macOS] Fallback to command line tools if xcode is missing Changes: https://git.openjdk.java.net/jfx/pull/13/files Webrev: https://webrevs.openjdk.java.net/jfx/13/webrev.00

Re: Skara transition: openjdk/jfx GitHub repo is ready to accept pull requests

1. The Skara bot sends email to the openjfx-dev mailing list as a reply to the RFR. Yes, this will lead to duplicate email for those on the mailing list who are following the PR thread. I can't think of any way to avoid this. 2. We don't need .hgignore any longer needed, but .hgtags has useful

Re: [Rev 01] RFR: 8207957: TableSkinUtils should not contain actual code implementation

On Wed, 9 Oct 2019 15:49:21 GMT, Nir Lisker wrote: > On Wed, 9 Oct 2019 12:25:26 GMT, Hadzic Samir wrote: > >> The pull request has been updated with additional changes. >> >> >> >> Added commits: >> - e846e51c: Remove TableColumn argument for resizeColumnToFitContent for >

Re: [Rev 01] RFR: 8207957: TableSkinUtils should not contain actual code implementation

On Wed, 9 Oct 2019 15:49:21 GMT, Nir Lisker wrote: > On Wed, 9 Oct 2019 12:25:26 GMT, Hadzic Samir wrote: > >> The pull request has been updated with additional changes. >> >> >> >> Added commits: >> - e846e51c: Remove TableColumn argument for resizeColumnToFitContent for >

Re: RFR: WIP: 8230231: font-family not updated in HTMLEditor

On Thu, 10 Oct 2019 12:19:18 GMT, Kevin Rushforth wrote: > On Thu, 10 Oct 2019 09:12:57 GMT, Hadzic Samir wrote: > >> On Wed, 9 Oct 2019 20:09:58 GMT, Kevin Rushforth wrote: >> >>> On Wed, 9 Oct 2019 16:09:58 GMT, Hadzic Samir wrote: >>> On Wed, 9 Oct 2019 16:09:07 GMT, Kevin Rushforth

Re: Skara transition: openjdk/jfx GitHub repo is ready to accept pull requests

Hi Kevin, A few questions and comments: 1. I'm getting double notifications from threads I'm subscribed to - one from GitHub and one from the bot, including notifications on my own comments. The Skara bot doesn't need to notify me on threads I'm subscribed to. 2. Are the hg files like hgignore an

Re: RFR: WIP: 8230231: font-family not updated in HTMLEditor

On Thu, 10 Oct 2019 09:12:57 GMT, Hadzic Samir wrote: > On Wed, 9 Oct 2019 20:09:58 GMT, Kevin Rushforth wrote: > >> On Wed, 9 Oct 2019 16:09:58 GMT, Hadzic Samir wrote: >> >>> On Wed, 9 Oct 2019 16:09:07 GMT, Kevin Rushforth wrote: >>> On Wed, 9 Oct 2019 16:09:06 GMT, Hadzic Samir wr

Re: Problem of compilation of OpenJFX

I don't see anything in your log that would explain the failure. What is the exact command to gradle that you are using? One thing to try is to use gradlew to run the exact version of gradle (5.3) that we use in production and do all of our testing with. Also, using the --info option might be

Re: [Rev 01] RFR: 8207957: TableSkinUtils should not contain actual code implementation

On Wed, 9 Oct 2019 15:49:21 GMT, Nir Lisker wrote: > On Wed, 9 Oct 2019 12:25:26 GMT, Hadzic Samir wrote: > >> The pull request has been updated with additional changes. >> >> >> >> Added commits: >> - e846e51c: Remove TableColumn argument for resizeColumnToFitContent for >

Re: RFR: WIP: 8230231: font-family not updated in HTMLEditor

On Wed, 9 Oct 2019 20:09:58 GMT, Kevin Rushforth wrote: > On Wed, 9 Oct 2019 16:09:58 GMT, Hadzic Samir wrote: > >> On Wed, 9 Oct 2019 16:09:07 GMT, Kevin Rushforth wrote: >> >>> On Wed, 9 Oct 2019 16:09:06 GMT, Hadzic Samir wrote: >>> Fix for https://github.com/javafxports/openjdk-jfx

Re: [Rev 02] RFR: 8207957: TableSkinUtils should not contain actual code implementation

The pull request has been updated with additional changes. Added commits: - 49abc7c7: Add space and update Javadoc for tableColumnHeader and NestedTableColumnHeader Changes: - all: https://git.openjdk.java.net/jfx/pull/6/files - new: https://git.openjdk.java.net/jfx/pull/6

Re: [Rev 01] RFR: 8207957: TableSkinUtils should not contain actual code implementation

On Wed, 9 Oct 2019 15:49:21 GMT, Nir Lisker wrote: > On Wed, 9 Oct 2019 12:25:26 GMT, Hadzic Samir wrote: > >> The pull request has been updated with additional changes. >> >> >> >> Added commits: >> - e846e51c: Remove TableColumn argument for resizeColumnToFitContent for >