Re: [Rev 01] RFR: 8237372: NullPointerException in TabPaneSkin.stopDrag

2020-01-23 Thread Robert Lichtenberger
> Test simulates a single mouse-released event. > Fix simply guards against the null case. The pull request has been updated with 1 additional commit. - Added commits: - 30290116: 8237372: NullPointerException in TabPaneSkin.stopDrag Changes: - all: https://git.openjdk.java.net/j

Re: [Rev 01] RFR: 8237372: NullPointerException in TabPaneSkin.stopDrag

2020-01-23 Thread Robert Lichtenberger
On Wed, 22 Jan 2020 08:01:49 GMT, Ambarish Rapte wrote: >> The pull request has been updated with 1 additional commit. > > modules/javafx.controls/src/main/java/javafx/scene/control/skin/TabPaneSkin.java > line 2216: > >> 2215: // Animate tab header being dragged to its final position.

Re: "Internal review ID : 9062887" (Re: FXMLLoader: not supplying filename to script engine, not supplying event object as argument to script

2020-01-23 Thread Anthony Vanelverdinghe
On 22/01/2020 18:52, Rony G. Flatscher wrote: Hi Anthony, On 22.01.2020 17:07, Anthony Vanelverdinghe wrote: Your issue has been converted into a JDK issue, with your testcase attached [1]. Thank you *very* much for this information! Normally you should’ve received an e-mail at the time of

Re: [Integrated] RFR: 8157224: isNPOTSupported check is too strict

2020-01-23 Thread Kevin Rushforth
Changeset: f5ee9631 Author:Jose Pereda Committer: Kevin Rushforth Date: 2020-01-23 14:36:36 + URL: https://git.openjdk.java.net/jfx/commit/f5ee9631 8157224: isNPOTSupported check is too strict Reviewed-by: kcr ! modules/javafx.graphics/src/main/java/com/sun/prism/es2/ES2Pipe

Re: RFR: WIP: 8236651: Simplify and update glass gtk backend

2020-01-23 Thread Thiago Milczarek Sayao
On Tue, 14 Jan 2020 11:30:49 GMT, Thiago Milczarek Sayao wrote: >> I understand. Will do that when the code works 100%. I have submitted the PR >> to avoid duplicated efforts and let people test it (if anyone is willing). > > Sizing and positioning completed and fairly tested. > > Will look i

Machine hangs when build with -PCOMPILE_WEBKIT=true

2020-01-23 Thread Thiago Milczarek Sayao
Hi, I have tried on different machines - they totally hang or present a fatal compiler error when compiling webkit. Sometimes (rarely) it works. This is on Ubuntu 18.04.3. Anyone has got this problem and found a solution? Cheers.

Re: RFR: 8157224: isNPOTSupported check is too strict

2020-01-23 Thread Kevin Rushforth
On Thu, 23 Jan 2020 13:02:42 GMT, Jose Pereda wrote: > This PR enables support for 3D on iOS devices, as they use OpenGL ES 2.0, > which has (limited) support for npot support. Marked as reviewed by kcr (Lead). - PR: https://git.openjdk.java.net/jfx/pull/92

RFR: 8157224: isNPOTSupported check is too strict

2020-01-23 Thread Jose Pereda
This PR enables support for 3D on iOS devices, as they use OpenGL ES 2.0, which has (limited) support for npot support. - Commits: - 1bef8cf6: Enable 3D support on iOS Changes: https://git.openjdk.java.net/jfx/pull/92/files Webrev: https://webrevs.openjdk.java.net/jfx/92/webrev.00

Re: [Rev 14] RFR: WIP: 8236651: Simplify and update glass gtk backend

2020-01-23 Thread Thiago Milczarek Sayao
> This proposed change does the following: > > - Ports DND target to use GTK reducing code size and adding extra text / > image formats (such as .gif); > - Use gtk signals instead of gdk events (also to reduce code size); > - Simplifies geometry (sizing/positioning) with a more straightforward co

Re: [Rev 02] RFR: 8232824: Removing TabPane with strong referenced content causes memory leak from weak one

2020-01-23 Thread Kevin Rushforth
On Thu, 23 Jan 2020 12:51:59 GMT, Ambarish Rapte wrote: >> This PR is a fix for >> [JDK-8232824](https://bugs.openjdk.java.net/browse/JDK-8232824) >> This issue is regression of >> [JDK-8187074](https://bugs.openjdk.java.net/browse/JDK-8187074). >> >> Issue. >> - `Parent.viewOrderChildren` is

Re: RFR: 8232824: Removing TabPane with strong referenced content causes memory leak from weak one

2020-01-23 Thread Ambarish Rapte
On Wed, 22 Jan 2020 23:58:29 GMT, Kevin Rushforth wrote: >>> >>> >>> The fix looks good. I'll take a closer look at the unit test later. >>> >>> Speaking of tests...since the addition of the `TabPane` reordering logic >>> was a victim of the already-existing leak in the `viewOrderChildren` li

Re: [Rev 02] RFR: 8232824: Removing TabPane with strong referenced content causes memory leak from weak one

2020-01-23 Thread Ambarish Rapte
> This PR is a fix for > [JDK-8232824](https://bugs.openjdk.java.net/browse/JDK-8232824) > This issue is regression of > [JDK-8187074](https://bugs.openjdk.java.net/browse/JDK-8187074). > > Issue. > - `Parent.viewOrderChildren` is a list of children sorted according to view > order. > - `Parent