Re: [Rev 03] RFR: 8196586: Remove use of deprecated finalize methods from javafx property objects

On Thu, 20 Feb 2020 20:43:22 GMT, Kevin Rushforth wrote: >> This patch removes the `finalize` methods from the `Property` classes in the >> `javafx.base` module. >> >> The `{Boolean,Double,Float,Int,Long}Property` classes each have a pair of >> methods -- `asObject` and `xProperty` --

Re: RFR: 8236832: [macos 10.15] JavaFX Application hangs on video play on Cata…

On Wed, 26 Feb 2020 03:39:49 GMT, Alexander Matveev wrote: > https://bugs.openjdk.java.net/browse/JDK-8236832 > > - This issue most likely caused by changes in AVFoundation APIs on macOS > 10.15. > - Getting currentTime from AVPlayer was blocked if it is done from > ProcessAudioTap callback

Re: RFR: 8185886: Improve scrolling performance of TableView and TreeTableView

On Wed, 26 Feb 2020 10:07:02 GMT, Jeanette Winzenburg wrote: >> Hmm .. personally, I would consider changing such a basic (and probably >> highly optimized) implementation used all over the framework is a very high >> risk change that at the worst outcome would detoriate internal and external

Re: Ad suggested test unit for "JDK-8234959 FXMLLoader does not populate ENGINE_SCOPE Bindings with FILENAME and ARGV"

If you want a preliminary review of a WIP PR, then yes, announcing it here is fine. -- Kevin On 2/26/2020 7:53 AM, Rony G. Flatscher wrote: After studying [1], not sure whether one is supposed to announce a WIP here or not, so in doubt also announcing the URL for the suggested test unit

Re: RFR: 8238650: Allow to override buildDate with SOURCE_DATE_EPOCH

On Wed, 29 Jan 2020 08:58:47 GMT, Bernhard M. Wiedemann wrote: > Allow to override buildDate with `SOURCE_DATE_EPOCH` > in order to make builds reproducible. > See https://reproducible-builds.org/ for why this is good > and https://reproducible-builds.org/specs/source-date-epoch/ > for the

Re: RFR: 8234959: FXMLLoader does not populate ENGINE_SCOPE Bindings with FILENAME and ARGV

On Tue, 25 Feb 2020 13:54:25 GMT, Kevin Rushforth wrote: >> Sorry, mixed up the link with the test unit WIP! :( >> >> This is the correct link with the explanatory text related to this suggested >> fix. Posted [1] which explains the problem and the suggested solution for >> discussion. >>

Re: [Rev 02] RFR: 8212034: Potential memory leaks in jpegLoader.c in error case

On Mon, 10 Feb 2020 13:27:27 GMT, Ambarish Rapte wrote: >> Memory allocated in initDecompressor() and decompressIndirect() is not freed >> in error case. >> In error case, >> 1. Allocated memory should be freed. >> 2. Appropriate de-initialization jpeg library calls should be added. >> >>

Re: RFR: 8236832: [macos 10.15] JavaFX Application hangs on video play on Cata…

On Wed, 26 Feb 2020 19:51:38 GMT, Kevin Rushforth wrote: >> https://bugs.openjdk.java.net/browse/JDK-8236832 >> >> - This issue most likely caused by changes in AVFoundation APIs on macOS >> 10.15. >> - Getting currentTime from AVPlayer was blocked if it is done from >> ProcessAudioTap

Re: RFR: 8236832: [macos 10.15] JavaFX Application hangs on video play on Cata…

On Wed, 26 Feb 2020 03:39:49 GMT, Alexander Matveev wrote: > https://bugs.openjdk.java.net/browse/JDK-8236832 > > - This issue most likely caused by changes in AVFoundation APIs on macOS > 10.15. > - Getting currentTime from AVPlayer was blocked if it is done from > ProcessAudioTap callback

Re: Ad suggested test unit for "JDK-8234959 FXMLLoader does not populate ENGINE_SCOPE Bindings with FILENAME and ARGV"

After studying [1], not sure whether one is supposed to announce a WIP here or not, so in doubt also announcing the URL for the suggested test unit (part of the systemTests) for those interested in checking it out: .  To run the systemTests tests only

Re: Request for adding my github userid ..

Yeah, he did. ;) On 22.02.2020 17:58, Kevin Rushforth wrote: You should be all set now. Dalibor will likely take care of this early next week. -- Kevin On 2/22/2020 8:42 AM, Rony G. Flatscher wrote: On 22.02.2020 17:33, Philip Race wrote: What openjdk ID would this be associated with ?

Re: RFR: 8185886: Improve scrolling performance of TableView and TreeTableView

On Wed, 26 Feb 2020 09:49:04 GMT, Jeanette Winzenburg wrote: >> Even though the order of notifications is unspecified, the following tests >> fail if we use a HashMap vs LinkedHashMap i.e. the notifications are not in >> order of registration: >> >> test.javafx.scene.control.TableViewTest >

Re: RFR: 8185886: Improve scrolling performance of TableView and TreeTableView

On Tue, 25 Feb 2020 14:06:23 GMT, dannygonzalez wrote: >> I think that a starting point would be to decide on a spec for the listener >> notification order: is it specified by their registration order, or that is >> it unspecified, in which case we can take advantage of this for better >>