Re: [Rev 06] RFR: 8236259: MemoryLeak in ProgressIndicator

2020-03-12 Thread Ambarish Rapte
On Thu, 12 Mar 2020 15:54:23 GMT, Florian Kirmaier wrote: >> Hi everyone, >> >> ticket: https://bugs.openjdk.java.net/browse/JDK-8236259 >> >> The fix itself is quite straight forward. >> It basically just removed the listener which causes the leak. >> >> The unit-test for the fix is a bit mo

Re: [Rev 28] RFR: 8236651: Simplify and update glass gtk backend

2020-03-12 Thread Thiago Milczarek Sayao
> This proposed change does the following: > > - Ports DND target to use GTK reducing code size and adding extra text / > image formats (such as .gif); > - Use gtk signals instead of gdk events (also to reduce code size); > - Simplifies geometry (sizing/positioning) with a more straightforward co

Re: JDK-8177945 : Single cell selection flickers when adding data to TableView

2020-03-12 Thread David Grieve
This fix causes several unit tests to fail. From: David Grieve Sent: Tuesday, March 10, 2020 12:48 PM To: David Grieve ; Danny Gonzalez Cc: openjfx-dev@openjdk.java.net Subject: RE: JDK-8177945 : Single cell selection flickers when adding data to TableView The

Proposed schedule for JavaFX 15

2020-03-12 Thread Kevin Rushforth
Here is the proposed schedule for JavaFX 15. RDP1: Jul 2, 2020 (aka “feature freeze”) RDP2: Jul 30, 2020 Freeze: Aug 20, 2020 GA: September 8, 2020 We plan to fork a jfx15 stabilization branch at RDP1. The GA date is expected to be one week ahead of JDK 15, matching what we did for 14. As a s

Re: [Rev 06] RFR: 8236259: MemoryLeak in ProgressIndicator

2020-03-12 Thread Kevin Rushforth
On Thu, 12 Mar 2020 15:54:23 GMT, Florian Kirmaier wrote: >> Hi everyone, >> >> ticket: https://bugs.openjdk.java.net/browse/JDK-8236259 >> >> The fix itself is quite straight forward. >> It basically just removed the listener which causes the leak. >> >> The unit-test for the fix is a bit mo

Re: [Rev 04] RFR: 8236259: MemoryLeak in ProgressIndicator

2020-03-12 Thread Florian Kirmaier
On Wed, 11 Mar 2020 12:38:48 GMT, Ambarish Rapte wrote: >> Florian Kirmaier has updated the pull request incrementally with one >> additional commit since the last revision: >> >> JDK-8200224 >> cleaned up code based on code review > > tests/system/src/test/java/test/javafx/scene/control/Pr

Re: [Rev 06] RFR: 8236259: MemoryLeak in ProgressIndicator

2020-03-12 Thread Florian Kirmaier
> Hi everyone, > > ticket: https://bugs.openjdk.java.net/browse/JDK-8236259 > > The fix itself is quite straight forward. > It basically just removed the listener which causes the leak. > > The unit-test for the fix is a bit more complicated. > > I added a library JMemoryBuddy https://github.co

Re: [Rev 05] RFR: 8236259: MemoryLeak in ProgressIndicator

2020-03-12 Thread Florian Kirmaier
> Hi everyone, > > ticket: https://bugs.openjdk.java.net/browse/JDK-8236259 > > The fix itself is quite straight forward. > It basically just removed the listener which causes the leak. > > The unit-test for the fix is a bit more complicated. > > I added a library JMemoryBuddy https://github.co

Re: [Rev 04] RFR: 8235480: Regression: [RTL] Arrow keys navigation doesn't respect TableView orientation

2020-03-12 Thread Jeanette Winzenburg
On Fri, 6 Mar 2020 11:47:42 GMT, Ajit Ghaisas wrote: >> Bug : https://bugs.openjdk.java.net/browse/JDK-8235480 >> >> Fix : Added the missed out RTL checks to the key mappings in >> TableViewBehaviorBase class. >> >> Testing : Modified unit tests in TableViewKeyInputTest to take orientation >>

Re: [Rev 04] RFR: 8235480: Regression: [RTL] Arrow keys navigation doesn't respect TableView orientation

2020-03-12 Thread Jeanette Winzenburg
On Fri, 6 Mar 2020 21:38:15 GMT, Kevin Rushforth wrote: >> Ajit Ghaisas has updated the pull request incrementally with one additional >> commit since the last revision: >> >> extra space removed > > I think the fix looks good and the approach you took for the new test looks > good to me. If

Re: [Rev 04] RFR: 8236259: MemoryLeak in ProgressIndicator

2020-03-12 Thread Jeanette Winzenburg
On Wed, 11 Mar 2020 12:51:12 GMT, Kevin Rushforth wrote: >> modules/javafx.controls/src/main/java/javafx/scene/control/skin/ProgressIndicatorSkin.java >> line 550: >> >>> 549: } >>> 550: >>> 551: private void setFillOverride(Paint fillOverride) { >> >> The issue can be alternat

RFR: 8239107: Update libjpeg to version 9d

2020-03-12 Thread Ambarish Rapte
Currently we use IJG libjpeg version 9c released on 14-Jan-2018 We should update the libjpeg to latest version [9d](http://www.ijg.org/) released on 12-Jan-2020 reference: https://jpegclub.org/reference/reference-sources/ - Commit messages: - [WIP] 8239107: Update libjpeg to versio