Re: Build instructions for Ubuntu 20.04

2020-03-23 Thread Nir Lisker
Updated On Tue, Mar 24, 2020 at 3:26 AM Thiago Milczarek Sayao < thiago.sa...@clamed.com.br> wrote: > Hi, > > Can someone update > https://wiki.openjdk.java.net/display/OpenJFX/Building+OpenJFX for Ubuntu > 20.04? > > > 1) libavformat-ffmpeg57 -> libavformat58 > > 2) Need to add libxxf86vm-dev

RFR: 8241476: Linux build warning issued on updated compilers (Ubuntu 18.04.4 / 20.04)

2020-03-23 Thread Thiago Milczarek Sayao
Simple fix to remove annoying warnings. - Commit messages: - Remove build warning - Merge pull request #7 from openjdk/master - Merge pull request #6 from openjdk/master - Merge pull request #5 from openjdk/master - Merge pull request #4 from openjdk/master Changes:

RFR: 8241474: Build failing on Ubuntu 20.04

2020-03-23 Thread Thiago Milczarek Sayao
Small fix for building on ubuntu 20.04. - Commit messages: - Fix build on 20.04 - Merge pull request #7 from openjdk/master - Merge pull request #6 from openjdk/master - Merge pull request #5 from openjdk/master - Merge pull request #4 from openjdk/master Changes:

Build instructions for Ubuntu 20.04

2020-03-23 Thread Thiago Milczarek Sayao
Hi, Can someone update https://wiki.openjdk.java.net/display/OpenJFX/Building+OpenJFX for Ubuntu 20.04? 1) libavformat-ffmpeg57 -> libavformat58 2) Need to add libxxf86vm-dev Thanks

Re: [Rev 02] RFR: 8240692: Cleanup of the javafx property objects

2020-03-23 Thread Kevin Rushforth
On Tue, 24 Mar 2020 00:06:21 GMT, Kevin Rushforth wrote: >> Nir Lisker has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Re-added newline at the end > > Marked as reviewed by kcr (Lead). Given that this PR is now just a cleanup fix, it

Re: [Rev 02] RFR: 8240692: Cleanup of the javafx property objects

2020-03-23 Thread Nir Lisker
> A simple readability cleanup for the files that were changed in #113. > > Note that the boolean property has an `instanceof` check that doesn't exist > in the other properties. Nir Lisker has updated the pull request incrementally with one additional commit since the last revision:

Re: [Rev 02] RFR: 8240692: Cleanup of the javafx property objects

2020-03-23 Thread Kevin Rushforth
On Tue, 24 Mar 2020 00:07:04 GMT, Nir Lisker wrote: >> A simple readability cleanup for the files that were changed in #113. >> >> Note that the boolean property has an `instanceof` check that doesn't exist >> in the other properties. > > Nir Lisker has updated the pull request incrementally

Re: RFR: 8234471: Canvas in webview displayed with wrong scale on Windows

2020-03-23 Thread Kevin Rushforth
On Mon, 6 Jan 2020 04:42:54 GMT, Guru Hb wrote: >> This bug can be reproduced when the screen resolution is at 125%, 150% and >> 175% for Windows, which correpsonds to >> `pixelScale` values of 1.25, 1.5 and 1.75, respectively. >> Issue: The rectangle inside canvas is rendered on `pixelScale`

Re: RFR: 8236840: Memory leak when switching ButtonSkin

2020-03-23 Thread Kevin Rushforth
On Mon, 23 Mar 2020 07:26:46 GMT, Ambarish Rapte wrote: > ButtonSkin adds a `ChangeListener` to `Control.sceneProperty()` which results > in leaking the `ButtonSkin` itself when > the `Button`'s skin is changed to a new `ButtonSkin`. Using a > `WeakChangeListener` instead of `ChangeListener`

Re: RFR: 8241455: ChoiceBox - memory leak on replacing selectionModel

2020-03-23 Thread Kevin Rushforth
On Mon, 23 Mar 2020 23:45:21 GMT, Kevin Rushforth wrote: >> ChoiceBox leaves a memory leak when replacing the selectionModel. Culprit is >> ChoiceBoxSelectionModel which registers >> listener with strong references. Fix is to change these to weak references. >> Added test that fails before and

Re: RFR: 8241455: ChoiceBox - memory leak on replacing selectionModel

2020-03-23 Thread Kevin Rushforth
On Mon, 23 Mar 2020 16:32:16 GMT, Jeanette Winzenburg wrote: > ChoiceBox leaves a memory leak when replacing the selectionModel. Culprit is > ChoiceBoxSelectionModel which registers > listener with strong references. Fix is to change these to weak references. > Added test that fails before and

Re: [Rev 07] RFR: 8235480: Regression: [RTL] Arrow keys navigation doesn't respect TableView orientation

2020-03-23 Thread Jeanette Winzenburg
On Tue, 17 Mar 2020 07:38:45 GMT, Ajit Ghaisas wrote: >> Bug : https://bugs.openjdk.java.net/browse/JDK-8235480 >> >> Fix : Added the missed out RTL checks to the key mappings in >> TableViewBehaviorBase class. >> >> Testing : Added a test to take NodeOrientation as a parameter and test >>

Re: RFR: 8089828: RTL Orientation, the flag of a mnemonic is not placed under the mnemonic letter.

2020-03-23 Thread Kevin Rushforth
On Mon, 23 Mar 2020 06:36:26 GMT, Ajit Ghaisas wrote: > **Bug :** > https://bugs.openjdk.java.net/browse/JDK-8089828 > > **Root Cause :** > RIGHT_TO_LEFT NodeOrientation was not considered during mnemonic position > calculation. > > **Fix :** > Corrected code to consider RIGHT_TO_LEFT

Re: RFR: 8089134: [2D traversal, RTL] TraversalEngine only handles left/right key traversal correctly in RTL for top-level engine in ToolBar

2020-03-23 Thread Kevin Rushforth
On Wed, 18 Mar 2020 15:13:40 GMT, Ajit Ghaisas wrote: > **Issue** > https://bugs.openjdk.java.net/browse/JDK-8089134 > > **Fix** > Added a fix to modify selection direction based on NodeOrientation of the > ToolBar. > > **Testing** > Added a unit test to test common focus movement scenarios

Re: [Rev 07] RFR: 8235480: Regression: [RTL] Arrow keys navigation doesn't respect TableView orientation

2020-03-23 Thread Kevin Rushforth
On Tue, 17 Mar 2020 07:38:45 GMT, Ajit Ghaisas wrote: >> Bug : https://bugs.openjdk.java.net/browse/JDK-8235480 >> >> Fix : Added the missed out RTL checks to the key mappings in >> TableViewBehaviorBase class. >> >> Testing : Added a test to take NodeOrientation as a parameter and test >>

Re: [Rev 01] RFR: 8240692: Cleanup of the javafx property objects

2020-03-23 Thread Kevin Rushforth
On Mon, 23 Mar 2020 05:32:29 GMT, Nir Lisker wrote: >> A simple readability cleanup for the files that were changed in #113. >> >> Note that the boolean property has an `instanceof` check that doesn't exist >> in the other properties. > > Nir Lisker has updated the pull request incrementally

Re: [Rev 02] RFR: 8234959: FXMLLoader does not populate ENGINE_SCOPE Bindings with FILENAME and ARGV

2020-03-23 Thread Kevin Rushforth
On Sat, 21 Mar 2020 19:19:18 GMT, Kevin Rushforth wrote: >> Rony G. Flatscher has updated the pull request incrementally with one >> additional commit since the last revision: >> >> corrected wrong test string > > The fix looks good. I left a few comments on the test. One of them is >

RFR: 8241455: ChoiceBox - memory leak on replacing selectionModel

2020-03-23 Thread Jeanette Winzenburg
ChoiceBox leaves a memory leak when replacing the selectionModel. Culprit is ChoiceBoxSelectionModel which registers listener with strong references. Fix is to change these to weak references. Added test that fails before and passes after the test. for convenience, the bug reference

Re: Behavior of jumpTo

2020-03-23 Thread Kevin Rushforth
I agree. If jumpTo took a relative (delta) Duration then it would make sense for it to take the direction of rate into account. Given that it is an absolute position, the current behavior just seems wrong. The spec says:     Jumps to a given position in this |Animation| I would interpret

Re: RFR: 8240466: AppJSCallback* apps launched by ModuleLauncherTest intermittently hang

2020-03-23 Thread Kevin Rushforth
WebKit has never used Nashorn so this is unrelated to the impending Nashorn removal. -- Kevin On 3/23/2020 5:49 AM, Eric Bresie wrote: This may be a little off topic but given this is a Javascript concern, is this (or will this) be impacted by Nashhorns depreciation (as of jdk11 I believe)

Re: Re: RFR: 8240688: Remove the JavaBeanXxxPropertyBuilders constructors

2020-03-23 Thread Eric Bresie
Is there any external skara documentation available on all these flags etc? Eric Bresie ebre...@gmail.com > On March 7, 2020 at 8:25:02 AM CST, Kevin Rushforth > wrote: > On Fri, 6 Mar 2020 20:46:39 GMT, Kevin Rushforth wrote: > > > > Marked as reviewed by kcr (Lead). > > > > @arapte can you

Re: Re: RFR: 8240466: AppJSCallback* apps launched by ModuleLauncherTest intermittently hang

2020-03-23 Thread Eric Bresie
This may be a little off topic but given this is a Javascript concern, is this (or will this) be impacted by Nashhorns depreciation (as of jdk11 I believe) and potential removal at some point? I see reference to Netscape JObject do maybe that circumvents some of that but does this need to

RFR: 8236840: Memory leak when switching ButtonSkin

2020-03-23 Thread Ambarish Rapte
ButtonSkin adds a `ChangeListener` to `Control.sceneProperty()` which results in leaking the `ButtonSkin` itself when the `Button`'s skin is changed to a new `ButtonSkin`. Using a `WeakChangeListener` instead of `ChangeListener` solves the issue. Please take a look. - Commit

RFR: 8089828: RTL Orientation, the flag of a mnemonic is not placed under the mnemonic letter.

2020-03-23 Thread Ajit Ghaisas
**Bug :** https://bugs.openjdk.java.net/browse/JDK-8089828 **Root Cause :** RIGHT_TO_LEFT NodeOrientation was not considered during mnemonic position calculation. **Fix :** Corrected code to consider RIGHT_TO_LEFT NodeOrientation while calculating mnemonic position. **Testing :** Existing