On Mon, 27 Apr 2020 12:35:11 GMT, Ajit Ghaisas wrote:
>> Issue : https://bugs.openjdk.java.net/browse/JDK-8175358
>>
>> Root cause : When a MenuItem is removed from a Scene, if any accelerator has
>> been set on MenuItem, it does not get
>> removed from Scene's list of accelerators.
>> Fix :
On Mon, 27 Apr 2020 23:32:04 GMT, Nir Lisker wrote:
> I will review this too anyway.
Thank you. That will be helpful.
-
PR: https://git.openjdk.java.net/jfx/pull/198
On Mon, 20 Apr 2020 05:40:51 GMT, Arun Joseph wrote:
> fillPath() and fillRect() functions in
> [GraphicsContextJava.cpp](https://github.com/openjdk/jfx/blob/master/modules/javafx.web/src/main/native/Source/WebCore/platform/graphics/java/GraphicsContextJava.cpp)
> use Image::drawPattern() for
On Mon, 27 Apr 2020 11:09:51 GMT, Alexander Scherbatiy
wrote:
>> See the detailed issue description on:
>> http://mail.openjdk.java.net/pipermail/openjfx-dev/2020-April/025975.html
>>
>> The fix 8236448 https://github.com/openjdk/jfx/pull/75 changes
>>
On Mon, 27 Apr 2020 13:19:49 GMT, Kevin Rushforth wrote:
>> The title of this PR should match exactly the title of the JBS bug. So:
>>
>> 8243115: Spurious invalidations due to bug in IntegerBinding and other
>> classes
>
> @arapte can you also review this?
I will review this too anyway.
On Fri, 24 Apr 2020 00:58:30 GMT, Nir Lisker wrote:
> Mostly refactoring in preparation of the upcoming fixes. The changes might
> look like a lot, but it's mostly rearranging
> of methods. Summery of changes:
> ### Animation
> * Added `isNearZero` and `areNearEqual` methods that deal with
On Mon, 27 Apr 2020 14:45:19 GMT, Jeanette Winzenburg
wrote:
>> Ajit Ghaisas has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> spelling_correction
>
> forgot to formally start a review - and approving it :)
@arapte can you also review
On Sun, 19 Apr 2020 09:51:07 GMT, Jesper Skov
wrote:
>> Make the two ways of associating a ToggleButton with a ToggleGroup interact
>> correctly.
>>
>> This fixes https://bugs.openjdk.java.net/browse/JDK-8198402
>
> Jesper Skov has updated the pull request incrementally with three additional
On Mon, 27 Apr 2020 17:43:09 GMT, Johan Vos wrote:
> I'm confused by this, what is the full version of JDK 14.0.1? JavaFX is not
> part of the JDK anymore, therefore I don't
> expect a javafx.platform.properties in the JDK. Iif this is the case, it
> seems a serious bug to me.
I used non
On Fri, 17 Apr 2020 19:11:19 GMT, John Neffenger
wrote:
>> This pull request adds support for e-paper displays with the i.MX 6 Series
>> of Applications Processors and implements
>> [Issue #521](https://github.com/javafxports/openjdk-jfx/issues/521) in the
>> obsolete
On Mon, 27 Apr 2020 15:49:31 GMT, John Neffenger
wrote:
>> Alexander Scherbatiy has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Search javafx.platform.properties in jfx-runtime/lib directory
>
> Thanks, Alexander! I just tested your
Results with NVIDIA Quadro P400:
Without the fix, 1000 quads, average FPS ~7.4
With the fix, 1000 quads, average FPS ~6.1
(this is with Kevin’s pointlighttest.zip)
From: Nir Lisker
Sent: Thursday, April 23, 2020 5:41 PM
To: David Grieve ; openjfx-dev@openjdk.java.net
Mailing
Subject:
On Sat, 25 Apr 2020 17:07:21 GMT, Kevin Rushforth wrote:
>> @kevinrushforth
>> Member
>> kevinrushforth commented Apr 18, 2020
>>
>> I think most of those are good suggestions going forward. As for the
>> performance drop, the only place we've seen it so
>> far is on graphics accelerators that
On Mon, 27 Apr 2020 11:09:51 GMT, Alexander Scherbatiy
wrote:
>> See the detailed issue description on:
>> http://mail.openjdk.java.net/pipermail/openjfx-dev/2020-April/025975.html
>>
>> The fix 8236448 https://github.com/openjdk/jfx/pull/75 changes
>>
On Wed, 22 Apr 2020 12:03:34 GMT, Florian Kirmaier
wrote:
>> Closed focused Stages are not collected with Monocle
>>
>> This commit adds a unit-test and a fix for collecting focused closed stages.
>>
>> ticket: https://bugs.openjdk.java.net/browse/JDK-8241840
>
> Florian Kirmaier has updated
On Mon, 27 Apr 2020 12:35:11 GMT, Ajit Ghaisas wrote:
>> Issue : https://bugs.openjdk.java.net/browse/JDK-8175358
>>
>> Root cause : When a MenuItem is removed from a Scene, if any accelerator has
>> been set on MenuItem, it does not get
>> removed from Scene's list of accelerators.
>> Fix :
On Mon, 27 Apr 2020 11:57:58 GMT, Ajit Ghaisas wrote:
> Issue : https://bugs.openjdk.java.net/browse/JDK-8175358
>
> Root cause : When a MenuItem is removed from a Scene, if any accelerator has
> been set on MenuItem, it does not get
> removed from Scene's list of accelerators.
> Fix : If
> This is a solution for 8242548. There was zero test coverage, so I added a
> few tests for this as well.
John Hendrikx has updated the pull request incrementally with one additional
commit since the last revision:
Fix typo in comment
-
Changes:
- all:
On Mon, 27 Apr 2020 13:13:44 GMT, Kevin Rushforth wrote:
>> This fixes a bug where the first call to unbind would clear the internal
>> invalidation listener used, resulting in
>> subsequent unbind calls to be no-ops, unless bind was called again first.
>> I had to rewrite the parameterized
On Mon, 27 Apr 2020 11:43:28 GMT, John Hendrikx wrote:
> This fixes a bug where the first call to unbind would clear the internal
> invalidation listener used, resulting in
> subsequent unbind calls to be no-ops, unless bind was called again first.
> I had to rewrite the parameterized test
+1
On 4/25/2020 11:02 AM, Johan Vos wrote:
Hi Kevin,
I request permission to backport JDK-8234916 ([macos 10.15] Garbled text
running with native-image) to OpenJFX 11.
The patch applies clean.
- Johan
> Issue : https://bugs.openjdk.java.net/browse/JDK-8175358
>
> Root cause : When a MenuItem is removed from a Scene, if any accelerator has
> been set on MenuItem, it does not get
> removed from Scene's list of accelerators.
> Fix : If Scene changes for a Menu, remove the registered accelerators
On Thu, 23 Apr 2020 11:32:26 GMT, John Hendrikx wrote:
>> This is a solution for 8242548. There was zero test coverage, so I added a
>> few tests for this as well.
>
> John Hendrikx has refreshed the contents of this pull request, and previous
> commits have been removed. The incremental
>
Issue : https://bugs.openjdk.java.net/browse/JDK-8175358
Root cause : When a MenuItem is removed from a Scene, if any accelerator has
been set on MenuItem, it does not get
removed from Scene's list of accelerators.
Fix : If Scene changes for a Menu, remove the registered accelerators from
This fixes a bug where the first call to unbind would clear the internal
invalidation listener used, resulting in
subsequent unbind calls to be no-ops, unless bind was called again first.
I had to rewrite the parameterized test slightly as Parameterized will only
call the parameters method
On Fri, 24 Apr 2020 15:07:59 GMT, Jeanette Winzenburg
wrote:
> Which seems to be hinted at in a code comment in
> `SingleSelectionModel.select(item)`:
I agree that selectedIndex should be -1 for an uncontained value, so that the
below condition always holds true. And
this is already working
On Mon, 20 Apr 2020 12:23:16 GMT, Jeanette Winzenburg
wrote:
> The issue is that ChoiceBoxSkin
> a) doesn't update the text of the label if the value is not contained in the
> items
> b) doesn't respect converter for label text
>
> Fixed by
> - listening to value changes to update the label
>
On Fri, 24 Apr 2020 17:07:25 GMT, John Neffenger
wrote:
>>> To debug the JavaFX on Raspberry Pi I built armv6hf-sdk and just copied the
>>> file _javafx.platform.properties_ from the
>>> full jdk version with JavaFX to jdk-14.0.1/lib directory of jdk without
>>> JavaFX which I used to run my
> See the detailed issue description on:
> http://mail.openjdk.java.net/pipermail/openjfx-dev/2020-April/025975.html
>
> The fix 8236448 https://github.com/openjdk/jfx/pull/75 changes
>
29 matches
Mail list logo
