RFR: 8237504: Update copyright header for files modified in 2020

2020-04-30 Thread Kevin Rushforth
Update last modified year of copyright headers for files modified in 2020. - Commit messages: - 8237504: Update copyright header for files modified in 2020 Changes: https://git.openjdk.java.net/jfx/pull/203/files Webrev: https://webrevs.openjdk.java.net/jfx/203/webrev.00 Issue:

Re: Gradle support for getting :web:test working properly

2020-04-30 Thread Kevin Rushforth
I went ahead and created the JBS bug that you will need for this: https://bugs.openjdk.java.net/browse/JDK-8244212 -- Kevin On 4/30/2020 11:59 AM, Jesper Skov wrote: I have created https://github.com/openjdk/jfx/pull/202 with a suggested implementation. Looking for feedback. Cheers, Jesper

Re: Gradle support for getting :web:test working properly

2020-04-30 Thread Jesper Skov
I have created https://github.com/openjdk/jfx/pull/202 with a suggested implementation. Looking for feedback. Cheers, Jesper On Fri, Apr 24, 2020 at 5:13 PM Jesper Skov wrote: > Thanks, I will give it a shot. > > Jesper > > > On Thu, Apr 23, 2020 at 7:45 PM Kevin Rushforth < >

Re: [Rev 51] RFR: 8236651: Simplify and update glass gtk backend

2020-04-30 Thread Thiago Milczarek Sayao
> ### Summary > * Simplify and update the Gtk glass backend, making Linux a first-class > OpenJFX platform. > > ### Goals > * Make Linux a first-class OpenJFX platform (see Motivation); > * Simplify the code and reduce it's size; > * Update to gtk3 (it was originally a port from gtk2); > *

Re: [Rev 50] RFR: 8236651: Simplify and update glass gtk backend

2020-04-30 Thread Thiago Milczarek Sayao
> ### Summary > * Simplify and update the Gtk glass backend, making Linux a first-class > OpenJFX platform. > > ### Goals > * Make Linux a first-class OpenJFX platform (see Motivation); > * Simplify the code and reduce it's size; > * Update to gtk3 (it was originally a port from gtk2); > *

Re: [Integrated] RFR: 8198402: ToggleButton.setToggleGroup causes memory leak when button is removed via ToggleGroup.getToggles()

2020-04-30 Thread Jesper Skov
On Thu, 9 Apr 2020 09:58:27 GMT, Jesper Skov wrote: > Make the two ways of associating a ToggleButton with a ToggleGroup interact > correctly. > > This fixes https://bugs.openjdk.java.net/browse/JDK-8198402 This pull request has now been integrated. Changeset: 3130fc80 Author:Jesper

Re: [Integrated] RFR: 8191758: Match WebKit's font weight rendering with JavaFX

2020-04-30 Thread Bhawesh Choudhary
On Tue, 14 Apr 2020 10:25:52 GMT, Bhawesh Choudhary wrote: > As per JavaFx 700 font weight is considered to be bold but webkit is using > 600 font weight for text to become bold. to > fix issue, use boldWeightValue() function which uses 700 font weight rather > than isFontWeightBold() which

Re: RFR: 8237602: TabPane doesn't respect order of TabPane.getTabs() list

2020-04-30 Thread Jeanette Winzenburg
On Thu, 30 Apr 2020 12:55:02 GMT, Ambarish Rapte wrote: > > A ready test  , That's very nice of you. Yes, We can move all the four tests > to unit test. But I would prefer to do > it as another TEST_BUG. Does that sound good ? not quite complete, just nearly - attached the unit test to the

Re: RFR: 8237602: TabPane doesn't respect order of TabPane.getTabs() list

2020-04-30 Thread Ambarish Rapte
On Thu, 30 Apr 2020 11:22:33 GMT, Jeanette Winzenburg wrote: > Would you consider moving both into a unit test? Have one locally, could send > it to you .. A ready test  , That's very nice of you. Yes, We can move all the four tests to unit test. But I would prefer to do it as another

Re: RFR: 8237602: TabPane doesn't respect order of TabPane.getTabs() list

2020-04-30 Thread Jeanette Winzenburg
On Thu, 30 Apr 2020 07:08:24 GMT, Ambarish Rapte wrote: > The system test file `TabPanePermuteGetTabsTest` was added to address exact > similar kind of issue > [JDK-8222457](https://bugs.openjdk.java.net/browse/JDK-8222457). The current > issue >

Re: RFR: 8237602: TabPane doesn't respect order of TabPane.getTabs() list

2020-04-30 Thread Ambarish Rapte
On Wed, 29 Apr 2020 14:42:32 GMT, Kevin Rushforth wrote: > > > The following is wrong in your Description: Thanks Kevin, the description is corrected now.  - PR: https://git.openjdk.java.net/jfx/pull/201