On Thu, 22 Oct 2020 20:36:40 GMT, Johan Vos wrote:
> releasenotes for JavaFX 15.0.1
doc-files/release-notes-15.0.1.md line 16:
> 14: [JDK-8255064](https://bugs.openjdk.java.net/browse/JDK-8255064) | Cherry
> pick GTK WebKit 2.28.4 changes | web
> 15:
releasenotes for JavaFX 15.0.1
-
Commit messages:
- Add security fixes
- Create release notes for JavaFX 15.0.1
Changes: https://git.openjdk.java.net/jfx/pull/335/files
Webrev: https://webrevs.openjdk.java.net/?repo=jfx=335=00
Issue:
On Sat, 17 Oct 2020 14:04:54 GMT, Kevin Rushforth wrote:
>> This is looking quite good now. I really like how it simplifies the tests
>> that you modified to use it. I'll run the tests next week after you update
>> the PR.
>>
>>> I don't plan to confirm all coding guidelines of the
> It's based on the discussion of my previous PR:
> https://github.com/openjdk/jfx/pull/71
>
> I Added test utility class copied from JMemoryBuddy and used it to simplify 4
> of the existing unit tests.
>
> It's a direct copy of my project
>
On Thu, 8 Oct 2020 06:57:31 GMT, Ambarish Rapte wrote:
>> Florian Kirmaier has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> JDK-8244297
>> Fixed unit-test
>
> modules/javafx.base/src/test/java/test/util/memory/JMemoryBuddy.java line
> It's based on the discussion of my previous PR:
> https://github.com/openjdk/jfx/pull/71
>
> I Added test utility class copied from JMemoryBuddy and used it to simplify 4
> of the existing unit tests.
>
> It's a direct copy of my project
>
On Wed, 7 Oct 2020 12:09:15 GMT, Ambarish Rapte wrote:
>> Florian Kirmaier has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> JDK-8244297
>> Fixed unit-test
>
> modules/javafx.base/src/test/java/test/util/memory/JMemoryBuddy.java line
On Sat, 17 Oct 2020 13:43:41 GMT, Kevin Rushforth wrote:
>> Florian Kirmaier has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> JDK-8244297
>> Fixed unit-test
>
> modules/javafx.base/src/test/java/test/util/memory/JMemoryBuddy.java line
On Sat, 17 Oct 2020 13:22:35 GMT, Kevin Rushforth wrote:
>> modules/javafx.base/src/test/java/test/util/memory/JMemoryBuddy.java line 52:
>>
>>> 50: private static int garbageAmount = 99;
>>> 51: private static String MX_BEAN_PROXY_TYPE =
>>>
On Fri, 2 Oct 2020 08:54:02 GMT, Ambarish Rapte wrote:
>> Florian Kirmaier has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> JDK-8244297
>> Fixing some wrong imports
>
>
> It's based on the discussion of my previous PR:
> https://github.com/openjdk/jfx/pull/71
>
> I Added test utility class copied from JMemoryBuddy and used it to simplify 4
> of the existing unit tests.
>
> It's a direct copy of my project
>
On Wed, 21 Oct 2020 17:30:36 GMT, Arun Joseph wrote:
> Issue: Tests using `WebPageShim::paint` fails around 1/10 times.
>
> Fix: Execute `WebPageShim::paint` in the render thread using `PrismInvoker`.
> Ran tests over 100 times, no failures.
>
> Used the initial unit test in the PR for
>
On Thu, 22 Oct 2020 15:37:38 GMT, Kevin Rushforth wrote:
> It works for me on Windows. Have you run it on more than one platform?
I have run it on macOS and Windows.
> I left one suggestion for you regarding the constants in TableColumnShim.
Thanks for this. That's a cleaner way instead of
> Some of the ignored unit tests in javafx.controls module pass with latest
> code.
> This bug is to address -
> - removal of ignored tag
> - fixing the test if fix is minor
Ajit Ghaisas has updated the pull request incrementally with one additional
commit since the last revision:
On Thu, 22 Oct 2020 12:29:51 GMT, Pankaj Bansal wrote:
> The test test.com.sun.javafx.image.impl.ImageRaceTest is fails intermittently
> in linux
>
> This is caused by use of Thread.yield. Thread.yield is used to pause the
> current thread for some time. It gives a hint to thread scheduler
On Thu, 22 Oct 2020 12:13:11 GMT, Ajit Ghaisas wrote:
> Some of the ignored unit tests in javafx.controls module pass with latest
> code.
> This bug is to address -
> - removal of ignored tag
> - fixing the test if fix is minor
It works for me on Windows. Have you run it on more than one
On Thu, 22 Oct 2020 12:29:51 GMT, Pankaj Bansal wrote:
> The test test.com.sun.javafx.image.impl.ImageRaceTest is fails intermittently
> in linux
>
> This is caused by use of Thread.yield. Thread.yield is used to pause the
> current thread for some time. It gives a hint to thread scheduler
On Thu, 22 Oct 2020 12:58:09 GMT, Kevin Rushforth wrote:
>> just curious - why 2021? back to the future or do we already prepare for the
>> next release?
>
> The latter. JavaFX 16 will ship in March 2021. Note that this doesn't touch
> the "last modified" year in the copyright license header
On Wed, 21 Oct 2020 17:30:36 GMT, Arun Joseph wrote:
> Issue: Tests using `WebPageShim::paint` fails around 1/10 times.
>
> Fix: Execute `WebPageShim::paint` in the render thread using `PrismInvoker`.
> Ran tests over 100 times, no failures.
>
> Used the initial unit test in the PR for
>
On Thu, 22 Oct 2020 12:48:07 GMT, Jeanette Winzenburg
wrote:
>> Marked as reviewed by kcr (Lead).
>
> just curious - why 2021? back to the future or do we already prepare for the
> next release?
The latter. JavaFX 16 will ship in March 2021. Note that this doesn't touch the
"last modified"
On Thu, 22 Oct 2020 11:53:35 GMT, Kevin Rushforth wrote:
>> Copyright year in these 3 docs needs to be updated to 2021.
>
> Marked as reviewed by kcr (Lead).
just curious - why 2021? back to the future or do we already prepare for the
next release?
-
PR:
The test test.com.sun.javafx.image.impl.ImageRaceTest is fails intermittently
in linux
This is caused by use of Thread.yield. Thread.yield is used to tell pause the
current thread for some time. It gives a hint to thread scheduler that the
current thread should pause and other threads with
Some of the ignored unit tests in javafx.controls module pass with latest code.
This bug is to address -
- removal of ignored tag
- fixing the test if fix is minor
-
Commit messages:
- remove-whitespace
- JDK-8255241-fix
Changes: https://git.openjdk.java.net/jfx/pull/331/files
On Thu, 22 Oct 2020 11:45:23 GMT, Ambarish Rapte wrote:
> Copyright year in these 3 docs needs to be updated to 2021.
This pull request has now been integrated.
Changeset: 16b697c9
Author:Ambarish Rapte
URL: https://git.openjdk.java.net/jfx/commit/16b697c9
Stats: 3 lines in 3
On Thu, 22 Oct 2020 11:45:23 GMT, Ambarish Rapte wrote:
> Copyright year in these 3 docs needs to be updated to 2021.
Marked as reviewed by kcr (Lead).
-
PR: https://git.openjdk.java.net/jfx/pull/330
Copyright year in these 3 docs needs to be updated to 2021.
-
Commit messages:
- doc copyright 2021
Changes: https://git.openjdk.java.net/jfx/pull/330/files
Webrev: https://webrevs.openjdk.java.net/?repo=jfx=330=00
Issue: https://bugs.openjdk.java.net/browse/JDK-8254100
Stats:
The test targets in `build.gradle` are set up to run only classes whose name
ends with exactly `Test`. A test class named `RunMyTest.java` will be run, but
a test called `CheckSomething.java` will not be. This was done because gradle's
built-in scanner for test classes was buggy in earlier
On Thu, 22 Oct 2020 11:45:23 GMT, Ambarish Rapte wrote:
> Copyright year in these 3 docs needs to be updated to 2021.
reviewer: @kevinrushforth
-
PR: https://git.openjdk.java.net/jfx/pull/330
On Tue, 20 Oct 2020 12:18:10 GMT, Ajit Ghaisas wrote:
> It is a test cleanup work.
>
> Issue :
> Many unit tests in javafx.controls module have incorrect naming that use text
> "impl_" in names and comments.
> The test code correctly avoids using impl_* methods (as they were removed in
> JDK
On Wed, 21 Oct 2020 11:54:24 GMT, Ajit Ghaisas wrote:
>> It is a test cleanup work.
>>
>> Issue :
>> Many unit tests in javafx.controls module have incorrect naming that use
>> text "impl_" in names and comments.
>> The test code correctly avoids using impl_* methods (as they were removed in
30 matches
Mail list logo
