On Mon, 14 Jun 2021 11:05:25 GMT, Andreas Heger
wrote:
>> @andreas-heger Welcome to the `jfx` project. At a quick glance, the fix
>> looks promising. Have you tested this on Windows with Hi-DPI to make sure
>> there is no impact? Would you be able add an automated test case that fails
>>
> The inconsistent illumination happens on Macs with retina displays only if
> the 3D shape is placed in a SubScene. The light sources are located with
> wrong coordinates in sub scenes and this causes a different illumination. The
> wrong coordinates for the light sources come from the fact
On Sun, 19 Sep 2021 15:33:46 GMT, Florian Kirmaier
wrote:
> Probably my most boring PR. ;)
> Setting the lambda to null, after it has been used, fixes the leak.
The fix looks obviously correct. I verified that the test catches the bug
(fails without the fix and passes with the fix). I left a
On Sun, 19 Sep 2021 10:53:02 GMT, Marius Hanl wrote:
>>> > ```
>>> > public static Border stroke(Paint stroke, double width) {
>>> > ```
>>> > ...
>>> > But I really want to hear other opinions. This can also be a follow up. :)
>>>
>>> I don't mind adding this variant, but it needs consensus.
On Sun, 19 Sep 2021 15:33:46 GMT, Florian Kirmaier
wrote:
> Probably my most boring PR. ;)
> Setting the lambda to null, after it has been used, fixes the leak.
I guess that makes sense - but I can think of a million ways to create nearly
unsolvable problems with it.
-
PR:
On Sun, 19 Sep 2021 15:58:24 GMT, Florian Kirmaier
wrote:
> For the strange reason, why i haven't used a lambda for the test, I've
> created another ticket: https://bugs.openjdk.java.net/browse/JDK-8273970
I dpn't think this is a bug - none capturing lambdas are instantiated once and
you
