Re: RFR: 8276847: JSException: ReferenceError: Can't find variable: IntersectionObserver

On Wed, 10 Nov 2021 18:20:11 GMT, Jose Pereda wrote: > This PR enables intersection observer support for WebKit, and includes a > system test. Looks good to me. Shall re-approve when PR is updated as per Kevin's suggestion. - Marked as reviewed by arapte (Reviewer). PR:

[jfx11u] RFR: 8277133: Dragboard contents retrieved all over again during a DND process on WebView

Clean backport of 8277133: Dragboard contents retrieved all over again during a DND process on WebView - Commit messages: - 8277133: Dragboard contents retrieved all over again during a DND process on WebView Changes: https://git.openjdk.java.net/jfx11u/pull/64/files Webrev:

[jfx17u] RFR: 8277133: Dragboard contents retrieved all over again during a DND process on WebView

Clean backport of 8277133: Dragboard contents retrieved all over again during a DND process on WebView - Commit messages: - 8277133: Dragboard contents retrieved all over again during a DND process on WebView Changes: https://git.openjdk.java.net/jfx17u/pull/23/files Webrev:

[jfx17u] RFR: 8160597: IllegalArgumentException when we initiate drag on Image

Clean backport of 8160597: IllegalArgumentException when we initiate drag on Image - Commit messages: - 8160597: IllegalArgumentException when we initiate drag on Image Changes: https://git.openjdk.java.net/jfx17u/pull/22/files Webrev:

[jfx11u] RFR: 8160597: IllegalArgumentException when we initiate drag on Image

Clean backport for 8160597: IllegalArgumentException when we initiate drag on Image - Commit messages: - 8160597: IllegalArgumentException when we initiate drag on Image Changes: https://git.openjdk.java.net/jfx11u/pull/63/files Webrev:

Re: [jfx11u] RFR: 8160597: IllegalArgumentException when we initiate drag on Image

On Mon, 29 Nov 2021 15:32:44 GMT, Johan Vos wrote: > clean backport from 18 to 11u I'll redo it properly - PR: https://git.openjdk.java.net/jfx11u/pull/62

[jfx11u] Withdrawn: 8160597: IllegalArgumentException when we initiate drag on Image

On Mon, 29 Nov 2021 15:32:44 GMT, Johan Vos wrote: > clean backport from 18 to 11u This pull request has been closed without being integrated. - PR: https://git.openjdk.java.net/jfx11u/pull/62

Re: Cross-compiling JavaFX for Apple ARM64

Not currently. I admit it would be nice, but there are some challenges that make this difficult. One of the main ones that Johan discovered is that the WebKit build system builds some tools (executable binaries) that are then used in later stages of the build. This means that those tools need

Re: Cleaning up warnings in the Mac glass code

I agree that this would be a good thing to aim for as long as we exclude deprecation warnings (given Apple's penchant for deprecating large API surfaces such as OpenGL or the older accessibility APIs we really can't have the use of deprecated APIs be an error). -- Kevin On 11/24/2021 7:44

Re: RFR: 8276553: ListView scrollTo() is broken after fix for JDK-8089589

On Mon, 29 Nov 2021 16:59:02 GMT, Kevin Rushforth wrote: >> good catch! the "additional" stuff typically is done in the properties' >> invalidated .. > > Exactly. This ensures consistent behavior regardless of how a property value > is set. I should add that this looks like a preexisting

Re: RFR: 8276553: ListView scrollTo() is broken after fix for JDK-8089589

On Mon, 29 Nov 2021 16:55:16 GMT, Jeanette Winzenburg wrote: >> modules/javafx.controls/src/main/java/javafx/scene/control/skin/VirtualFlow.java >> line 903: >> >>> 901: recalculateAndImproveEstimatedSize(2); >>> 902: >>> 903: cellCount.set(value); >> >> Can this be

Re: RFR: 8276553: ListView scrollTo() is broken after fix for JDK-8089589

On Mon, 29 Nov 2021 14:38:10 GMT, Michael Strauß wrote: >> After (re)setting the number of elements, make sure to do at least some >> estimation of the total size. >> Added a testcase for this scenario. > > modules/javafx.controls/src/main/java/javafx/scene/control/skin/VirtualFlow.java > line

Re: [jfx11u] RFR: 8160597: IllegalArgumentException when we initiate drag on Image

On Mon, 29 Nov 2021 15:32:44 GMT, Johan Vos wrote: > clean backport from 18 to 11u This looks like it is missing part of the original patch, which is why it isn't marked clean. - PR: https://git.openjdk.java.net/jfx11u/pull/62

[jfx11u] RFR: 8160597: 6e6c71190e5b9b07a323af0ab483dfc993302164

clean backport from 18 to 11u - Commit messages: - backport 8160597 Changes: https://git.openjdk.java.net/jfx11u/pull/62/files Webrev: https://webrevs.openjdk.java.net/?repo=jfx11u=62=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8160597 Stats: 2 lines in 2 files changed:

Re: RFR: 8276847: JSException: ReferenceError: Can't find variable: IntersectionObserver

On Wed, 10 Nov 2021 18:20:11 GMT, Jose Pereda wrote: > This PR enables intersection observer support for WebKit, and includes a > system test. @aghaisas or @arapte can one of you be the second reviewer? - PR: https://git.openjdk.java.net/jfx/pull/664

Re: RFR: 8276553: ListView scrollTo() is broken after fix for JDK-8089589

On Mon, 29 Nov 2021 11:56:45 GMT, Johan Vos wrote: > After (re)setting the number of elements, make sure to do at least some > estimation of the total size. > Added a testcase for this scenario. modules/javafx.controls/src/main/java/javafx/scene/control/skin/VirtualFlow.java line 903: > 901:

RFR: 8276553: ListView scrollTo() is broken after fix for JDK-8089589

After (re)setting the number of elements, make sure to do at least some estimation of the total size. Added a testcase for this scenario. - Commit messages: - After (re)setting the number of elements, make sure to do at least some estimation of the total size. Changes: