Re: RFR: 8274066: Polygon filled outside its area when very large coordinates are used [v2]

2022-01-12 Thread Kevin Rushforth
On Mon, 10 Jan 2022 00:04:00 GMT, Laurent Bourgès wrote: >> Changelog for this MarlinFX 0.9.4.5 release: >> >> The Marlin-renderer 0.9.4.5 release provides bug fixes on Marlin's path >> clipper: >> - improved Stroker to handle huge coordinates, up to 1E15 >> - improved PathClipFilter (filler)

Re: RFR: 8277853: With Touch enabled devices scrollbar disappears and the table is scrolled to the beginning

2022-01-12 Thread Kevin Rushforth
On Thu, 2 Dec 2021 10:12:50 GMT, meghanEmbrace wrote: > With a touch-enabled device, the scrollbar disappears a short while after > it's used. During the layout, updateHbar() checks the hbar visibility and > resets the clip, causing the user to be scrolled fully to the left when > trying to

RFR: 8277853: With Touch enabled devices scrollbar disappears and the table is scrolled to the beginning

2022-01-12 Thread meghanEmbrace
With a touch-enabled device, the scrollbar disappears a short while after it's used. During the layout, updateHbar() checks the hbar visibility and resets the clip, causing the user to be scrolled fully to the left when trying to access columns on the right. Using hbar.isVisible() is not

Re: RFR: 8277572: ImageStorage should correctly handle MIME types for images encoded in data URIs [v6]

2022-01-12 Thread Kevin Rushforth
On Sat, 8 Jan 2022 17:30:55 GMT, Michael Strauß wrote: >> `com.sun.javafx.iio.ImageStorage` currently ignores the MIME image subtype >> specified for images encoded in data URIs. This should be improved as >> follows: >> >> 1. If the specified image subtype is not supported, an exception will

Re: RFR: 8278938: [Win] Robot can target wrong key for punctuation and symbols [v2]

2022-01-12 Thread Martin Fox
> When processing a `WM_CHAR` event on an OEM key (punctuation, symbol, dead > key) the glass code will dynamically query the key's unshifted character to > determine the Java code to assign to it. This is necessary since the > relationship between OEM key codes and the characters they generate

Re: RFR: 8242544: CMD+ENTER key event crashes the application when invoked on dialog

2022-01-12 Thread Kevin Rushforth
On Wed, 29 Dec 2021 00:44:44 GMT, Andreas Heger wrote: > This also solves [JDK-8205915 [macOS] Accelerator assigned to button in > dialog fires menuItem in owning > stage](https://bugs.openjdk.java.net/browse/JDK-8205915l). > > I must admit that I don't have 100% insight about what actually

Integrated: 8242544: CMD+ENTER key event crashes the application when invoked on dialog

2022-01-12 Thread Martin Fox
On Tue, 11 Jan 2022 22:18:53 GMT, Martin Fox wrote: > The OS crashes if the contentView of a window is set to nil while handling > processKeyEquivalent. With this PR we just set the contentView to a basic > do-nothing NSView for the interim. This pull request has now been integrated.

Withdrawn: 8242544: CMD+ENTER key event crashes the application when invoked on dialog

2022-01-12 Thread Kevin Rushforth
On Wed, 29 Dec 2021 00:44:44 GMT, Andreas Heger wrote: > This also solves [JDK-8205915 [macOS] Accelerator assigned to button in > dialog fires menuItem in owning > stage](https://bugs.openjdk.java.net/browse/JDK-8205915l). > > I must admit that I don't have 100% insight about what actually

Re: RFR: 8242544: CMD+ENTER key event crashes the application when invoked on dialog [v2]

2022-01-12 Thread Martin Fox
On Wed, 12 Jan 2022 16:56:12 GMT, Martin Fox wrote: >> The OS crashes if the contentView of a window is set to nil while handling >> processKeyEquivalent. With this PR we just set the contentView to a basic >> do-nothing NSView for the interim. > > Martin Fox has updated the pull request

Re: RFR: 8242544: CMD+ENTER key event crashes the application when invoked on dialog [v2]

2022-01-12 Thread Jose Pereda
On Wed, 12 Jan 2022 18:34:19 GMT, Martin Fox wrote: >> I don't know. I'm always skeptical of 0 size rectangles. I'd either leave it >> as-is or maybe use a `(0,0,1,1)` rectangle. > > The initial size should not matter since it will be re-sized to the window's > content bounds. But I would

Re: RFR: 8242544: CMD+ENTER key event crashes the application when invoked on dialog [v2]

2022-01-12 Thread Jose Pereda
On Wed, 12 Jan 2022 16:56:12 GMT, Martin Fox wrote: >> The OS crashes if the contentView of a window is set to nil while handling >> processKeyEquivalent. With this PR we just set the contentView to a basic >> do-nothing NSView for the interim. > > Martin Fox has updated the pull request

Re: RFR: 8242544: CMD+ENTER key event crashes the application when invoked on dialog [v2]

2022-01-12 Thread Martin Fox
On Wed, 12 Jan 2022 18:24:36 GMT, Kevin Rushforth wrote: >> Martin Fox has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Releasing dummy NSView > > modules/javafx.graphics/src/main/native-glass/mac/GlassWindow.m line 849: > >> 847:

Re: RFR: 8242544: CMD+ENTER key event crashes the application when invoked on dialog [v2]

2022-01-12 Thread Martin Fox
On Wed, 12 Jan 2022 18:23:20 GMT, Kevin Rushforth wrote: >> modules/javafx.graphics/src/main/native-glass/mac/GlassWindow.m line 847: >> >>> 845: { >>> 846: // If the contentView is set to nil within >>> performKeyEquivalent: the OS will crash. >>> 847: NSView*

Re: RFR: 8242544: CMD+ENTER key event crashes the application when invoked on dialog [v2]

2022-01-12 Thread Kevin Rushforth
On Wed, 12 Jan 2022 16:14:16 GMT, Jose Pereda wrote: >> Martin Fox has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Releasing dummy NSView > > modules/javafx.graphics/src/main/native-glass/mac/GlassWindow.m line 847: > >> 845: {

Re: RFR: 8242544: CMD+ENTER key event crashes the application when invoked on dialog [v2]

2022-01-12 Thread Kevin Rushforth
On Wed, 12 Jan 2022 16:56:12 GMT, Martin Fox wrote: >> The OS crashes if the contentView of a window is set to nil while handling >> processKeyEquivalent. With this PR we just set the contentView to a basic >> do-nothing NSView for the interim. > > Martin Fox has updated the pull request

Re: RFR: 8242544: CMD+ENTER key event crashes the application when invoked on dialog [v2]

2022-01-12 Thread Martin Fox
> The OS crashes if the contentView of a window is set to nil while handling > processKeyEquivalent. With this PR we just set the contentView to a basic > do-nothing NSView for the interim. Martin Fox has updated the pull request incrementally with one additional commit since the last

Re: RFR: 8242544: CMD+ENTER key event crashes the application when invoked on dialog

2022-01-12 Thread Martin Fox
On Wed, 12 Jan 2022 16:24:48 GMT, Kevin Rushforth wrote: >> modules/javafx.graphics/src/main/native-glass/mac/GlassWindow.m line 848: >> >>> 846: // If the contentView is set to nil within >>> performKeyEquivalent: the OS will crash. >>> 847: NSView* dummy = [[NSView

Re: RFR: 8242544: CMD+ENTER key event crashes the application when invoked on dialog

2022-01-12 Thread Kevin Rushforth
On Wed, 12 Jan 2022 16:14:58 GMT, Jose Pereda wrote: >> The OS crashes if the contentView of a window is set to nil while handling >> processKeyEquivalent. With this PR we just set the contentView to a basic >> do-nothing NSView for the interim. > >

Re: RFR: 8242544: CMD+ENTER key event crashes the application when invoked on dialog

2022-01-12 Thread Jose Pereda
On Tue, 11 Jan 2022 22:18:53 GMT, Martin Fox wrote: > The OS crashes if the contentView of a window is set to nil while handling > processKeyEquivalent. With this PR we just set the contentView to a basic > do-nothing NSView for the interim. This PR fixes the JDK-8242544 issue as intended.

Re: RFR: 8242544: CMD+ENTER key event crashes the application when invoked on dialog

2022-01-12 Thread Kevin Rushforth
On Tue, 11 Jan 2022 22:18:53 GMT, Martin Fox wrote: > The OS crashes if the contentView of a window is set to nil while handling > processKeyEquivalent. With this PR we just set the contentView to a basic > do-nothing NSView for the interim. In the interest of getting as much testing as

Re: RFR: 8242544: CMD+ENTER key event crashes the application when invoked on dialog

2022-01-12 Thread Johan Vos
On Tue, 11 Jan 2022 22:18:53 GMT, Martin Fox wrote: > The OS crashes if the contentView of a window is set to nil while handling > processKeyEquivalent. With this PR we just set the contentView to a basic > do-nothing NSView for the interim. This looks good with the current tools/OS

Re: RFR: 8242544: CMD+ENTER key event crashes the application when invoked on dialog

2022-01-12 Thread Kevin Rushforth
On Tue, 11 Jan 2022 22:18:53 GMT, Martin Fox wrote: > The OS crashes if the contentView of a window is set to nil while handling > processKeyEquivalent. With this PR we just set the contentView to a basic > do-nothing NSView for the interim. The fix looks good, and as mentioned above, is