Re: RFR: 8255940: localStorage is null after window.close() [v2]

2022-02-04 Thread Jay Bhaskar
On Fri, 28 Jan 2022 00:11:40 GMT, Kevin Rushforth wrote: >> Jay Bhaskar has updated the pull request with a new target base due to a >> merge or a rebase. The incremental webrev excludes the unrelated changes >> brought in by the merge/rebase. The pull request contains two additional >>

Re: RFR: 8273336: Clicking a selected cell from a group of selected cells in a TableView clears the selected items list but remains selected

2022-02-04 Thread yosbits
On Fri, 7 Jan 2022 19:36:45 GMT, Jose Pereda wrote: > This PR adds a predicate to TableView and TreeTableView selection models > order to remove rows from the selection only when there are no selected cells > in that given row, when cell selection is enabled. > > Two tests have been added as

Re: RFR: 8255940: localStorage is null after window.close() [v2]

2022-02-04 Thread Jay Bhaskar
> Issue: The current implementation of DOMWindow ::localStorage(..) returns > null pointer in case of page is being closed. > Fix: It should not return nullptr , as per the [w3c web storage > spec](https://www.w3.org/TR/2016/REC-webstorage-20160419/) > "User agents should expire data from the

Re: [jfx18] RFR: 8279345: Realign class docs of LightBase and subclasses [v5]

2022-02-04 Thread Kevin Rushforth
On Fri, 4 Feb 2022 18:26:57 GMT, Nir Lisker wrote: >> Now that the standard concrete light types were added, there is an >> opportunity to rearrange and rewrite some of the class docs. Here is a >> summary of the changes: >> >> * Moved the explanations of attenuation and direction up to

Re: RFR: 8277309: Add support for H.265/HEVC to HTTP Live Streaming

2022-02-04 Thread yosbits
On Fri, 4 Feb 2022 11:24:48 GMT, Alexander Matveev wrote: > - Added support for fragmented MP4 with HEVC/H.265, H.264 and AAC. > - Added support for elementary AAC streams without any container for audio > only streams. > - Added "aacparse" plugin from GStreamer. Required on Linux, since

Re: [jfx18] RFR: 8279345: Realign class docs of LightBase and subclasses [v5]

2022-02-04 Thread Nir Lisker
On Thu, 27 Jan 2022 19:01:32 GMT, Kevin Rushforth wrote: >> I think the description should focus on the meaning of the respective term >> in the lighting equation, and not on a non-technical analogy. In this case, >> the analogy is a bit misleading on several aspects, including the fact that

Re: [jfx18] RFR: 8279345: Realign class docs of LightBase and subclasses [v5]

2022-02-04 Thread Nir Lisker
> Now that the standard concrete light types were added, there is an > opportunity to rearrange and rewrite some of the class docs. Here is a > summary of the changes: > > * Moved the explanations of attenuation and direction up to `LightBase` since > different light types share

Re: RFR: 8277309: Add support for H.265/HEVC to HTTP Live Streaming

2022-02-04 Thread Kevin Rushforth
On Fri, 4 Feb 2022 17:19:36 GMT, yosbits wrote: > Why not use BitSet instead of ArrayList? Can you be more specific? The only use of `ArrayList` that I see in the patch is in code that uses a few already-existing lists. Changing that to some other data structure would be an unrelated change

Re: RFR: 8273336: Clicking a selected cell from a group of selected cells in a TableView clears the selected items list but remains selected

2022-02-04 Thread Michael Strauß
On Fri, 7 Jan 2022 19:36:45 GMT, Jose Pereda wrote: > This PR adds a predicate to TableView and TreeTableView selection models > order to remove rows from the selection only when there are no selected cells > in that given row, when cell selection is enabled. > > Two tests have been added as

Re: RFR: 8277309: Add support for H.265/HEVC to HTTP Live Streaming

2022-02-04 Thread yosbits
On Fri, 4 Feb 2022 11:24:48 GMT, Alexander Matveev wrote: > - Added support for fragmented MP4 with HEVC/H.265, H.264 and AAC. > - Added support for elementary AAC streams without any container for audio > only streams. > - Added "aacparse" plugin from GStreamer. Required on Linux, since

Integrated: 8278980: Update WebKit to 613.1

2022-02-04 Thread Ambarish Rapte
On Wed, 2 Feb 2022 07:34:55 GMT, Ambarish Rapte wrote: > Update JavaFX WebKit to GTK WebKit 2.34 (613.1). > > Verified the updated version build, tests run and sanity testing. > This does not cause any issues except a unit test failure > `IrresponsiveScriptTest`. > It is recorded and ignored

RFR: 8277309: Add support for H.265/HEVC to HTTP Live Streaming

2022-02-04 Thread Alexander Matveev
- Added support for fragmented MP4 with HEVC/H.265, H.264 and AAC. - Added support for elementary AAC streams without any container for audio only streams. - Added "aacparse" plugin from GStreamer. Required on Linux, since decoder cannot handle AAC elementary streams directly. DirectShow

Re: RFR: 8278980: Update WebKit to 613.1 [v2]

2022-02-04 Thread Ajit Ghaisas
On Wed, 2 Feb 2022 15:29:51 GMT, Ambarish Rapte wrote: >> Update JavaFX WebKit to GTK WebKit 2.34 (613.1). >> >> Verified the updated version build, tests run and sanity testing. >> This does not cause any issues except a unit test failure >> `IrresponsiveScriptTest`. >> It is recorded and

Re: RFR: 8278980: Update WebKit to 613.1 [v2]

2022-02-04 Thread Johan Vos
On Wed, 2 Feb 2022 15:29:51 GMT, Ambarish Rapte wrote: >> Update JavaFX WebKit to GTK WebKit 2.34 (613.1). >> >> Verified the updated version build, tests run and sanity testing. >> This does not cause any issues except a unit test failure >> `IrresponsiveScriptTest`. >> It is recorded and