Re: RFR: 8282099: Cherry-pick WebKit 613.1 stabilization fixes (2)

2022-02-22 Thread Johan Vos
On Tue, 22 Feb 2022 17:15:19 GMT, Ambarish Rapte wrote: > Include additional stabilization fixes of WebKit 613.1 > Sanity testing did not show any concerns. Ok on mac/linux/win x86_64 and on linux aarch64 - Marked as reviewed by jvos (Reviewer). PR:

Re: RFR: 8280020: Underline and line-through not straight in WebView [v4]

2022-02-22 Thread Kevin Rushforth
On Mon, 21 Feb 2022 06:02:32 GMT, Jay Bhaskar wrote: >> Issue: The end point of line in drawLinesForText , add thickness to the >> endPoint.y(). In this case origin which is start point and the end point >> would not be same, and line would be drawn not straight. >> Solution: Do not add

Re: RFR: 8280020: Underline and line-through not straight in WebView [v3]

2022-02-22 Thread Kevin Rushforth
On Mon, 21 Feb 2022 01:57:29 GMT, Jay Bhaskar wrote: >> tests/system/src/test/java/test/javafx/scene/web/StraightLineTest.java line >> 105: >> >>> 103: Platform.runLater(() -> { >>> 104: webView = new WebView(); >>> 105: Scene scene = new Scene(webView,80,60);

Re: RFR: 8280020: Underline and line-through not straight in WebView [v3]

2022-02-22 Thread Kevin Rushforth
On Mon, 21 Feb 2022 05:30:36 GMT, Jay Bhaskar wrote: >> The bounding rect.x rect.y is top left corner, and line is being drawn below >> the bottom, so height and thickness need to be considered. > > for (int i = line_start_y; i <= (width - line_start_y -6); i++) { , this > meets the condition

Re: RFR: 8282099: Cherry-pick WebKit 613.1 stabilization fixes (2)

2022-02-22 Thread Johan Vos
On Tue, 22 Feb 2022 17:15:19 GMT, Ambarish Rapte wrote: > Include additional stabilization fixes of WebKit 613.1 > Sanity testing did not show any concerns. I notice changes specific to AArch64 and Linux, so I did a testbuild on Linux AArch64 which was successful. Will test the

Re: RFR: 8282099: Cherry-pick WebKit 613.1 stabilization fixes (2)

2022-02-22 Thread Kevin Rushforth
On Tue, 22 Feb 2022 17:15:19 GMT, Ambarish Rapte wrote: > Include additional stabilization fixes of WebKit 613.1 > Sanity testing did not show any concerns. Marked as reviewed by kcr (Lead). - PR: https://git.openjdk.java.net/jfx/pull/740

RFR: 8282099: Cherry-pick WebKit 613.1 stabilization fixes (2)

2022-02-22 Thread Ambarish Rapte
Include additional stabilization fixes of WebKit 613.1 Sanity testing did not show any concerns. - Commit messages: - Cherry-pick WebKit 613.1 stabilization fixes (2) Changes: https://git.openjdk.java.net/jfx/pull/740/files Webrev: https://webrevs.openjdk.java.net/?repo=jfx=740=00

Integrated: 8281953: NullPointer in InputMethod components in JFXPanel

2022-02-22 Thread eduardsdv
On Thu, 17 Feb 2022 12:57:27 GMT, eduardsdv wrote: > If the InputMethod's node is not in the scene, the default text location > point is returned. This pull request has now been integrated. Changeset: a0bb545b Author:Eduard Sedov Committer: Ajit Ghaisas URL:

Integrated: 8282134: Certain regex can cause a JS trap in WebView

2022-02-22 Thread Jay Bhaskar
On Sat, 19 Feb 2022 11:43:00 GMT, Jay Bhaskar wrote: > Fix YarrJIT backtrackCharacterClassNonGreedy breakpoint() Certain regex can > cause a JS trap in WebView This pull request has now been integrated. Changeset: 73963960 Author:Jay Bhaskar Committer: Kevin Rushforth URL:

Re: RFR: 8282134: Certain regex can cause a JS trap in WebView [v3]

2022-02-22 Thread Kevin Rushforth
On Tue, 22 Feb 2022 12:43:37 GMT, Jay Bhaskar wrote: >> Fix YarrJIT backtrackCharacterClassNonGreedy breakpoint() Certain regex can >> cause a JS trap in WebView > > Jay Bhaskar has refreshed the contents of this pull request, and previous > commits have been removed. Incremental views are not

Re: RFR: 8282134: Certain regex can cause a JS trap in WebView [v3]

2022-02-22 Thread Jay Bhaskar
On Tue, 22 Feb 2022 12:43:37 GMT, Jay Bhaskar wrote: >> Fix YarrJIT backtrackCharacterClassNonGreedy breakpoint() Certain regex can >> cause a JS trap in WebView > > Jay Bhaskar has refreshed the contents of this pull request, and previous > commits have been removed. Incremental views are not

Re: RFR: 8282134: Certain regex can cause a JS trap in WebView [v3]

2022-02-22 Thread Ambarish Rapte
On Tue, 22 Feb 2022 12:43:37 GMT, Jay Bhaskar wrote: >> Fix YarrJIT backtrackCharacterClassNonGreedy breakpoint() Certain regex can >> cause a JS trap in WebView > > Jay Bhaskar has refreshed the contents of this pull request, and previous > commits have been removed. Incremental views are not

Re: RFR: 8282134: Certain regex can cause a JS trap in WebView [v3]

2022-02-22 Thread Kevin Rushforth
On Tue, 22 Feb 2022 12:43:37 GMT, Jay Bhaskar wrote: >> Fix YarrJIT backtrackCharacterClassNonGreedy breakpoint() Certain regex can >> cause a JS trap in WebView > > Jay Bhaskar has refreshed the contents of this pull request, and previous > commits have been removed. Incremental views are not

Re: RFR: 8282134: Certain regex can cause a JS trap in WebView [v3]

2022-02-22 Thread Ambarish Rapte
On Tue, 22 Feb 2022 12:43:37 GMT, Jay Bhaskar wrote: >> Fix YarrJIT backtrackCharacterClassNonGreedy breakpoint() Certain regex can >> cause a JS trap in WebView > > Jay Bhaskar has refreshed the contents of this pull request, and previous > commits have been removed. Incremental views are not

Re: RFR: 8282134: Certain regex can cause a JS trap in WebView [v3]

2022-02-22 Thread Jay Bhaskar
> Fix YarrJIT backtrackCharacterClassNonGreedy breakpoint() Certain regex can > cause a JS trap in WebView Jay Bhaskar has refreshed the contents of this pull request, and previous commits have been removed. Incremental views are not available. The pull request now contains one commit:

Re: RFR: 8282134: Certain regex can cause a JS trap in WebView [v2]

2022-02-22 Thread Jay Bhaskar
On Tue, 22 Feb 2022 10:03:30 GMT, Jay Bhaskar wrote: >> Fix YarrJIT backtrackCharacterClassNonGreedy breakpoint() Certain regex can >> cause a JS trap in WebView > > Jay Bhaskar has updated the pull request incrementally with two additional > commits since the last revision: > > - Merge

Re: RFR: 8282134: Certain regex can cause a JS trap in WebView [v2]

2022-02-22 Thread Jay Bhaskar
> Fix YarrJIT backtrackCharacterClassNonGreedy breakpoint() Certain regex can > cause a JS trap in WebView Jay Bhaskar has updated the pull request incrementally with two additional commits since the last revision: - Merge branch 'public-sec-bug' of https://github.com/jaybhaskar/jfx into

Re: RFR: 8282134: Certain regex can cause a JS trap in WebView

2022-02-22 Thread Ambarish Rapte
On Sat, 19 Feb 2022 11:43:00 GMT, Jay Bhaskar wrote: > Fix YarrJIT backtrackCharacterClassNonGreedy breakpoint() Certain regex can > cause a JS trap in WebView Marked as reviewed by arapte (Reviewer). - PR: https://git.openjdk.java.net/jfx/pull/739