Re: RFR: 8274771: Map, FlatMap and OrElse fluent bindings for ObservableValue [v14]

2022-03-22 Thread John Hendrikx
On Tue, 22 Mar 2022 17:06:12 GMT, yosbits wrote: > The reason I think the Null Safe explanation is incorrect is because In the > interest of fairness, I feel it would be better to have an example of using > the Optional API when comparing the existing way of writing to the new way of >

Re: RFR: 8274771: Map, FlatMap and OrElse fluent bindings for ObservableValue [v14]

2022-03-22 Thread Kevin Rushforth
On Tue, 22 Mar 2022 07:46:40 GMT, John Hendrikx wrote: >> This is an implementation of the proposal in >> https://bugs.openjdk.java.net/browse/JDK-8274771 that me and Nir Lisker >> (@nlisker) have been working on. It's a complete implementation including >> good test coverage. >> >> This

Re: RFR: 8274771: Map, FlatMap and OrElse fluent bindings for ObservableValue

2022-03-22 Thread Nir Lisker
On Thu, 18 Nov 2021 21:38:28 GMT, Kevin Rushforth wrote: >> This is an implementation of the proposal in >> https://bugs.openjdk.java.net/browse/JDK-8274771 that me and Nir Lisker >> (@nlisker) have been working on. It's a complete implementation including >> good test coverage. >> >>

Re: RFR: 8274771: Map, FlatMap and OrElse fluent bindings for ObservableValue [v14]

2022-03-22 Thread Nir Lisker
On Tue, 22 Mar 2022 07:46:40 GMT, John Hendrikx wrote: >> This is an implementation of the proposal in >> https://bugs.openjdk.java.net/browse/JDK-8274771 that me and Nir Lisker >> (@nlisker) have been working on. It's a complete implementation including >> good test coverage. >> >> This

Re: RFR: 8274771: Map, FlatMap and OrElse fluent bindings for ObservableValue [v14]

2022-03-22 Thread yosbits
On Tue, 22 Mar 2022 07:46:40 GMT, John Hendrikx wrote: >> This is an implementation of the proposal in >> https://bugs.openjdk.java.net/browse/JDK-8274771 that me and Nir Lisker >> (@nlisker) have been working on. It's a complete implementation including >> good test coverage. >> >> This

RFR: 8283509: Invisible menus can lead to IndexOutOfBoundsException

2022-03-22 Thread Robert Lichtenberger
findSibling adapted to only use visible menus when calculating the index. - Commit messages: - 8283509: Invisible menus can lead to IndexOutOfBoundsException Changes: https://git.openjdk.java.net/jfx/pull/759/files Webrev: https://webrevs.openjdk.java.net/?repo=jfx=759=00 Issue:

Re: RFR: 8274771: Map, FlatMap and OrElse fluent bindings for ObservableValue [v14]

2022-03-22 Thread John Hendrikx
On Tue, 22 Mar 2022 12:38:43 GMT, yosbits wrote: > This PR is considered a design change that delegates multiple > responsibilities to the basic JavaFX class ObservableValue. The balance > between implementation complexity and convenience seems to be a point of > contention. If you could do

Re: RFR: 8274771: Map, FlatMap and OrElse fluent bindings for ObservableValue [v14]

2022-03-22 Thread yosbits
On Tue, 22 Mar 2022 07:46:40 GMT, John Hendrikx wrote: >> This is an implementation of the proposal in >> https://bugs.openjdk.java.net/browse/JDK-8274771 that me and Nir Lisker >> (@nlisker) have been working on. It's a complete implementation including >> good test coverage. >> >> This

Re: RFR: 8277309: Add support for H.265/HEVC to HTTP Live Streaming [v3]

2022-03-22 Thread Johan Vos
On Fri, 18 Mar 2022 02:20:11 GMT, Alexander Matveev wrote: >> - Added support for fragmented MP4 with HEVC/H.265, H.264 and AAC. >> - Added support for elementary AAC streams without any container for audio >> only streams. >> - Added "aacparse" plugin from GStreamer. Required on Linux,

Re: RFR: 8277785: ListView scrollTo jumps to wrong location when CellHeight is changed [v2]

2022-03-22 Thread Johan Vos
> When the size of a ListCell is changed and a scrollTo method is invoked > without having a layout calculation in between, the old (wrong) size is used > to calculcate the total estimate. This happens e.g. when the size is changed > in the `updateItem` method. > This PR will immediately resize

Re: RFR: 8277309: Add support for H.265/HEVC to HTTP Live Streaming [v3]

2022-03-22 Thread Ambarish Rapte
On Fri, 18 Mar 2022 02:20:11 GMT, Alexander Matveev wrote: >> - Added support for fragmented MP4 with HEVC/H.265, H.264 and AAC. >> - Added support for elementary AAC streams without any container for audio >> only streams. >> - Added "aacparse" plugin from GStreamer. Required on Linux,

Re: RFR: 8274771: Map, FlatMap and OrElse fluent bindings for ObservableValue [v13]

2022-03-22 Thread John Hendrikx
On Tue, 22 Mar 2022 02:21:05 GMT, yosbits wrote: > I think you are incorrect about the Null Safe explanation. Wouldn't using > Optional solve this? I'm not sure what you are trying to say, the fluent bindings offered by this API are null safe. Using standard JavaFX you have to do additional

Re: RFR: 8274771: Map, FlatMap and OrElse fluent bindings for ObservableValue [v13]

2022-03-22 Thread John Hendrikx
On Mon, 21 Mar 2022 21:49:33 GMT, Nir Lisker wrote: >> John Hendrikx has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Small wording change in API of ObservableValue after proof reading > >

Re: RFR: 8274771: Map, FlatMap and OrElse fluent bindings for ObservableValue [v14]

2022-03-22 Thread John Hendrikx
> This is an implementation of the proposal in > https://bugs.openjdk.java.net/browse/JDK-8274771 that me and Nir Lisker > (@nlisker) have been working on. It's a complete implementation including > good test coverage. > > This was based on https://github.com/openjdk/jfx/pull/434 but with a