Re: RFR: 8283218: Update GStreamer to 1.20.1 [v4]
On Mon, 18 Apr 2022 18:38:03 GMT, Alexander Matveev wrote: >> - GStreamer updated to 1.20.1 and GLib updated to 2.72.0. >> - No changes to our code, except in GstAudioSpectrum.cpp >> g_atomic_pointer_compare_and_exchange() was changed to >> g_atomic_pointer_set(). For some reason I was not able to get code compiled >> with g_atomic_pointer_compare_and_exchange() used from C++ code. Also, I do >> not see a need to use g_atomic_pointer_compare_and_exchange(), since >> m_pHolder always equals to old_holder. >> - Tested on all platforms with all supported media streams. > > Alexander Matveev has updated the pull request incrementally with one > additional commit since the last revision: > > 8283218: Update GStreamer to 1.20.1 [v4] The latest patch builds and runs for me now on Ubuntu 16.04. I do want to make sure that regardless of whatever system we build it on, the binary is able to run on the oldest version we are targeting. Otherwise, a binary built on, say, Oracle Linux 7.x or Ubuntu 20.04 might not run on an Ubuntu 16.04 system. Basically what we don't want is to be dependent on a particular version of libraries at compile time. The more I think about it, the best long term solution (not this time) is probably to build and deliver glib-lite.so on Linux. - PR: https://git.openjdk.java.net/jfx/pull/768
Re: RFR: 8283218: Update GStreamer to 1.20.1 [v4]
On Mon, 18 Apr 2022 18:38:03 GMT, Alexander Matveev wrote: >> - GStreamer updated to 1.20.1 and GLib updated to 2.72.0. >> - No changes to our code, except in GstAudioSpectrum.cpp >> g_atomic_pointer_compare_and_exchange() was changed to >> g_atomic_pointer_set(). For some reason I was not able to get code compiled >> with g_atomic_pointer_compare_and_exchange() used from C++ code. Also, I do >> not see a need to use g_atomic_pointer_compare_and_exchange(), since >> m_pHolder always equals to old_holder. >> - Tested on all platforms with all supported media streams. > > Alexander Matveev has updated the pull request incrementally with one > additional commit since the last revision: > > 8283218: Update GStreamer to 1.20.1 [v4] 8283218: Update GStreamer to 1.20.1 [v5] - Added missing define which required for Windows 32-bit build. - PR: https://git.openjdk.java.net/jfx/pull/768
Re: RFR: 8283218: Update GStreamer to 1.20.1 [v5]
> - GStreamer updated to 1.20.1 and GLib updated to 2.72.0. > - No changes to our code, except in GstAudioSpectrum.cpp > g_atomic_pointer_compare_and_exchange() was changed to > g_atomic_pointer_set(). For some reason I was not able to get code compiled > with g_atomic_pointer_compare_and_exchange() used from C++ code. Also, I do > not see a need to use g_atomic_pointer_compare_and_exchange(), since > m_pHolder always equals to old_holder. > - Tested on all platforms with all supported media streams. Alexander Matveev has updated the pull request incrementally with one additional commit since the last revision: 8283218: Update GStreamer to 1.20.1 [v5] - Changes: - all: https://git.openjdk.java.net/jfx/pull/768/files - new: https://git.openjdk.java.net/jfx/pull/768/files/a29cd34b..39f0b050 Webrevs: - full: https://webrevs.openjdk.java.net/?repo=jfx=768=04 - incr: https://webrevs.openjdk.java.net/?repo=jfx=768=03-04 Stats: 1 line in 1 file changed: 1 ins; 0 del; 0 mod Patch: https://git.openjdk.java.net/jfx/pull/768.diff Fetch: git fetch https://git.openjdk.java.net/jfx pull/768/head:pull/768 PR: https://git.openjdk.java.net/jfx/pull/768
RFR: 8285217: [Android] Window's screen is not updated after native screen was disposed
This PR updates the screen for each window even for the case where the old screen has been disposed but there is a new screen instance found for such window. This is the case of Android, where the lifecycle of the application allows destroying the native screen when the app goes to the background, and providing a new native screen, in case it comes back to the foreground. Before this PR, the screen for the window wasn't updated after returning from the background, and if orientation changes happened, the dimensions were wrong. - Commit messages: - Update the screen for each window even after old screen being disposed Changes: https://git.openjdk.java.net/jfx/pull/778/files Webrev: https://webrevs.openjdk.java.net/?repo=jfx=778=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8285217 Stats: 4 lines in 1 file changed: 1 ins; 0 del; 3 mod Patch: https://git.openjdk.java.net/jfx/pull/778.diff Fetch: git fetch https://git.openjdk.java.net/jfx pull/778/head:pull/778 PR: https://git.openjdk.java.net/jfx/pull/778
[jfx11u] Integrated: 8283328: Update libxml2 to 2.9.13
On Wed, 20 Apr 2022 13:21:39 GMT, Johan Vos wrote: > Reviewed-by: jvos, kcr, arapte This pull request has now been integrated. Changeset: 1b214b04 Author:Johan Vos URL: https://git.openjdk.java.net/jfx11u/commit/1b214b04f78e5bbf2d49f63e7995f55141dba6b4 Stats: 55661 lines in 105 files changed: 5761 ins; 24999 del; 24901 mod 8283328: Update libxml2 to 2.9.13 Backport-of: b0f2521219efc1b0d0c45088736d5105712bc2c9 - PR: https://git.openjdk.java.net/jfx11u/pull/84
[jfx18] Integrated: 8283328: Update libxml2 to 2.9.13
On Wed, 20 Apr 2022 13:29:36 GMT, Johan Vos wrote: > Reviewed-by: jvos, kcr, arapte This pull request has now been integrated. Changeset: 2a1805a2 Author:Johan Vos URL: https://git.openjdk.java.net/jfx/commit/2a1805a2b9ac83011677b654d2505d7147a6e916 Stats: 55661 lines in 105 files changed: 5761 ins; 24999 del; 24901 mod 8283328: Update libxml2 to 2.9.13 Backport-of: b0f2521219efc1b0d0c45088736d5105712bc2c9 - PR: https://git.openjdk.java.net/jfx/pull/777
[jfx17u] Integrated: 8283328: Update libxml2 to 2.9.13
On Wed, 20 Apr 2022 13:24:53 GMT, Johan Vos wrote: > Reviewed-by: jvos, kcr, arapte This pull request has now been integrated. Changeset: 5c0d0a65 Author:Johan Vos URL: https://git.openjdk.java.net/jfx17u/commit/5c0d0a653f6066c545b2cc61655f29e99c9ccca6 Stats: 55661 lines in 105 files changed: 5761 ins; 24999 del; 24901 mod 8283328: Update libxml2 to 2.9.13 Backport-of: b0f2521219efc1b0d0c45088736d5105712bc2c9 - PR: https://git.openjdk.java.net/jfx17u/pull/41
Re: [jfx18] RFR: 8283328: Update libxml2 to 2.9.13
On Wed, 20 Apr 2022 13:29:36 GMT, Johan Vos wrote: > Reviewed-by: jvos, kcr, arapte I confirm that this is a clean backport, but Skara failed to detect that it was clean due to [SKARA-1332](https://bugs.openjdk.java.net/browse/SKARA-1332). - PR: https://git.openjdk.java.net/jfx/pull/777
Re: [jfx11u] RFR: 8283328: Update libxml2 to 2.9.13
On Wed, 20 Apr 2022 13:21:39 GMT, Johan Vos wrote: > Reviewed-by: jvos, kcr, arapte I confirm that this is a clean backport, but Skara failed to detect that it was clean due to [SKARA-1332](https://bugs.openjdk.java.net/browse/SKARA-1332). - PR: https://git.openjdk.java.net/jfx11u/pull/84
Re: [jfx17u] RFR: 8283328: Update libxml2 to 2.9.13
On Wed, 20 Apr 2022 13:24:53 GMT, Johan Vos wrote: > Reviewed-by: jvos, kcr, arapte I confirm that this is a clean backport, but Skara failed to detect that it was clean due to [SKARA-1332](https://bugs.openjdk.java.net/browse/SKARA-1332). - PR: https://git.openjdk.java.net/jfx17u/pull/41
[jfx18] RFR: 8283328: Update libxml2 to 2.9.13
Reviewed-by: jvos, kcr, arapte - Commit messages: - 8283328: Update libxml2 to 2.9.13 Changes: https://git.openjdk.java.net/jfx/pull/777/files Webrev: https://webrevs.openjdk.java.net/?repo=jfx=777=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8283328 Stats: 55661 lines in 105 files changed: 5761 ins; 24999 del; 24901 mod Patch: https://git.openjdk.java.net/jfx/pull/777.diff Fetch: git fetch https://git.openjdk.java.net/jfx pull/777/head:pull/777 PR: https://git.openjdk.java.net/jfx/pull/777
[jfx17u] RFR: 8283328: Update libxml2 to 2.9.13
Reviewed-by: jvos, kcr, arapte - Commit messages: - 8283328: Update libxml2 to 2.9.13 Changes: https://git.openjdk.java.net/jfx17u/pull/41/files Webrev: https://webrevs.openjdk.java.net/?repo=jfx17u=41=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8283328 Stats: 55661 lines in 105 files changed: 5761 ins; 24999 del; 24901 mod Patch: https://git.openjdk.java.net/jfx17u/pull/41.diff Fetch: git fetch https://git.openjdk.java.net/jfx17u pull/41/head:pull/41 PR: https://git.openjdk.java.net/jfx17u/pull/41
[jfx11u] RFR: 8283328: Update libxml2 to 2.9.13
Reviewed-by: jvos, kcr, arapte - Commit messages: - 8283328: Update libxml2 to 2.9.13 Changes: https://git.openjdk.java.net/jfx11u/pull/84/files Webrev: https://webrevs.openjdk.java.net/?repo=jfx11u=84=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8283328 Stats: 55661 lines in 105 files changed: 5761 ins; 24999 del; 24901 mod Patch: https://git.openjdk.java.net/jfx11u/pull/84.diff Fetch: git fetch https://git.openjdk.java.net/jfx11u pull/84/head:pull/84 PR: https://git.openjdk.java.net/jfx11u/pull/84
Re: [External] : Backport requests for JavaFX 11, 17, 18
+1 On 4/20/2022 5:59 AM, Johan Vos wrote: Hi Kevin, I request permission to backport the following issue to JavaFX 11.0.16, JavaFX 17.0.4 and JavaFX 18.0.2 https://bugs.openjdk.java.net/browse/JDK-8283328 Apart from whitespace warnings, the patch applies clean - Johan
[jfx18] Integrated: 8285181: Change JavaFX release version to 18.0.2 in jfx18 branch
On Wed, 20 Apr 2022 07:00:46 GMT, Johan Vos wrote: > Increase security version to 2 for JavaFX 18.0.2 This pull request has now been integrated. Changeset: 60d76c8b Author:Johan Vos URL: https://git.openjdk.java.net/jfx/commit/60d76c8b5d60a816376aa569ad562b56fc790b4c Stats: 2 lines in 2 files changed: 0 ins; 0 del; 2 mod 8285181: Change JavaFX release version to 18.0.2 in jfx18 branch Reviewed-by: kcr - PR: https://git.openjdk.java.net/jfx/pull/776
Backport requests for JavaFX 11, 17, 18
Hi Kevin, I request permission to backport the following issue to JavaFX 11.0.16, JavaFX 17.0.4 and JavaFX 18.0.2 https://bugs.openjdk.java.net/browse/JDK-8283328 Apart from whitespace warnings, the patch applies clean - Johan
[jfx11u] Integrated: 8285152: Change JavaFX release version to 11.0.16 in jfx11u
On Wed, 20 Apr 2022 06:37:08 GMT, Johan Vos wrote: > Update security version for JavaFX 11 to 16. This pull request has now been integrated. Changeset: f0440390 Author:Johan Vos URL: https://git.openjdk.java.net/jfx11u/commit/f0440390bdb064c7a5a4cfd19bdba47322cd3009 Stats: 2 lines in 2 files changed: 0 ins; 0 del; 2 mod 8285152: Change JavaFX release version to 11.0.16 in jfx11u Reviewed-by: kcr - PR: https://git.openjdk.java.net/jfx11u/pull/83
[jfx17u] Integrated: 8285153: Change JavaFX release version to 17.0.4 in jfx17u
On Wed, 20 Apr 2022 06:43:32 GMT, Johan Vos wrote: > Update security version for JavaFX 17 to 4. This pull request has now been integrated. Changeset: b41307ff Author:Johan Vos URL: https://git.openjdk.java.net/jfx17u/commit/b41307ff3f0cec70f1eafe808173ec0fb0cba36c Stats: 2 lines in 2 files changed: 0 ins; 0 del; 2 mod 8285153: Change JavaFX release version to 17.0.4 in jfx17u Reviewed-by: kcr - PR: https://git.openjdk.java.net/jfx17u/pull/40
Re: [jfx11u] RFR: 8285152: Change JavaFX release version to 11.0.16 in jfx11u
On Wed, 20 Apr 2022 06:37:08 GMT, Johan Vos wrote: > Update security version for JavaFX 11 to 16. Marked as reviewed by kcr (Lead). - PR: https://git.openjdk.java.net/jfx11u/pull/83
Re: [jfx17u] RFR: 8285153: Change JavaFX release version to 17.0.4 in jfx17u
On Wed, 20 Apr 2022 06:43:32 GMT, Johan Vos wrote: > Update security version for JavaFX 17 to 4. Marked as reviewed by kcr (Lead). - PR: https://git.openjdk.java.net/jfx17u/pull/40
Re: [jfx18] RFR: 8285181: Change JavaFX release version to 18.0.2 in jfx18 branch
On Wed, 20 Apr 2022 07:00:46 GMT, Johan Vos wrote: > Increase security version to 2 for JavaFX 18.0.2 Marked as reviewed by kcr (Lead). - PR: https://git.openjdk.java.net/jfx/pull/776
Re: RFR: 8251480: TableColumnHeader: calc of cell width must respect row styling
On Tue, 19 Apr 2022 09:57:58 GMT, Marius Hanl wrote: >>> @effad Do you have time and interest to take a look at this for the >>> `TreeTableView` as well? Just asking as otherwise I will have a look :) >> >> Sorry for late response (extended easter holidays ...). Yes I could also >> take a look at this for TreeTableView. Is there a pre-existing issue for >> this? Otherwise I'll try and come up with an example and create a new >> issue... > >> Is there a pre-existing issue for this? Otherwise I'll try and come up with >> an example and create a new issue... > > I don't think so, you may need to create a new issue. I think it's pretty > much the same problem and solution as this ticket was, so you can probably > copy some information. @Maran23 https://bugs.openjdk.java.net/browse/JDK-8285197 created. - PR: https://git.openjdk.java.net/jfx/pull/757
[jfx17u] RFR: 8285153: Change JavaFX release version to 17.0.4 in jfx17u
Update security version for JavaFX 17 to 4. - Commit messages: - Increase security version to 4 Changes: https://git.openjdk.java.net/jfx17u/pull/40/files Webrev: https://webrevs.openjdk.java.net/?repo=jfx17u=40=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8285153 Stats: 2 lines in 2 files changed: 0 ins; 0 del; 2 mod Patch: https://git.openjdk.java.net/jfx17u/pull/40.diff Fetch: git fetch https://git.openjdk.java.net/jfx17u pull/40/head:pull/40 PR: https://git.openjdk.java.net/jfx17u/pull/40
[jfx18] RFR: 8285181: Change JavaFX release version to 18.0.2 in jfx18 branch
Increase security version to 2 for JavaFX 18.0.2 - Commit messages: - Increase security version to 2 for JavaFX 18.0.2 Changes: https://git.openjdk.java.net/jfx/pull/776/files Webrev: https://webrevs.openjdk.java.net/?repo=jfx=776=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8285181 Stats: 2 lines in 2 files changed: 0 ins; 0 del; 2 mod Patch: https://git.openjdk.java.net/jfx/pull/776.diff Fetch: git fetch https://git.openjdk.java.net/jfx pull/776/head:pull/776 PR: https://git.openjdk.java.net/jfx/pull/776
[jfx11u] RFR: 8285152: Change JavaFX release version to 11.0.16 in jfx11u
Update security version for JavaFX 11 to 16. - Commit messages: - Update security version for JavaFX 11 to 16. Changes: https://git.openjdk.java.net/jfx11u/pull/83/files Webrev: https://webrevs.openjdk.java.net/?repo=jfx11u=83=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8285152 Stats: 2 lines in 2 files changed: 0 ins; 0 del; 2 mod Patch: https://git.openjdk.java.net/jfx11u/pull/83.diff Fetch: git fetch https://git.openjdk.java.net/jfx11u pull/83/head:pull/83 PR: https://git.openjdk.java.net/jfx11u/pull/83
