Re: SceneBuilder

2015-01-09 Thread Eric Le Ponner
Hi Adam,

You correctly filled the JIRA. We're simply late.

Indeed Scene Builder 1.x used to allow to setup
(some) properties on fx:include object.
And Scene Builder 2 does not provide this.
We should probably reconsider this choice.

Note that you may wrap your fx:include in a StackPane instance
and tune the layout constraints on the StackPane using SB. This 
works pretty well. And it avoids the parent FXML file to make
some assumptions on the child FXML file.

Regards,

Eric



On 09 Jan 2015, at 08:34, Adam Granger  wrote:

> I raised this December 4th, I understand everyone is busy, but this hasn't
> even been triaged. Did I fill out the wrong fields the JIRA?
> 
> Cannot set layout constraints for included FXML (fx:include)
>  - http://javafx-jira.kenai.com/browse/DTL-6915
> 
> When including another FXML node (via File -> Import -> FXML) there is no
> way to set its layout attributes using the Scene Builder tool, the layout
> panel is empty.
> 
> For example, if I wished to set the following child.fxml to fill its
> parent VBox vertically this cannot be done using the UI.
> 
> 
> 
> 
>  minWidth="-Infinity" prefHeight="500.0" prefWidth="500.0"
> xmlns="http://javafx.com/javafx/8"; xmlns:fx="http://javafx.com/fxml/1";>
>   
>  
>   
> 
> 
> FXML seems to support this "under the hood", if I manually edit the file,
> scene builder preview (and my actual app using FXMLLoader) work correctly.
> 
>  minWidth="-Infinity" prefHeight="500.0" prefWidth="500.0"
> xmlns="http://javafx.com/javafx/8"; xmlns:fx="http://javafx.com/fxml/1";>
>   
>  
>   
> 
> 
> According to my colleague this was possible in an older version of Scene
> Builder
> 
> Regards,
> 
> Adam.
> 
> 



Re: Make TableView height match content

2015-01-07 Thread Eric Le Ponner
On 07 Jan 2015, at 11:49, Werner Lehmann  wrote:

> Hi Dan,
> 
> typically it is not a good idea to do this. TableView has a reason to manage 
> scrolling on its own: if the tableview has 10 items you don't want to 
> have all these nodes in the scenegraph when it is sufficent to show the 
> visible ones.
> 
> Your approach may have some value if the number of items is quite low. In 
> that case I'd suggest to skip tableview and put your items in that same vbox. 
> Of course you'd have to handle columns yourself then.

GridPane would make column handling will be a bit easier.

Eric

> 
> Werner
> 
> On 06.01.2015 21:26, Dan Smith wrote:
>> Putting this another way: TableViews automatically wrap their content
>> in a (implicit?) scroll pane.  I'd like to turn that off.  Is there
>> any way to do so?



hg: openjfx/8u-dev/rt: [SCENEBUILDER] Changed shortcut for ZoomOut to CMD and / (DTL-6790).

2014-09-16 Thread eric . le . ponner
Changeset: f965f6d9b20a
Author:Eric Le Ponner 
Date:  2014-09-16 11:12 +0200
URL:   http://hg.openjdk.java.net/openjfx/8u-dev/rt/rev/f965f6d9b20a

[SCENEBUILDER] Changed shortcut for ZoomOut to CMD and / (DTL-6790).

! 
apps/scenebuilder/SceneBuilderApp/src/com/oracle/javafx/scenebuilder/app/menubar/MenuBarController.java



hg: openjfx/8u-dev/rt: [SCENEBUILDER] Fix for DTL-6879 (Content Panel can fail to visualise CSS changes from external style sheet).

2014-09-16 Thread eric . le . ponner
Changeset: 2c70de168a90
Author:Eric Le Ponner 
Date:  2014-09-16 11:05 +0200
URL:   http://hg.openjdk.java.net/openjfx/8u-dev/rt/rev/2c70de168a90

[SCENEBUILDER] Fix for DTL-6879 (Content Panel can fail to visualise CSS 
changes from external style sheet).

! 
apps/scenebuilder/SceneBuilderApp/src/com/oracle/javafx/scenebuilder/app/preview/PreviewWindowController.java
! 
apps/scenebuilder/SceneBuilderKit/src/com/oracle/javafx/scenebuilder/kit/editor/panel/inspector/editors/StylesheetEditor.java
! 
apps/scenebuilder/SceneBuilderKit/src/com/oracle/javafx/scenebuilder/kit/fxom/FXOMDocument.java
! 
apps/scenebuilder/SceneBuilderKit/src/com/oracle/javafx/scenebuilder/kit/util/Deprecation.java



hg: openjfx/8u-dev/rt: [SCENEBUILDER] Moved content of EditorController.performAddTooltip() into AddTooltipToSelectionJob class.

2014-09-12 Thread eric . le . ponner
Changeset: 6d5af625b22a
Author:Eric Le Ponner 
Date:  2014-09-12 11:43 +0200
URL:   http://hg.openjdk.java.net/openjfx/8u-dev/rt/rev/6d5af625b22a

[SCENEBUILDER] Moved content of EditorController.performAddTooltip() into  
AddTooltipToSelectionJob class.

! 
apps/scenebuilder/SceneBuilderKit/src/com/oracle/javafx/scenebuilder/kit/editor/EditorController.java
! 
apps/scenebuilder/SceneBuilderKit/src/com/oracle/javafx/scenebuilder/kit/editor/job/AddTooltipToSelectionJob.java
 < 
apps/scenebuilder/SceneBuilderKit/src/com/oracle/javafx/scenebuilder/kit/editor/job/AddContextMenuToSelectionJob.java



hg: openjfx/8u-dev/rt: [SCENEBUILDER] Moved content of EditorController.performAddContextMenu() into AddContextMenuToSelectionJob class.

2014-09-12 Thread eric . le . ponner
Changeset: 787b2e2d5c86
Author:Eric Le Ponner 
Date:  2014-09-12 11:15 +0200
URL:   http://hg.openjdk.java.net/openjfx/8u-dev/rt/rev/787b2e2d5c86

[SCENEBUILDER] Moved content of EditorController.performAddContextMenu() into  
AddContextMenuToSelectionJob class.

! 
apps/scenebuilder/SceneBuilderKit/src/com/oracle/javafx/scenebuilder/kit/editor/EditorController.java
+ 
apps/scenebuilder/SceneBuilderKit/src/com/oracle/javafx/scenebuilder/kit/editor/job/AddContextMenuToSelectionJob.java



hg: openjfx/8u-dev/rt: [SCENEBUILDER] SetDocumentRootJob now takes responsibility to invoke UsePredefinedSizeJob (part of DTL-6783).

2014-09-11 Thread eric . le . ponner
Changeset: 12530777d84a
Author:Eric Le Ponner 
Date:  2014-09-11 18:54 +0200
URL:   http://hg.openjdk.java.net/openjfx/8u-dev/rt/rev/12530777d84a

[SCENEBUILDER] SetDocumentRootJob now takes responsibility to invoke 
UsePredefinedSizeJob (part of DTL-6783).
This removes some code duplication and avoids creating some BatchJob instances.

! 
apps/scenebuilder/SceneBuilderKit/src/com/oracle/javafx/scenebuilder/kit/editor/EditorController.java
! 
apps/scenebuilder/SceneBuilderKit/src/com/oracle/javafx/scenebuilder/kit/editor/drag/target/RootDropTarget.java
! 
apps/scenebuilder/SceneBuilderKit/src/com/oracle/javafx/scenebuilder/kit/editor/job/SetDocumentRootJob.java



Re: Need help with ScrollPane sizing inside nested panes

2014-09-11 Thread Eric Le Ponner
Try using StackPane in place of Pane.
Pane is pretty basic in term of layout capabilities.

Eric


On 11 Sep 2014, at 01:46, Kevin Smith  wrote:

> If we have a Pane containing a ScrollPane containing a GridPane,
> everything works as expected. But as soon as we inject a second Pane
> (which is hard for us to avoid in this case), the ScrollPane no longer
> grows to fit its space. See the example app below. Without "inner", it
> works great.
> 
> Is there a simple way to get the ScrollPane to fill its parent?
> 
> I have tried every combination of prefWidth and prefViewportWidth that I
> can think of, and I have tried Border Pane, and nothing has worked. I
> have searched the web, but have been unable to find an answer to this.
> If the answer is already out there, please feel free to just point me to
> it.
> 
> I just upgraded to Java 8u20, which didn't help.
> 
> Thanks,
> 
> 
> Kevin
> 
> public class FxScrollPaneTest extends Application
> {
>public static void main(String[] args)
>{
>launch(args);
>}
> 
>@Override
>public void start(Stage primaryStage)
>{
>primaryStage.setTitle("Hello World!");
>   
>GridPane grid = new GridPane();
> 
>grid.add(new Label("upper left"), 0, 0);
>grid.add(new Label("upper right"), 1, 0);
>grid.add(new Label("lower left"), 0, 1);
>grid.add(new Label("lower left"), 1, 1);
>   
>Pane root = new Pane();
>Pane inner = new Pane();
>root.getChildren().add(inner);
>ScrollPane scroller = new ScrollPane(grid);
>inner.getChildren().add(scroller);
>primaryStage.setScene(new Scene(root, 300, 250));
>primaryStage.show();
>}
> }



hg: openjfx/8u-dev/rt: [SCENEBUILDER] Fix for DTL-6817 (SB should resolve lookups defined in a .root style class).

2014-09-11 Thread eric . le . ponner
Changeset: 4fd7ffb45afb
Author:Eric Le Ponner 
Date:  2014-09-11 12:16 +0200
URL:   http://hg.openjdk.java.net/openjfx/8u-dev/rt/rev/4fd7ffb45afb

[SCENEBUILDER] Fix for DTL-6817 (SB should resolve lookups defined in a .root 
style class).

! 
apps/scenebuilder/SceneBuilderKit/src/com/oracle/javafx/scenebuilder/kit/fxom/FXOMRefresher.java



hg: openjfx/8u-dev/rt: 2 new changesets

2014-09-10 Thread eric . le . ponner
Changeset: d8c7120ab268
Author:Eric Le Ponner 
Date:  2014-09-10 12:02 +0200
URL:   http://hg.openjdk.java.net/openjfx/8u-dev/rt/rev/d8c7120ab268

[SCENEBUILDER] Fix for DTL-6837 (NPE when using X or Y rotationAxis).

! 
apps/scenebuilder/SceneBuilderKit/src/com/oracle/javafx/scenebuilder/kit/editor/panel/content/ContentPanelController.java

Changeset: c9450b73265d
Author:Eric Le Ponner 
Date:  2014-09-10 17:11 +0200
URL:   http://hg.openjdk.java.net/openjfx/8u-dev/rt/rev/c9450b73265d

[SCENEBUILDER] Merge (no conflict).




hg: openjfx/8u-dev/rt: [SCENEBUILDER] Removed dead variables form UpdateReferencesJob to fix DLS_DEAD_LOCAL_STORE warning from FindBugs.

2014-09-09 Thread eric . le . ponner
Changeset: 31ebc23af41d
Author:Eric Le Ponner 
Date:  2014-09-09 20:15 +0200
URL:   http://hg.openjdk.java.net/openjfx/8u-dev/rt/rev/31ebc23af41d

[SCENEBUILDER] Removed dead variables form UpdateReferencesJob to fix 
DLS_DEAD_LOCAL_STORE warning from FindBugs.

! 
apps/scenebuilder/SceneBuilderKit/src/com/oracle/javafx/scenebuilder/kit/editor/job/reference/UpdateReferencesJob.java



hg: openjfx/8u-dev/rt: [SCENEBUILDER] Fix for DTL-6641 (Remove workaround for DTL-6628).

2014-09-09 Thread eric . le . ponner
Changeset: a64315959187
Author:Eric Le Ponner 
Date:  2014-09-09 17:22 +0200
URL:   http://hg.openjdk.java.net/openjfx/8u-dev/rt/rev/a64315959187

[SCENEBUILDER] Fix for DTL-6641 (Remove workaround for DTL-6628).

! 
apps/scenebuilder/SceneBuilderKit/src/com/oracle/javafx/scenebuilder/kit/editor/panel/content/AbstractDecoration.java



hg: openjfx/8u-dev/rt: [SCENEBUILDER] UpdateReferencesJob should not invoke Selection.beginUpdate()/endUpdate().

2014-09-09 Thread eric . le . ponner
Changeset: aaf6fe8865fc
Author:Eric Le Ponner 
Date:  2014-09-09 16:22 +0200
URL:   http://hg.openjdk.java.net/openjfx/8u-dev/rt/rev/aaf6fe8865fc

[SCENEBUILDER] UpdateReferencesJob should not invoke 
Selection.beginUpdate()/endUpdate().
Only subjobs that actually change the selection should do that.

! 
apps/scenebuilder/SceneBuilderKit/src/com/oracle/javafx/scenebuilder/kit/editor/job/reference/UpdateReferencesJob.java



hg: openjfx/8u-dev/rt: [SCENEBUILDER] Content panel now uses SubScene (DTL-6797).

2014-09-09 Thread eric . le . ponner
Changeset: 86b0f5599fad
Author:Eric Le Ponner 
Date:  2014-09-09 15:55 +0200
URL:   http://hg.openjdk.java.net/openjfx/8u-dev/rt/rev/86b0f5599fad

[SCENEBUILDER] Content panel now uses SubScene (DTL-6797).

! 
apps/scenebuilder/SceneBuilderKit/src/com/oracle/javafx/scenebuilder/kit/editor/panel/content/AbstractDecoration.java
! 
apps/scenebuilder/SceneBuilderKit/src/com/oracle/javafx/scenebuilder/kit/editor/panel/content/ContentPanel.fxml
! 
apps/scenebuilder/SceneBuilderKit/src/com/oracle/javafx/scenebuilder/kit/editor/panel/content/ContentPanelController.java
! 
apps/scenebuilder/SceneBuilderKit/src/com/oracle/javafx/scenebuilder/kit/editor/panel/content/WorkspaceController.java
! 
apps/scenebuilder/SceneBuilderKit/src/com/oracle/javafx/scenebuilder/kit/util/Deprecation.java



hg: openjfx/8u-dev/rt: [SCENEBUILDER] Additional fix for DTL-6790 (Add Zoom In (CMD +) and Zoom Out (CMD -) to Menubar > View > Zoom).

2014-09-09 Thread eric . le . ponner
Changeset: d62cb8404b84
Author:Eric Le Ponner 
Date:  2014-09-09 11:01 +0200
URL:   http://hg.openjdk.java.net/openjfx/8u-dev/rt/rev/d62cb8404b84

[SCENEBUILDER] Additional fix for DTL-6790 (Add Zoom In (CMD +) and Zoom Out 
(CMD -) to Menubar > View > Zoom).
Replaced CMD/- by CMD/SHIFT/- (because of RT-37805).

! 
apps/scenebuilder/SceneBuilderApp/src/com/oracle/javafx/scenebuilder/app/menubar/MenuBarController.java



hg: openjfx/8u-dev/rt: [SCENEBUILDER] Fix for DTL-6790 (Add Zoom In (CMD +) and Zoom Out (CMD -) to Menubar > View > Zoom).

2014-09-09 Thread eric . le . ponner
Changeset: 2e40d9c0d7e4
Author:Eric Le Ponner 
Date:  2014-09-09 10:24 +0200
URL:   http://hg.openjdk.java.net/openjfx/8u-dev/rt/rev/2e40d9c0d7e4

[SCENEBUILDER] Fix for DTL-6790 (Add Zoom In (CMD +) and Zoom Out (CMD -) to 
Menubar > View > Zoom).

! 
apps/scenebuilder/SceneBuilderApp/src/com/oracle/javafx/scenebuilder/app/i18n/SceneBuilderApp.properties
! 
apps/scenebuilder/SceneBuilderApp/src/com/oracle/javafx/scenebuilder/app/menubar/MenuBarController.java



hg: openjfx/8u-dev/rt: [SCENEBUILDER] Last (?) preparatory work to ease migration to SubScene.

2014-09-05 Thread eric . le . ponner
Changeset: 0d65ca9c3cef
Author:Eric Le Ponner 
Date:  2014-09-05 12:47 +0200
URL:   http://hg.openjdk.java.net/openjfx/8u-dev/rt/rev/0d65ca9c3cef

[SCENEBUILDER] Last (?) preparatory work to ease migration to SubScene.
Transforms calls to Node.localToScene(Bounds) as calls to 
Node.localToScene(Bounds, Boolean).

! 
apps/scenebuilder/SceneBuilderApp/src/com/oracle/javafx/scenebuilder/app/SceneBuilderTest.java
! 
apps/scenebuilder/SceneBuilderKit/src/com/oracle/javafx/scenebuilder/kit/editor/job/atomic/RelocateNodeJob.java
! 
apps/scenebuilder/SceneBuilderKit/src/com/oracle/javafx/scenebuilder/kit/editor/panel/content/ContentPanelController.java
! 
apps/scenebuilder/SceneBuilderKit/src/com/oracle/javafx/scenebuilder/kit/editor/panel/content/driver/AbstractNodeDriver.java
! 
apps/scenebuilder/SceneBuilderKit/src/com/oracle/javafx/scenebuilder/kit/editor/panel/content/driver/TabDriver.java
! 
apps/scenebuilder/SceneBuilderKit/src/com/oracle/javafx/scenebuilder/kit/editor/panel/content/driver/TableColumnDriver.java
! 
apps/scenebuilder/SceneBuilderKit/src/com/oracle/javafx/scenebuilder/kit/editor/panel/content/driver/TreeTableColumnDriver.java
! 
apps/scenebuilder/SceneBuilderKit/src/com/oracle/javafx/scenebuilder/kit/editor/panel/content/gesture/DragGesture.java
! 
apps/scenebuilder/SceneBuilderKit/src/com/oracle/javafx/scenebuilder/kit/editor/panel/content/guides/MovingGuideController.java
! 
apps/scenebuilder/SceneBuilderKit/src/com/oracle/javafx/scenebuilder/kit/editor/panel/content/guides/MovingGuideRenderer.java
! 
apps/scenebuilder/SceneBuilderKit/src/com/oracle/javafx/scenebuilder/kit/editor/panel/content/guides/ResizingGuideController.java
! 
apps/scenebuilder/SceneBuilderKit/src/com/oracle/javafx/scenebuilder/kit/editor/panel/hierarchy/treeview/HierarchyTreeCell.java



hg: openjfx/8u-dev/rt: [SCENEBUILDER] Some other preparatory work to ease migration to SubScene.

2014-09-05 Thread eric . le . ponner
Changeset: f8b58635d604
Author:Eric Le Ponner 
Date:  2014-09-05 12:32 +0200
URL:   http://hg.openjdk.java.net/openjfx/8u-dev/rt/rev/f8b58635d604

[SCENEBUILDER] Some other preparatory work to ease migration to SubScene.
Added Deprecation.localToLocal() routines and use them everywhere possible.
This routine shields the rootScene / not rootScene question.

! 
apps/scenebuilder/SceneBuilderKit/src/com/oracle/javafx/scenebuilder/kit/editor/panel/content/AbstractDecoration.java
! 
apps/scenebuilder/SceneBuilderKit/src/com/oracle/javafx/scenebuilder/kit/editor/panel/content/driver/TabPaneDesignInfoX.java
! 
apps/scenebuilder/SceneBuilderKit/src/com/oracle/javafx/scenebuilder/kit/editor/panel/content/driver/TableViewDesignInfoX.java
! 
apps/scenebuilder/SceneBuilderKit/src/com/oracle/javafx/scenebuilder/kit/editor/panel/content/driver/TreeTableViewDesignInfoX.java
! 
apps/scenebuilder/SceneBuilderKit/src/com/oracle/javafx/scenebuilder/kit/editor/panel/content/driver/handles/TabHandles.java
! 
apps/scenebuilder/SceneBuilderKit/src/com/oracle/javafx/scenebuilder/kit/editor/panel/content/driver/tring/GenericParentTring.java
! 
apps/scenebuilder/SceneBuilderKit/src/com/oracle/javafx/scenebuilder/kit/editor/panel/inspector/InspectorPanelController.java
! 
apps/scenebuilder/SceneBuilderKit/src/com/oracle/javafx/scenebuilder/kit/util/Deprecation.java



hg: openjfx/8u-dev/rt: [SCENEBUILDER] Another step of prework before migrating to SubScene (DTL-6797).

2014-09-05 Thread eric . le . ponner
Changeset: a2948aa2ab67
Author:Eric Le Ponner 
Date:  2014-09-05 10:11 +0200
URL:   http://hg.openjdk.java.net/openjfx/8u-dev/rt/rev/a2948aa2ab67

[SCENEBUILDER] Another step of prework before migrating to SubScene (DTL-6797).
Content panel now uses Node.localToScene(x,y,true) and 
Node.sceneToLocal(x,y,true) everywhere.
This should make the move to SubScene neutral.

! 
apps/scenebuilder/SceneBuilderKit/src/com/oracle/javafx/scenebuilder/kit/editor/drag/target/ContainerXYDropTarget.java
! 
apps/scenebuilder/SceneBuilderKit/src/com/oracle/javafx/scenebuilder/kit/editor/panel/content/driver/BorderPaneDriver.java
! 
apps/scenebuilder/SceneBuilderKit/src/com/oracle/javafx/scenebuilder/kit/editor/panel/content/driver/GridPaneDriver.java
! 
apps/scenebuilder/SceneBuilderKit/src/com/oracle/javafx/scenebuilder/kit/editor/panel/content/driver/HBoxDriver.java
! 
apps/scenebuilder/SceneBuilderKit/src/com/oracle/javafx/scenebuilder/kit/editor/panel/content/driver/SplitPaneDesignInfoX.java
! 
apps/scenebuilder/SceneBuilderKit/src/com/oracle/javafx/scenebuilder/kit/editor/panel/content/driver/TabPaneDesignInfoX.java
! 
apps/scenebuilder/SceneBuilderKit/src/com/oracle/javafx/scenebuilder/kit/editor/panel/content/driver/TableViewDesignInfoX.java
! 
apps/scenebuilder/SceneBuilderKit/src/com/oracle/javafx/scenebuilder/kit/editor/panel/content/driver/TreeTableViewDesignInfoX.java
! 
apps/scenebuilder/SceneBuilderKit/src/com/oracle/javafx/scenebuilder/kit/editor/panel/content/driver/VBoxDriver.java
! 
apps/scenebuilder/SceneBuilderKit/src/com/oracle/javafx/scenebuilder/kit/editor/panel/content/driver/tring/GenericParentTring.java
! 
apps/scenebuilder/SceneBuilderKit/src/com/oracle/javafx/scenebuilder/kit/editor/panel/content/gesture/DragGesture.java
! 
apps/scenebuilder/SceneBuilderKit/src/com/oracle/javafx/scenebuilder/kit/editor/panel/content/gesture/mouse/ResizeColumnGesture.java
! 
apps/scenebuilder/SceneBuilderKit/src/com/oracle/javafx/scenebuilder/kit/editor/panel/content/gesture/mouse/ResizeGesture.java
! 
apps/scenebuilder/SceneBuilderKit/src/com/oracle/javafx/scenebuilder/kit/editor/panel/content/gesture/mouse/ResizeRowGesture.java
! 
apps/scenebuilder/SceneBuilderKit/src/com/oracle/javafx/scenebuilder/kit/editor/panel/content/gesture/mouse/ResizeTableColumnGesture.java
! 
apps/scenebuilder/SceneBuilderKit/src/com/oracle/javafx/scenebuilder/kit/editor/panel/content/gesture/mouse/ResizeTreeTableColumnGesture.java
! 
apps/scenebuilder/SceneBuilderKit/src/com/oracle/javafx/scenebuilder/kit/editor/panel/content/gesture/mouse/SelectAndMoveGesture.java
! 
apps/scenebuilder/SceneBuilderKit/src/com/oracle/javafx/scenebuilder/kit/editor/panel/content/gesture/mouse/SelectWithMarqueeGesture.java
! 
apps/scenebuilder/SceneBuilderKit/src/com/oracle/javafx/scenebuilder/kit/editor/panel/content/guides/MovingGuideRenderer.java
! 
apps/scenebuilder/SceneBuilderKit/src/com/oracle/javafx/scenebuilder/kit/editor/panel/content/guides/ResizingGuideRenderer.java
! 
apps/scenebuilder/SceneBuilderKit/src/com/oracle/javafx/scenebuilder/kit/editor/panel/content/util/BoundsUtils.java
! 
apps/scenebuilder/SceneBuilderKit/src/com/oracle/javafx/scenebuilder/kit/editor/panel/content/util/Picker.java
! 
apps/scenebuilder/SceneBuilderKit/src/com/oracle/javafx/scenebuilder/kit/util/Deprecation.java



hg: openjfx/8u-dev/rt: [SCENEBUILDER] Fixed some imports.

2014-09-04 Thread eric . le . ponner
Changeset: e57c43d3e16f
Author:Eric Le Ponner 
Date:  2014-09-04 18:40 +0200
URL:   http://hg.openjdk.java.net/openjfx/8u-dev/rt/rev/e57c43d3e16f

[SCENEBUILDER] Fixed some imports.

! 
apps/scenebuilder/SceneBuilderKit/src/com/oracle/javafx/scenebuilder/kit/editor/panel/content/driver/pring/TabPring.java
! 
apps/scenebuilder/SceneBuilderKit/src/com/oracle/javafx/scenebuilder/kit/editor/panel/content/driver/pring/TreeTableColumnPring.java
! 
apps/scenebuilder/SceneBuilderKit/src/com/oracle/javafx/scenebuilder/kit/editor/panel/content/driver/tring/TabTring.java



hg: openjfx/8u-dev/rt: [SCENEBUILDER] Some preparatory work to ease migration to SubScene.

2014-09-04 Thread eric . le . ponner
Changeset: e43736c57ec8
Author:eric.le.ponner 
Date:  2014-09-04 18:29 +0200
URL:   http://hg.openjdk.java.net/openjfx/8u-dev/rt/rev/e43736c57ec8

[SCENEBUILDER] Some preparatory work to ease migration to SubScene.
AbstractDecoration.getSceneGraphToSceneTransform() is now replaced by 
AbstractDecoration.getSceneGraphObjectProxy().

! 
apps/scenebuilder/SceneBuilderKit/src/com/oracle/javafx/scenebuilder/kit/editor/panel/content/AbstractDecoration.java
! 
apps/scenebuilder/SceneBuilderKit/src/com/oracle/javafx/scenebuilder/kit/editor/panel/content/driver/gridpane/GridPanePring.java
! 
apps/scenebuilder/SceneBuilderKit/src/com/oracle/javafx/scenebuilder/kit/editor/panel/content/driver/handles/AbstractCurveHandles.java
! 
apps/scenebuilder/SceneBuilderKit/src/com/oracle/javafx/scenebuilder/kit/editor/panel/content/driver/handles/AbstractNodeHandles.java
! 
apps/scenebuilder/SceneBuilderKit/src/com/oracle/javafx/scenebuilder/kit/editor/panel/content/driver/handles/TabHandles.java
! 
apps/scenebuilder/SceneBuilderKit/src/com/oracle/javafx/scenebuilder/kit/editor/panel/content/driver/handles/TableColumnHandles.java
! 
apps/scenebuilder/SceneBuilderKit/src/com/oracle/javafx/scenebuilder/kit/editor/panel/content/driver/handles/TreeTableColumnHandles.java
! 
apps/scenebuilder/SceneBuilderKit/src/com/oracle/javafx/scenebuilder/kit/editor/panel/content/driver/outline/NodeOutline.java
! 
apps/scenebuilder/SceneBuilderKit/src/com/oracle/javafx/scenebuilder/kit/editor/panel/content/driver/pring/NodePring.java
! 
apps/scenebuilder/SceneBuilderKit/src/com/oracle/javafx/scenebuilder/kit/editor/panel/content/driver/pring/TabPring.java
! 
apps/scenebuilder/SceneBuilderKit/src/com/oracle/javafx/scenebuilder/kit/editor/panel/content/driver/pring/TableColumnPring.java
! 
apps/scenebuilder/SceneBuilderKit/src/com/oracle/javafx/scenebuilder/kit/editor/panel/content/driver/pring/TreeTableColumnPring.java
! 
apps/scenebuilder/SceneBuilderKit/src/com/oracle/javafx/scenebuilder/kit/editor/panel/content/driver/rudder/ResizeRudder.java
! 
apps/scenebuilder/SceneBuilderKit/src/com/oracle/javafx/scenebuilder/kit/editor/panel/content/driver/tring/AbstractNodeTring.java
! 
apps/scenebuilder/SceneBuilderKit/src/com/oracle/javafx/scenebuilder/kit/editor/panel/content/driver/tring/TabTring.java
! 
apps/scenebuilder/SceneBuilderKit/src/com/oracle/javafx/scenebuilder/kit/editor/panel/content/driver/tring/TableColumnTring.java
! 
apps/scenebuilder/SceneBuilderKit/src/com/oracle/javafx/scenebuilder/kit/editor/panel/content/driver/tring/TreeTableColumnTring.java
! 
apps/scenebuilder/SceneBuilderKit/src/com/oracle/javafx/scenebuilder/kit/editor/panel/content/mode/HitNodeChrome.java



hg: openjfx/8u-dev/rt: 2 new changesets

2014-09-04 Thread eric . le . ponner
Changeset: 7753c3b79504
Author:eric.le.pon...@oracle.com
Date:  2014-09-03 19:26 +0200
URL:   http://hg.openjdk.java.net/openjfx/8u-dev/rt/rev/7753c3b79504

[SCENEBUILDER] Removed FXOMNodes.collectToggleGroupReferences() routine (now 
dead code).

! 
apps/scenebuilder/SceneBuilderKit/src/com/oracle/javafx/scenebuilder/kit/fxom/FXOMNodes.java

Changeset: 2f6e9cce8328
Author:eric.le.pon...@oracle.com
Date:  2014-09-04 09:53 +0200
URL:   http://hg.openjdk.java.net/openjfx/8u-dev/rt/rev/2f6e9cce8328

[SCENEBUILDER] merge (no conflict).




hg: openjfx/8u-dev/rt: 2 new changesets

2014-09-03 Thread eric . le . ponner
Changeset: afa5accd7234
Author:eric.le.pon...@oracle.com
Date:  2014-09-03 19:17 +0200
URL:   http://hg.openjdk.java.net/openjfx/8u-dev/rt/rev/afa5accd7234

[SCENEBUILDER] Removed unused code to fix DLS_DEAD_LOCAL_STORE reported by 
FindBugs.

! 
apps/scenebuilder/SceneBuilderKit/src/com/oracle/javafx/scenebuilder/kit/editor/job/reference/FixToggleGroupIntrinsicReferenceJob.java

Changeset: c1d51a6e4338
Author:eric.le.pon...@oracle.com
Date:  2014-09-03 19:18 +0200
URL:   http://hg.openjdk.java.net/openjfx/8u-dev/rt/rev/c1d51a6e4338

[SCENEBUILDER] Removed unused code to fix UCF_USELESS_CONTROL_FLOW reported by 
FindBugs.

! 
apps/scenebuilder/SceneBuilderKit/src/com/oracle/javafx/scenebuilder/kit/editor/job/reference/ObjectDeleter.java



hg: openjfx/8u-dev/rt: [SCENEBUILDER] Removed unused code from ObjectDeleter to fix BC_IMPOSSIBLE_INSTANCEOF from FindBugs.

2014-09-03 Thread eric . le . ponner
Changeset: b9eb9718108b
Author:eric.le.pon...@oracle.com
Date:  2014-09-03 14:22 +0200
URL:   http://hg.openjdk.java.net/openjfx/8u-dev/rt/rev/b9eb9718108b

[SCENEBUILDER] Removed unused code from ObjectDeleter to fix 
BC_IMPOSSIBLE_INSTANCEOF from FindBugs.

! 
apps/scenebuilder/SceneBuilderKit/src/com/oracle/javafx/scenebuilder/kit/editor/job/reference/ObjectDeleter.java



hg: openjfx/8u-dev/rt: 4 new changesets

2014-09-03 Thread eric . le . ponner
Changeset: bef2f999b920
Author:eric.le.pon...@oracle.com
Date:  2014-09-03 10:07 +0200
URL:   http://hg.openjdk.java.net/openjfx/8u-dev/rt/rev/bef2f999b920

[SCENEBUILDER] ReferencesUpdate class now treats ToggleGroup reference with 
some special logic (DTL-6774).

! 
apps/scenebuilder/SceneBuilderKit/src/com/oracle/javafx/scenebuilder/kit/editor/job/atomic/RemovePropertyJob.java
+ 
apps/scenebuilder/SceneBuilderKit/src/com/oracle/javafx/scenebuilder/kit/editor/job/reference/FixToggleGroupExpressionReferenceJob.java
+ 
apps/scenebuilder/SceneBuilderKit/src/com/oracle/javafx/scenebuilder/kit/editor/job/reference/FixToggleGroupIntrinsicReferenceJob.java
+ 
apps/scenebuilder/SceneBuilderKit/src/com/oracle/javafx/scenebuilder/kit/editor/job/reference/FixToggleGroupReferenceJob.java
! 
apps/scenebuilder/SceneBuilderKit/src/com/oracle/javafx/scenebuilder/kit/editor/job/reference/ReferencesUpdater.java
! 
apps/scenebuilder/SceneBuilderKit/src/com/oracle/javafx/scenebuilder/kit/fxom/FXOMNodes.java

Changeset: d89f3f7fd22b
Author:Eric Le Ponner 
Date:  2014-09-03 11:40 +0200
URL:   http://hg.openjdk.java.net/openjfx/8u-dev/rt/rev/d89f3f7fd22b

[SCENEBUILDER] Removed some legacy calls to Selection.clear() from 
AddPropertyJob, AddPropertyValueJob and RemovePropertyJob.

! 
apps/scenebuilder/SceneBuilderKit/src/com/oracle/javafx/scenebuilder/kit/editor/job/atomic/AddPropertyJob.java
! 
apps/scenebuilder/SceneBuilderKit/src/com/oracle/javafx/scenebuilder/kit/editor/job/atomic/AddPropertyValueJob.java
! 
apps/scenebuilder/SceneBuilderKit/src/com/oracle/javafx/scenebuilder/kit/editor/job/atomic/RemovePropertyJob.java

Changeset: bb45978e3156
Author:Eric Le Ponner 
Date:  2014-09-03 11:42 +0200
URL:   http://hg.openjdk.java.net/openjfx/8u-dev/rt/rev/bb45978e3156

[SCENEBUILDER] Removed AdjustAllToggleGroupJob and AdjustToggleGroupJob.
Toggle group consistency is now ensured by UpdateReferencesJob.

! 
apps/scenebuilder/SceneBuilderKit/src/com/oracle/javafx/scenebuilder/kit/editor/drag/target/AccessoryDropTarget.java
! 
apps/scenebuilder/SceneBuilderKit/src/com/oracle/javafx/scenebuilder/kit/editor/drag/target/ContainerXYDropTarget.java
! 
apps/scenebuilder/SceneBuilderKit/src/com/oracle/javafx/scenebuilder/kit/editor/drag/target/ContainerZDropTarget.java
! 
apps/scenebuilder/SceneBuilderKit/src/com/oracle/javafx/scenebuilder/kit/editor/drag/target/GridPaneDropTarget.java
! 
apps/scenebuilder/SceneBuilderKit/src/com/oracle/javafx/scenebuilder/kit/editor/drag/target/RootDropTarget.java
! 
apps/scenebuilder/SceneBuilderKit/src/com/oracle/javafx/scenebuilder/kit/editor/job/BringForwardJob.java
! 
apps/scenebuilder/SceneBuilderKit/src/com/oracle/javafx/scenebuilder/kit/editor/job/BringToFrontJob.java
! 
apps/scenebuilder/SceneBuilderKit/src/com/oracle/javafx/scenebuilder/kit/editor/job/DuplicateSelectionJob.java
! 
apps/scenebuilder/SceneBuilderKit/src/com/oracle/javafx/scenebuilder/kit/editor/job/PasteIntoJob.java
! 
apps/scenebuilder/SceneBuilderKit/src/com/oracle/javafx/scenebuilder/kit/editor/job/PasteJob.java
! 
apps/scenebuilder/SceneBuilderKit/src/com/oracle/javafx/scenebuilder/kit/editor/job/SendBackwardJob.java
! 
apps/scenebuilder/SceneBuilderKit/src/com/oracle/javafx/scenebuilder/kit/editor/job/SendToBackJob.java
! 
apps/scenebuilder/SceneBuilderKit/src/com/oracle/javafx/scenebuilder/kit/editor/job/TrimSelectionJob.java
! 
apps/scenebuilder/SceneBuilderKit/src/com/oracle/javafx/scenebuilder/kit/editor/job/gridpane/DeleteColumnJob.java
! 
apps/scenebuilder/SceneBuilderKit/src/com/oracle/javafx/scenebuilder/kit/editor/job/gridpane/DeleteRowJob.java
! 
apps/scenebuilder/SceneBuilderKit/src/com/oracle/javafx/scenebuilder/kit/editor/job/gridpane/RemoveColumnContentJob.java
! 
apps/scenebuilder/SceneBuilderKit/src/com/oracle/javafx/scenebuilder/kit/editor/job/gridpane/RemoveRowContentJob.java
- 
apps/scenebuilder/SceneBuilderKit/src/com/oracle/javafx/scenebuilder/kit/editor/job/togglegroup/AdjustAllToggleGroupJob.java
- 
apps/scenebuilder/SceneBuilderKit/src/com/oracle/javafx/scenebuilder/kit/editor/job/togglegroup/AdjustToggleGroupJob.java
! 
apps/scenebuilder/SceneBuilderKit/src/com/oracle/javafx/scenebuilder/kit/editor/job/togglegroup/ModifySelectionToggleGroupJob.java

Changeset: 6f74aae81004
Author:eric.le.pon...@oracle.com
Date:  2014-09-03 14:14 +0200
URL:   http://hg.openjdk.java.net/openjfx/8u-dev/rt/rev/6f74aae81004

[SCENEBUILDER] merge (no conflict).




hg: openjfx/8u-dev/rt: 6 new changesets

2014-09-02 Thread eric . le . ponner
Changeset: 64c45eaad799
Author:eric.le.ponner 
Date:  2014-09-02 12:53 +0200
URL:   http://hg.openjdk.java.net/openjfx/8u-dev/rt/rev/64c45eaad799

[SCENEBUILDER] added FXOMObject.collectReferences() method (with 'scope' 
parameter).

! 
apps/scenebuilder/SceneBuilderKit/src/com/oracle/javafx/scenebuilder/kit/fxom/FXOMCollection.java
! 
apps/scenebuilder/SceneBuilderKit/src/com/oracle/javafx/scenebuilder/kit/fxom/FXOMInstance.java
! 
apps/scenebuilder/SceneBuilderKit/src/com/oracle/javafx/scenebuilder/kit/fxom/FXOMIntrinsic.java
! 
apps/scenebuilder/SceneBuilderKit/src/com/oracle/javafx/scenebuilder/kit/fxom/FXOMObject.java

Changeset: b798513fd328
Author:eric.le.ponner 
Date:  2014-09-02 12:56 +0200
URL:   http://hg.openjdk.java.net/openjfx/8u-dev/rt/rev/b798513fd328

[SCENEBUILDER] AbstractDropTarget subclasses and edit jobs now uses 
RemoveObjectJob in place of DeleteObjectJob.
DeleteObjectJob semantic is going to change and it will be reserved to delete 
command only.

! 
apps/scenebuilder/SceneBuilderKit/src/com/oracle/javafx/scenebuilder/kit/editor/drag/target/AccessoryDropTarget.java
! 
apps/scenebuilder/SceneBuilderKit/src/com/oracle/javafx/scenebuilder/kit/editor/drag/target/ContainerXYDropTarget.java
! 
apps/scenebuilder/SceneBuilderKit/src/com/oracle/javafx/scenebuilder/kit/editor/drag/target/ContainerZDropTarget.java
! 
apps/scenebuilder/SceneBuilderKit/src/com/oracle/javafx/scenebuilder/kit/editor/drag/target/GridPaneDropTarget.java
! 
apps/scenebuilder/SceneBuilderKit/src/com/oracle/javafx/scenebuilder/kit/editor/job/TrimSelectionJob.java
! 
apps/scenebuilder/SceneBuilderKit/src/com/oracle/javafx/scenebuilder/kit/editor/job/gridpane/MoveColumnJob.java
! 
apps/scenebuilder/SceneBuilderKit/src/com/oracle/javafx/scenebuilder/kit/editor/job/gridpane/MoveRowJob.java

Changeset: 92121f1d5ae1
Author:eric.le.ponner 
Date:  2014-09-02 13:02 +0200
URL:   http://hg.openjdk.java.net/openjfx/8u-dev/rt/rev/92121f1d5ae1

[SCENEBUILDER] Second step for DTL-6774 implementation.
Delete command is now reference aware:
- DeleteObjectJob now relies on ObjectDeleter
- DeleteObjectSelection no longer needs to invoke 
AdjustAllToggleGroupsJob

! 
apps/scenebuilder/SceneBuilderKit/src/com/oracle/javafx/scenebuilder/kit/editor/job/DeleteObjectJob.java
! 
apps/scenebuilder/SceneBuilderKit/src/com/oracle/javafx/scenebuilder/kit/editor/job/DeleteObjectSelectionJob.java
+ 
apps/scenebuilder/SceneBuilderKit/src/com/oracle/javafx/scenebuilder/kit/editor/job/reference/ObjectDeleter.java

Changeset: a0da8fd3717c
Author:eric.le.ponner 
Date:  2014-09-02 13:04 +0200
URL:   http://hg.openjdk.java.net/openjfx/8u-dev/rt/rev/a0da8fd3717c

[SCENEBUILDER] Debug menu now displays sub jobs attached to UpdateReferencesJob.

! 
apps/scenebuilder/SceneBuilderApp/src/com/oracle/javafx/scenebuilder/app/menubar/DebugMenuController.java

Changeset: 1e20da46a3c7
Author:eric.le.pon...@oracle.com
Date:  2014-09-02 14:19 +0200
URL:   http://hg.openjdk.java.net/openjfx/8u-dev/rt/rev/1e20da46a3c7

[SCENEBUILDER] Removed FXOMObject.lookupFirstReference() (no longer used).

! 
apps/scenebuilder/SceneBuilderKit/src/com/oracle/javafx/scenebuilder/kit/fxom/FXOMCollection.java
! 
apps/scenebuilder/SceneBuilderKit/src/com/oracle/javafx/scenebuilder/kit/fxom/FXOMInstance.java
! 
apps/scenebuilder/SceneBuilderKit/src/com/oracle/javafx/scenebuilder/kit/fxom/FXOMIntrinsic.java
! 
apps/scenebuilder/SceneBuilderKit/src/com/oracle/javafx/scenebuilder/kit/fxom/FXOMObject.java

Changeset: 043cd5a12fd9
Author:eric.le.pon...@oracle.com
Date:  2014-09-02 20:05 +0200
URL:   http://hg.openjdk.java.net/openjfx/8u-dev/rt/rev/043cd5a12fd9

[SCENEBUILDER] merge (no conflict).




hg: openjfx/8u-dev/rt: [SCENEBUILDER] First step for DTL-6774 implementation.

2014-09-01 Thread eric . le . ponner
Changeset: b0a0f059cc4e
Author:eric.le.pon...@oracle.com
Date:  2014-09-01 19:32 +0200
URL:   http://hg.openjdk.java.net/openjfx/8u-dev/rt/rev/b0a0f059cc4e

[SCENEBUILDER] First step for DTL-6774  implementation.
JobManager now automatically incokes UpdateReferencesJob.
This job takes care to fix any forward reference created by the
last editing action.

! 
apps/scenebuilder/SceneBuilderKit/src/com/oracle/javafx/scenebuilder/kit/editor/JobManager.java
+ 
apps/scenebuilder/SceneBuilderKit/src/com/oracle/javafx/scenebuilder/kit/editor/job/reference/ReferencesUpdater.java
+ 
apps/scenebuilder/SceneBuilderKit/src/com/oracle/javafx/scenebuilder/kit/editor/job/reference/UpdateReferencesJob.java



hg: openjfx/8u-dev/rt: [SCENEBUILDER] Added CombineReferenceJob and ExpandReferenceJob classes (to be used for DTL-6774).

2014-09-01 Thread eric . le . ponner
Changeset: 5ee50928c1d6
Author:eric.le.pon...@oracle.com
Date:  2014-09-01 16:24 +0200
URL:   http://hg.openjdk.java.net/openjfx/8u-dev/rt/rev/5ee50928c1d6

[SCENEBUILDER] Added CombineReferenceJob and ExpandReferenceJob classes (to be 
used for DTL-6774).

+ 
apps/scenebuilder/SceneBuilderKit/src/com/oracle/javafx/scenebuilder/kit/editor/job/atomic/ReplaceObjectJob.java
+ 
apps/scenebuilder/SceneBuilderKit/src/com/oracle/javafx/scenebuilder/kit/editor/job/atomic/ReplacePropertyValueJobT.java
+ 
apps/scenebuilder/SceneBuilderKit/src/com/oracle/javafx/scenebuilder/kit/editor/job/reference/CombineExpressionReferenceJob.java
+ 
apps/scenebuilder/SceneBuilderKit/src/com/oracle/javafx/scenebuilder/kit/editor/job/reference/CombineIntrinsicReferenceJob.java
+ 
apps/scenebuilder/SceneBuilderKit/src/com/oracle/javafx/scenebuilder/kit/editor/job/reference/CombineReferenceJob.java
+ 
apps/scenebuilder/SceneBuilderKit/src/com/oracle/javafx/scenebuilder/kit/editor/job/reference/ExpandExpressionReferenceJob.java
+ 
apps/scenebuilder/SceneBuilderKit/src/com/oracle/javafx/scenebuilder/kit/editor/job/reference/ExpandIntrinsicReferenceJob.java
+ 
apps/scenebuilder/SceneBuilderKit/src/com/oracle/javafx/scenebuilder/kit/editor/job/reference/ExpandReferenceJob.java
! 
apps/scenebuilder/SceneBuilderKit/src/com/oracle/javafx/scenebuilder/kit/fxom/FXOMCloner.java
! 
apps/scenebuilder/SceneBuilderKit/src/com/oracle/javafx/scenebuilder/kit/fxom/FXOMNodes.java



hg: openjfx/8u-dev/rt: [SCENEBUILDER] Fix for DTL-6846 (Dropping an object between two GridPane rows does not reorganize the grid content correctly).

2014-08-29 Thread eric . le . ponner
Changeset: 8a83d139c837
Author:eric.le.pon...@oracle.com
Date:  2014-08-29 16:03 +0200
URL:   http://hg.openjdk.java.net/openjfx/8u-dev/rt/rev/8a83d139c837

[SCENEBUILDER] Fix for DTL-6846 (Dropping an object between two GridPane rows 
does not reorganize the grid content correctly).

! 
apps/scenebuilder/SceneBuilderKit/src/com/oracle/javafx/scenebuilder/kit/editor/job/gridpane/v2/InsertColumnJob.java
! 
apps/scenebuilder/SceneBuilderKit/src/com/oracle/javafx/scenebuilder/kit/editor/job/gridpane/v2/InsertRowJob.java



hg: openjfx/8u-dev/rt: [SCENEBUILDER] DeleteObjectJob now uses RemoveObjectJob.

2014-08-27 Thread eric . le . ponner
Changeset: a5c10d255438
Author:eric.le.pon...@oracle.com
Date:  2014-08-27 17:38 +0200
URL:   http://hg.openjdk.java.net/openjfx/8u-dev/rt/rev/a5c10d255438

[SCENEBUILDER] DeleteObjectJob now uses RemoveObjectJob.
This fixes a latent bug and will ease work of references (DTL-6774).

! 
apps/scenebuilder/SceneBuilderKit/src/com/oracle/javafx/scenebuilder/kit/editor/job/DeleteObjectJob.java
+ 
apps/scenebuilder/SceneBuilderKit/src/com/oracle/javafx/scenebuilder/kit/editor/job/v2/RemoveCollectionItemJob.java
+ 
apps/scenebuilder/SceneBuilderKit/src/com/oracle/javafx/scenebuilder/kit/editor/job/v2/RemoveNodeJob.java
+ 
apps/scenebuilder/SceneBuilderKit/src/com/oracle/javafx/scenebuilder/kit/editor/job/v2/RemoveObjectJob.java



hg: openjfx/8u-dev/rt: [SCENEBUILDER] Going on fixing DTL-6783: RemovePropertyValueJob now removes the property

2014-08-27 Thread eric . le . ponner
Changeset: 96fb6a5bd1fc
Author:eric.le.pon...@oracle.com
Date:  2014-08-27 16:27 +0200
URL:   http://hg.openjdk.java.net/openjfx/8u-dev/rt/rev/96fb6a5bd1fc

[SCENEBUILDER] Going on fixing DTL-6783: RemovePropertyValueJob now removes the 
property
after removing the last value. This enables to simplify DeleteObjectJob.

! 
apps/scenebuilder/SceneBuilderKit/src/com/oracle/javafx/scenebuilder/kit/editor/job/DeleteObjectJob.java
! 
apps/scenebuilder/SceneBuilderKit/src/com/oracle/javafx/scenebuilder/kit/editor/job/v2/RemovePropertyJob.java
! 
apps/scenebuilder/SceneBuilderKit/src/com/oracle/javafx/scenebuilder/kit/editor/job/v2/RemovePropertyValueJob.java



hg: openjfx/8u-dev/rt: [SCENEBUILDER] Improved FXOMCloner class to avoid WMI_WRONG_MAP_ITERATOR warning from FindBugs.

2014-08-26 Thread eric . le . ponner
Changeset: e282fa2c4093
Author:eric.le.ponner 
Date:  2014-08-26 11:16 +0200
URL:   http://hg.openjdk.java.net/openjfx/8u-dev/rt/rev/e282fa2c4093

[SCENEBUILDER] Improved FXOMCloner class to avoid WMI_WRONG_MAP_ITERATOR 
warning from FindBugs.

! 
apps/scenebuilder/SceneBuilderKit/src/com/oracle/javafx/scenebuilder/kit/fxom/FXOMCloner.java



hg: openjfx/8u-dev/rt: [SCENEBUILDER] Some classes in FXOM now use LinkedHashMap (in place of HashMap) to preserve FXML declaration order.

2014-08-26 Thread eric . le . ponner
Changeset: caa2c16ce66b
Author:eric.le.ponner 
Date:  2014-08-26 10:25 +0200
URL:   http://hg.openjdk.java.net/openjfx/8u-dev/rt/rev/caa2c16ce66b

[SCENEBUILDER] Some classes in FXOM now use LinkedHashMap (in place of HashMap) 
to preserve FXML declaration order.
This will be useful for DTL-6774. This also avoids extra sorting in FXOMCloner 
(and FxIdCollector).

! 
apps/scenebuilder/SceneBuilderKit/src/com/oracle/javafx/scenebuilder/kit/fxom/FXOMCloner.java
! 
apps/scenebuilder/SceneBuilderKit/src/com/oracle/javafx/scenebuilder/kit/fxom/FXOMInstance.java
! 
apps/scenebuilder/SceneBuilderKit/src/com/oracle/javafx/scenebuilder/kit/fxom/FXOMIntrinsic.java
! 
apps/scenebuilder/SceneBuilderKit/src/com/oracle/javafx/scenebuilder/kit/fxom/FXOMObject.java
! 
apps/scenebuilder/SceneBuilderKit/src/com/oracle/javafx/scenebuilder/kit/fxom/FxIdCollector.java



hg: openjfx/8u-dev/rt: [SCENEBUILDER] Tested and fixed FXOMObject.lookupFirstReference() method (to be used for DTL-6774).

2014-08-22 Thread eric . le . ponner
Changeset: 9ec1f60df809
Author:Eric Le Ponner 
Date:  2014-08-22 18:47 +0200
URL:   http://hg.openjdk.java.net/openjfx/8u-dev/rt/rev/9ec1f60df809

[SCENEBUILDER] Tested and fixed FXOMObject.lookupFirstReference() method (to be 
used for DTL-6774).

! 
apps/scenebuilder/SceneBuilderKit/src/com/oracle/javafx/scenebuilder/kit/fxom/FXOMInstance.java



hg: openjfx/8u-dev/rt: [SCENEBUILDER] Fix for DTL-6825 (Copy command fails when selected object contains references).

2014-08-22 Thread eric . le . ponner
Changeset: 04e7f28714b3
Author:Eric Le Ponner 
Date:  2014-08-22 16:32 +0200
URL:   http://hg.openjdk.java.net/openjfx/8u-dev/rt/rev/04e7f28714b3

[SCENEBUILDER] Fix for DTL-6825 (Copy command fails when selected object 
contains references).
FXOMNodes.newDocument() now relies on FXOMCloner (the new cloning code).
newInstance() methods rom FXOMInstance, FXOMCollection, FXOMIntrinsic and 
FXOMProperty
classes have been removed.

! 
apps/scenebuilder/SceneBuilderKit/src/com/oracle/javafx/scenebuilder/kit/fxom/FXOMArchive.java
! 
apps/scenebuilder/SceneBuilderKit/src/com/oracle/javafx/scenebuilder/kit/fxom/FXOMCollection.java
! 
apps/scenebuilder/SceneBuilderKit/src/com/oracle/javafx/scenebuilder/kit/fxom/FXOMInstance.java
! 
apps/scenebuilder/SceneBuilderKit/src/com/oracle/javafx/scenebuilder/kit/fxom/FXOMIntrinsic.java
! 
apps/scenebuilder/SceneBuilderKit/src/com/oracle/javafx/scenebuilder/kit/fxom/FXOMNodes.java
! 
apps/scenebuilder/SceneBuilderKit/src/com/oracle/javafx/scenebuilder/kit/fxom/FXOMPropertyC.java
! 
apps/scenebuilder/SceneBuilderKit/src/com/oracle/javafx/scenebuilder/kit/fxom/FXOMPropertyT.java
! 
apps/scenebuilder/SceneBuilderKit/src/com/oracle/javafx/scenebuilder/kit/metadata/util/ClipboardEncoder.java



hg: openjfx/8u-dev/rt: [SCENEBUILDER] Added preserveCloneeFxId mode to FXOMCloner.

2014-08-22 Thread eric . le . ponner
Changeset: bbe230959561
Author:Eric Le Ponner 
Date:  2014-08-22 14:27 +0200
URL:   http://hg.openjdk.java.net/openjfx/8u-dev/rt/rev/bbe230959561

[SCENEBUILDER] Added preserveCloneeFxId mode to FXOMCloner.

! 
apps/scenebuilder/SceneBuilderKit/src/com/oracle/javafx/scenebuilder/kit/fxom/FXOMCloner.java



hg: openjfx/8u-dev/rt: [SCENEBUILDER] Updated FxIdCollector to fix DM_BOXED_PRIMITIVE_FOR_PARSING warning reported by FindBugs.

2014-08-22 Thread eric . le . ponner
Changeset: 9b0ba231846e
Author:Eric Le Ponner 
Date:  2014-08-22 11:36 +0200
URL:   http://hg.openjdk.java.net/openjfx/8u-dev/rt/rev/9b0ba231846e

[SCENEBUILDER] Updated FxIdCollector to fix DM_BOXED_PRIMITIVE_FOR_PARSING 
warning reported by FindBugs.

! 
apps/scenebuilder/SceneBuilderKit/src/com/oracle/javafx/scenebuilder/kit/fxom/FxIdCollector.java



hg: openjfx/8u-dev/rt: [SCENEBUILDER] Added FXOMCloner class (to be used for implementing DTL-6774).

2014-08-22 Thread eric . le . ponner
Changeset: e9e55cb81e13
Author:Eric Le Ponner 
Date:  2014-08-22 10:46 +0200
URL:   http://hg.openjdk.java.net/openjfx/8u-dev/rt/rev/e9e55cb81e13

[SCENEBUILDER] Added FXOMCloner class (to be used for implementing DTL-6774).

+ 
apps/scenebuilder/SceneBuilderKit/src/com/oracle/javafx/scenebuilder/kit/fxom/FXOMCloner.java
+ 
apps/scenebuilder/SceneBuilderKit/src/com/oracle/javafx/scenebuilder/kit/fxom/FxIdCollector.java



Re: JavaFX 8 and TextFields

2014-08-18 Thread Eric Le Ponner
Dirk, Anothony,

I’ve never observed this visual artifact on Mac OS 10.9 (.4)
no matter it’s SB 2.0 (i.e. b20) or latest SB (with latest FX8dev code).

Strange…

Could it be related to the graphics pipeline ?
What model of Mac are you using Dirk ?

Eric



Le 18 août 2014 à 15:34, Anthony Petrov  a écrit :

> Hi Dirk,
> 
> This looks like a bug. Could you please verify if the latest 8u20 ea build 
> works for you? You can download it at:
> 
> http://jdk8.java.net/download.html
> 
> 
> If it still fails, please file a new bug at
> 
> https://javafx-jira.kenai.com/secure/CreateIssue!default.jspa
> 
> --
> best regards,
> Anthony
> 
> On 8/18/2014 5:28 PM, Dirk Dittert wrote:
>> Hi,
>> 
>> I'm wondering about the design of TextFields in JavaFX 8. Why are they
>> having a horizontal line through the input area? I find that this looks
>> rather peculiar...
>> 
>> I posted some screenshots here:
>> http://d.dittert.org/E4D7EB53-D198-47AC-9230-53E9A23F6767/
>> 
>> One is from SceneBuilder 2.0-b20 on OS X 10.9. The other one is from one of
>> my applications (running on 1.8.0_11) on OS X.
>> 
>> Thanks,
>> Dirk
>> 



hg: openjfx/8u-dev/rt: [SCENEBUILDER] Preparatory work for DTL-6797 (Content panel should rely on SubScene).

2014-08-14 Thread eric . le . ponner
Changeset: 8f931434e0c7
Author:eric.le.ponner 
Date:  2014-08-14 09:27 +0200
URL:   http://hg.openjdk.java.net/openjfx/8u-dev/rt/rev/8f931434e0c7

[SCENEBUILDER] Preparatory work for DTL-6797 (Content panel should rely on 
SubScene).
Simplified AbstractDecoration (sceneToSceneGraphObject() and 
sceneGraphObjectToScene() are
not necessary ; getSceneGraphToSceneTransform() is enough).

! 
apps/scenebuilder/SceneBuilderKit/src/com/oracle/javafx/scenebuilder/kit/editor/panel/content/AbstractDecoration.java
! 
apps/scenebuilder/SceneBuilderKit/src/com/oracle/javafx/scenebuilder/kit/editor/panel/content/driver/gridpane/GridPanePring.java
! 
apps/scenebuilder/SceneBuilderKit/src/com/oracle/javafx/scenebuilder/kit/editor/panel/content/driver/handles/AbstractCurveHandles.java
! 
apps/scenebuilder/SceneBuilderKit/src/com/oracle/javafx/scenebuilder/kit/editor/panel/content/driver/handles/AbstractNodeHandles.java
! 
apps/scenebuilder/SceneBuilderKit/src/com/oracle/javafx/scenebuilder/kit/editor/panel/content/driver/handles/TabHandles.java
! 
apps/scenebuilder/SceneBuilderKit/src/com/oracle/javafx/scenebuilder/kit/editor/panel/content/driver/handles/TableColumnHandles.java
! 
apps/scenebuilder/SceneBuilderKit/src/com/oracle/javafx/scenebuilder/kit/editor/panel/content/driver/handles/TreeTableColumnHandles.java
! 
apps/scenebuilder/SceneBuilderKit/src/com/oracle/javafx/scenebuilder/kit/editor/panel/content/driver/outline/NodeOutline.java
! 
apps/scenebuilder/SceneBuilderKit/src/com/oracle/javafx/scenebuilder/kit/editor/panel/content/driver/pring/NodePring.java
! 
apps/scenebuilder/SceneBuilderKit/src/com/oracle/javafx/scenebuilder/kit/editor/panel/content/driver/pring/TabPring.java
! 
apps/scenebuilder/SceneBuilderKit/src/com/oracle/javafx/scenebuilder/kit/editor/panel/content/driver/pring/TableColumnPring.java
! 
apps/scenebuilder/SceneBuilderKit/src/com/oracle/javafx/scenebuilder/kit/editor/panel/content/driver/pring/TreeTableColumnPring.java
! 
apps/scenebuilder/SceneBuilderKit/src/com/oracle/javafx/scenebuilder/kit/editor/panel/content/driver/rudder/ResizeRudder.java
! 
apps/scenebuilder/SceneBuilderKit/src/com/oracle/javafx/scenebuilder/kit/editor/panel/content/driver/tring/AbstractNodeTring.java
! 
apps/scenebuilder/SceneBuilderKit/src/com/oracle/javafx/scenebuilder/kit/editor/panel/content/driver/tring/TabTring.java
! 
apps/scenebuilder/SceneBuilderKit/src/com/oracle/javafx/scenebuilder/kit/editor/panel/content/driver/tring/TableColumnTring.java
! 
apps/scenebuilder/SceneBuilderKit/src/com/oracle/javafx/scenebuilder/kit/editor/panel/content/driver/tring/TreeTableColumnTring.java
! 
apps/scenebuilder/SceneBuilderKit/src/com/oracle/javafx/scenebuilder/kit/editor/panel/content/mode/HitNodeChrome.java



hg: openjfx/8u-dev/rt: [SCENEBUILDER] Added FXOMObject.lookupFirstReference() method (to be used for DTL-6774).

2014-08-12 Thread eric . le . ponner
Changeset: 340aba2d2506
Author:Eric Le Ponner 
Date:  2014-08-12 18:03 +0200
URL:   http://hg.openjdk.java.net/openjfx/8u-dev/rt/rev/340aba2d2506

[SCENEBUILDER] Added FXOMObject.lookupFirstReference() method (to be used for 
DTL-6774).

! 
apps/scenebuilder/SceneBuilderKit/src/com/oracle/javafx/scenebuilder/kit/fxom/FXOMCollection.java
! 
apps/scenebuilder/SceneBuilderKit/src/com/oracle/javafx/scenebuilder/kit/fxom/FXOMInstance.java
! 
apps/scenebuilder/SceneBuilderKit/src/com/oracle/javafx/scenebuilder/kit/fxom/FXOMIntrinsic.java
! 
apps/scenebuilder/SceneBuilderKit/src/com/oracle/javafx/scenebuilder/kit/fxom/FXOMObject.java



hg: openjfx/8u-dev/rt: [SCENEBUILDER] Updated StringListPropertyMetadata.assembleValue() to avoid IIO_INEFFICIENT_INDEX_OF from FindBugs.

2014-08-08 Thread eric . le . ponner
Changeset: 15354d7a3f1c
Author:Eric Le Ponner 
Date:  2014-08-08 14:24 +0200
URL:   http://hg.openjdk.java.net/openjfx/8u-dev/rt/rev/15354d7a3f1c

[SCENEBUILDER] Updated StringListPropertyMetadata.assembleValue() to avoid 
IIO_INEFFICIENT_INDEX_OF from FindBugs.

! 
apps/scenebuilder/SceneBuilderKit/src/com/oracle/javafx/scenebuilder/kit/metadata/property/value/list/StringListPropertyMetadata.java



hg: openjfx/8u-dev/rt: [SCENEBUILDER] Updated CssPanelController.getLookupImage() to fix LI_LAZY_INIT_STATIC warning reported by FindBugs.

2014-08-08 Thread eric . le . ponner
Changeset: 62363aafe7c6
Author:Eric Le Ponner 
Date:  2014-08-08 14:14 +0200
URL:   http://hg.openjdk.java.net/openjfx/8u-dev/rt/rev/62363aafe7c6

[SCENEBUILDER] Updated CssPanelController.getLookupImage() to fix 
LI_LAZY_INIT_STATIC warning reported by FindBugs.

! 
apps/scenebuilder/SceneBuilderKit/src/com/oracle/javafx/scenebuilder/kit/editor/panel/css/CssPanelController.java



hg: openjfx/8u-dev/rt: [SCENEBUILDER] Updated EditorController to avoid SIC_INNER_SHOULD_BE_STATIC_ANON reported by FindBugs.

2014-08-08 Thread eric . le . ponner
Changeset: bade1b511bf6
Author:Eric Le Ponner 
Date:  2014-08-08 14:07 +0200
URL:   http://hg.openjdk.java.net/openjfx/8u-dev/rt/rev/bade1b511bf6

[SCENEBUILDER] Updated EditorController to avoid 
SIC_INNER_SHOULD_BE_STATIC_ANON reported by FindBugs.

! 
apps/scenebuilder/SceneBuilderKit/src/com/oracle/javafx/scenebuilder/kit/editor/EditorController.java



hg: openjfx/8u-dev/rt: [SCENEBUILDER] Fix for DTL-6709 (SceneBuilder always writes default properties when saving...).

2014-08-07 Thread eric . le . ponner
Changeset: 68151eb75ef8
Author:Eric Le Ponner 
Date:  2014-08-07 17:44 +0200
URL:   http://hg.openjdk.java.net/openjfx/8u-dev/rt/rev/68151eb75ef8

[SCENEBUILDER] Fix for DTL-6709 (SceneBuilder always writes default properties 
when saving...).

! 
apps/scenebuilder/SceneBuilderKit/src/com/oracle/javafx/scenebuilder/kit/fxom/TransientObject.java
! 
apps/scenebuilder/SceneBuilderKit/src/com/oracle/javafx/scenebuilder/kit/fxom/glue/GlueElement.java
! 
apps/scenebuilder/SceneBuilderKit/src/com/oracle/javafx/scenebuilder/kit/fxom/glue/GlueSerializer.java



hg: openjfx/8u-dev/rt: [SCENEBUILDER] Fix for DTL-6773 (Read and preserve accessibility information found in FXML).

2014-08-07 Thread eric . le . ponner
Changeset: 14666e81cd7c
Author:Eric Le Ponner 
Date:  2014-08-07 09:37 +0200
URL:   http://hg.openjdk.java.net/openjfx/8u-dev/rt/rev/14666e81cd7c

[SCENEBUILDER] Fix for DTL-6773 (Read and preserve accessibility information 
found in FXML).
Regenerated Metadata.java.
The following properties are now exposed in the Accessibility section of the 
Inspector panel:
- accessibleHelp
- accessibleText
- role
- roleDescription

! 
apps/scenebuilder/SceneBuilderKit/src/com/oracle/javafx/scenebuilder/kit/metadata/Metadata.java



Re: [API REVIEW REQUEST] RT-19659 - [TabPane] Support for draggable tabs

2014-07-30 Thread Eric Le Ponner
Interesting.
Then may be ‘drag’ wording would more consistent with remaining APIs.
‘dnd’ is currently used nowhere else.

Eric


Le 30 juil. 2014 à 10:09, Tom Schindl  a écrit :

> No - it allows also to drag the tab to another TabPane as well and in
> future outside the window to detach it.
> 
> Tom
> 
> On 30.07.14 10:07, Eric Le Ponner wrote:
>> Hi Tom,
>> 
>> I wonder if we should really use the wording « dnd ».
>> The feature is really to enable the user to re-order the tabs 
>> inside a TabPane, right ?
>> 
>> So may be:
>> 
>> public boolean isTabReorderingEnabled();
>> public void setTabReorderingEnabled(boolean tabReorderingEnabled);
>> public BooleanProperty tabReorderingEnabledProperty();
>> 
>> Eric
>> 
>> PS: I’m assuming you don’t expect this gesture to work between two different 
>> TabPanes.
>> 
>> 
>> 
>> Le 30 juil. 2014 à 09:35, Tom Schindl  a écrit :
>> 
>>> Hi,
>>> 
>>> I'd like you to review the API proposed to make TabPane Tabs draggable.
>>> 
>>> The proposed public API only allows to put the TabPane in DnD mode:
>>> 
>>> public boolean isDndEnabled()
>>> public void setDndEnabled(boolean dndEnabled)
>>> public BooleanProperty dndEnabledProperty()
>>> 
>>> Tom
>> 
> 



Re: [API REVIEW REQUEST] RT-19659 - [TabPane] Support for draggable tabs

2014-07-30 Thread Eric Le Ponner
Hi Tom,

I wonder if we should really use the wording « dnd ».
The feature is really to enable the user to re-order the tabs 
inside a TabPane, right ?

So may be:

public boolean isTabReorderingEnabled();
public void setTabReorderingEnabled(boolean tabReorderingEnabled);
public BooleanProperty tabReorderingEnabledProperty();

Eric

PS: I’m assuming you don’t expect this gesture to work between two different 
TabPanes.



Le 30 juil. 2014 à 09:35, Tom Schindl  a écrit :

> Hi,
> 
> I'd like you to review the API proposed to make TabPane Tabs draggable.
> 
> The proposed public API only allows to put the TabPane in DnD mode:
> 
> public boolean isDndEnabled()
> public void setDndEnabled(boolean dndEnabled)
> public BooleanProperty dndEnabledProperty()
> 
> Tom



Re: [SceneBuilderKit]

2014-07-10 Thread Eric Le Ponner
Also missed the reply all…

Eric

Le 9 juil. 2014 à 14:51, Eric Le Ponner  a écrit :

> 
> Le 9 juil. 2014 à 13:58, Sven Reimers  a écrit :
>> My train of thought is more along expressiveness... The revision is a 
>> general trigger and the API user has to check for the actual state of the 
>> different properties. I thought it may be more natural to just listen to the 
>> real changes..
>> 
>> What I am looking for is a simple way to bridge undo/redo to NetBeans 
>> undo/redo including detection if scene has changed...
>> 
>> 
> 
> When revision changes, this means
> - currentJob has changed
> - undoStack has changed
> - redoSack has changed
> - canUndo has (potentially) changed
> - canRedo has (potentially) changed
> 
> In that situation, I must recognized that I prefer one single observable point
> even if it’s a bit less expressive I agree.
> 
> Having played a lot with observable properties on Node instances, 
> I end up in situation where I missed a single well defined observable point
> (like Swing events of the old time). That’s why I intentionally limited the
> observables in SB to their strict minimum.
> 
> Eric
> 
> 
>> -Sven
>> 
>> Am 09.07.2014 09:59 schrieb "Eric Le Ponner" :
>> Hi Sven,
>> 
>> There is already JobManager.revisionProperty() available.
>> Isn’t it enough for Netbeans plugin to update its state ?
>> Scene Builder App does everything with this observable prop.
>> 
>> Eric
>> 
>> 
>> Le 8 juil. 2014 à 23:28, Sven Reimers  a écrit :
>> 
>> > Hi guys,
>> >
>> > I am still working on integration SceneBuilder into NetBeans. To
>> > enable/disable some of the icons present it would be helpful if
>> >
>> > 1. currentJob would be an observable read only property
>> > 2. undoStack would be an observable immutable collection
>> > 3. redoStack would be an observable immutable collection
>> > 4. canRedo would be an observable ready only property
>> > 5. canUndo would be an observable ready only property
>> >
>> > Does this make sense?
>> >
>> > Shall I file an issue and prepare a patch?
>> >
>> > Thanks
>> >
>> > -Sven
>> >
>> > --
>> > Sven Reimers
>> >
>> > * Senior Expert Software Architect
>> > * NetBeans Dream Team Member: http://dreamteam.netbeans.org
>> > * Community Leader  NetBeans: http://community.java.net/netbeans
>> >  Desktop Java:
>> > http://community.java.net/javadesktop
>> > * JUG Leader JUG Bodensee: http://www.jug-bodensee.de
>> > * Duke's Choice Award Winner 2009
>> > * Blog: https://www.java.net//blog/sven
>> >
>> > * XING: https://www.xing.com/profile/Sven_Reimers8
>> > * LinkedIn: http://www.linkedin.com/in/svenreimers
>> >
>> > Join the NetBeans Groups:
>> > * XING: http://www.xing.com/group-20148.82db20
>> > * NUGM: http://haug-server.dyndns.org/display/NUGM/Home
>> > * LinkedIn: http://www.linkedin.com/groups?gid=1860468
>> >   http://www.linkedin.com/groups?gid=107402
>> >   http://www.linkedin.com/groups?gid=1684717
>> > * Oracle: https://mix.oracle.com/groups/18497
>> 
> 



Re: [SceneBuilderKit]

2014-07-09 Thread Eric Le Ponner
Hi Sven,

There is already JobManager.revisionProperty() available.
Isn’t it enough for Netbeans plugin to update its state ?
Scene Builder App does everything with this observable prop.

Eric


Le 8 juil. 2014 à 23:28, Sven Reimers  a écrit :

> Hi guys,
> 
> I am still working on integration SceneBuilder into NetBeans. To
> enable/disable some of the icons present it would be helpful if
> 
> 1. currentJob would be an observable read only property
> 2. undoStack would be an observable immutable collection
> 3. redoStack would be an observable immutable collection
> 4. canRedo would be an observable ready only property
> 5. canUndo would be an observable ready only property
> 
> Does this make sense?
> 
> Shall I file an issue and prepare a patch?
> 
> Thanks
> 
> -Sven
> 
> -- 
> Sven Reimers
> 
> * Senior Expert Software Architect
> * NetBeans Dream Team Member: http://dreamteam.netbeans.org
> * Community Leader  NetBeans: http://community.java.net/netbeans
>  Desktop Java:
> http://community.java.net/javadesktop
> * JUG Leader JUG Bodensee: http://www.jug-bodensee.de
> * Duke's Choice Award Winner 2009
> * Blog: https://www.java.net//blog/sven
> 
> * XING: https://www.xing.com/profile/Sven_Reimers8
> * LinkedIn: http://www.linkedin.com/in/svenreimers
> 
> Join the NetBeans Groups:
> * XING: http://www.xing.com/group-20148.82db20
> * NUGM: http://haug-server.dyndns.org/display/NUGM/Home
> * LinkedIn: http://www.linkedin.com/groups?gid=1860468
>   http://www.linkedin.com/groups?gid=107402
>   http://www.linkedin.com/groups?gid=1684717
> * Oracle: https://mix.oracle.com/groups/18497



Re: SubScene => Node.localToWindow() ?

2014-07-08 Thread Eric Le Ponner
Hi Kevin

I created https://javafx-jira.kenai.com/browse/RT-37855.

Eric


Le 8 juil. 2014 à 14:36, Kevin Rushforth  a écrit :

> Hi Eric,
> 
> This seems like a reasonable request to me. Please file a new JIRA (Tweak) 
> with component=SceneGraph and we (Martin) can take a look.
> 
> -- Kevin
> 
> 
> Eric Le Ponner wrote:
>> Folks,
>> 
>> I started playing with SubScene a few days ago.
>> And I realized that I could not use Node.localToScene() as I did before.
>> 
>> When there is no SubScene in the scene graph, Node.localToScene() is
>> basically a way to convert local coordinates to window coordinates (because
>> Scene and Window can be considered as one entity).
>> 
>> When there are SubScene's, then Node.localToScene() convert local
>> coordinates to coordinates *relative to the closest enclosing SubScene*.
>> These coordinates are not relative to the window anymore. To get window 
>> coordinates, you need to call Node.localToScene() up to the root Scene.
>> 
>> This computation could be performed by FX and named Node.localToWindow() for 
>> instance. With SubScene now in the picture, this seems pretty consistent 
>> with existing FX design.
>> 
>> Any opinion ?
>> 
>> Eric
>> 
>>  



SubScene => Node.localToWindow() ?

2014-07-08 Thread Eric Le Ponner
Folks,

I started playing with SubScene a few days ago.
And I realized that I could not use Node.localToScene() as I did before.

When there is no SubScene in the scene graph, Node.localToScene() is
basically a way to convert local coordinates to window coordinates (because
Scene and Window can be considered as one entity).

When there are SubScene's, then Node.localToScene() convert local
coordinates to coordinates *relative to the closest enclosing SubScene*.
These coordinates are not relative to the window anymore. To get window 
coordinates, you need to call Node.localToScene() up to the root Scene.

This computation could be performed by FX and named Node.localToWindow() 
for instance. With SubScene now in the picture, this seems pretty consistent 
with existing FX design.

Any opinion ?

Eric



hg: openjfx/8u-dev/rt: [SCENEBUILDER] Updated Metadata.java so that properties like "prefViewportWidth" land

2014-07-04 Thread eric . le . ponner
Changeset: c369d4c75688
Author:eric.le.pon...@oracle.com
Date:  2014-07-04 15:13 +0200
URL:   http://hg.openjdk.java.net/openjfx/8u-dev/rt/rev/c369d4c75688

[SCENEBUILDER] Updated Metadata.java so that properties like 
"prefViewportWidth" land
in the "Specific" section (in place of the "Size" section).

! 
apps/scenebuilder/SceneBuilderKit/src/com/oracle/javafx/scenebuilder/kit/metadata/Metadata.java



hg: openjfx/8u-dev/rt: 3 new changesets

2014-07-04 Thread eric . le . ponner
Changeset: 55296da24ffd
Author:eric.le.pon...@oracle.com
Date:  2014-07-03 18:59 +0200
URL:   http://hg.openjdk.java.net/openjfx/8u-dev/rt/rev/55296da24ffd

[SCENEBUILDER] Aligned Metadata.java with JRE 1.8.0_20-ea-b21

! 
apps/scenebuilder/SceneBuilderKit/src/com/oracle/javafx/scenebuilder/kit/metadata/Metadata.java

Changeset: f6fdf541549e
Author:eric.le.ponner 
Date:  2014-07-04 11:03 +0200
URL:   http://hg.openjdk.java.net/openjfx/8u-dev/rt/rev/f6fdf541549e

[SCENEBUILDER] Updated metadata with a better description of SubScene.
SubScene.userAgentStylesheet is now displayed in Inspector.

! 
apps/scenebuilder/SceneBuilderKit/src/com/oracle/javafx/scenebuilder/kit/metadata/Metadata.java

Changeset: ed229384f325
Author:eric.le.pon...@oracle.com
Date:  2014-07-04 11:04 +0200
URL:   http://hg.openjdk.java.net/openjfx/8u-dev/rt/rev/ed229384f325

[SCENEBUILDER] merge (no conflict).




hg: openjfx/8u-dev/rt: [SCENEBUILDER] Fix for DTL-6700 (SceneBuilder does not open FXML with fx:script).

2014-06-27 Thread eric . le . ponner
Changeset: 1f847b5308e6
Author:eric.le.ponner 
Date:  2014-06-27 16:06 +0200
URL:   http://hg.openjdk.java.net/openjfx/8u-dev/rt/rev/1f847b5308e6

[SCENEBUILDER] Fix for DTL-6700 (SceneBuilder does not open FXML with 
fx:script).

! 
apps/scenebuilder/SceneBuilderKit/src/com/oracle/javafx/scenebuilder/kit/fxom/FXOMLoader.java
+ 
apps/scenebuilder/SceneBuilderKit/src/com/oracle/javafx/scenebuilder/kit/fxom/TransientIgnored.java



Re: ScrollPane.content moves with arrow keys

2014-06-10 Thread Eric Le Ponner
Curious indeed :)
And probably not intended you’re right.

Note that Scene Builder 2.0 embeds its own jdk.
So it means the problem can be reproduced with FX8 GA release.

Eric


Le 10 juin 2014 à 18:18, Werner Lehmann  a écrit :

> Hi,
> 
> we came across a curious behavior of ScrollPane in 8u5: the scrollpane 
> content can be moved around with arrow keys if it is smaller than the 
> viewport. This can be reproduced in SceneBuilder with simple FXML:
> 
>> 
>> 
>> 
>> 
>> 
>> 
>> > minWidth="-Infinity" prefHeight="517.0" prefWidth="272.0" 
>> xmlns="http://javafx.com/javafx/8"; xmlns:fx="http://javafx.com/fxml/1";>
>>   
>>  > text="CheckBox" />
>>   
>> 
> 
> Just a scrollpane with a checkbox in it. It looks like a bug to me but maybe 
> I am missing something?
> 
> Werner



Re: SceneBuilder 2.0 import custom components from Jar

2014-06-10 Thread Eric Le Ponner
@Christian,

JAR import command of Scene Builder 2.0 collects all the classes found
in the JAR file and retains only the one that 
1) can be instantiated using FXMLLoader
2) extends javafx.scene.Node.

In practice, for each class a.b.C, it generates the following FXML:

and passes it to FXMLLoader.load(). Then it checks instanceof Node on
the resulting object.

See JarExplorer.exploreEntry() method in Scene Builder sources for more details.


@Jonathan
We’ve acknowledged your request and will have a look to ControlsFX.


Eric



Le 8 juin 2014 à 22:56, Jonathan Giles  a écrit :

> Christian,
> 
> With my OpenJFX hat on:
> ===
> ControlsFX-related issues are best discussed on the controlsfx-dev mailing 
> list, which can be accessed (and signed up to) here: 
> http://groups.controlsfx.org
> 
> Scene Builder is open source - you can access it by cloning the OpenJFX rt 
> repo, and you'll find the Scene Builder source code in apps/scenebuilder.
> 
> 
> With my ControlsFX hat on:
> ===
> Regarding getting ControlsFX to play nicer with Scene Builder - that is 
> really a matter for the ControlsFX project to resolve. ControlsFX needs to 
> follow the requirements of Scene Builder and FXML, and I'm not 100% clear on 
> what the definitive list of requirements is, but I know some of the 
> requirements include having a public no-args constructor, and using @NamedArg 
> on constructor parameters to define the parameter name. I have been hoping 
> someone from the community would step up to make ControlsFX more FXML and 
> Scene Builder compliant. If you're interested please ping me off-list.
> 
> Relatedly, I recently asked if the Scene Builder team if someone could take a 
> quick look at ControlsFX to cast their expert eyes over the API and let me 
> know what is and isn't going to work well for them.
> 
> Thanks,
> 
> -- Jonathan
> 
> On 8/06/2014 8:24 p.m., Christian wrote:
>> Hi,
>> I was trying to import controlsfx-5.0.6 and controlsfx-5.0.6_20 into 
>> scenebuilder.
>> However only some or few controls could be imported.
>> When using these controls strange effects happen.
>> I was looking into the user guide in order to determine the requirements 
>> that have to be met by the components in the jar file.
>> However there was just a simple guideline about how to import and not how to 
>> develop custom components so that they match the scenebuilder.
>> I further turned the logging level of the scenbuilder to finest and hoped to 
>> see at least some stacktraces that might give me a hint.
>> But I only saw stacktraces when using the imported components (mainly 
>> belonging to missing resources because of classpath problems) nothing from 
>> the import/jarfile-scan itself.
>> I was hoping that I can adjust the controlsfx classes so that they work fine 
>> with the scenebuilder.
>> Any hints are more then welcome!
>> 
>> ps.:
>> It seems that scenebuilder is closed source, or is the some source out there 
>> I could start with?
>> Is there an early access release for 8u20?
>> 
>> Thanks,
>> Christian
> 



Re: Dragboard.dragView and Dragboard.content

2014-04-25 Thread Eric Le Ponner
Will do.
Thanks Anthony.

Eric

Le 25 avr. 2014 à 16:12, Anthony Petrov  a écrit :

> Hi Eric,
> 
> This looks like a bug. Only the dragView image should be displayed in this 
> case. Please enter a JIRA against Glass.
> Also, it would be great if you could test this on other platforms (Mac, Gtk) 
> and report the results.
> 
> --
> best regards,
> Anthony
> 
> On 4/25/2014 6:06 PM, Eric Le Ponner wrote:
>> Folks,
>> 
>> In my onDragDetected() listener, I do the following:
>> 
>> 0) I create an Image
>> 1) I set it as content of my drag board (using a DataFormat.IMAGE entry)
>> 2) I set it as drag view (using Dragboard.setDragView)
>> 
>> During the drag gesture on Windows, I see my image twice.
>> If I remove step #2 then I see my image only once.
>> 
>> So it seems that:
>> - one image comes from the drag view
>> - other image is a kind of « automatic representation » of the clipboard
>> 
>> I find it a bit surprising to have two images in that case.
>> Shouldn’t we have one image only : the one passed to setDragView() ?
>> 
>> Any help / opinion are welcome.
>> 
>> Eric
>> 



Dragboard.dragView and Dragboard.content

2014-04-25 Thread Eric Le Ponner
Folks,

In my onDragDetected() listener, I do the following:

0) I create an Image
1) I set it as content of my drag board (using a DataFormat.IMAGE entry)
2) I set it as drag view (using Dragboard.setDragView)

During the drag gesture on Windows, I see my image twice.
If I remove step #2 then I see my image only once.

So it seems that:
- one image comes from the drag view
- other image is a kind of « automatic representation » of the clipboard

I find it a bit surprising to have two images in that case.
Shouldn’t we have one image only : the one passed to setDragView() ?

Any help / opinion are welcome.

Eric



Re: Drag events following pressed events.

2014-04-23 Thread Eric Le Ponner
You might have a look to PopupWindow.consumeAutoHidingEvents property.

By default, it’s true so I think it’s why PopupWindow consumes the 
MOUSE_PRESSED event.
If you turn it to false, MOUSE_PRESSED event should flow up and reach your 
background object.

Eric


Le 23 avr. 2014 à 16:40, Robert Fisher  a écrit :

> Hi everyone,
> 
> I'm confused about how pressed and dragged events are related in JavaFX. My 
> initial assumption was that MOUSE_PRESSED events would *always* precede 
> MOUSE_DRAGGED events. That is, you would never find a case where a 
> MOUSE_DRAGGED event fired on a node and a MOUSE_PRESSED event had not fired.
> 
> However I then found the following exception: when I have a popup showing 
> that is configured to hide itself when it loses focus. If I drag on a 
> background node, a MOUSE_DRAGGED handler will fire but a MOUSE_PRESSED 
> handler will not. Like the MOUSE_PRESSED event is being consumed in the 
> process of hiding the popup, or something. I observed this behaviour in both 
> JavaFX 7 and 8.
> 
> Is this a bug? Or am I making too many assumptions about how MOUSE_PRESSED 
> and MOUSE_DRAGGED events are related?
> 
> Cheers,
> Rob



Re: SceneBuilder Integration in NetBeans

2014-03-17 Thread Eric Le Ponner
Le 17 mars 2014 à 16:10, Sven Reimers  a écrit :

> Yes, I can confirm everything looks ok.. but exceptions all over the place 
> don't make feel comfortable...
> 
> 

Sure.
I created DTL-6648 to track issue at Scene Builder level.

Eric

> This is with fixed DataFormat String..
> 
> Thanks
> 
> -Sven
> 
> Am 17.03.2014 15:32 schrieb "Eric Le Ponner" :
> Hi Sven,
> 
> As you mentioned, some fixes are also required at SB level  (the strings 
> passed to DataFormat).
> I'm going to file a JIRA against Scene Builder for that.
> 
> I did a sample Swing test with Scene Builder Kit and reproduced the exception
> reported in RT-36240. However it seems that this exception does not prevent
> SB to complete its drag and drop gestures. Does it match what you've observed 
> ?
> 
> Cheers.
> 
> Eric
> 
> 
> 
> Le 17 mars 2014 à 14:49, Sven Reimers  a écrit :
> 
> > Created RT-36240
> >
> > -Sven
> > Am 17.03.2014 13:10 schrieb "Kevin Rushforth" :
> >
> >> Hi Sven,
> >>
> >> If you file the bug then yes, we can look at it for 8u20 (there is no
> >> "earlier").
> >>
> >> And thanks to Petr for providing the evaluation for this.
> >>
> >> -- Kevin
> >>
> >>
> >> Sven Reimers wrote:
> >>
> >>> Ok.
> >>>
> >>> Will file an issue and if possible create a patch.
> >>>
> >>> Any this could end up in 8u20 (or earlier)?
> >>>
> >>> Thanks
> >>>
> >>> -Sven
> >>> Am 17.03.2014 11:05 schrieb "Petr Pchelko" :
> >>>
> >>>
> >>>
> >>>> Ok, I see.
> >>>>
> >>>> This is the problem in FX interop.
> >>>> In javafx.embed.swing.SwingDnD.DnDTransferable class. It's wrapper that
> >>>> wraps the FX dragboard into the Swing Trasferable.
> >>>> It is a simple class and many features are simply not implemented. The
> >>>> implementation is very basic - it just creates the DataFlavor with the
> >>>> mime-type corresponding to the DataFormat mime-type. However it does not
> >>>> take into account the representation class. This works fine for basic
> >>>> types
> >>>> like text or may be image, but it completely does not work for custom
> >>>> types
> >>>> with custom representation classes.
> >>>>
> >>>> You could file a bug for this.
> >>>>
> >>>> With best regards. Petr.
> >>>>
> >>>> On 17.03.2014, at 13:39, Sven Reimers  wrote:
> >>>>
> >>>> The problem seems to be in AbstractDragSource in SceneBuilder. It defines
> >>>> a javafx.scene.input.DataFormat.
> >>>> This seems to cause problems if running embedded in Swing. I do not
> >>>> define
> >>>> my own DataFlavors..
> >>>>
> >>>> Any further help appreciated..
> >>>>
> >>>> -Sven
> >>>> Am 17.03.2014 09:54 schrieb "Petr Pchelko" :
> >>>>
> >>>>
> >>>>
> >>>>> Hello, Sven.
> >>>>>
> >>>>> Looks like you are not specifying the representation class for the
> >>>>> DataFlavor and it defaults
> >>>>> to the InputStream. So, scene builder puts a ByteBuffer while the
> >>>>> DataTransferer is trying to treat it as an
> >>>>> InputStream.
> >>>>>
> >>>>> Could you please try to explicitly specify the representation class in
> >>>>> the DataFlavor you are trying to put?
> >>>>> Like this: new DataFlavor("scene.builder/internal;
> >>>>> class=java.nio.HeapByteBuffer", "SceneBuilder internal DF"")
> >>>>>
> >>>>> With best regards. Petr.
> >>>>>
> >>>>> On 17.03.2014, at 0:13, Sven Reimers  wrote:
> >>>>>
> >>>>>
> >>>>>
> >>>>>> Ok... figured it out. It seems scene.builder.internal crashes the Swing
> >>>>>> parsing mechanism for mime types in the data transfer. Changing it to
> >>>>>> scene.builder/internal fixes this problem.
> >>>>>>
> >>>>>> Shall I open an issue in Jira for it?
> >>>&

Re: SceneBuilder Integration in NetBeans

2014-03-17 Thread Eric Le Ponner
Hi Sven,

As you mentioned, some fixes are also required at SB level  (the strings passed 
to DataFormat).
I'm going to file a JIRA against Scene Builder for that.

I did a sample Swing test with Scene Builder Kit and reproduced the exception 
reported in RT-36240. However it seems that this exception does not prevent 
SB to complete its drag and drop gestures. Does it match what you've observed ?

Cheers.

Eric



Le 17 mars 2014 à 14:49, Sven Reimers  a écrit :

> Created RT-36240
> 
> -Sven
> Am 17.03.2014 13:10 schrieb "Kevin Rushforth" :
> 
>> Hi Sven,
>> 
>> If you file the bug then yes, we can look at it for 8u20 (there is no
>> "earlier").
>> 
>> And thanks to Petr for providing the evaluation for this.
>> 
>> -- Kevin
>> 
>> 
>> Sven Reimers wrote:
>> 
>>> Ok.
>>> 
>>> Will file an issue and if possible create a patch.
>>> 
>>> Any this could end up in 8u20 (or earlier)?
>>> 
>>> Thanks
>>> 
>>> -Sven
>>> Am 17.03.2014 11:05 schrieb "Petr Pchelko" :
>>> 
>>> 
>>> 
 Ok, I see.
 
 This is the problem in FX interop.
 In javafx.embed.swing.SwingDnD.DnDTransferable class. It's wrapper that
 wraps the FX dragboard into the Swing Trasferable.
 It is a simple class and many features are simply not implemented. The
 implementation is very basic - it just creates the DataFlavor with the
 mime-type corresponding to the DataFormat mime-type. However it does not
 take into account the representation class. This works fine for basic
 types
 like text or may be image, but it completely does not work for custom
 types
 with custom representation classes.
 
 You could file a bug for this.
 
 With best regards. Petr.
 
 On 17.03.2014, at 13:39, Sven Reimers  wrote:
 
 The problem seems to be in AbstractDragSource in SceneBuilder. It defines
 a javafx.scene.input.DataFormat.
 This seems to cause problems if running embedded in Swing. I do not
 define
 my own DataFlavors..
 
 Any further help appreciated..
 
 -Sven
 Am 17.03.2014 09:54 schrieb "Petr Pchelko" :
 
 
 
> Hello, Sven.
> 
> Looks like you are not specifying the representation class for the
> DataFlavor and it defaults
> to the InputStream. So, scene builder puts a ByteBuffer while the
> DataTransferer is trying to treat it as an
> InputStream.
> 
> Could you please try to explicitly specify the representation class in
> the DataFlavor you are trying to put?
> Like this: new DataFlavor("scene.builder/internal;
> class=java.nio.HeapByteBuffer", "SceneBuilder internal DF"")
> 
> With best regards. Petr.
> 
> On 17.03.2014, at 0:13, Sven Reimers  wrote:
> 
> 
> 
>> Ok... figured it out. It seems scene.builder.internal crashes the Swing
>> parsing mechanism for mime types in the data transfer. Changing it to
>> scene.builder/internal fixes this problem.
>> 
>> Shall I open an issue in Jira for it?
>> 
>> Having fixed this I get another problem :-(
>> (see stacktrace below)
>> 
>> Not sure how to fix this... investigating now.
>> 
>> -Sven
>> 
>> java.lang.ClassCastException: java.nio.HeapByteBuffer cannot be cast to
>> java.io.InputStream
>> at
>> 
>> 
>> 
> sun.awt.datatransfer.DataTransferer.translateTransferable(
> DataTransferer.java:1372)
> 
> 
>> at
>> 
>> 
>> 
> sun.lwawt.macosx.CDataTransferer.translateTransferable(
> CDataTransferer.java:131)
> 
> 
>> at sun.awt.datatransfer.DataTransferer$6.run(DataTransferer.java:2380)
>> at java.awt.event.InvocationEvent.dispatch(InvocationEvent.java:311)
>> at java.awt.EventQueue.dispatchEventImpl(EventQueue.java:744)
>> at java.awt.EventQueue.access$400(EventQueue.java:97)
>> at java.awt.EventQueue$3.run(EventQueue.java:697)
>> at java.awt.EventQueue$3.run(EventQueue.java:691)
>> at java.security.AccessController.doPrivileged(Native Method)
>> at
>> 
>> 
>> 
> java.security.ProtectionDomain$1.doIntersectionPrivilege(
> ProtectionDomain.java:75)
> 
> 
>> at
>> 
>> 
>> 
> java.security.ProtectionDomain$1.doIntersectionPrivilege(
> ProtectionDomain.java:86)
> 
> 
>> at java.awt.EventQueue$4.run(EventQueue.java:719)
>> at java.awt.EventQueue$4.run(EventQueue.java:717)
>> at java.security.AccessController.doPrivileged(Native Method)
>> at
>> 
>> 
>> 
> java.security.ProtectionDomain$1.doIntersectionPrivilege(
> ProtectionDomain.java:75)
> 
> 
>> at java.awt.EventQueue.dispatchEvent(EventQueue.java:716)
>> at
>> 
>> 
>> 
> org.netbeans.core.TimableEventQueue.dispatchEvent(
> TimableEventQueue.java:159)
> 
> 
>> at
>> 
>> 
>> 
> java.awt.EventDispatchThread.pumpOneEventForFilters(
> EventDispatchThread

Re: Blend image in javaFX 2.0

2014-02-28 Thread Eric Le Ponner
There is a Blend effect class. I guess it can be combined with an ImageView
to produce a blend image rendering.

Eric

Le 28 févr. 2014 à 02:53, Cinta Damayanti  a écrit :

> How to blend two image in javaFX 2.0. I browse to entire internet, but
> not meet the right solution.



Re: custom FXML builders in SceneBuilder

2014-01-21 Thread Eric Le Ponner
Hi Tom,

Sorry, I was a bit optimistic and found no time to look at it.
I'll give a try this week.

Eric


Le 21 janv. 2014 à 11:00, Tom Eugelink  a écrit :

> 
> Hi Eric,
> 
> Any chance you had time to look into this?
> 
> Tom
> 
> 
> 
> On 2014-1-3 12:19, Eric Le Ponner wrote:
>> I will look at that and come back to you middle of next week.
>> 
>> Eric
>> 
>> Le 3 janv. 2014 à 12:12, Tom Eugelink  a écrit :
>> 
>>> I think there are two usages of builders:
>>> - construct compontents / controls programatically (ending in the build() 
>>> call).
>>> - mapping of FXML attributes to node properties, because in FXML everything 
>>> must be a string.
>>> 
>>> For example, CalendarTextField has no builder class in the first sense (I 
>>> used withers for that), but does have a class that converts the dateFormats 
>>> (list of SimpleDateFormat strings) in an fxml file to an actual list of 
>>> DateFormats instances.
>>> 
>>> https://github.com/JFXtras/jfxtras-labs/blob/8.0/src/main/java/jfxtras/labs/fxml/CalendarTextFieldBuilder.java
>>> 
>>> If you can explain to me how to do this without a builder, but also without 
>>> polluting CalendarTextField with FXML aspects, then I'll change the code.
>>> 
>>> Tom
>>> 
>>> 
>>> 
>>> On 2014-1-3 11:44, Eric Le Ponner wrote:
>>>> When Scene Builder 2.0 found a custom components, it instantiates it using 
>>>> FXMLLoader
>>>> without making any specific builder setup. So FXMLLoader uses the default 
>>>> JavaFX
>>>> builder factory.
>>>> 
>>>> Since builders are deprecated, I'm not sure it make sense for SB to have 
>>>> dependency on them.
>>>> 
>>>> Eric
>>>> 
>>>> 
>>>> Le 3 janv. 2014 à 10:55, Tom Eugelink  a écrit :
>>>> 
>>>>> I had no problems adding the JFXtras components to SceneBuilder, but one 
>>>>> of the controls has a custom FXML builder. It is present in the same jar, 
>>>>> but how do I tell SceneBuilder to use it? Now when I try to load an fxml 
>>>>> file an exception ("unable to coerse") is shown by SceneBuilder.
>>>>> 
>>>>> Tom
>>>>> 
>>>>> 
>>> 
> 
> 



Re: scenebuilder and migpane

2014-01-06 Thread Eric Le Ponner

Le 6 janv. 2014 à 17:19, Richard Bair  a écrit :

>> MigLayout is a very popular layout engine in Swing and SWT (and also gaining 
>> ground on Android), I think it would be good for SceneBuilder to better 
>> support MigLayout.
> 
> +1, I’d love to see enough support in SceneBuilder that any 3rd party layout 
> container could supply editor support, so that the SceneBuilder team doesn’t 
> have to hard code support for different layout containers. This was one of 
> the goals of the “Design Time API for Java Beans” JSR (273, or 277? I don’t 
> remember) to do the same for Swing. We haven’t got that far with Scene 
> Builder but I think the idea is great.

The idea is great I agree.
However defining an API that opens the user interactive gestures of a tool like 
SB
is not a trivial task. And FXML brings some additional complexity.
IMHO the "Design Time API" from JSR 273 would require several amendments to be 
implementable in the context of SB.

May be for SB 4.0 ?… ;)

> MigLayout is widely used enough that we could just add hard-coded support for 
> it (maybe you or another person could contribute that?). Ideally it would be 
> something any 3rd party layout vendor could provide — but in practice there 
> are not that many widely used 3rd party layouts — even in the Swing world.

In the middle term, I think hard-coded support is probably the best option, I 
think.

> 
> Richard

Eric



Re: properties of custom controls in SceneBuilder

2014-01-06 Thread Eric Le Ponner
I would say it's deeply embedded.

SB2 currently defines a fixed list of "property classes" that can be edited in 
the Inspector panel.
Extending this list with a new type means:
- adding some specific metadata that help Scene Builder to edit/create FXML text
- adding some specific UI logic that enables the Inspector panel to present and 
let the user edit the value
Doing this requires a pretty deep understanding of SB2 architecture.

Eric



Le 6 janv. 2014 à 17:20, Richard Bair  a écrit :

> If somebody else wanted to contribute, where should they go looking for those 
> limitations and how to remove them? Or is it very deeply embedded in the code?
> 
> On Jan 3, 2014, at 2:15 AM, Eric Le Ponner  wrote:
> 
>> Yes, SB currently makes a filtering :  for custom components, it displays:
>> - properties that are inherited from JavaFX core classes
>> - properties with basic java types (integer, double, string, boolean).
>> 
>> We'll try to remove some of those limitations over the time.
>> 
>> Eric
>> 
>> 
>> Le 3 janv. 2014 à 11:01, Tom Eugelink  a écrit :
>> 
>>> 
>>> Adding the controls in JFXtras to SceneBuilder worked without a problem, 
>>> but scene builder does not show all their properties. For example 
>>> CalendarTextField has 5 properties like Locale, Calendar, DateFormat, but 
>>> only "promptText" is shown by SceneBuilder.
>>> 
>>> 
>>> 
>>> 
>> 
> 



Re: custom FXML builders in SceneBuilder

2014-01-03 Thread Eric Le Ponner
I will look at that and come back to you middle of next week.

Eric

Le 3 janv. 2014 à 12:12, Tom Eugelink  a écrit :

> 
> I think there are two usages of builders:
> - construct compontents / controls programatically (ending in the build() 
> call).
> - mapping of FXML attributes to node properties, because in FXML everything 
> must be a string.
> 
> For example, CalendarTextField has no builder class in the first sense (I 
> used withers for that), but does have a class that converts the dateFormats 
> (list of SimpleDateFormat strings) in an fxml file to an actual list of 
> DateFormats instances.
> 
> https://github.com/JFXtras/jfxtras-labs/blob/8.0/src/main/java/jfxtras/labs/fxml/CalendarTextFieldBuilder.java
> 
> If you can explain to me how to do this without a builder, but also without 
> polluting CalendarTextField with FXML aspects, then I'll change the code.
> 
> Tom
> 
> 
> 
> On 2014-1-3 11:44, Eric Le Ponner wrote:
>> When Scene Builder 2.0 found a custom components, it instantiates it using 
>> FXMLLoader
>> without making any specific builder setup. So FXMLLoader uses the default 
>> JavaFX
>> builder factory.
>> 
>> Since builders are deprecated, I'm not sure it make sense for SB to have 
>> dependency on them.
>> 
>> Eric
>> 
>> 
>> Le 3 janv. 2014 à 10:55, Tom Eugelink  a écrit :
>> 
>>> I had no problems adding the JFXtras components to SceneBuilder, but one of 
>>> the controls has a custom FXML builder. It is present in the same jar, but 
>>> how do I tell SceneBuilder to use it? Now when I try to load an fxml file 
>>> an exception ("unable to coerse") is shown by SceneBuilder.
>>> 
>>> Tom
>>> 
>>> 
> 
> 



Re: custom FXML builders in SceneBuilder

2014-01-03 Thread Eric Le Ponner
When Scene Builder 2.0 found a custom components, it instantiates it using 
FXMLLoader
without making any specific builder setup. So FXMLLoader uses the default 
JavaFX 
builder factory.

Since builders are deprecated, I'm not sure it make sense for SB to have 
dependency on them.

Eric


Le 3 janv. 2014 à 10:55, Tom Eugelink  a écrit :

> 
> I had no problems adding the JFXtras components to SceneBuilder, but one of 
> the controls has a custom FXML builder. It is present in the same jar, but 
> how do I tell SceneBuilder to use it? Now when I try to load an fxml file an 
> exception ("unable to coerse") is shown by SceneBuilder.
> 
> Tom
> 
> 



Re: properties of custom controls in SceneBuilder

2014-01-03 Thread Eric Le Ponner
Yes, SB currently makes a filtering :  for custom components, it displays:
- properties that are inherited from JavaFX core classes
- properties with basic java types (integer, double, string, boolean).

We'll try to remove some of those limitations over the time.

Eric


Le 3 janv. 2014 à 11:01, Tom Eugelink  a écrit :

> 
> Adding the controls in JFXtras to SceneBuilder worked without a problem, but 
> scene builder does not show all their properties. For example 
> CalendarTextField has 5 properties like Locale, Calendar, DateFormat, but 
> only "promptText" is shown by SceneBuilder.
> 
> 
> 
> 



Re: scenebuilder and migpane

2014-01-03 Thread Eric Le Ponner
I guess it's worth trying to drop MigPane JAR file in SB2 library panel and see.
However SB2 makes some assumptions about containers.
So that might not work straight away.

Eric


Le 3 janv. 2014 à 10:10, Tom Eugelink  a écrit :

> 
> Would it be possible to offer MigPane as a Container in SceneBuilder?
> 
> Tom
> 



Re: Cylinder divisions and PerspectiveCamera fixedEyePosition should be mutable

2013-10-07 Thread Eric Le Ponner
As long as Cylinder/divisions/PerspectiveCamera/fixedEyePosition can be
encoded in FXML, that should be fine for Scene Builder. Having setters for 
those properties can be a way to optimize previewing. But it's not mandatory.

Eric



> Date: Fri, 04 Oct 2013 14:10:43 -0700
> From: Kevin Rushforth 
> Subject: Re: Cylinder divisions and PerspectiveCamera fixedEyePosition
>   should  be mutable
> To: Richard Bair 
> Cc: "openjfx-dev@openjdk.java.net list" 
> Message-ID: <524f2ed3.7060...@oracle.com>
> Content-Type: text/plain; charset=ISO-8859-1; format=flowed
> 
> Sounds good.
> 
> 
>> Depends on whether it is usable from SceneBuilder and FXML, and the 
>> following:
>>   - We must *not* expose a ReadOnly property for these properties 
>> (and I don't think we do)
> 
> No, we don't.
> 
>>   - The FXML changes must be backwards compatible (they should be but 
>> we need to verify)
> 
> I'll add a note to the JIRA and the FXML folks can reply.
> 
> 
>>   - The SceneBuilder can do something reasonable as is (not sure).
> 
> Chien or I can reach out to the SB team.
> 
> -- Kevin
> 
> 
> Richard Bair wrote:
>> Depends on whether it is usable from SceneBuilder and FXML, and the 
>> following:
>>   - We must *not* expose a ReadOnly property for these properties 
>> (and I don't think we do)
>>   - The FXML changes must be backwards compatible (they should be but 
>> we need to verify)
>>   - The SceneBuilder can do something reasonable as is (not sure).
>> 
>> Richard
>> 
>> On Oct 4, 2013, at 1:08 PM, Kevin Rushforth 
>> mailto:kevin.rushfo...@oracle.com>> wrote:
>> 
>>> Certainly for divisions there is no reason to keep them immutable. 
>>> For fixedEyeAtCameraZero, I don't think the reasons for keeping it 
>>> immutable are compelling.
>>> 
>>> Making either change in FX 8 is a different matter, though, given how 
>>> late we are. The implementation assumes immutability and we would 
>>> need to change it, implement it, test it, and then fix any bugs as a 
>>> result. Seems like we could add mutability in a subsequent release.
>>> 
>>> -- Kevin
>>> 
>>> 
>>> Richard Bair wrote:
 I would turn that around and say that unless there is a compelling reason 
 for something to be immutable, it should be mutable. Mutability is 
 important for tools as well as for FXML as well as for developers.
 
 Immutable state is awesome for thread-safety or any type of concurrency. 
 But these types of classes are not of that nature, they're UI only 
 classes, and as such their state should be mutable (and like all mutable 
 state in FX, the range of possible values should not be hindered by the 
 evil "unbind" pattern).
 
 Richard
 
 On Oct 4, 2013, at 12:46 PM, Kevin Rushforth  
 wrote:
 
 
> Yes, that pretty much captures the thinking behind it.
> 
> My thought is that there is no real reason that subdivisions need to be 
> immutable, although I wouldn't want to change it at this late date for FX 
> 8 unless it is needed for FXML support.
> 
> The fixedEyeAtCameraZero mode is not something I think should be mutable, 
> since the camera behaves fairly differently in each mode. Having said 
> that, there is no reason it couldn't be made mutable in a subsequent 
> release if there was a good reason to do so.
> 
> -- Kevin
> 
> 
> Chien Yang wrote:
> 
>> We did discuss making divisions in the predefined 3D shapes mutable in 
>> earlier meeting. However we decided against it since it is a heavy 
>> weight operation as the supporting mesh will has to be regenerated. I 
>> believe the constructor with the divisions argument will not have much 
>> use in the future when we move away from mesh implementation of our 
>> predefined 3D shapes.
>> 
>> The fixedEyeAtCameraZero flag in PerspectiveCamera is a setup flag to 
>> the camera and once set it shouldn't be changed. The perspective 
>> projection matrix is constructed differently depending on the flag. In 
>> the default mode, JavaFX controls the eye to achieve a projection plane 
>> at Z=0 so that simple adding of 3D shapes into a 2D scene looks 
>> intuitive. The other mode, where eye is fixed a camera zero, is well 
>> suitable for movable camera in the 3d space.
>> 
>> - Chien
>> 
>> On 10/4/2013 9:28 AM, Richard Bair wrote:
>> 
>>> Why are they not? It isn't immediately obvious to me why these are not 
>>> mutable? I was readinghttps://javafx-jira.kenai.com/browse/RT-29577 and 
>>> this struck me as odd.
>>> 
>>> Richard
>>> 
 
 
>> 
> 


Re: [API Review]: Add 'fxml.version' to System Properties (Was: FXML version number)

2013-07-09 Thread Eric Le Ponner
Hi Danno,

Scene Builder relies on FXMLLoader:
- it won't open an FXML file whose fxml.version does not match FXMLLoader own 
version
- it will attempt to open an FXML file no matter javafx.version but this may 
fail if SB FX SDK
  is no longer compatible with the FX version specified in the FXML file

Scene Builder is strongly coupled to the FX SDK bundled with it.
I don't see this changing very soon.

Eric




>  Original Message 
> Subject:  Re: [API Review]: Add 'fxml.version' to System Properties (Was: 
> FXML version number)
> Date: Tue, 9 Jul 2013 08:41:13 -0600
> From: Danno Ferrin 
> To:   Svata Dedic 
> CC:   openjfx-dev@openjdk.java.net
> 
> 
> I think mixing FXML versions in one FXML document is a bad idea, so my
> proposal of a version attribute would only show at the root of the document
> applying to all elements of that document, seeing the fx:version attribute
> anywhere else should be considered a strict validation error, so the
> concerns about messy XPaths is less of a problem because the check is once
> at the root.
> 
> So one question I have is are the existing tools (SceneBuilder, FXMLLoader)
> paying attention to the attributes and loading them any different if
> anything other than the current version is detected?  Is that in the long
> term plans?
> 
> 
> On Tue, Jul 9, 2013 at 5:44 AM, Svata Dedic wrote:
> 
> > Hi,
> >
> > sorry to step in in the middle of the discussion. I was pointed to this
> > thread only lately, as a part of review process of
> > https://javafx-jira.kenai.com/**browse/RT-28599
> >
> > The note about XML diff / processing tools is valid; indeed even NetBeans
> > which processes FXML must be adapted to creatively handle namespace with
> > URIs matching a certain prefix.
> >
> > But... consider the FXML file as a XML document. It's grammar must
> > correspond to the version of Javafx runtime - or at least to one of the
> > already released past versions. I.e., the FXML should not use an unknown
> > property or unknown class (more on the classpath contents concept below).
> > So each version of Javafx runtime library constitutes a set of tags for
> > classes, for class properties and events - which means a XML schema could
> > be eventually generated for each javafx release. And XML schemas are
> > usually identified by their target namespace URI and referenced using a xml
> > namespace prefix declared in the document.
> > In addition, we *need* a namespace different from the fx: namespace: while
> > the [default] namespace contains elements from the javafx runtime
> > "language", the fx: namespace contains elements from the FXML loader
> > "language" (references, includes, ids). As Milan has pointed out, those
> > languages are likely to evolve independently, but definitely have different
> > 'schemas' (although generated).
> >
> > Consider for example a XSLT-based tool for FXML translation or processing:
> > it can react appropriately to XML elemnents targetting different javafx
> > runtimes, allowing to develop a XSLT-based transformation which is
> > universal. If fx:version was used, matching in XSLT and XPaths would be
> > unnatural to those languages instead of matching just for QName, you need
> > to construct a XPath expression like
> > /*[fx:version='8']//javafx:**AnchorPane
> > or even more bloated syntax.
> >
> > From this point of view, using XML namespace makes a lot of sense for XML
> > processing tools than fx:version, with an implicit rule to inherit
> > fx:version down the element hierarchy until a different one is found.
> >
> > As for the 'classpath contents' concept: there's one unresolved issue with
> > either fx:version or xmlns declaration. We allow to declare the version of
> > javafx runtime in the fxml, but the actual usable language (components,
> > their properties and events) are defined by the contents of the classpath,
> > that possibly contain additional libraries.
> >
> > Right now, a 3rd party (e.g.) ChoiceBox component element will use a QName
> > from javafx namespace as if that component was a part of core javafx
> > runtime library, which does not as the "right XML way" (but it's the way
> > how FXML works at the moment).
> > While we now define a versioning mechanism for our own library (javafx
> > runtime), we do not define anything that can be useful by 3rd party vendors
> > to version their component state persisted in FXML - which is a pity.
> >
> >
> > On 07/09/2013 11:57 AM, Werner Lehmann wrote:
> >
> >> Hi,
> >>
> >> I don't particularly prefer one way or another but the first thing which
> >> came to my mind is to use a processing instruction. Especially because
> >> it can be "used by tools somehow". XML itself shows this:
> >>
> >> 
> >>
> >>  Using a processing instruction could be used if ever just one version
> > applies to the entire FXML source. While processing instructions apply in
> > textual order, FXML elements nest, so multipl

[API Review]: Add 'fxml.version' to System Properties (Was: FXML version number)

2013-07-05 Thread Eric Le Ponner
Hi Milan,

This looks good.

Note that, since b28, Scene Builder 1.1 now generates FXML files which include:
xmlns:fx="http://javafx.com/fxml/1";
xmlns="http://javafx.com/javafx/2.2";

Scene Builder Next will do the same but using values from 'fxml.version' and 
'javafx.version'.
It may also use those variables to improve error report or version management 
(to be defined).

Cheers.

Eric



> From: Milan Kubec 
> Subject: [API Review]: Add 'fxml.version' to System Properties (Was: FXML 
> version number)
> Date: July 1, 2013 7:01:12 AM PDT
> To: "openjfx-dev@openjdk.java.net" 
> Reply-To: milan.ku...@oracle.com
> 
> Hello,
> I propose to add 'fxml.version' property to JVM System Properties to
> store version of FXML specific version that is supported by FXML Loader.
> The property would be more specific equivalent of 'javafx.version'
> because these two versions won't advance simultaneously.
> 
> Details about versioning and proposed namespaces are described in issue:
> https://javafx-jira.kenai.com/browse/RT-28599
> 
> Thanks for comments
> 
>  Milan
> 
> 
> Dne 7.6.2013 10:49, Milan Kubec napsal(a):
>> Hello,
>> I have implemented simple versioning for FXML documents in FXMLLoader, but 
>> without support in tools it won't be very useful. I have agreed with 
>> NetBeans and Scene Builder folks that they will include support for 
>> versioning too. Support means that they will produce document with two XML 
>> namespaces - one defines version of fx: prefixed elements and attributes 
>> (xmlns:fx; it's already there, just the version is appended) and the other 
>> of actual JavaFX API used to produce document (xmlns; default, no prefix). 
>> The first will be checked, because wrong version can cause failure. The 
>> latter is only informational, no strict checking of version is possible, but 
>> tools can suggest to upgrade runtime, translate document etc.
>> 
>> JavaFX API version is stored in System Properties as "javafx.version". The 
>> open question is still where and how to store fxml version in code. I think 
>> that we could have also property for this purpose, e.g. "fxml.version" in 
>> System Properties. So far it's part of FXMLLoader API, which is probably not 
>> very fortunate. What do you think?
>> 
>> Issue details: https://javafx-jira.kenai.com/browse/RT-28599
>> 
>> Milan