Re: RFR: 8263788: JavaFX application freezes completely after some time when using the WebView

[Guru Hb]

On Mon, 12 Apr 2021 13:10:53 GMT, Arun Joseph  wrote:

> Issue: Java application (with WebView) will completely freeze after using it 
> for a while.
> 
> Fix: Use native isMainThread functions instead of JNI call.

Looks good to me . 
Tested on Windows with Modified WebView which loads multiple URL every 30 
seconds (executed for 30 min and didn't find any freeze or crash).

-

Marked as reviewed by ghb (Reviewer).

PR: https://git.openjdk.java.net/jfx/pull/461

Re: RFR: 8260165: CSSFilterTest.testCSSFilterRendering system test fails

[Guru Hb]

On Mon, 22 Feb 2021 11:55:00 GMT, Arun Joseph  wrote:

> Issue: Initial layout delay was removed and layout() is called from 
> layoutTimer instead of WebPage::prePaint().
> 
> Fix: Re-introduce the initial layout delay.

Tested on Linux and Windows, Looks good to me.

-

Marked as reviewed by ghb (Reviewer).

PR: https://git.openjdk.java.net/jfx/pull/408

Re: RFR: 8260257: [Linux] WebView no longer reacts to some mouse events

[Guru Hb]

On Wed, 17 Feb 2021 14:14:35 GMT, Arun Joseph  wrote:

> Timer in RunLoopGeneric has an open bug in WebKit 
> (https://bugs.webkit.org/show_bug.cgi?id=189335) causing the timer to remain 
> active even after firing.
> 
> Reverting back to WebCore Timer for ScrollAnimation in Linux.

Looks good to me. Verified on Ubuntu 20.04

-

Marked as reviewed by ghb (Reviewer).

PR: https://git.openjdk.java.net/jfx/pull/404

Re: RFR: 8261927: WebKit build fails with Visual Studio 2017

[Guru Hb]

On Thu, 18 Feb 2021 13:25:14 GMT, Arun Joseph  wrote:

> The WebKit build fails with Visual Studio 2017.
> 
> Issue: Visual Studio 2017 doesn't support if constexpr in lambda
> 
> Test: Build webkit with the VS2017 compiler with and without this fix. It 
> should fail without the fix and build with the fix.

Compiled and verified on VS 2017. Changes looks good to me.

-

Marked as reviewed by ghb (Reviewer).

PR: https://git.openjdk.java.net/jfx/pull/405

Re: RFR: 8259635: Update to 610.2 version of WebKit [v2]

[Guru Hb]

On Thu, 21 Jan 2021 15:57:04 GMT, Arun Joseph  wrote:

>> Update JavaFX WebKit to GTK WebKit 2.30 (610.2)
>
> Arun Joseph has updated the pull request incrementally with one additional 
> commit since the last revision:
> 
>   Fix color in DefaultPlugin

Changes looks good to me. Did a local build on all three Platform and sanity 
test by loading top 10 websites loaded without any deviation from old build.

-

Marked as reviewed by ghb (Reviewer).

PR: https://git.openjdk.java.net/jfx/pull/382

Re: RFR: 8254049: Update WebView to public suffix list 2020-04-24 [v5]

[Guru Hb]

On Tue, 1 Dec 2020 03:12:10 GMT, Arun Joseph  wrote:

>> We should use the public_suffix_list.dat file in the JDK instead. Reading 
>> the public_suffix_list.dat file is modified to be similar to 
>> [DomainName.java](https://github.com/openjdk/jdk/blob/master/src/java.base/share/classes/sun/security/util/DomainName.java).
>>  If the file is not present, `isPublicSuffix()` returns `false`, which is 
>> similar to how WebKit ignores the public suffix check when it is disabled.
>> 
>> Test: Run PublicSuffixesTest.java
>
> Arun Joseph has updated the pull request incrementally with one additional 
> commit since the last revision:
> 
>   Concat log warning

Looks good to me

-

Marked as reviewed by ghb (Reviewer).

PR: https://git.openjdk.java.net/jfx/pull/324

Re: RFR: 8247963: Update SQLite to version 3.32.3

[Guru Hb]

On Wed, 1 Jul 2020 17:14:30 GMT, Arun Joseph  wrote:

> We currently use SQLite version 3.31.1. We should update to the latest stable 
> release version 3.32.3 released on
> 2020-06-18. https://www.sqlite.org/index.html

Looks good to me

-

Marked as reviewed by ghb (Reviewer).

PR: https://git.openjdk.java.net/jfx/pull/261

Re: RFR: 8244579: Windows "User Objects" leakage with WebView

[Guru Hb]

On Wed, 20 May 2020 14:30:11 GMT, Arun Joseph  wrote:

> Cause: The Window Class `RunLoopMessageWindow` is never registered (this 
> happens because
> registerRunLoopMessageWindowClass() is moved to MainThreadWin.cpp while 
> openjfx uses MainThreadJava.cpp) and this
> causes every SetTimer() call in
> [RunLoopWin.cpp](https://github.com/openjdk/jfx/blob/master/modules/javafx.web/src/main/native/Source/WTF/wtf/win/RunLoopWin.cpp)
> to create a new user object instead of reusing the same object over again.  
> Fix: Call
> registerRunLoopMessageWindowClass() from MainThreadJava.cpp  Test: To verify 
> open any webpage using WebView on WIndows,
> with and without the fix and compare the number of user objects created using 
> Windows Task Manager.

Looks good to me
Tested with your fix and ran Test case provided in JBS 
(WebViewUserObjectLeakage) didn't exceeds more than 50 user
objects (Which is same as in 14-GA build).

-

Marked as reviewed by ghb (Reviewer).

PR: https://git.openjdk.java.net/jfx/pull/229

Re: RFR: 8242505: Some WebKit tests might fail because Microsoft libraries are not loaded

[Guru Hb]

On Wed, 22 Apr 2020 18:07:09 GMT, Kevin Rushforth  wrote:

> This PR will allow javafx.web unit tests to run to completion and pass on 
> Windows with Visual Studio 2019.
> 
> Two of the WebKit tests load the native WebKit library without initializing 
> the JavaFX runtime. This will lead to test
> failures and will hang the test run if those tests are run before the other 
> tests, and if the system doesn't have all
> the needed runtime libraries.   The simple fix is to call the Toolkit method 
> to load those libraries. This is only
> needed for unit tests that don't already initialize the JavaFX runtime (e.g., 
> by calling `Platform::startup` or
> `Application::launch`) and call internal methods that execute native code as 
> part of the test.

Looks good to me

-

Marked as reviewed by ghb (Reviewer).

PR: https://git.openjdk.java.net/jfx/pull/194

Re: RFR: 8242077: Add information about HTTP/2 and HttpClient usage in WebEngine

[Guru Hb]

On Sun, 19 Apr 2020 08:12:07 GMT, Abhinay Agarwal 
 wrote:

> Update WebEngine's Javadoc to add information on how it switches to 
> HttpClient instead of URLConnection in JavaFX 14
> when used with JDK 12 or later.
> Identification of the correct client is important as both these clients may 
> offer different ways to achieve a task. One
> such task can be bypassing insecure HTTPS connection.

looks good to me

-

Marked as reviewed by ghb (Reviewer).

PR: https://git.openjdk.java.net/jfx/pull/189

Re: [Rev 02] RFR: 8223298: SVG patterns are drawn wrong

[Guru Hb]

On Wed, 15 Apr 2020 15:14:49 GMT, Arun Joseph  wrote:

>> Issue: Assuming the pixelScale is 2, the tile image size is doubled at the 
>> native side which is propagated to the java
>> side as well. But, as transform initialization takes place after scaling, 
>> the transform is reset to default value.
>> Fix: Override scale() method in WCBufferedContext class to call init() 
>> before scaling.
>
> Arun Joseph has updated the pull request incrementally with one additional 
> commit since the last revision:
> 
>   Added SVGTest

Looks good to me , verified on mac os x and windows.

-

Marked as reviewed by ghb (Reviewer).

PR: https://git.openjdk.java.net/jfx/pull/164

Re: [Rev 01] RFR: 8223298: SVG patterns are drawn wrong

[Guru Hb]

On Wed, 8 Apr 2020 11:55:03 GMT, Arun Joseph  wrote:

>> Issue: Assuming the pixelScale is 2, the tile image size is doubled at the 
>> native side which is propagated to the java
>> side as well. But, as transform initialization takes place after scaling, 
>> the transform is reset to default value.
>> Fix: Override scale() method in WCBufferedContext class to call init() 
>> before scaling.
>
> Arun Joseph has updated the pull request incrementally with one additional 
> commit since the last revision:
> 
>   Update copyright year

Looks good to me. Tested on Windows and mac OS X.
If feasible can we have Unit test for this.

-

Marked as reviewed by ghb (Reviewer).

PR: https://git.openjdk.java.net/jfx/pull/164

Re: RFR: 8242209: Increase web native thread stack size for x86 mode

[Guru Hb]

On Mon, 6 Apr 2020 11:57:54 GMT, Arun Joseph  wrote:

> CLoop interpreter used in 32-bit Windows uses 87 KB of stack space each time 
> CLoop::execute() is called. For web native
> threads which has a default stack size of 320 KB, a Stack Overflow Error is 
> raised just after two calls to execute()
> function. While 64-bit windows has a default stack size of 1 MB.  Fix: 
> Increase the thread stack size of web native
> threads for x86 to 1 MB.

Looks good to me, Tested on Windows with test case added in JBS.

-

Marked as reviewed by ghb (Reviewer).

PR: https://git.openjdk.java.net/jfx/pull/159

Re: [Rev 01] RFR: 8240694: [macos 10.15] JavaFX Media hangs on some video files on Catalina

[Guru Hb]

On Thu, 9 Apr 2020 01:45:27 GMT, Alexander Matveev  wrote:

>> https://bugs.openjdk.java.net/browse/JDK-8240694
>> 
>> - Original fix JDK-8236832 was reverted.
>> - Timestamp will be queried on event loop thread when spectrum event is 
>> received by event loop.
>> - FIx only enabled for macOS when using OSXPlatform.
>
> Alexander Matveev has updated the pull request incrementally with one 
> additional commit since the last revision:
> 
>   8240694: Improved comments per reviewers request

Looks good to me, Tested on MacOS 10.12.6 (Sierra) with the use case provided 
in JBS).

-

Marked as reviewed by ghb (Reviewer).

PR: https://git.openjdk.java.net/jfx/pull/163

Re: [Rev 02] RFR: 8234471: Canvas in webview displayed with wrong scale on Windows

[Guru Hb]

On Wed, 25 Mar 2020 18:12:41 GMT, Arun Joseph  wrote:

>> This bug can be reproduced when the screen resolution is at 125%, 150% and 
>> 175% for Windows, which correpsonds to
>> `pixelScale` values of 1.25, 1.5 and 1.75, respectively.
>> Issue: The rectangle inside canvas is rendered on `pixelScale` while the 
>> borders are rendered on `Math.ceil(pixelScale)`
>> 
>> Fix: Use `Math.ceil(pixelScale)` for calculating `pixelScaleTransform`
>
> Arun Joseph has updated the pull request incrementally with one additional 
> commit since the last revision:
> 
>   Updated test

Marked as reviewed by ghb (Reviewer).

-

PR: https://git.openjdk.java.net/jfx/pull/62

Re: RFR: 8240211: Stack overflow on Windows 32-bit can lead to crash

[Guru Hb]

On Thu, 5 Mar 2020 14:51:03 GMT, Arun Joseph  wrote:

> Issue: The stack pointer is checked close to the stack limit during the last 
> iteration of calling frameLoaded() and then, grows beyond the thread's stack 
> range causing a stack overflow and crashes. This occurs as the stack grows by 
> an amount larger than the reserved zone at the end of the stack.
> 
> Fix: Reduce the stack range visible to the thread in 
> [StackBounds.cpp](https://github.com/openjdk/jfx/blob/master/modules/javafx.web/src/main/native/Source/WTF/wtf/StackBounds.cpp)
>  similar to Mac and Linux. This causes the stack pointer check to throw a 
> StackOverflowError during the last iteration.

Looks good to me. 
I believe you have executed DRT on both 64 & 32 bit build.

-

Marked as reviewed by ghb (Reviewer).

PR: https://git.openjdk.java.net/jfx/pull/137

Re: RFR: 8236832: [macos 10.15] JavaFX Application hangs on video play on Cata…

[Guru Hb]

On Wed, 26 Feb 2020 03:39:49 GMT, Alexander Matveev  
wrote:

> https://bugs.openjdk.java.net/browse/JDK-8236832
> 
> - This issue most likely caused by changes in AVFoundation APIs on macOS 
> 10.15.
> - Getting currentTime from AVPlayer was blocked if it is done from 
> ProcessAudioTap callback (used for spectrum, equalizer and volume) on first 
> call. If we reading currentTime after first callback returns, then it will 
> not block. Fixed by not reading currentTime on first call and default it 0.

+1, Looks good to me.

-

Marked as reviewed by ghb (Reviewer).

PR: https://git.openjdk.java.net/jfx/pull/126

Re: [Integrated] RFR: 8239109: Update SQLite to version 3.31.1

[Guru Hb]

Changeset: 4eaff0de
Author:Guru Hb 
Date:  2020-02-24 04:08:43 +
URL:   https://git.openjdk.java.net/jfx/commit/4eaff0de

8239109: Update SQLite to version 3.31.1

Reviewed-by: ajoseph, kcr, jvos

! modules/javafx.web/src/main/native/Source/ThirdParty/sqlite/VERSION
! modules/javafx.web/src/main/native/Source/ThirdParty/sqlite/sqlite3.c
! modules/javafx.web/src/main/native/Source/ThirdParty/sqlite/sqlite3.h
! modules/javafx.web/src/main/native/Source/ThirdParty/sqlite/sqlite3ext.h

RFR: 8239109: Update SQLite to version 3.31.1

[Guru Hb]

Updating SQLite to version 3.31.1 (Currently used version is 3.30.1).

-

Commits:
 - d4e17340: 8239109: Update SQLite to version 3.31.1

Changes: https://git.openjdk.java.net/jfx/pull/119/files
 Webrev: https://webrevs.openjdk.java.net/jfx/119/webrev.00
  Issue: https://bugs.openjdk.java.net/browse/JDK-8239109
  Stats: 9862 lines in 4 files changed: 4400 ins; 774 del; 4688 mod
  Patch: https://git.openjdk.java.net/jfx/pull/119.diff
  Fetch: git fetch https://git.openjdk.java.net/jfx pull/119/head:pull/119

PR: https://git.openjdk.java.net/jfx/pull/119

Re: RFR: 8239454: LLIntData : invalid opcode returned for 16 and 32 bit wide instructions

[Guru Hb]

On Wed, 19 Feb 2020 12:09:50 GMT, Arun Joseph  wrote:

> With new bytecode format introduced in Webkit 608.1, the unlinked and linked 
> bytecodes were replaced by narrow (1-byte operand) and wide (4-byte operand) 
> bytecodes. These were extended to narrow, wide16 and wide32 bytecodes in 
> WebKit 609.1. In narrow instructions, each argument of the opcode has a fixed 
> size of 1-byte. The same applies for wide 16 and wide32 with 2-byte and 
> 4-byte, respectively.
> 
> In the Low Level Intepreter (LLInt), each opcode has a corresponding ID 
> assigned for narrow, wide16 and wide32 implementation, and the variable 
> `numOpcodeIDs` is used to denote the total number of opcodes. The narrow 
> opcode IDs are mapped from 0 to (`numOpcodeIDs` - 1). The next `numOpcodeIDs` 
> opcode IDs are mapped to wide16 opcodes, and similarly, the next 
> `numOpcodeIDs` to wide32 opcodes. The same can be found in 
> [LowLevelInterpreter.cpp](https://github.com/openjdk/jfx/blob/master/modules/javafx.web/src/main/native/Source/JavaScriptCore/llint/LowLevelInterpreter.cpp#L265)
>  and also in the autogenerated file `Bytecodes.h`. 
> 
> Bug: When `getOpcodeWide(id)` is called in `LLIntData.h`, the value (`id` - 
> `numOpcodesIDs`) is returned.
> 
> Fix: It's modified to (`id` + `numOpcodesIDs`) in `getOpcodeWide16()` and 
> (`id` + `numOpcodesIDs`*2) in `getOpcodeWide32()`.

Marked as reviewed by ghb (Reviewer).

-

PR: https://git.openjdk.java.net/jfx/pull/115

Re: [Integrated] RFR: 8238526: Cherry pick GTK WebKit 2.26.3 changes

[Guru Hb]

Changeset: e224e549
Author:Guru Hb 
Date:  2020-02-07 02:13:15 +
URL:   https://git.openjdk.java.net/jfx/commit/e224e549

8238526: Cherry pick GTK WebKit 2.26.3 changes

Reviewed-by: kcr, jvos

! 
modules/javafx.web/src/main/native/Source/JavaScriptCore/dfg/DFGObjectAllocationSinkingPhase.cpp
! modules/javafx.web/src/main/native/Source/JavaScriptCore/dfg/DFGValidate.cpp
! modules/javafx.web/src/main/native/Source/JavaScriptCore/offlineasm/parser.rb
! 
modules/javafx.web/src/main/native/Source/JavaScriptCore/runtime/NativeErrorConstructor.h
! modules/javafx.web/src/main/native/Source/WTF/wtf/Platform.h
! modules/javafx.web/src/main/native/Source/WTF/wtf/URLHelpers.cpp
! modules/javafx.web/src/main/native/Source/WebCore/dom/Document.cpp
! modules/javafx.web/src/main/native/Source/WebCore/page/FrameView.cpp
! modules/javafx.web/src/main/native/Source/WebCore/page/Page.cpp
! 
modules/javafx.web/src/main/native/Source/WebCore/platform/graphics/ComplexTextController.cpp
! 
modules/javafx.web/src/main/native/Source/WebCore/platform/graphics/freetype/FontPlatformDataFreeType.cpp
! 
modules/javafx.web/src/main/native/Source/WebCore/platform/graphics/harfbuzz/ComplexTextControllerHarfBuzz.cpp
! modules/javafx.web/src/main/native/Source/WebCore/rendering/RenderFrameSet.cpp
! modules/javafx.web/src/main/native/Source/WebCore/rendering/RenderThemeGtk.cpp
! modules/javafx.web/src/main/native/Source/WebCore/rendering/RenderThemeGtk.h
! 
modules/javafx.web/src/main/native/Source/WebCore/rendering/SimpleLineLayoutResolver.cpp
! 
modules/javafx.web/src/main/native/Source/WebCore/svg/properties/SVGAnimatedPropertyPairAccessor.h
! modules/javafx.web/src/main/native/Source/WebCore/testing/InternalSettings.cpp
! modules/javafx.web/src/main/native/Source/cmake/OptionsGTK.cmake

RFR: 8238526: Cherry pick GTK WebKit 2.26.3 changes

[Guru Hb]

Fix contains https://webkitgtk.org/2020/01/22/webkitgtk2.26.3-released.html

-

Commits:
 - 025373db: 8238526: Cherry pick GTK WebKit 2.26.3 changes

Changes: https://git.openjdk.java.net/jfx/pull/107/files
 Webrev: https://webrevs.openjdk.java.net/jfx/107/webrev.00
  Issue: https://bugs.openjdk.java.net/browse/JDK-8238526
  Stats: 123 lines in 19 files changed: 39 ins; 59 del; 25 mod
  Patch: https://git.openjdk.java.net/jfx/pull/107.diff
  Fetch: git fetch https://git.openjdk.java.net/jfx pull/107/head:pull/107

PR: https://git.openjdk.java.net/jfx/pull/107

Re: [Integrated] RFR: 8237944: webview native cl "-m32" unknown option for windows 32-bit build

[Guru Hb]

Changeset: aa91ebbb
Author:Guru Hb 
Date:  2020-02-03 08:51:25 +
URL:   https://git.openjdk.java.net/jfx/commit/aa91ebbb

8237944: webview native cl "-m32" unknown option for windows 32-bit build

Reviewed-by: kcr

! modules/javafx.web/src/main/native/Tools/Scripts/webkitdirs.pm

Re: [Integrated] RFR: 8237003: Remove hardcoded WebAnimationsCSSIntegrationEnabled flag in DumpRenderTree

[Guru Hb]

Changeset: b96bc52b
Author:Guru Hb 
Date:  2020-01-29 16:44:56 +
URL:   https://git.openjdk.java.net/jfx/commit/b96bc52b

8237003: Remove hardcoded WebAnimationsCSSIntegrationEnabled flag in 
DumpRenderTree

Reviewed-by: kcr

! modules/javafx.web/src/main/java/com/sun/javafx/webkit/drt/DumpRenderTree.java

Re: [Rev 01] RFR: 8237944: webview native cl "-m32" unknown option for windows 32-bit build

[Guru Hb]

On Wed, 29 Jan 2020 12:57:41 GMT, Kevin Rushforth  wrote:

>> The pull request has been updated with 1 additional commit.
> 
> Marked as reviewed by kcr (Lead).

> the -m32 option seems to be ignored by the compiler:
> cl : Command line warning D9002 : ignoring unknown option '-m32'
> 
> However, I agree it is better to conditionally remove it.
"-m32" required for compiling other ports of webkit (WebkitGTK, WPE) and for 
our platform I haven't tested this feature (i.e cross compiling on a 64 bit 
Linux).

-

PR: https://git.openjdk.java.net/jfx/pull/97

RFR: 8237003: Remove hardcoded WebAnimationsCSSIntegrationEnabled flag in DumpRenderTree

[Guru Hb]

AnimationBase and WebAnimation are two different abstract animation API 
provider. By default KeyFrameAnimation (which is a sub class of AnimationBase) 
is used for controlling and rendering the CSS animation. 
Enabling "WebAnimationsCSSIntegrationEnabled" overrides the 
CSSAnimationController to use WebAnimation which is not used in our port (JAVA) 
and we are using KeyFrameAnimation.

Test : need to run DRT test harness with this fix for "LayoutTests/animations".

-

Commits:
 - c473f6e2: 8237003: Remove hardcoded WebAnimationsCSSIntegrationEnabled flag 
in DumpRenderTree

Changes: https://git.openjdk.java.net/jfx/pull/100/files
 Webrev: https://webrevs.openjdk.java.net/jfx/100/webrev.00
  Issue: https://bugs.openjdk.java.net/browse/JDK-8237003
  Stats: 1 line in 1 file changed: 0 ins; 1 del; 0 mod
  Patch: https://git.openjdk.java.net/jfx/pull/100.diff
  Fetch: git fetch https://git.openjdk.java.net/jfx pull/100/head:pull/100

PR: https://git.openjdk.java.net/jfx/pull/100

Re: [Rev 01] RFR: 8237944: webview native cl "-m32" unknown option for windows 32-bit build

[Guru Hb]

> cl : Command line warning D9002 : ignoring unknown option '-m32'
> 
> post fix for "https://trac.webkit.org/changeset/242724/webkit; makes use of 
> cross compiling 32 bit JSC in a 64 bit and its holds good only for Linux. 
> '-m32' flag is gcc specifc and on windows cl.exe (visual studio) doesn't 
> recognize this flag.

The pull request has been updated with 1 additional commit.

-

Added commits:
 - bbb6201b: inforporated review comments

Changes:
  - all: https://git.openjdk.java.net/jfx/pull/97/files
  - new: https://git.openjdk.java.net/jfx/pull/97/files/0d9ca899..bbb6201b

Webrevs:
 - full: https://webrevs.openjdk.java.net/jfx/97/webrev.01
 - incr: https://webrevs.openjdk.java.net/jfx/97/webrev.00-01

  Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod
  Patch: https://git.openjdk.java.net/jfx/pull/97.diff
  Fetch: git fetch https://git.openjdk.java.net/jfx pull/97/head:pull/97

PR: https://git.openjdk.java.net/jfx/pull/97

RFR: 8237944: webview native cl "-m32" unknown option for windows 32-bit build

[Guru Hb]

cl : Command line warning D9002 : ignoring unknown option '-m32'

post fix for "https://trac.webkit.org/changeset/242724/webkit; makes use of 
cross compiling 32 bit JSC in a 64 bit and its holds good only for Linux. 
'-m32' flag is gcc specifc and on windows cl.exe (visual studio) doesn't 
recognize this flag.

-

Commits:
 - 0d9ca899: 8237944: webview native cl "-m32" unknown option for windows 
32-bit build

Changes: https://git.openjdk.java.net/jfx/pull/97/files
 Webrev: https://webrevs.openjdk.java.net/jfx/97/webrev.00
  Issue: https://bugs.openjdk.java.net/browse/JDK-8237944
  Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod
  Patch: https://git.openjdk.java.net/jfx/pull/97.diff
  Fetch: git fetch https://git.openjdk.java.net/jfx pull/97/head:pull/97

PR: https://git.openjdk.java.net/jfx/pull/97

Re: [Rev 03] RFR: 8236912: NullPointerException when clicking in WebView with Button 4 or Button 5

[Guru Hb]

On Fri, 24 Jan 2020 14:41:11 GMT, Robert Lichtenberger  
wrote:

>> As documented in JDK-8236912, WebView did not check whether the idMap really 
>> contained a mapping for the given button, making it prone to errors, when 
>> things are extended (as has happened here).
>> 
>> The fix consists of two test cases that show the problem in unfixed WebViews 
>> and a fix which works analogously to the check whether the given event type 
>> is mapped.
> 
> Previous commits in this pull request have been removed, probably due to a 
> force push. The incremental views will show differences compared to the 
> previous content of the PR.

Marked as reviewed by ghb (Reviewer).

-

PR: https://git.openjdk.java.net/jfx/pull/85

Re: [Rev 03] RFR: 8236912: NullPointerException when clicking in WebView with Button 4 or Button 5

[Guru Hb]

On Fri, 17 Jan 2020 23:18:28 GMT, Kevin Rushforth  wrote:

>> Previous commits in this pull request have been removed, probably due to a 
>> force push. The incremental views will show differences compared to the 
>> previous content of the PR.
> 
> Looks good to me.
> 
> @guruhb can you re-review this when you get a chance?

+1, Looks good to me.

-

PR: https://git.openjdk.java.net/jfx/pull/85

RFR: 8233942: Update to 609.1 version of WebKit

[Guru Hb]

Updated GTK Webkit 2.26 (609.1) into jfx.

-

Commits:
 - 8b48b1e0: 8233942: Update to 609.1 version of WebKit

Changes: https://git.openjdk.java.net/jfx/pull/91/files
 Webrev: https://webrevs.openjdk.java.net/jfx/91/webrev.00
  Issue: https://bugs.openjdk.java.net/browse/JDK-8233942
  Stats: 279532 lines in 5731 files changed: 169844 ins; 72559 del; 37129 mod
  Patch: https://git.openjdk.java.net/jfx/pull/91.diff
  Fetch: git fetch https://git.openjdk.java.net/jfx pull/91/head:pull/91

PR: https://git.openjdk.java.net/jfx/pull/91

Re: [Rev 02] RFR: 8236912: NullPointerException when clicking in WebView with Button 4 or Button 5

[Guru Hb]

On Tue, 14 Jan 2020 14:13:54 GMT, Robert Lichtenberger  
wrote:

>> As documented in JDK-8236912, WebView did not check whether the idMap really 
>> contained a mapping for the given button, making it prone to errors, when 
>> things are extended (as has happened here).
>> 
>> The fix consists of two test cases that show the problem in unfixed WebViews 
>> and a fix which works analogously to the check whether the given event type 
>> is mapped.
> 
> The pull request has been updated with a new target base due to a merge or a 
> rebase. The incremental webrev excludes the unrelated changes brought in by 
> the merge/rebase.

Partially reviewed, Need to re-check after the change of branch.

-

Changes requested by ghb (Reviewer).

PR: https://git.openjdk.java.net/jfx/pull/85

Re: RFR: 8236912: NullPointerException when clicking in WebView with Button 4 or Button 5

[Guru Hb]

On Tue, 14 Jan 2020 12:01:11 GMT, Robert Lichtenberger  
wrote:

> As documented in JDK-8236912, WebView did not check whether the idMap really 
> contained a mapping for the given button, making it prone to errors, when 
> things are extended (as has happened here).
> 
> The fix consists of two test cases that show the problem in unfixed WebViews 
> and a fix which works analogously to the check whether the given event type 
> is mapped.

+1, Looks good to me.

-

Marked as reviewed by ghb (Reviewer).

PR: https://git.openjdk.java.net/jfx/pull/85

Re: RFR: 8234471: Canvas in webview displayed with wrong scale on Windows

[Guru Hb]

On Mon, 9 Dec 2019 13:09:04 GMT, Arun Joseph  wrote:

> This bug can be reproduced when the screen resolution is at 125%, 150% and 
> 175% for Windows, which correpsonds to `pixelScale` values of 1.25, 1.5 and 
> 1.75, respectively.
> 
> Issue: The rectangle inside canvas is rendered on `pixelScale` while the 
> borders are rendered on `Math.ceil(pixelScale)`
> 
> Fix: Use `Math.ceil(pixelScale)` for calculating `pixelScaleTransform`

have you tested this on Linux and Mac by changing JVM option 
-Dglass.win.uiScale=.

-

PR: https://git.openjdk.java.net/jfx/pull/62

Re: [Rev 03] RFR: 8233747: JVM crash in com.sun.webkit.dom.DocumentImpl.createAttribute

[Guru Hb]

On Mon, 6 Jan 2020 04:32:34 GMT, Arun Joseph  wrote:

>> Issue: Native part of WebView throws a DOMException and then, continues 
>> executing the rest of the function assuming that value is present. This 
>> causes the JVM to crash when retrieving the value.
>> 
>> Fix: Return from the function if exception was raised (code is similar to 
>> exception handling in 
>> [WebKitLegacy/java/DOM/JavaTreeWalker.cpp](https://github.com/openjdk/jfx/blob/master/modules/javafx.web/src/main/native/Source/WebKitLegacy/java/DOM/JavaTreeWalker.cpp))
>> 
>> This fix also needs to be applied to all function calls in 
>> [WebKitLegacy/java/DOM](https://github.com/openjdk/jfx/tree/master/modules/javafx.web/src/main/native/Source/WebKitLegacy/java/DOM)
>>  functions which raises DOMError similar to createAttributeImpl().
> 
> The pull request has been updated with 1 additional commit.

+1, Looks good to me.

-

Marked as reviewed by ghb (Reviewer).

PR: https://git.openjdk.java.net/jfx/pull/47

Re: [Approved] RFR: 8211308: Support HTTP/2 in WebView

[Guru Hb]

On Wed, 16 Oct 2019 17:57:58 GMT, Arunprasad Rajkumar  
wrote:

> The pull request has been updated with additional changes.
> 
> 
> 
> Added commits:
>  - 1832c2db: Incorporate fixes provided by @kcr
> 
> Changes:
>   - all: https://git.openjdk.java.net/jfx/pull/14/files
>   - new: https://git.openjdk.java.net/jfx/pull/14/files/1798a661..1832c2db
> 
> Webrevs:
>  - full: https://webrevs.openjdk.java.net/jfx/14/webrev.01
>  - incr: https://webrevs.openjdk.java.net/jfx/14/webrev.00-01
> 
>   Stats: 13 lines in 2 files changed: 5 ins; 0 del; 8 mod
>   Patch: https://git.openjdk.java.net/jfx/pull/14.diff
>   Fetch: git fetch https://git.openjdk.java.net/jfx pull/14/head:pull/14

Looks good to me.



Approved by ghb (Reviewer).

PR: https://git.openjdk.java.net/jfx/pull/14

Re: [Integrated] RFR: 8218640: Update ICU4C to version 64.2

[Guru Hb]

Changeset: b6e53f4f
Author:Arun Joseph 
Committer: Guru Hb 
Date:  2019-10-15 17:41:33 +
URL:   https://git.openjdk.java.net/jfx/commit/b6e53f4f

8218640: Update ICU4C to version 64.2

Reviewed-by: kcr, ghb, jvos

! modules/javafx.web/src/main/legal/icu_web.md
! modules/javafx.web/src/main/native/Source/ThirdParty/icu/CMakeLists.txt
! modules/javafx.web/src/main/native/Source/ThirdParty/icu/LICENSE
- 
modules/javafx.web/src/main/native/Source/ThirdParty/icu/java/data/icudt62l.zip
+ 
modules/javafx.web/src/main/native/Source/ThirdParty/icu/java/data/icudt64l.zip
! 
modules/javafx.web/src/main/native/Source/ThirdParty/icu/source/common/bmpset.cpp
! 
modules/javafx.web/src/main/native/Source/ThirdParty/icu/source/common/brkeng.cpp
! 
modules/javafx.web/src/main/native/Source/ThirdParty/icu/source/common/bytesinkutil.cpp
! 
modules/javafx.web/src/main/native/Source/ThirdParty/icu/source/common/bytesinkutil.h
! 
modules/javafx.web/src/main/native/Source/ThirdParty/icu/source/common/bytestriebuilder.cpp
+ 
modules/javafx.web/src/main/native/Source/ThirdParty/icu/source/common/capi_helper.h
+ 
modules/javafx.web/src/main/native/Source/ThirdParty/icu/source/common/characterproperties.cpp
! 
modules/javafx.web/src/main/native/Source/ThirdParty/icu/source/common/charstr.cpp
! 
modules/javafx.web/src/main/native/Source/ThirdParty/icu/source/common/charstr.h
! 
modules/javafx.web/src/main/native/Source/ThirdParty/icu/source/common/cmemory.h
! 
modules/javafx.web/src/main/native/Source/ThirdParty/icu/source/common/common.rc
! 
modules/javafx.web/src/main/native/Source/ThirdParty/icu/source/common/common.vcxproj
! 
modules/javafx.web/src/main/native/Source/ThirdParty/icu/source/common/common.vcxproj.filters
! 
modules/javafx.web/src/main/native/Source/ThirdParty/icu/source/common/common_uwp.vcxproj
! 
modules/javafx.web/src/main/native/Source/ThirdParty/icu/source/common/dictbe.cpp
! 
modules/javafx.web/src/main/native/Source/ThirdParty/icu/source/common/dictionarydata.h
! 
modules/javafx.web/src/main/native/Source/ThirdParty/icu/source/common/edits.cpp
! modules/javafx.web/src/main/native/Source/ThirdParty/icu/source/common/hash.h
- 
modules/javafx.web/src/main/native/Source/ThirdParty/icu/source/common/listformatter.cpp
! 
modules/javafx.web/src/main/native/Source/ThirdParty/icu/source/common/loadednormalizer2impl.cpp
+ 
modules/javafx.web/src/main/native/Source/ThirdParty/icu/source/common/localebuilder.cpp
! 
modules/javafx.web/src/main/native/Source/ThirdParty/icu/source/common/localsvc.h
! 
modules/javafx.web/src/main/native/Source/ThirdParty/icu/source/common/locavailable.cpp
! 
modules/javafx.web/src/main/native/Source/ThirdParty/icu/source/common/locdispnames.cpp
! 
modules/javafx.web/src/main/native/Source/ThirdParty/icu/source/common/locdspnm.cpp
! 
modules/javafx.web/src/main/native/Source/ThirdParty/icu/source/common/locid.cpp
! 
modules/javafx.web/src/main/native/Source/ThirdParty/icu/source/common/loclikely.cpp
! 
modules/javafx.web/src/main/native/Source/ThirdParty/icu/source/common/locmap.cpp
! 
modules/javafx.web/src/main/native/Source/ThirdParty/icu/source/common/locmap.h
! 
modules/javafx.web/src/main/native/Source/ThirdParty/icu/source/common/locresdata.cpp
! 
modules/javafx.web/src/main/native/Source/ThirdParty/icu/source/common/locutil.cpp
! modules/javafx.web/src/main/native/Source/ThirdParty/icu/source/common/mutex.h
! 
modules/javafx.web/src/main/native/Source/ThirdParty/icu/source/common/norm2_nfc_data.h
! 
modules/javafx.web/src/main/native/Source/ThirdParty/icu/source/common/normalizer2.cpp
! 
modules/javafx.web/src/main/native/Source/ThirdParty/icu/source/common/normalizer2impl.cpp
! 
modules/javafx.web/src/main/native/Source/ThirdParty/icu/source/common/normalizer2impl.h
! 
modules/javafx.web/src/main/native/Source/ThirdParty/icu/source/common/normlzr.cpp
! 
modules/javafx.web/src/main/native/Source/ThirdParty/icu/source/common/patternprops.cpp
! 
modules/javafx.web/src/main/native/Source/ThirdParty/icu/source/common/patternprops.h
! 
modules/javafx.web/src/main/native/Source/ThirdParty/icu/source/common/propname_data.h
! 
modules/javafx.web/src/main/native/Source/ThirdParty/icu/source/common/putil.cpp
! 
modules/javafx.web/src/main/native/Source/ThirdParty/icu/source/common/putilimp.h
! 
modules/javafx.web/src/main/native/Source/ThirdParty/icu/source/common/rbbi.cpp
! 
modules/javafx.web/src/main/native/Source/ThirdParty/icu/source/common/rbbi_cache.cpp
! 
modules/javafx.web/src/main/native/Source/ThirdParty/icu/source/common/rbbi_cache.h
! 
modules/javafx.web/src/main/native/Source/ThirdParty/icu/source/common/rbbicst.pl
! 
modules/javafx.web/src/main/native/Source/ThirdParty/icu/source/common/rbbirb.cpp
! 
modules/javafx.web/src/main/native/Source/ThirdParty/icu/source/common/rbbirpt.txt
! 
modules/javafx.web/src/main/native/Source/ThirdParty/icu/source/common/rbbiscan.cpp
! 
modules/javafx.web/src/main/native/Source/ThirdParty/icu/source/common/rbbiscan.h
! 
modules

Re: [Approved] RFR: 8218640: Update ICU4C to version 64.2

[Guru Hb]

On Wed, 9 Oct 2019 13:25:54 GMT, Arun Joseph 
 wrote:

> We currently use ICU4C version 62.1. We should update to the latest stable 
> version 64.2.
> http://site.icu-project.org/home
> 
> 
> 
> Commits:
>  - b56b720e: 8218640: Update ICU4C to version 64.2
> 
> Changes: https://git.openjdk.java.net/jfx/pull/10/files
>  Webrev: https://webrevs.openjdk.java.net/jfx/10/webrev.00
>   Issue: https://bugs.openjdk.java.net/browse/JDK-8218640
>   Stats: 41065 lines in 430 files changed: 23684 ins; 7205 del; 10176 mod
>   Patch: https://git.openjdk.java.net/jfx/pull/10.diff
>   Fetch: git fetch https://git.openjdk.java.net/jfx pull/10/head:pull/10

+1 Looks good to me



Approved by ghb (Reviewer).

PR: https://git.openjdk.java.net/jfx/pull/10

Re: [Approved] RFR: 8231854: Change Mercurial to git in various README files

[Guru Hb]

On Thu, 3 Oct 2019 23:15:56 GMT, Kevin Rushforth  wrote:

> https://bugs.openjdk.java.net/browse/JDK-8231854
> 
> Follow-on fix to 
> [JDK-8231590](https://bugs.openjdk.java.net/browse/JDK-8231590) -- PR #3 -- 
> to change Mercurial or hg to git in a few README files where appropriate.
> 
> 
> 
> Commits:
>  - bb9544ac: 8231854: Change Mercurial to git in various README files
> 
> Changes: https://git.openjdk.java.net/jfx/pull/7/files
>  Webrev: https://webrevs.openjdk.java.net/jfx/7/webrev.00
>   Issue: https://bugs.openjdk.java.net/browse/JDK-8231854
>   Stats: 7 lines in 4 files changed: 0 ins; 0 del; 7 mod
>   Patch: https://git.openjdk.java.net/jfx/pull/7.diff
>   Fetch: git fetch https://git.openjdk.java.net/jfx pull/7/head:pull/7

Approved by ghb (Reviewer).

PR: https://git.openjdk.java.net/jfx/pull/7

[10] Review request: 8191035: WebView Canvas Graphics2D arc renders incorrectly

[Guru Hb]

Hi Kevin, Arun,

Please review 
JBS : https://bugs.openjdk.java.net/browse/JDK-8191035 

Webrev : http://cr.openjdk.java.net/~ghb/8191035/webrev.00/ 

RC and solution update in JBS.

Thanks,
Guru

Re: CFV: New OpenJFX Committer: Ambarish Rapte

[Guru Hb]

Vote: yes

> On 01-Nov-2017, at 1:48 AM, Kevin Rushforth  
> wrote:
> 
> I hereby nominate Ambarish Rapte [1] to OpenJFX Committer.
> 
> Ambarish is a member of JavaFX team at Oracle, who has contributed 10 
> changesets [2][3] to OpenJFX.
> 
> Votes are due by November 14, 2017.
> 
> Only current OpenJFX Committers [4] are eligible to vote on this nomination. 
> Votes must be cast in the open by replying to this mailing list.
> 
> For Lazy Consensus voting instructions, see [5]. Nomination to a project 
> Committer is described in [6].
> 
> Thanks.
> 
> -- Kevin
> 
> [1] http://openjdk.java.net/census#arapte
> 
> [2] 
> http://hg.openjdk.java.net/openjfx/10-dev/rt/log?revcount=20=author%28arapte%29
> [3] http://hg.openjdk.java.net/openjfx/10-dev/rt/rev/f7d38650fa15
> 
> [4] http://openjdk.java.net/census#openjfx
> 
> [5] http://openjdk.java.net/bylaws#lazy-consensus
> 
> [6] http://openjdk.java.net/projects#project-committer
> 

[10] Review request: 8185654: Fix copyright notice on WebKit porting layer files in platform/java

[Guru Hb]

Please review the fix for 
https://bugs.openjdk.java.net/browse/JDK-8185654 

http://cr.openjdk.java.net/~ghb/8185654/8185654_0.diff 
 

Thanks,
Guru

[webkit][10] Review request: 8170955: JavaFX crash in libjfxwebkit.so

[Guru Hb]

Hi Arun, Murali & Kevin,

Please review the fix for 
JBS : https://bugs.openjdk.java.net/browse/JDK-8187568 

Webrev: http://cr.openjdk.java.net/~ghb/8187568/webrev.00/ 


RC and solution updated in JBS.

Thanks,
Guru

Re: CFV: New OpenJFX Committer: Prasanta Sadhukhan

[Guru Hb]

Vote: YES

> On 28-Sep-2017, at 6:40 AM, Kevin Rushforth  
> wrote:
> 
> I hereby nominate Prasanta Sadhukhan [1] to OpenJFX Committer.
> 
> Prasanta is a member of JavaFX team at Oracle, who has contributed 12 
> changesets [2] to OpenJFX.
> 
> Votes are due by October 11, 2017.
> 
> Only current OpenJFX Committers [3] are eligible to vote on this nomination. 
> Votes must be cast in the open by replying to this mailing list.
> 
> For Lazy Consensus voting instructions, see [4]. Nomination to a project 
> Committer is described in [5].
> 
> Thanks.
> 
> -- Kevin
> 
> [1] http://openjdk.java.net/census#psadhukhan
> 
> [2] 
> http://hg.openjdk.java.net/openjfx/10-dev/rt/log?revcount=20=author%28psadhukhan%29
> 
> [3] http://openjdk.java.net/census#openjfx
> 
> [4] http://openjdk.java.net/bylaws#lazy-consensus
> 
> [5] http://openjdk.java.net/projects#project-committer
> 

[webkit][10] Review request: 8170955: HTML5 canvas shadow properties should not be affected by transform

[Guru Hb]

Hi Arun & Murali,

Please review the fix for :
JBS : https://bugs.openjdk.java.net/browse/JDK-8170955 

webrev : http://cr.openjdk.java.net/~ghb/8170955/webrev.00/ 


Thanks,
Guru

[webkit][10] 8185940: Web native compiled files not removed during gradle clean

[Guru Hb]

Hi Arun, Murali,

Please review the fix for 
JBS : https://bugs.openjdk.java.net/browse/JDK-8185940 

WebRev : http://cr.openjdk.java.net/~ghb/8185940/webrev.00 


Thanks,
Guru

[10] Review request: 8184797: Copy DumpRenderTreeJava.dll from bin to lib directory

[Guru Hb]

Hi Arun & Murali,

Please review the fix for: 
JBS :  https://bugs.openjdk.java.net/browse/JDK-8184797 

Webrev : http://cr.openjdk.java.net/~ghb/8184797/webrev.00/ 


Thanks,
Guru

Re: Support for JavaScript FileReader object in JavaFX WebView

[Guru Hb]

Hi Jelurida,

You are correct, We are not yet (in Java 9) supporting File Api in our 
javafx.WebView.
Will update once we have this enhancement is implemented 
https://bugs.openjdk.java.net/browse/JDK-8184785 
 .

Thanks,
Guru

> On 17-Jul-2017, at 4:29 PM, Jelurida  wrote:
> 
> Greetings,
> 
> Is there a chance that the JavaScript FileReader object in JavaFX
> WebView will be supported in Java 9?
> Tried with the latest pre-release and it looks like the window.FileReader
> object is still unsupported.

[10] Review request: 8178360: Build and integrate ICU from source

[Guru Hb]

Hi Kevin, Arun and Murali,

Please review the fix for :
JBS : https://bugs.openjdk.java.net/browse/JDK-8178360 

Webrev : http://cr.openjdk.java.net/~ghb/8178360/webrev.07 
 (Modified Source)
patch : http://cr.openjdk.java.net/~ghb/8178360/rt.patch_07.tar.gz 
 (patch for local 
build and testing)

Thanks,
Guru

[10] Review request: 8179673: JVM Crash in WebPage.setBackgroundColor() during webpage navigation (Non Public API)

[Guru Hb]

Hi Arun, Murali & Kevin,

Please review the fix for : https://bugs.openjdk.java.net/browse/JDK-8179673 

Webrev : http://cr.openjdk.java.net/~ghb/8179673/webrev.00/ 


Thanks,
Guru

[9] Review request: 8174919: SocketException no longer handled by WebView when processing web pages

[Guru Hb]

Hi Kevin & Murali,

Please review the fix for JBS : 
https://bugs.openjdk.java.net/browse/JDK-8174919 

Webrev : http://cr.openjdk.java.net/~ghb/8174919/webrev.00/ 


Thanks,
Guru

Re: CFV: New OpenJFX Committer: Semyon Sadetsky

[Guru Hb]

Vote: YES

> On 26-Jan-2017, at 1:09 AM, David Hill  wrote:
> 
> 
> I hereby nominate Semyon Sadetsky to OpenJFX Committer.
> 
> Semyon Sadetsky is part of the JavaFX team focusing on glass.
> 
> A list of Semyon's commits and reviews is available by the following links
> 
> http://hg.openjdk.java.net/openjfx/9-dev/rt/log?rev=author%28ssadetsky%29
> 
> Votes are due by Feb 9th, 2017.
> 
> Only current OpenJFX Committers [1] are eligible to vote on this nomination. 
> Votes must be cast in the open by replying to this mailing list.
> 
> For Lazy Consensus voting instructions, see [2]. Nomination to a project 
> Committer is described in [3].
> 
> [1] http://openjdk.java.net/census#openjfx
> 
> [2] http://openjdk.java.net/bylaws#lazy-consensus
> 
> [3] http://openjdk.java.net/projects#project-committer
> 
> Thanks,
> 
> Dave

[9] Review request: 8158196: WebView Form Post fails if connection is closed before keepAlive-Timeout

[Guru Hb]

Hi Kevin, Arun & Murali,

Please review the fix for: 

JBS : https://bugs.openjdk.java.net/browse/JDK-8158196 

Webrev : http://cr.openjdk.java.net/~ghb/8158196/webrev.00/ 


RC and solution updated in JBS.

Thanks,
Guru

Re: CFV: New OpenJFX Committer: Ramesh Gangadhar

[Guru Hb]

Vote: yes
> On 19-Jan-2017, at 3:23 AM, Kevin Rushforth  
> wrote:
> 
> I hereby nominate Ramesh Gangadhar [1] to OpenJFX Committer.
> 
> Ramesh is a member of JavaFX SQE team at Oracle working on test development 
> for the Java packager, who has contributed 20 changesets to OpenJFX, at least 
> 8 of which [5] are significant.
> 
> Votes are due by February 1, 2017.
> 
> Only current OpenJFX Committers [2] are eligible to vote on this nomination. 
> Votes must be cast in the open by replying to this mailing list.
> 
> For Lazy Consensus voting instructions, see [3]. Nomination to a project 
> Committer is described in [4].
> 
> Thanks,
> 
> -- Kevin
> 
> 
> [1] http://openjdk.java.net/census#rgangadhar
> 
> [2] http://openjdk.java.net/census#openjfx
> 
> [3] http://openjdk.java.net/bylaws#lazy-consensus
> 
> [4] http://openjdk.java.net/projects#project-committer
> 
> [5]  List of significant changesets:
> http://hg.openjdk.java.net/openjfx/9-dev/tests/rev/0b702e5db31c
> http://hg.openjdk.java.net/openjfx/9-dev/tests/rev/0787febc9b94
> http://hg.openjdk.java.net/openjfx/9-dev/tests/rev/b80a8efca46c
> http://hg.openjdk.java.net/openjfx/9-dev/tests/rev/9fe019fe7f5c
> http://hg.openjdk.java.net/openjfx/9-dev/tests/rev/bf6ae1d345ce
> http://hg.openjdk.java.net/openjfx/9-dev/tests/rev/be0c0e2d0d31
> http://hg.openjdk.java.net/openjfx/9-dev/tests/rev/b743144c5e11
> http://hg.openjdk.java.net/openjfx/9-dev/tests/rev/0181e5e6b9bb
> http://hg.openjdk.java.net/openjfx/9-dev/tests/rev/a141695f4a7f
> http://hg.openjdk.java.net/openjfx/9-dev/tests/rev/16542d3f79a9
> http://hg.openjdk.java.net/openjfx/9-dev/tests/rev/78f45d216138
> http://hg.openjdk.java.net/openjfx/9-dev/tests/rev/92b56a32ebd1
> 

Re: [WebView] Single page application - relative resource in a different jar

[Guru Hb]

Hi Steve,

Could you please share the layout of jar file (two jars) so i can re-create the 
problem and let you know the failure reason.

Thanks,
Guru
> On 16-Nov-2016, at 2:37 PM, Hruda, Steve  
> wrote:
> 
> Hi,
> short question from my side. I’ve submitted the following bug report which is 
> fixed with 8u112.
> 
> 
> -  [WebView] Icon font doesn't work if single page application will 
> be loaded from jar
> 
> https://bugs.openjdk.java.net/browse/JDK-8152420
> 
> I’ve tested it and I’ve found a new related one.
> 
> A relative resources only works if the resource is located in the same jar as 
> it’s root.
> 
> E.g. I changed my test application so that the “pic_mountain.jpg” is located 
> at another jar but it is still relative to my index.html.
> 
> Result: It can’t see the image.
> 
> Is that expected?
> 
> Best Regards,
> Steve
> 
> 
> 
> Diese E-Mail wurde versandt im Auftrag des Unternehmens Intergraph Ges.m.b.H.
> Vertretungsberechtigte Geschäftsführer: Maximilian Weber
> Sitz der Gesellschaft: Margaretenstraße 70/I/1, 1050 Wien, Österreich, Tel. 
> +43 (1) 9610567-0
> Eingetragen beim Handelsgericht Wien, Firmenbuch-Nr.: FN 116859 b
> Umsatzsteuer-Identifikationsnummer / VAT-ID: ATU15138401, Steuer-Nummer: 
> 264/4807
> 
> This E-Mail has been sent on behalf of the company Intergraph Ges.m.b.H.
> Authorised Managing Directors: Maximilian Weber
> Registered office and Austrian headquarters: Margaretenstr. 70/I/1, 1050 
> Wien, Austria, Tel. +43 (1) 9610567-0
> The company is recorded at the commercial court of Vienna under the company 
> register number FN 116859 b
> VAT-ID: ATU15138401, Austrian Tax ID: 264/4807
> 
> Diese E-Mail (mit zugehörigen Dateien) enthält möglicherweise Informationen, 
> die vertraulich sind, dem Urheberrecht unterliegen oder ein 
> Geschäftsgeheimnis darstellen. Falls Sie diese Nachricht irrtümlicherweise 
> erhalten haben, benachrichtigen Sie uns bitte umgehend, indem Sie eine 
> Antwort senden, und löschen Sie bitte diese E-Mail und Ihre Antwort darauf. 
> Sämtliche aufgeführten Ansichten oder Meinungen sind ausschließlich 
> diejenigen des Autors und entsprechen nicht notwendigerweise denen des 
> Unternehmens Intergraph.
> 
> This E-Mail (and any attachments) may be confidential and protected by legal 
> privilege. If you are not the intended recipient please notify us immediately 
> by replying to the sender and delete this E-Mail and your reply from your 
> system. All the views and opinions published here are solely based on the 
> author's own opinion and should not be considered necessarily as reflecting 
> the opinion of Intergraph.
> 
> 
> 
> 

[9] Review request for 8157686: JavaFX WebView fails to track URL changes for PJAX websites

[Guru Hb]

Hi Arun, Kevin & Murali,

Please review the fix for 
JBS: https://bugs.openjdk.java.net/browse/JDK-8157686 

Webrev: http://cr.openjdk.java.net/~ghb/8157686/webrev.00/ 


RC and Solution updated in JBS.

Thanks,
Guru

Re: SVG

[Guru Hb]

WebView renders SVG ( WebView.getWebEngine().load("PathToSvg.svg"); ).
Could you please let us know which content (SVG) failed to rendered as 
expected. Please file a JBS with simplified test content , will analyze.


Thanks,
Guru

On 11/10/16 6:56 PM, Scott Palmer wrote:

On Oct 11, 2016, at 8:36 AM, Kevin Rushforth  wrote:

JavaFX supports SVG paths both directly and via CSS, but there is no general 
support for SVG.


Perhaps there should be?  Is there an enhancement request in JIRA?

I just Worte a program that tried to get around this using WebView to render 
the SVG. It is more awkward than it should be, and due to an existing issue I 
had to use a workaround to get the background to be transparent that will 
surely break with Java 9.

Scott

[9] Review request for 8165853: Loading "https://www.windyty.com" with JavaFX WebView crashes JVM.

[Guru Hb]

Hi Kevin, Arun & Murali,

Please review the fix for (RC and fix updated in JBS)
JBS : https://bugs.openjdk.java.net/browse/JDK-8165853
Webrev : http://cr.openjdk.java.net/~ghb/8165853/webrev.00/index.html

Thanks,
Guru

[9] Review request for 8164076: [Windows] JavaFX crash in WebPage.twkOpen in 8u112 when closing WebView while debugging

[Guru Hb]

Hi Kevin, Murali & Ankit,

Please review the fix for
JBS : https://bugs.openjdk.java.net/browse/JDK-8164076
Webrev : http://cr.openjdk.java.net/~ghb/8164960/webrev.00/

RC and Solution updated in JBS.

Thanks,
Guru

[9][tests]Review request for 8164498 : Backout changeset c9f45449d053 which has wrong bug id and commit message

[Guru Hb]

Hi Kevin,

Please review the change for (Backing out the changes done for 
JDK-8163084 with wrong bug ID and commit message).

Webrev : http://cr.openjdk.java.net/~ghb/rbgangad/8164498/webrev.00/
JBS : https://bugs.openjdk.java.net/browse/JDK-8164498

Thanks,
Guru

[9] Review request 8163971: Revert "MiscellaneousTest.testRT26306 and testWebViewWithoutSceneGraph" Indentation done while JDK-8163582 fix

[Guru Hb]

Hi Kevin,

Please review the fix for
JBS : https://bugs.openjdk.java.net/browse/JDK-8163971
Webrev : http://cr.openjdk.java.net/~ghb/8163971/webrev.00/

Accidentally Indent two other Unit test case while merging JDK-8163582.

Thanks,
Guru

[9] Review request 8163582: JavaFX browser can get stuck in an infinite loop when calling path.getTotalLength()

[Guru Hb]

Hi Kevin, Arun & Murali,

Please review the fix for :
JBS : https://bugs.openjdk.java.net/browse/JDK-8163582
Webrev : http://cr.openjdk.java.net/~ghb/8163582/webrev.00/

RC : Merged back JDK-8090035 and added Unit test case.

Thanks,
Guru

[9] Review request: 8163183: [test] Correct assertEquals ("", actual, expected) in LoadTest.loadJarFile

[Guru Hb]

Hi Kevin & Arun,

Please review the fix for
JBS : https://bugs.openjdk.java.net/browse/JDK-8163183
Webrev : http://cr.openjdk.java.net/~ghb/8163183/webrev.00/

Thanks,
Guru

[9] Review request 8153681: WebView needs to resolve resources relative to "jrt:" URLs

[Guru Hb]

Hi Kevin, Arun & Murali,

Please review the fix for : https://bugs.openjdk.java.net/browse/JDK-8153681
Webrev : http://cr.openjdk.java.net/~ghb/8153681/webrev.00/
Solution updated in JBS.

Thanks,
Guru

Re: Problem building WebView with latest 8u-dev and 9-dev

[Guru Hb]

webview-deps (version 1.3.1) has been uploaded to maven central.

Please revert the work around suggested earlier.

-- Guru
On 20/7/16 3:52 AM, Kevin Rushforth wrote:
With the recently-integrated changes from 8u102, the WebKit build 
requires a new version of the webview-deps bundle. This new bundle has 
not yet been uploaded to maven central. Until we are able to do this, 
you will not be able to build WebKit without applying a workaround. I 
have filed a tracking bug in JBS for this:


https://bugs.openjdk.java.net/browse/JDK-8161766

The workaround is to locally revert the change to the version number 
of webview-deps in build.gradle.


diff --git a/build.gradle b/build.gradle
--- a/build.gradle
+++ b/build.gradle
@@ -2717,7 +2717,7 @@
  IS_64 ? "${t.name}-amd64" : "${t.name}-i586"
dependencies {
webkit group: "com.sun.webkit", name: "webview-deps",
-   version: "1.3.1", classifier: "$classifier", ext: 
"zip"

+   version: "1.3", classifier: "$classifier", ext: "zip"
}

def webkitOutputDir = cygpath("$buildDir/${t.name}")


-- Kevin

Re: CFV: New OpenJFX Committer: Andrey Rusakov

[Guru Hb]

Vote: YES

On 23/7/16 9:05 PM, Murali Billa wrote:

Vote: YES

Kevin Rushforth wrote:

I hereby nominate Andrey Rusakov [1] to OpenJFX Committer.

Andrey is a member of JavaFX SQE team at Oracle working on test
development, who has contributed 19 changesets [5] to OpenJFX, at
least 8 of which are significant.

Votes are due by August 6, 2016.

Only current OpenJFX Committers [2] are eligible to vote on this
nomination. Votes must be cast in the open by replying to this mailing
list.

For Lazy Consensus voting instructions, see [3]. Nomination to a
project Committer is described in [4].

Thanks,

-- Kevin

[1] http://openjdk.java.net/census#arusakov

[2] http://openjdk.java.net/census#openjfx

[3] http://openjdk.java.net/bylaws#lazy-consensus

[4] http://openjdk.java.net/projects#project-committer

[5] List of changesets:
http://hg.openjdk.java.net/openjfx/9-dev/rt/rev/a1e73dd4613e
http://hg.openjdk.java.net/openjfx/9-dev/rt/rev/7cce7ed57d89
http://hg.openjdk.java.net/openjfx/9-dev/rt/rev/34e657660c5c
http://hg.openjdk.java.net/openjfx/9-dev/tests/rev/0e78b9e0f50e
http://hg.openjdk.java.net/openjfx/9-dev/tests/rev/d356db6612c7
http://hg.openjdk.java.net/openjfx/9-dev/tests/rev/1be0ce8c6667
http://hg.openjdk.java.net/openjfx/9-dev/tests/rev/adbed89b4b79
http://hg.openjdk.java.net/openjfx/9-dev/tests/rev/30fbc7690076
http://hg.openjdk.java.net/openjfx/9-dev/tests/rev/b6bd30234e94
http://hg.openjdk.java.net/openjfx/9-dev/tests/rev/9b0f70918dc4
http://hg.openjdk.java.net/openjfx/9-dev/tests/rev/38c836fde6ab
http://hg.openjdk.java.net/openjfx/9-dev/tests/rev/bee64c78137a
http://hg.openjdk.java.net/openjfx/9-dev/tests/rev/1e1aea3def0f
http://hg.openjdk.java.net/openjfx/9-dev/tests/rev/c20f5594ed04
http://hg.openjdk.java.net/openjfx/9-dev/tests/rev/f34e58cb89ff
http://hg.openjdk.java.net/openjfx/9-dev/tests/rev/558c27a5d330
http://hg.openjdk.java.net/openjfx/9-dev/tests/rev/8ab04be9195b
http://hg.openjdk.java.net/openjfx/9-dev/tests/rev/f741badededf
http://hg.openjdk.java.net/openjfx/9-dev/tests/rev/2e6d6f449f08

Re: CFV: New OpenJFX Committer: Ankit Srivastava

[Guru Hb]

Vote: YES


On 19/7/16 7:07 PM, David Hill wrote:


I hereby nominate Ankit Srivastava to OpenJFX Committer.

Ankit Srivastava is part of the JavaFX team focusing on Web.

A list of Ankit's commits and reviews is available by the following links

http://hg.openjdk.java.net/openjfx/8u-dev/rt/log?rev=a.ankit.srivast...@oracle.com 


http://hg.openjdk.java.net/openjfx/8u-dev/rt/log?rev=asrivastava

Votes are due by August 3th, 2016.

Only current OpenJFX Committers [1] are eligible to vote on this 
nomination. Votes must be cast in the open by replying to this mailing 
list.


For Lazy Consensus voting instructions, see [2]. Nomination to a 
project Committer is described in [3].


[1] http://openjdk.java.net/census#openjfx

[2] http://openjdk.java.net/bylaws#lazy-consensus

[3] http://openjdk.java.net/projects#project-committer

Thanks,

Dave

Re: [9] Review request 8160837: WebEngine doesn't handle html5 color picker

[Guru Hb]

Hi Kevin, Arun & Alexander Z,

Please review the updated webrev : 
http://cr.openjdk.java.net/~ghb/8160837/webrev.02/

Solution updated in JBS.

Thanks,
Guru

On 14/7/16 10:30 AM, Guru Hb wrote:

Hi Jonathan, Arun & Alexander Z,

Please review the fix for: 
https://bugs.openjdk.java.net/browse/JDK-8160837

Webrev : http://cr.openjdk.java.net/~ghb/8160837/webrev.00/

Thanks,
Guru

[9] Review request 8160837: WebEngine doesn't handle html5 color picker

[Guru Hb]

Hi Jonathan, Arun & Alexander Z,

Please review the fix for: https://bugs.openjdk.java.net/browse/JDK-8160837
Webrev : http://cr.openjdk.java.net/~ghb/8160837/webrev.00/

Thanks,
Guru

Re: Fix for test runner review request.

[Guru Hb]

http://hg.openjdk.java.net/openjfx/8u-dev/tests/rev/7562f73c8642
http://hg.openjdk.java.net/openjfx/9-dev/tests/rev/30fbc7690076

On 7/7/16 1:51 AM, Andrey Rusakov wrote:
Could anyone commit this fix to open fx tests, 8 and 9? It's important 
for testing process.


05.07.2016 12:56, Andrey Rusakov пишет:

Hi everyone.
Please take a look at my fix for openjfx test runner: JDK-8160349, 
 webrev: 
8160349/webrev.00 


Fixes are applicable for both 8 and 9 tests.

Re: [webkit][9] Review request 8160563: jvm crash at javafx com.sun.webkit.WebPage.twkPrePaint (GFlag + Heap verification)

[Guru Hb]

Please ref webrev  : http://cr.openjdk.java.net/~ghb/8160563/webrev.00


On 5/7/16 9:43 AM, Guru Hb wrote:

Hi Alexander & Arun,

Please review the fix for:
JBS : https://bugs.openjdk.java.net/browse/JDK-8160563
webrev : file:///D:/ws/patch/8160563/webrev.00

RC and Solution updated in JBS.

Thanks,
Guru

[webkit][9] Review request 8160563: jvm crash at javafx com.sun.webkit.WebPage.twkPrePaint (GFlag + Heap verification)

[Guru Hb]

Hi Alexander & Arun,

Please review the fix for:
JBS : https://bugs.openjdk.java.net/browse/JDK-8160563
webrev : file:///D:/ws/patch/8160563/webrev.00

RC and Solution updated in JBS.

Thanks,
Guru

Re: [9] Review request : 8159868 :the JVM for our Swing application crashes, once we login into our application server

[Guru Hb]

Please ignore my previous email and ref

https://bugs.openjdk.java.net/browse/JDK-8159868
http://cr.openjdk.java.net/~ghb/8159868/webrev.00/

Thanks,
Guru
On 22/6/16 10:34 AM, Guru Hb wrote:

Hi Arun & Kevin,

Could you please review the fix for :
https://bugs.openjdk.java.net/browse/JDK-8159868
http://cr.openjdk.java.net/~ghb/8159868/webrev.00/
RC and solution update in JBS.

Thanks,
Guru

[9] Review request : 8159868 :the JVM for our Swing application crashes, once we login into our application server

[Guru Hb]

Hi Arun & Kevin,

Could you please review the fix for :
https://bugs.openjdk.java.net/browse/JDK-8159868
http://cr.openjdk.java.net/~ghb/8159868/webrev.00/

RC and solution update in JBS.

Thanks,
Guru

[9] Review request: 8157145: DRT crash at fast/css-generated-content/initial-letter-basic.html

[Guru Hb]

Hi Arun & Kevin,

Please review the fix :

JBS : https://bugs.openjdk.java.net/browse/JDK-8157145
Webrev : http://cr.openjdk.java.net/~ghb/8157145/webrev.00/

RC and Solution updated in JBS.

Thanks,
Guru

Re: [9] Review request: 8154186: JVM crash while using JavaFW WebView and colgroup/cols html feature

[Guru Hb]

Kevin and Dave Sorry for my ignorance.

Reply to my previous review request (JDK-8154186 previous defect sent 
out for review and it's already fixed).


will incorporate the review comments and send out the updated webrev 
(with correct subject: line)


Thanks,
Guru

On 27/4/16 8:24 PM, Kevin Rushforth wrote:
Oh I see the problem. This was just sent out with the wrong subject 
line. Please resend with the correct subject line for 8152420 and 
remove the quoted text for the other bug.


Thanks.

-- Kevin


Kevin Rushforth wrote:

Yes, please open a new bug.

-- Kevin


David Hill wrote:

On 4/27/16, 9:56 AM, Guru Hb wrote:

Hi Dave & Kevin,

Could you please review updated Unit test case 
http://cr.openjdk.java.net/~ghb/8152420/webrev.01/


Solution updated in JBS.

Hi Guru,
 JDK-8154186 is closed, so I suspect you will need to open a new 
bug. Kevin will say for sure but I think the new world is one 
commit/one bug id.


Looking at the changes - the only minor issues I have are:

The new directory build/resources for the jar file. While not a big 
deal, build/testing (perhaps build/testing/resources ?) feels like a 
better home as the jar is for testing purposes. build/testing was 
added with Jigsaw, so you may not have noticed it in your build, but 
we are headed that way :-)


The assumption of a working directory in the test:
 load("jar:" + new File("build/resources/webArchiveJar.jar")
This is /probably/ ok from a sustainability point of view. But there 
are other places where we pass in a property to find stuff in the 
build tree like:  def cssDir = 
file("$buildDir/classes/main/javafx")
jvmArgs 
"-Djavafx.toolkit=test.com.sun.javafx.pgstub.StubToolkit",

"-DCSS_META_DATA_TEST_DIR=$cssDir"

+1 after consideration of these minor points, and I am OK if they 
are not acted on.


Dave




Thanks,
Guru

On 20/4/16 7:25 PM, Guru Hb wrote:

Hi Alexander Z , Kevin & Arunprasad,

Please review the fix :
https://bugs.openjdk.java.net/browse/JDK-8154186
http://cr.openjdk.java.net/~ghb/8154186/webrev.00/

Root Cause and solution updated in JBS.

Thanks,
Guru






--
David Hill <david.h...@oracle.com>
Java Embedded Development

"A man's feet should be planted in his country, but his eyes should 
survey the world."

-- George Santayana (1863 - 1952)

Re: [9] Review request: 8154186: JVM crash while using JavaFW WebView and colgroup/cols html feature

[Guru Hb]

Hi Dave & Kevin,

Could you please review updated Unit test case 
http://cr.openjdk.java.net/~ghb/8152420/webrev.01/


Solution updated in JBS.

Thanks,
Guru

On 20/4/16 7:25 PM, Guru Hb wrote:

Hi Alexander Z , Kevin & Arunprasad,

Please review the fix :
https://bugs.openjdk.java.net/browse/JDK-8154186
http://cr.openjdk.java.net/~ghb/8154186/webrev.00/

Root Cause and solution updated in JBS.

Thanks,
Guru

Re: status behind JDK-8149738

[Guru Hb]

Hi Matthieu,

I could re-produce the crash as you have mentioned. Thanks for helping 
out to for the html test content.


Please keep an eye on JI-9035239 for further updates.

Thanks,
Guru

On 13/4/16 9:13 PM, Matthieu BROUILLARD wrote:

Hi Guru,

I have filled an issue in http://bugreport.java.com/ ; denominated for 
the moment JI-9035239.


I have a simple reproducer test app that I also put in the bug report: 
https://gist.github.com/McFoggy/e6166349b8ea012c925665fcf9625501


The problem occures when colgroups>col width are reset/recomputed 
only. If in the webapp you uncheck the "Clear col sizes" combobox then 
the app should work correctly.
If at startup you uncheck it ; it will normally work. What is weird is 
that if then you re-check it ; it will continue to work and will not 
fail anymore.


Notice that with this simple reproducer test case I now reproduce the 
problem not only on 32bits versions but also on 64bits 8u74 & 8u77.


Thanks

Matthieu


On Wed, Apr 13, 2016 at 5:07 AM, Guru Hb <guru...@oracle.com 
<mailto:guru...@oracle.com>> wrote:


Hi Matthieu,

If you could update the re-producer html/js in the JBS would be
very help full.

I could reproduce with
http://advanced-gwt.sourceforge.net/demo/index.html --> "Click
Heading (Caption)" --> Crash. There are multiple Table listed in
the left panel, where i can re-produce the crash which originates
from "com.sun.webkit.WebPage.twkProcessMouseEvent".

Thanks,
Guru

On 12/4/16 10:00 PM, Matthieu BROUILLARD wrote:

Hi Guru,

I think I have isolated the problem ; it relates to GWT FlexTable
(with fixed column & row size) that is cleaned and refilled.
Tomorrow I'll build a clean GWT reproducer app and will send it
to you.
I'll also do the exact same in pure html/js without GWT being
involved.

    Matthieu


On Tue, Apr 12, 2016 at 11:18 AM, Guru Hb <guru...@oracle.com
<mailto:guru...@oracle.com>> wrote:

Thank you Matthieu,

Let me create a sample GWT web  application with tabs along
with the use case mentioned below. Will update the status in
the JBS.

Thanks,
Guru


On 12/4/16 2:26 PM, Matthieu BROUILLARD wrote:

Hi,

let me try to give more insights

/>>> 0. resume of running and crashing JVMs/
64 bits: all tested work (at least issue not reproduced)
32 bits:
   - 8u74-i586, 8u60-i586: fail
   - 8u45-i586: OK

/>>> 00. Application under test/
We have simplified the reproducer JavaFX app as "just" a
simple webview opening our GWT webapplication.
There's no magic here, just a call to load() method on the
WebEngine of a WebView.

/>>> 1. What Content is loaded to WebEngine. (Live webpage
or custom content)/
It is a dynamic GWT webapplication.
When launched, the application loads correctly: dynamic
content (multiple dynamic parts in the app) is
created/loaded/shown.
The loaded page shows several tabs, when clicking on a tab
the JVM crashes.

/>>> 2. which mouse event lead to crash (Right / left click,
Double click, Scroll)/
single left click.

/>>> 3. W.r.t 2nd point, is there a pop-up dialog exist ? or
what was the html element under which mouse event triggered
(Input element, Editable div, Form elements, Image , upload
dialog, table,etc)./
it is a simple div element that is CSS styled.

/>>> 4. Any Modal Dialog used in the application under test
, which will be used as a call back to an event from
WebEngine ?/
No in this case our JavaFX reproducer app, is nothing more than:
...
WebView wv = new WebView();
wv.getEngine().load("http://ourwebapp;);
...

In our global product we have indeed interaction between the
host JVM & the webapp ; but here we reproduce the crash with
a simple app consisting of the 2 lines above.


On Tue, Apr 12, 2016 at 9:41 AM, Guru Hb <guru...@oracle.com
<mailto:guru...@oracle.com>> wrote:

Hi Matthieu,

Crash is due to Mouse event is not handled correctly
from WebView context.

Could you please provide these details.

1. What Content is loaded to WebEngine. (Live webpage or
custom content)
2. which mouse event lead to crash (Right / left click,
Double click, Scroll)
3. W.r.t 2nd point, is there a pop-up dialog exist ? or
what was the html element under which mouse event
triggered (Input element, Editable div, Form elements,
Image , upload dialog, table,etc

Re: status behind JDK-8149738

[Guru Hb]

Hi Matthieu,

If you could update the re-producer html/js in the JBS would be very 
help full.


I could reproduce with 
http://advanced-gwt.sourceforge.net/demo/index.html --> "Click Heading 
(Caption)" --> Crash. There are multiple Table listed in the left panel, 
where i can re-produce the crash which originates from 
"com.sun.webkit.WebPage.twkProcessMouseEvent".


Thanks,
Guru
On 12/4/16 10:00 PM, Matthieu BROUILLARD wrote:

Hi Guru,

I think I have isolated the problem ; it relates to GWT FlexTable 
(with fixed column & row size) that is cleaned and refilled.

Tomorrow I'll build a clean GWT reproducer app and will send it to you.
I'll also do the exact same in pure html/js without GWT being involved.

Matthieu


On Tue, Apr 12, 2016 at 11:18 AM, Guru Hb <guru...@oracle.com 
<mailto:guru...@oracle.com>> wrote:


Thank you Matthieu,

Let me create a sample GWT web  application with tabs along with
the use case mentioned below. Will update the status in the JBS.

Thanks,
Guru


On 12/4/16 2:26 PM, Matthieu BROUILLARD wrote:

Hi,

let me try to give more insights

/>>> 0. resume of running and crashing JVMs/
64 bits: all tested work (at least issue not reproduced)
32 bits:
   - 8u74-i586, 8u60-i586: fail
   - 8u45-i586: OK

/>>> 00. Application under test/
We have simplified the reproducer JavaFX app as "just" a simple
webview opening our GWT webapplication.
There's no magic here, just a call to load() method on the
WebEngine of a WebView.

/>>> 1. What Content is loaded to WebEngine. (Live webpage or
custom content)/
It is a dynamic GWT webapplication.
When launched, the application loads correctly: dynamic content
(multiple dynamic parts in the app) is created/loaded/shown.
The loaded page shows several tabs, when clicking on a tab the
JVM crashes.

/>>> 2. which mouse event lead to crash (Right / left click,
Double click, Scroll)/
single left click.

/>>> 3. W.r.t 2nd point, is there a pop-up dialog exist ? or what
was the html element under which mouse event triggered (Input
element, Editable div, Form elements, Image , upload dialog,
table,etc)./
it is a simple div element that is CSS styled.

/>>> 4. Any Modal Dialog used in the application under test ,
which will be used as a call back to an event from WebEngine ?/
No in this case our JavaFX reproducer app, is nothing more than:
...
WebView wv = new WebView();
wv.getEngine().load("http://ourwebapp;);
...

In our global product we have indeed interaction between the host
JVM & the webapp ; but here we reproduce the crash with a simple
app consisting of the 2 lines above.


On Tue, Apr 12, 2016 at 9:41 AM, Guru Hb <guru...@oracle.com
<mailto:guru...@oracle.com>> wrote:

Hi Matthieu,

Crash is due to Mouse event is not handled correctly from
WebView context.

Could you please provide these details.

1. What Content is loaded to WebEngine. (Live webpage or
custom content)
2. which mouse event lead to crash (Right / left click,
Double click, Scroll)
3. W.r.t 2nd point, is there a pop-up dialog exist ? or what
was the html element under which mouse event triggered (Input
element, Editable div, Form elements, Image , upload dialog,
table,etc).
4. Any Modal Dialog used in the application under test ,
which will be used as a call back to an event from WebEngine ?

With above details , i could derive a test content / scenario
to re-produce the crash.

Thanks,
Guru

On 11/4/16 10:09 PM, Matthieu BROUILLARD wrote:

Hi all,

In our application that integrates some webapps we are
facing quite the
same error than the one reported at
https://bugs.openjdk.java.net/browse/JDK-8149738.
The issue above has been marked with 'bugdb_22696741' ;
does it mean it is
referenced with more details elsewhere? Is there a known
workaround?

In our use case, when navigating in the webview into some
GWT based
application using 8u74-i586 (or 8u60-i586) we always
crash the JVM and
using 8u74 (64 bits) everything works.
Doing additional tests revealed that 8u45-b51-i586 is
working ; but
unfortunately we have already moved on to more recent
JDKs for our entire
application.

Sadly I do not have a simple reproduction app to provide.
We also enable some prism debug settings without seeing
anything relevant
in the logs ; activating the software pipelin

Re: status behind JDK-8149738

[Guru Hb]

Hi Matthieu,

Crash is due to Mouse event is not handled correctly from WebView context.

Could you please provide these details.

1. What Content is loaded to WebEngine. (Live webpage or custom content)
2. which mouse event lead to crash (Right / left click, Double click, 
Scroll)
3. W.r.t 2nd point, is there a pop-up dialog exist ? or what was the 
html element under which mouse event triggered (Input element, Editable 
div, Form elements, Image , upload dialog, table,etc).
4. Any Modal Dialog used in the application under test , which will be 
used as a call back to an event from WebEngine ?


With above details , i could derive a test content / scenario to 
re-produce the crash.


Thanks,
Guru
On 11/4/16 10:09 PM, Matthieu BROUILLARD wrote:

Hi all,

In our application that integrates some webapps we are facing quite the
same error than the one reported at
https://bugs.openjdk.java.net/browse/JDK-8149738.
The issue above has been marked with 'bugdb_22696741' ; does it mean it is
referenced with more details elsewhere? Is there a known workaround?

In our use case, when navigating in the webview into some GWT based
application using 8u74-i586 (or 8u60-i586) we always crash the JVM and
using 8u74 (64 bits) everything works.
Doing additional tests revealed that 8u45-b51-i586 is working ; but
unfortunately we have already moved on to more recent JDKs for our entire
application.

Sadly I do not have a simple reproduction app to provide.
We also enable some prism debug settings without seeing anything relevant
in the logs ; activating the software pipeline didn't changed anything
neither.

Are there specific debug params for the webview, webkit & jfxwebkit.dll ?

The crash report looks the same than in the above issue:

# # # # # # # # # # # # # # # # #

#
# A fatal error has been detected by the Java Runtime Environment:
#
#  EXCEPTION_ACCESS_VIOLATION (0xc005) at pc=0x5456b7c9, pid=5836,
tid=6260
#
# JRE version: Java(TM) SE Runtime Environment (8.0_74-b02) (build
1.8.0_74-b02)
# Java VM: Java HotSpot(TM) Client VM (25.74-b02 mixed mode windows-x86 )
# Problematic frame:
# C  [jfxwebkit.dll+0x8eb7c9]
...
#

---  T H R E A D  ---

Current thread (0x0563d000):  JavaThread "JavaFX Application Thread"
[_thread_in_native, id=6260, stack(0x05c7,0x05cc)]

siginfo: ExceptionCode=0xc005, reading address 0x002e0060

Registers:
EAX=0x002e0030, EBX=0x0011, ECX=0x0d457870, EDX=0x
ESP=0x05cbd578, EBP=0x, ESI=0x0d457870, EDI=0x0bae3030
EIP=0x5456b7c9, EFLAGS=0x00210246

Top of Stack: (sp=0x05cbd578)
0x05cbd578:   0d202f60 54580e41 0001 0001
...
0x05cbd5e8:   54a51a88  54510e95 0d2f89a0

Instructions: (pc=0x5456b7c9)
0x5456b7a9:   24 0c 01 75 35 8b 4e 14 8b c1 c1 e8 09 a8 01 75
...
0x5456b7d9:   06 74 07 8b ce e8 4d de ff ff 5e c2 08 00 cc cc


Register to memory mapping:

EAX=0x002e0030 is an unknown value
EBX=0x0011 is an unknown value
ECX=0x0d457870 is an unknown value
EDX=0x is an unknown value
ESP=0x05cbd578 is pointing into the stack for thread: 0x0563d000
EBP=0x is an unknown value
ESI=0x0d457870 is an unknown value
EDI=0x0bae3030 is an unknown value


Stack: [0x05c7,0x05cc],  sp=0x05cbd578,  free space=309k
Native frames: (J=compiled Java code, j=interpreted, Vv=VM code, C=native
code)
C  [jfxwebkit.dll+0x8eb7c9]

Java frames: (J=compiled Java code, j=interpreted, Vv=VM code)
j  com.sun.webkit.WebPage.twkProcessMouseEvent(JIIIZF)Z+0
j
  
com.sun.webkit.WebPage.dispatchMouseEvent(Lcom/sun/webkit/event/WCMouseEvent;)Z+141
j
  
javafx.scene.web.WebView.processMouseEvent(Ljavafx/scene/input/MouseEvent;)V+175
j
  
javafx.scene.web.WebView.lambda$registerEventHandlers$32(Ljavafx/scene/input/MouseEvent;)V+2
j  javafx.scene.web.WebView$$Lambda$87.handle(Ljavafx/event/Event;)V+8
j
  
com.sun.javafx.event.CompositeEventHandler$NormalEventHandlerRecord.handleBubblingEvent(Ljavafx/event/Event;)V+5
j
  
com.sun.javafx.event.CompositeEventHandler.dispatchBubblingEvent(Ljavafx/event/Event;)V+28
j
  
com.sun.javafx.event.EventHandlerManager.dispatchBubblingEvent(Ljavafx/event/EventType;Ljavafx/event/Event;)Ljavafx/event/Event;+29
j
  
com.sun.javafx.event.EventHandlerManager.dispatchBubblingEvent(Ljavafx/event/Event;)Ljavafx/event/Event;+8
j
  
com.sun.javafx.event.CompositeEventDispatcher.dispatchBubblingEvent(Ljavafx/event/Event;)Ljavafx/event/Event;+11
j
  
com.sun.javafx.event.BasicEventDispatcher.dispatchEvent(Ljavafx/event/Event;Ljavafx/event/EventDispatchChain;)Ljavafx/event/Event;+29
j
  
com.sun.javafx.event.EventDispatchChainImpl.dispatchEvent(Ljavafx/event/Event;)Ljavafx/event/Event;+69
j
  
com.sun.javafx.event.BasicEventDispatcher.dispatchEvent(Ljavafx/event/Event;Ljavafx/event/EventDispatchChain;)Ljavafx/event/Event;+17
j
  
com.sun.javafx.event.EventDispatchChainImpl.dispatchEvent(Ljavafx/event/Event;)Ljavafx/event/Event;+69
j
  

Review request for 8152420 : [WebView] Icon font doesn't work if single page application will be loaded from jar

[Guru Hb]

Hi Alexander, Arunprasad & Kevin,

JBS : https://bugs.openjdk.java.net/browse/JDK-8152420
Webrev : http://cr.openjdk.java.net/~ghb/8152420/webrev.00/

Root cause and fix description updated in JBS.

Thanks,
Guru

Re: [9] Review request for 8152315 : Don't server / request the Cached resource for if its Main resource is explicitly cancelled

[Guru Hb]

Updated webrev : http://cr.openjdk.java.net/~ghb/8152315/webrev.01/
Which address heap corruption detected by using GFlag

On 22/3/16 12:54 AM, Guru Hb wrote:

Hi Alexander, Arunprasad & Kevin,

JBS : https://bugs.openjdk.java.net/browse/JDK-8152315
Webrev : http://cr.openjdk.java.net/~ghb/8152315/webrev.00/

RC and Solution updated in JIRA, fix tested on Windows.

Thanks,
Guru

[9] Review request for 8152315 : Don't server / request the Cached resource for if its Main resource is explicitly cancelled

[Guru Hb]

Hi Alexander, Arunprasad & Kevin, 

JBS : https://bugs.openjdk.java.net/browse/JDK-8152315 
Webrev : http://cr.openjdk.java.net/~ghb/8152315/webrev.00/  

RC and Solution updated in JIRA, fix tested on Windows. 

Thanks, 
Guru

[9] Review request for 8139114: WebView crashes on Yahoo login page

[Guru Hb]

Hi Alexander, Kevin and Arun

JBS : https://bugs.openjdk.java.net/browse/JDK-8139114
Webrev : http://cr.openjdk.java.net/~ghb/8139114/webrev.00/ 

RC and Solution updated in JIRA.

Thanks, 
Guru

[9] Review request for 8146898 : Webview - Bug in JavaScript Date() constructor after Feb 28 2034

[Guru Hb]

Hi Alexander & Kevin, 

JBS : https://bugs.openjdk.java.net/browse/JDK-8146898 
Webrev : http://cr.openjdk.java.net/~ghb/8146898/webrev.00/ 

RC and Solution updated in JIRA, fix tested on Windows & Ubuntu. 

Thanks, 
Guru

RE: Full Screen Mode in JavaFX WebView

[Guru Hb]

Please see comments embedded 

-Original Message-
From: BoydEdmondson-NebulaSoftware [mailto:boydedmond...@nebulasoftware.com] 
Sent: Monday, January 04, 2016 7:01 PM
To: openjfx-dev@openjdk.java.net
Subject: Full Screen Mode in JavaFX WebView

I have a custom Java application that uses JavaFX WebView to create a web 
browser (which uses WebKit).  I am trying to get the browser full screen mode 
to work (https://fullscreen.spec.whatwg.org/).



How can I get full screen mode to work in WebKit?
[WebView is an Embedded component and current it doesn't have full screen 
context menu (Like what we see in browser). WebView exposes two api 
setPrefWidth  & setPrefHeight, you can try setting it to max allowable view 
port size based on screen resolution. In addition (But I don't suggest), set 
the stage or group border to 0. But do NOTE that there won't be scroll bars 
visible, But you can drag the webpage]


I'm also trying to get WebKit's Web Inspector to work in my browser to help me 
debug this issue.  How can I activate Web Inspector in JavaFX WebView?
[Sorry, Web Inspector is not enabled in this port (Webkit port of JavaFX), 
alternatively you could  debug the application on Chrome or Safari. If you find 
a difference in the Rendering, JavaScript or other defect, feel free to log a 
defect ref 
https://wiki.openjdk.java.net/display/OpenJFX/Submitting+a+Bug+Report] 

Thanks for any information.

RE: WebKit future planning

[Guru Hb]

Hi Bosko, 

Please find my comments embedded below. 

Thanks, 
Guru

-Original Message-
From: Bosko Popovic [mailto:bosk...@gmail.com] 
Sent: Saturday, December 19, 2015 7:21 PM
To: openjfx-dev@openjdk.java.net
Subject: WebKit future planning

Hi,
 
We are developing application that uses Chromium Embedded Framework (CEF). 
Application supports Win, OSX and Linux.
We want to switch to JavaFx WebView.
 
The major things that concern us:
 
1) WebKit removed support for Windows acording to
https://bugs.webkit.org/show_bug.cgi?id=106264 and
https://bugs.webkit.org/show_bug.cgi?id=136385
Question: What is the plan for JavaFx browser support for Windows OS in future?
[This wont impact our JavaFX WebView support on Windows OS, Above two defects 
is for multi process model but our existing webkit port is based on non Webkit2]

2) JavaFX uses WebView based on WebKit 538.19 (released on February 2014). 
Is there a plan to update WebKit version?
[Yes, we are in process of merging latest trunk (webkit.org) to our WebView]

Thanks,

Bosko

[9] Review request: 8139842: NullPointerException in WCPageBackBufferImpl when a WebView is too large

[Guru Hb]

Hi Kevin,  Jim,  Alexander

 

Please provide your review comments for 

 

JBS : https://bugs.openjdk.java.net/browse/JDK-8139842 

Webrev : http://cr.openjdk.java.net/~ghb/8139842/webrev.00/ 

 

Tested on Windows , Linux and Mac. 

 

Thanks, 

Guru

 

 

Re: [9] Review request for 8140501 : WebView crashes when loading content in a locationlistener

[Guru Hb]

Updated webrev : http://cr.openjdk.java.net/~ghb/8140501/webrev.03/
Changes updated in JBS : https://bugs.openjdk.java.net/browse/JDK-8140501

- Original Message -
From: guru...@oracle.com
To: alexander.zvegint...@oracle.com, arunprasad.rajku...@oracle.com, 
kevin.rushfo...@oracle.com
Cc: openjfx-dev@openjdk.java.net
Sent: Tuesday, December 1, 2015 10:26:23 AM GMT +05:30 Chennai, Kolkata, 
Mumbai, New Delhi
Subject: RE: [9] Review request for 8140501 : WebView crashes when loading 
content in a locationlistener

Hi Arun, Alexander & Kevin, 

JBS : https://bugs.openjdk.java.net/browse/JDK-8140501/ 
Webrev : http://cr.openjdk.java.net/~ghb/8140501/webrev.01/ 

Regression test incorporated and Async loadcontent executed only in READY 
state. 

Thanks, 
Guru 

-Original Message-
From: Guru Hb 
Sent: Monday, November 30, 2015 12:22 PM
To: Alexander Zvegintsev; Arunprasad Rajkumar; Kevin C Rushforth
Cc: openjfx-dev@openjdk.java.net
Subject: [9] Review request for 8140501 : WebView crashes when loading content 
in a locationlistener

Hi Arunprasad, Alexander & Kevin, 

JBS : https://bugs.openjdk.java.net/browse/JDK-8140501
Webrev : http://cr.openjdk.java.net/~ghb/8140501/webrev.00/

Tested on Windows and Linux (both 64 bit). 

Thnaks, 
Guru

Re: [9] Review request for 8143894 : clipboard paste on outlook email body doesn't work for the first time

[Guru Hb]

Review comments incorporated and updated fix : 
http://cr.openjdk.java.net/~ghb/8143894/webrev.04/

- Original Message -
From: guru...@oracle.com
To: arunprasad.rajku...@oracle.com, alexander.zvegint...@oracle.com, 
kevin.rushfo...@oracle.com
Cc: openjfx-dev@openjdk.java.net, a.ankit.srivast...@oracle.com
Sent: Thursday, December 10, 2015 12:34:47 AM GMT +05:30 Chennai, Kolkata, 
Mumbai, New Delhi
Subject: RE: [9] Review request for 8143894 : clipboard paste on outlook email 
body doesn't work for the first time

JBS : https://bugs.openjdk.java.net/browse/JDK-8143894 
Review comments incorporated with updated fix : 
http://cr.openjdk.java.net/~ghb/8143894/webrev.03/ (Tested on Windows and 
Linux) 

//Todo : setURL, setFiles, setData, setHtml (needs URL) : will be tracked in 
https://bugs.openjdk.java.net/browse/JDK-8145028 

Thanks, 
Guru
-Original Message-
From: Guru Hb 
Sent: Wednesday, December 09, 2015 3:12 AM
To: Arunprasad Rajkumar; Alexander Zvegintsev; Kevin Rushforth
Cc: Ankit Srivastava; openjfx-dev@openjdk.java.net
Subject: RE: [9] Review request for 8143894 : clipboard paste on outlook email 
body doesn't work for the first time

Fixed Test failure on MAC 
Webrev : http://cr.openjdk.java.net/~ghb/8143894/webrev.02/ 
Tested on Windows , Linux and Mac 

Thanks, 
Guru

-Original Message-
From: Guru Hb 
Sent: Tuesday, December 08, 2015 4:08 PM
To: Arunprasad Rajkumar; Alexander Zvegintsev; Kevin Rushforth
Cc: openjfx-dev@openjdk.java.net; Ankit Srivastava; Murali Billa
Subject: RE: [9] Review request for 8143894 : clipboard paste on outlook email 
body doesn't work for the first time

Hi Arunprasad, Alexander and Kevin, 

JBS : https://bugs.openjdk.java.net/browse/JDK-8143894/
Webrev : http://cr.openjdk.java.net/~arapte/ghb/8143894/webrev.01/ 

(Due to permission bit corrupted to my g...@cr.openjdk.java.net account I am 
sending this patch from ~arapte account) 

Fix updated with regression test 

Thanks, 
Guru
-Original Message-
From: Guru Hb 
Sent: Tuesday, December 01, 2015 10:29 AM
To: Arunprasad Rajkumar; Alexander Zvegintsev; Kevin Rushforth
Cc: openjfx-dev@openjdk.java.net
Subject: [9] Review request for 8143894 : clipboard paste on outlook email body 
doesn't work for the first time

Hi Arunprasad, Alexander & Kevin, 

JBS : https://bugs.openjdk.java.net/browse/JDK-8143894/ 
Webrev : http://cr.openjdk.java.net/~ghb/8143894/webrev.00 

Tested on Windows and Linux (both 64 bit).

Thnaks, 
Guru

RE: [9] Review request for 8143894 : clipboard paste on outlook email body doesn't work for the first time

[Guru Hb]

JBS : https://bugs.openjdk.java.net/browse/JDK-8143894 
Review comments incorporated with updated fix : 
http://cr.openjdk.java.net/~ghb/8143894/webrev.03/ (Tested on Windows and 
Linux) 

//Todo : setURL, setFiles, setData, setHtml (needs URL) : will be tracked in 
https://bugs.openjdk.java.net/browse/JDK-8145028 

Thanks, 
Guru
-Original Message-
From: Guru Hb 
Sent: Wednesday, December 09, 2015 3:12 AM
To: Arunprasad Rajkumar; Alexander Zvegintsev; Kevin Rushforth
Cc: Ankit Srivastava; openjfx-dev@openjdk.java.net
Subject: RE: [9] Review request for 8143894 : clipboard paste on outlook email 
body doesn't work for the first time

Fixed Test failure on MAC 
Webrev : http://cr.openjdk.java.net/~ghb/8143894/webrev.02/ 
Tested on Windows , Linux and Mac 

Thanks, 
Guru

-Original Message-
From: Guru Hb 
Sent: Tuesday, December 08, 2015 4:08 PM
To: Arunprasad Rajkumar; Alexander Zvegintsev; Kevin Rushforth
Cc: openjfx-dev@openjdk.java.net; Ankit Srivastava; Murali Billa
Subject: RE: [9] Review request for 8143894 : clipboard paste on outlook email 
body doesn't work for the first time

Hi Arunprasad, Alexander and Kevin, 

JBS : https://bugs.openjdk.java.net/browse/JDK-8143894/
Webrev : http://cr.openjdk.java.net/~arapte/ghb/8143894/webrev.01/ 

(Due to permission bit corrupted to my g...@cr.openjdk.java.net account I am 
sending this patch from ~arapte account) 

Fix updated with regression test 

Thanks, 
Guru
-Original Message-
From: Guru Hb 
Sent: Tuesday, December 01, 2015 10:29 AM
To: Arunprasad Rajkumar; Alexander Zvegintsev; Kevin Rushforth
Cc: openjfx-dev@openjdk.java.net
Subject: [9] Review request for 8143894 : clipboard paste on outlook email body 
doesn't work for the first time

Hi Arunprasad, Alexander & Kevin, 

JBS : https://bugs.openjdk.java.net/browse/JDK-8143894/ 
Webrev : http://cr.openjdk.java.net/~ghb/8143894/webrev.00 

Tested on Windows and Linux (both 64 bit).

Thnaks, 
Guru

RE: [9] Review request for 8143894 : clipboard paste on outlook email body doesn't work for the first time

[Guru Hb]

Hi Arunprasad, Alexander and Kevin, 

JBS : https://bugs.openjdk.java.net/browse/JDK-8143894/
Webrev : http://cr.openjdk.java.net/~arapte/ghb/8143894/webrev.01/ 

(Due to permission bit corrupted to my g...@cr.openjdk.java.net account I am 
sending this patch from ~arapte account) 

Fix updated with regression test 

Thanks, 
Guru
-Original Message-
From: Guru Hb 
Sent: Tuesday, December 01, 2015 10:29 AM
To: Arunprasad Rajkumar; Alexander Zvegintsev; Kevin Rushforth
Cc: openjfx-dev@openjdk.java.net
Subject: [9] Review request for 8143894 : clipboard paste on outlook email body 
doesn't work for the first time

Hi Arunprasad, Alexander & Kevin, 

JBS : https://bugs.openjdk.java.net/browse/JDK-8143894/ 
Webrev : http://cr.openjdk.java.net/~ghb/8143894/webrev.00 

Tested on Windows and Linux (both 64 bit).

Thnaks, 
Guru

RE: [9] Review request for 8143894 : clipboard paste on outlook email body doesn't work for the first time

[Guru Hb]

Fixed Test failure on MAC 
Webrev : http://cr.openjdk.java.net/~ghb/8143894/webrev.02/ 
Tested on Windows , Linux and Mac 

Thanks, 
Guru

-Original Message-
From: Guru Hb 
Sent: Tuesday, December 08, 2015 4:08 PM
To: Arunprasad Rajkumar; Alexander Zvegintsev; Kevin Rushforth
Cc: openjfx-dev@openjdk.java.net; Ankit Srivastava; Murali Billa
Subject: RE: [9] Review request for 8143894 : clipboard paste on outlook email 
body doesn't work for the first time

Hi Arunprasad, Alexander and Kevin, 

JBS : https://bugs.openjdk.java.net/browse/JDK-8143894/
Webrev : http://cr.openjdk.java.net/~arapte/ghb/8143894/webrev.01/ 

(Due to permission bit corrupted to my g...@cr.openjdk.java.net account I am 
sending this patch from ~arapte account) 

Fix updated with regression test 

Thanks, 
Guru
-Original Message-
From: Guru Hb 
Sent: Tuesday, December 01, 2015 10:29 AM
To: Arunprasad Rajkumar; Alexander Zvegintsev; Kevin Rushforth
Cc: openjfx-dev@openjdk.java.net
Subject: [9] Review request for 8143894 : clipboard paste on outlook email body 
doesn't work for the first time

Hi Arunprasad, Alexander & Kevin, 

JBS : https://bugs.openjdk.java.net/browse/JDK-8143894/ 
Webrev : http://cr.openjdk.java.net/~ghb/8143894/webrev.00 

Tested on Windows and Linux (both 64 bit).

Thnaks, 
Guru

RE: [9] Review request for 8140501 : WebView crashes when loading content in a locationlistener

[Guru Hb]

Hi Arun, Alexander & Kevin, 

JBS : https://bugs.openjdk.java.net/browse/JDK-8140501/ 
Webrev : http://cr.openjdk.java.net/~ghb/8140501/webrev.01/ 

Regression test incorporated and Async loadcontent executed only in READY 
state. 

Thanks, 
Guru 

-Original Message-
From: Guru Hb 
Sent: Monday, November 30, 2015 12:22 PM
To: Alexander Zvegintsev; Arunprasad Rajkumar; Kevin C Rushforth
Cc: openjfx-dev@openjdk.java.net
Subject: [9] Review request for 8140501 : WebView crashes when loading content 
in a locationlistener

Hi Arunprasad, Alexander & Kevin, 

JBS : https://bugs.openjdk.java.net/browse/JDK-8140501
Webrev : http://cr.openjdk.java.net/~ghb/8140501/webrev.00/

Tested on Windows and Linux (both 64 bit). 

Thnaks, 
Guru

[9] Review request for 8143894 : clipboard paste on outlook email body doesn't work for the first time

[Guru Hb]

Hi Arunprasad, Alexander & Kevin, 

JBS : https://bugs.openjdk.java.net/browse/JDK-8143894/ 
Webrev : http://cr.openjdk.java.net/~ghb/8143894/webrev.00 

Tested on Windows and Linux (both 64 bit).

Thnaks, 
Guru

[9] Review request for 8140501 : WebView crashes when loading content in a locationlistener

[Guru Hb]

Hi Arunprasad, Alexander & Kevin, 

JBS : https://bugs.openjdk.java.net/browse/JDK-8140501
Webrev : http://cr.openjdk.java.net/~ghb/8140501/webrev.00/

Tested on Windows and Linux (both 64 bit). 

Thnaks, 
Guru

RE: AW: JDK-8139844 com.sun.webkit.Timer is never fired if delay is too low

[Guru Hb]

Command Line option while running the java ? 
Host and Test server (considering "every time against our test server")
CPU Make & Model
Windows 7 (64 bit) type (Professional / Home / etc..) ? 
Service pack version ?
Are you using Oracle provided JDK or modified ? 
Both Host and Test server is having JDK or only JRE ? 

Tried myself on 8u51, 8u60 and 8u64 (all 32 bit JDK) , but couldn't re-produce 
here locally. 

Thanks, 
Guru
-Original Message-
From: Schmidtmer, Oliver [mailto:o.schmidt...@elo.com] 
Sent: Thursday, November 12, 2015 9:22 PM
To: Guru Hb
Cc: openjfx-dev@openjdk.java.net
Subject: AW: JDK-8139844 com.sun.webkit.Timer is never fired if delay is too low

Hello Guru,

I've tested it with 8u51 32bit, 8u60 32bit and 8u65 32bit using windows 7 64bit 
where I can reproduce this every time against our test server.
Indeed it doesn't happen with 8u65 64bit and 8u66 64bit on windows 7 64bit. 
I've not checked other 64bit JREs but can do so if wished.

Mac OS X with 64bit JRE and Linux with 32bit&64bit JRE also don't seem to have 
this issue.
Maybe this really happens only on windows with 32bit JREs.

Thanks,
Oliver

-Ursprüngliche Nachricht-
Von: Guru Hb [mailto:guru...@oracle.com]
Gesendet: Donnerstag, 12. November 2015 11:19
An: Schmidtmer, Oliver
Cc: openjfx-dev@openjdk.java.net
Betreff: RE: JDK-8139844 com.sun.webkit.Timer is never fired if delay is too low

Hello Oliver,

Could you please provide info where this problem is seen more often.

OS type, version & 32 / 64 bit
JDK version & 32 / 64 bit. (already mentioned 8u66 and 32 bit in email)

fireTime (argument) value can't go less than "1.0E-9". As you pointed out the 
problem lies in "Math.ceil(fireTime * 1000)". Initially I have tested on window 
7 64 bit and JDK 8u66 64 bit.

Asserting the value if less than 0 in "fwkSetFireTime" would be a temporary 
solution.

Thanks,
Guru
-Original Message-
From: Schmidtmer, Oliver [mailto:o.schmidt...@elo.com]
Sent: Wednesday, November 11, 2015 7:06 PM
To: openjfx-dev@openjdk.java.net
Subject: JDK-8139844 com.sun.webkit.Timer is never fired if delay is too low

Hello,
I'm the submitter of JDK-8139844.

A few of our customers are affected by this issue and we can only reproduce it 
when loading webpages from a specific machine, independent from which machine 
the client with the web view is started.

As a workaround for our problem and JDK-8091962 I modified 
com.sun.webkit.Timer.fwkSetFireTime in 1.8.0_65-b17 - 32 bit as following and 
added some output to the calculations:

private static void fwkSetFireTime(double fireTime) {
 long fireTimeMS = (long)Math.ceil(fireTime * 1000);
 if(fireTimeMS < 0){
   double withoutCast = 
Math.ceil(fireTime * 1000);
   System.err.println( "fireTime=" 
+ fireTime + " before cast=" + withoutCast + " after cast=" + ((long) 
withoutCast) + " as one step=" + ((long)Math.ceil(fireTime * 1000)) + " 
original calculation=" + fireTimeMS);
fireTimeMS = 1;
 }
 getTimer().setFireTime(System.currentTimeMillis() + fireTimeMS);
}

Which produces the following output:
fireTime=1.0E-9 before cast=1.0 after cast=1 as one step=1 original 
calculation=-9223372036854775808
fireTime=0.03379535675048828 before cast=34.0 after cast=34 as one step=34 
original calculation=-9223372036854775808
fireTime=0.042267560958862305 before cast=43.0 after cast=43 as one step=43 
original calculation=-9223372036854775808
fireTime=0.04301285743713379 before cast=44.0 after cast=44 as one step=44 
original calculation=-9223372036854775808
fireTime=0.041814565658569336 before cast=42.0 after cast=42 as one step=42 
original calculation=-9223372036854775808
fireTime=0.03879666328430176 before cast=39.0 after cast=39 as one step=39 
original calculation=-9223372036854775808
fireTime=0.04811882972717285 before cast=49.0 after cast=49 as one step=49 
original calculation=-9223372036854775808
fireTime=0.0494379997253418 before cast=50.0 after cast=50 as one step=50 
original calculation=-9223372036854775808
fireTime=0.04372882843017578 before cast=44.0 after cast=44 as one step=44 
original calculation=-9223372036854775808
fireTime=0.04262733459472656 before cast=43.0 after cast=43 as one step=43 
original calculation=-9223372036854775808
fireTime=1.0E-9 before cast=1.0 after cast=1 as one step=1 original 
calculation=-9223372036854775808
fireTime=0.04141855239868164 before cast=42.0 after cast=42 as one step=42 
original calculation=-9223372036854775808
fireTime=0.01515507698059082 before cast=16.0 after cast=16 as one step=16 
original calculation=-9223372036854775808
fireTime=0.047502994537353516 before cast=48.0 after cast=48 as one step=48 
original calculation=-9223372036854775808

It seems this only happens sometime

[9] Review request for 8141345: Cannot build WebKit with bison3 (only on windows)

[Guru Hb]

Hi Kevin, Alexander & Vadim, 

 

JBS : https://bugs.openjdk.java.net/browse/JDK-8141345

Webrev : http://cr.openjdk.java.net/~ghb/8141345/webrev.00/

 

Tested on Windows (Bison 3.0.4), Linux and Mac. 

 

Thanks, 

Guru

RE: JDK-8139844 com.sun.webkit.Timer is never fired if delay is too low

[Guru Hb]

Hello Oliver, 

Could you please provide info where this problem is seen more often. 

OS type, version & 32 / 64 bit 
JDK version & 32 / 64 bit. (already mentioned 8u66 and 32 bit in email)

fireTime (argument) value can't go less than "1.0E-9". As you pointed out the 
problem lies in "Math.ceil(fireTime * 1000)". Initially I have tested on window 
7 64 bit and JDK 8u66 64 bit. 

Asserting the value if less than 0 in "fwkSetFireTime" would be a temporary 
solution. 

Thanks, 
Guru
-Original Message-
From: Schmidtmer, Oliver [mailto:o.schmidt...@elo.com] 
Sent: Wednesday, November 11, 2015 7:06 PM
To: openjfx-dev@openjdk.java.net
Subject: JDK-8139844 com.sun.webkit.Timer is never fired if delay is too low

Hello,
I'm the submitter of JDK-8139844.

A few of our customers are affected by this issue and we can only reproduce it 
when loading webpages from a specific machine, independent from which machine 
the client with the web view is started.

As a workaround for our problem and JDK-8091962 I modified 
com.sun.webkit.Timer.fwkSetFireTime in 1.8.0_65-b17 - 32 bit as following and 
added some output to the calculations:

private static void fwkSetFireTime(double fireTime) {
 long fireTimeMS = (long)Math.ceil(fireTime * 1000);
 if(fireTimeMS < 0){
   double withoutCast = 
Math.ceil(fireTime * 1000);
   System.err.println( "fireTime=" 
+ fireTime + " before cast=" + withoutCast + " after cast=" + ((long) 
withoutCast) + " as one step=" + ((long)Math.ceil(fireTime * 1000)) + " 
original calculation=" + fireTimeMS);
fireTimeMS = 1;
 }
 getTimer().setFireTime(System.currentTimeMillis() + fireTimeMS);
}

Which produces the following output:
fireTime=1.0E-9 before cast=1.0 after cast=1 as one step=1 original 
calculation=-9223372036854775808
fireTime=0.03379535675048828 before cast=34.0 after cast=34 as one step=34 
original calculation=-9223372036854775808
fireTime=0.042267560958862305 before cast=43.0 after cast=43 as one step=43 
original calculation=-9223372036854775808
fireTime=0.04301285743713379 before cast=44.0 after cast=44 as one step=44 
original calculation=-9223372036854775808
fireTime=0.041814565658569336 before cast=42.0 after cast=42 as one step=42 
original calculation=-9223372036854775808
fireTime=0.03879666328430176 before cast=39.0 after cast=39 as one step=39 
original calculation=-9223372036854775808
fireTime=0.04811882972717285 before cast=49.0 after cast=49 as one step=49 
original calculation=-9223372036854775808
fireTime=0.0494379997253418 before cast=50.0 after cast=50 as one step=50 
original calculation=-9223372036854775808
fireTime=0.04372882843017578 before cast=44.0 after cast=44 as one step=44 
original calculation=-9223372036854775808
fireTime=0.04262733459472656 before cast=43.0 after cast=43 as one step=43 
original calculation=-9223372036854775808
fireTime=1.0E-9 before cast=1.0 after cast=1 as one step=1 original 
calculation=-9223372036854775808
fireTime=0.04141855239868164 before cast=42.0 after cast=42 as one step=42 
original calculation=-9223372036854775808
fireTime=0.01515507698059082 before cast=16.0 after cast=16 as one step=16 
original calculation=-9223372036854775808
fireTime=0.047502994537353516 before cast=48.0 after cast=48 as one step=48 
original calculation=-9223372036854775808

It seems this only happens sometimes in the first calculation. Even when the 
ceiling & cast is done again with the same value it doesn't happen again.
If I can do anything to help sorting this out I will happily do so.
Regards,
Oliver



ELO Digital Office GmbH
Firmensitz: T?binger Strasse 43, 70178 Stuttgart
Fon: +49 711 806089-0, Fax: +49 711 806089-19, Web: www.elo.com
Gesch?ftsf?hrer: Karl Heinz Mosbach, Matthias Thiele BW-Bank, Konto-Nr. 
2089782, BLZ 600 501 01
IBAN: DE67600501010002089782 BIC: SOLADEST Registergericht Stuttgart HRB 15059 
- USt-IdNr.: DE812471516

[9, 8u] review request: 8136466 : [regression] [WebView] Load single page application from jar

[Guru Hb]

Hi Kevin / Chien / Alexander, 

 

JIRA  : https://bugs.openjdk.java.net/browse/JDK-8136466

Webrev : http://cr.openjdk.java.net/~psadhukhan/guru/8136466/webrev.00/

 

Root cause : Relative url of sub resource which are requested from base url of 
protocol type "jar:" was missing. 

Fix : Parse the protocol type of "jar:" and append the baseurl to relative url 
(Detailed comments updated in JIRA). 

 

Please review the fix (comments updated in JIRA). 

 

Thanks, 

Guru