On Thu, 30 Apr 2020 18:56:40 GMT, Jesper Skov
wrote:
> I have tested on Linux (Fedora 31) only.
> It works as intended (with one test failure due to 15-ea+4 being too old now).
>
> UPDATE_STUB_CACHE suggests there is some magic available to help manage the
> stub cache.
&
On Thu, 30 Apr 2020 20:15:22 GMT, Kevin Rushforth wrote:
>> I have tested on Linux (Fedora 31) only.
>> It works as intended (with one test failure due to 15-ea+4 being too old
>> now).
>>
>> UPDATE_STUB_CACHE suggests there is some magic available to help manage the
>> stub cache.
>> But as
I have tested on Linux (Fedora 31) only.
It works as intended (with one test failure due to 15-ea+4 being too old now).
UPDATE_STUB_CACHE suggests there is some magic available to help manage the
stub cache.
But as I could not find anything about it, that section in the documentation
may need
On Thu, 30 Apr 2020 20:10:19 GMT, Kevin Rushforth wrote:
>> I have tested on Linux (Fedora 31) only.
>> It works as intended (with one test failure due to 15-ea+4 being too old
>> now).
>>
>> UPDATE_STUB_CACHE suggests there is some magic available to help manage the
>> stub cache.
>> But as
On Tue, 5 May 2020 20:39:18 GMT, Florian Kirmaier wrote:
>> It's also worth mentioning that this utility allows checking whether an
>> object can not be collected. This is important
>> because the applications, which are using WeakReferences/WeakListeners often
>> introduce bugs that are hard
On Tue, 17 Mar 2020 11:08:36 GMT, Ambarish Rapte wrote:
>> Marked as reviewed by arapte (Reviewer).
>
> @FlorianKirmaier
> Please integrate this PR by issuing `/integrate` command in a new comment.
> After that one of us can sponsor it.
@FlorianKirmaier did you want to persue a common shared
I have created https://github.com/openjdk/jfx/pull/202 with a suggested
implementation.
Looking for feedback.
Cheers,
Jesper
On Fri, Apr 24, 2020 at 5:13 PM Jesper Skov wrote:
> Thanks, I will give it a shot.
>
> Jesper
>
>
> On Thu, Apr 23, 2020 at 7:45 PM Kevin Rushfort
On Thu, 9 Apr 2020 09:58:27 GMT, Jesper Skov
wrote:
> Make the two ways of associating a ToggleButton with a ToggleGroup interact
> correctly.
>
> This fixes https://bugs.openjdk.java.net/browse/JDK-8198402
This pull request has now been integrated.
Changeset: 3130fc80
Autho
ack it
> (underneath either build or buildSrc/build).
>
> -- Kevin
>
>
> On 4/23/2020 1:14 AM, Jesper Skov wrote:
> > Hi
> >
> > I struggled somewhat to get :web:test running with -PSTUB_RUNTIME.
> >
> > The JVM kept crashing by what turned out to be missing m
Hi again,
I have an additional suggestion for CONTRIBUTING.md changes.
In the Code Review section:
If any changes are needed, you would push additional commits to the
branch from which you made the pull request.
Maybe add something to the effect that;
These additional commits should have
On Sun, 19 Apr 2020 13:50:18 GMT, Jesper Skov
wrote:
>> Uh, the exception is (as the comment note suggests) from using a prebuilt
>> webkit.
>> I will try a locally built one now.
>
> Ah, well. Ended with the same VM crash when building webkit myself.
>
> So I a
On Sun, 19 Apr 2020 12:44:23 GMT, Jesper Skov
wrote:
>> I have failed getting web:tests to work.
>> Both with java 11.0.7 and 14.0.0 (adoptajdk 14.0.1 not ready yet), I get the
>> error below.
>>
>> And that is with both a locally built webkit, and the o
On Sun, 19 Apr 2020 12:42:09 GMT, Jesper Skov
wrote:
>> @kevinrushforth I tested by:
>> `
>> bash ./gradlew clean all test -x :web:test
>> `
>> I assumed that would do it.
>> But I see use of ToggleButton in javafx.web, so that was clearly a faulty
>
On Sun, 19 Apr 2020 09:56:27 GMT, Jesper Skov
wrote:
>> The fix looks correct to me. Have you run all tests to ensure no regressions?
>>
>> I left a couple inline comments.
>
> @kevinrushforth I tested by:
> `
> bash ./gradlew clean all test -x :web:test
On Sat, 18 Apr 2020 16:04:34 GMT, Kevin Rushforth wrote:
>> Jesper Skov has updated the pull request incrementally with three additional
>> commits since the last revision:
>>
>> - Fail instead of print message
>> - addedToggles list is final
>> - Le
> Make the two ways of associating a ToggleButton with a ToggleGroup interact
> correctly.
>
> This fixes https://bugs.openjdk.java.net/browse/JDK-8198402
Jesper Skov has updated the pull request incrementally with three additional
commits since the last revision:
- Fail inst
On Sat, 18 Apr 2020 15:50:55 GMT, Kevin Rushforth wrote:
>> Make the two ways of associating a ToggleButton with a ToggleGroup interact
>> correctly.
>>
>> This fixes https://bugs.openjdk.java.net/browse/JDK-8198402
>
>
On Thu, 9 Apr 2020 09:58:27 GMT, Jesper Skov
wrote:
> Make the two ways of associating a ToggleButton with a ToggleGroup interact
> correctly.
>
> This fixes https://bugs.openjdk.java.net/browse/JDK-8198402
/signed
-
PR: https://git.openjdk.java.net/jfx/pull/167
Make the two ways of associating a ToggleButton with a ToggleGroup interact
correctly.
This fixes https://bugs.openjdk.java.net/browse/JDK-8198402
-
Commit messages:
- 8198402: Fix ToggleButton leak in ToggleGroup
Changes: https://git.openjdk.java.net/jfx/pull/167/files
Webrev:
Hi,
I happened to fall over this issue:
https://bugs.openjdk.java.net/browse/JDK-8198402
while reading another jfx PR.
I have a shot at a fix:
https://github.com/openjdk/jfx/compare/master...jskov:toggleGroupSync-JDK-8198402
But I was not entirely sure if just submitting a PR without saying
Hi,
I had a look quick look around in the bugs lists for something to try
fixing. I happened on this issue.
I am aware that the other primitive binding classes should have similar
treatment.
But I wanted to get approval/hints before continuing.
The change adds a new inner class that allows the
21 matches
Mail list logo
