Re: [9] Review request for 8150076: Print jobs are not finished when used a page range

[mikhail cherkasov]

Hi Phil,

Please see my update in jbs:
https://bugs.openjdk.java.net/browse/JDK-8150076

Thanks,
Mikhail.

On 4/14/2016 12:28 AM, Phil Race wrote:

I have an old PageRange printing test where I set
settings.setPageRanges(new 
PageRange(1,3));

and it prints fine on JDK 9 on Win 7 x64.
In fact it also prints fine with 8u74

Also a thread dump doesn't show any problem with the print thread not 
terminating.


So I assume the test that shows the bug must be doing something I am not.

You say [9] above but I see your webrev suggests 8u !
"/cygdrive/c/ws/javafx/8u-dev/rt"

Can you please
(a)  prepare a webrev against 9 instead of 8u.
(b) include (and therefore share) the test you are using that 
illustrates the problem.


-phil.

On 04/12/2016 09:21 AM, mikhail cherkasov wrote:

Hi all,

Could you please review the fix for:
https://bugs.openjdk.java.net/browse/JDK-8150076
webrev:
http://cr.openjdk.java.net/~mcherkas/8150076/webrev.00/

J2DPrinterJob waits when page printing is done, but doesn't check that
the whole job is done or that it is failed due error, as result we can
never quit from while cycle in method " implPrintPage".
The fix adds this checks.

Thanks,
Mikhail.

[9] Review request for 8150076: Print jobs are not finished when used a page range

[mikhail cherkasov]

Hi all,

Could you please review the fix for:
https://bugs.openjdk.java.net/browse/JDK-8150076
webrev:
http://cr.openjdk.java.net/~mcherkas/8150076/webrev.00/

J2DPrinterJob waits when page printing is done, but doesn't check that
the whole job is done or that it is failed due error, as result we can
never quit from while cycle in method " implPrintPage".
The fix adds this checks.

Thanks,
Mikhail.

[9] Review request for 8150181: javafx print jobs take 60 times longer than javax.print

[mikhail cherkasov]

Hi all,

Could you please review the fix for:
https://bugs.openjdk.java.net/browse/JDK-8150181
webrev:
http://cr.openjdk.java.net/~mcherkas/8150181/webrev.02/

Javafx print is slow because after sending node for printing
we wait 1 sec before checking that page was done,
see implPrintPage method:
   while (!pageDone) {
synchronized (monitor) {
try {
monitor.wait(1000);
} catch (InterruptedException e) {
}
}
}

so if you need to print 100 pages to pdf you will have to wait
for 100 seconds while with  javax.print it happens almost instantly.
I added "notify" when page is printed, so now we start a new printing 
without waiting.


Thanks,
Mikhail.

[9] RFR for 8149737:JRE crash in com.sun.webkit.network.URLLoader.twkDidFinishLoading

[mikhail cherkasov]

Hi Guru, Kevin,

Please review the webrev :
 http://cr.openjdk.java.net/~mcherkas/8149737/webrev/

Crash occurs during the page destroy and still there is are some pending 
sub-resource from network.
I added a check for null, see line 814 in CachedResourceLoader.cpp to 
prevent crash.


JBS:
https://bugs.openjdk.java.net/browse/JDK-8149737

Thanks,
Mikhail.