Re: [10] Review request for 8176844: Menus not always selected properly with GTK 3

2017-04-05 Thread Semyon Sadetsky
On 04/05/2017 11:23 AM, David Hill wrote: On 4/5/17, 12:52 PM, Semyon Sadetsky wrote: Okay. Thank you to you all! The root cause why we need to add sync is a new way to grab/ungrab focus used in the GTK3 glass implementation. The GTK2 way to grab/ungrab is still applicable in GTK3 though

Re: [10] Review request for 8176844: Menus not always selected properly with GTK 3

2017-04-05 Thread David Hill
On 4/5/17, 12:52 PM, Semyon Sadetsky wrote: Okay. Thank you to you all! The root cause why we need to add sync is a new way to grab/ungrab focus used in the GTK3 glass implementation. The GTK2 way to grab/ungrab is still applicable in GTK3 though it is deprecated. But the used GTK3

Re: [10] Review request for 8176844: Menus not always selected properly with GTK 3

2017-04-05 Thread Semyon Sadetsky
Okay. Thank you to you all! The root cause why we need to add sync is a new way to grab/ungrab focus used in the GTK3 glass implementation. The GTK2 way to grab/ungrab is still applicable in GTK3 though it is deprecated. But the used GTK3 grab/ungrab is deprecated as well since version 3.20

Re: [10] Review request for 8176844: Menus not always selected properly with GTK 3

2017-04-04 Thread Kevin Rushforth
I raised the same concern in the JBS issue, especially for mouse and keyboard events. -- Kevin Jim Graham wrote: I don't think I was specifically involved in AWT fixes for that issue, but the concerns that David raises are all valid and Phil correctly points out that this is much worse in a

Re: [10] Review request for 8176844: Menus not always selected properly with GTK 3

2017-04-04 Thread Jim Graham
I don't think I was specifically involved in AWT fixes for that issue, but the concerns that David raises are all valid and Phil correctly points out that this is much worse in a network display environment... ...jim On 4/4/17 3:53 PM, Philip Race wrote: AWT used to

Re: [10] Review request for 8176844: Menus not always selected properly with GTK 3

2017-04-04 Thread Philip Race
AWT used to have really bad at X11 remote display and it was looked at a few times and I think it was improved noticeably when we could get rid of "round trip" requests. I think Jim had a hand in some of that work. So I am sure a round trip - or similar - is bad for performance. If you want to

Re: [10] Review request for 8176844: Menus not always selected properly with GTK 3

2017-04-04 Thread David Hill
On 4/4/17, 1:27 PM, Semyon Sadetsky wrote: Hello Kevin & David, Please review the fix for jfx9: bug: https://bugs.openjdk.java.net/browse/JDK-8176844 webrev: http://cr.openjdk.java.net/~ssadetsky/8176844/ --Semyon Semyon, I have been sitting here for a while thinking about adding

Re: [10] Review request for 8176844: Menus not always selected properly with GTK 3

2017-04-04 Thread Semyon Sadetsky
Sorry. The fix is for JFX *10*. On 04/04/2017 10:27 AM, Semyon Sadetsky wrote: Hello Kevin & David, Please review the fix for jfx9: bug: https://bugs.openjdk.java.net/browse/JDK-8176844 webrev: http://cr.openjdk.java.net/~ssadetsky/8176844/ --Semyon

[10] Review request for 8176844: Menus not always selected properly with GTK 3

2017-04-04 Thread Semyon Sadetsky
Hello Kevin & David, Please review the fix for jfx9: bug: https://bugs.openjdk.java.net/browse/JDK-8176844 webrev: http://cr.openjdk.java.net/~ssadetsky/8176844/ --Semyon