Re: [Rev 01] RFR: 8196586: Remove use of deprecated finalize methods from javafx property objects

2020-02-20 Thread Kevin Rushforth
On Thu, 20 Feb 2020 18:50:04 GMT, Nir Lisker wrote: >> The pull request has been updated with 1 additional commit. > > modules/javafx.base/src/test/java/test/javafx/beans/property/ObjectPropertyLeakTest.java > line 111: > >> 110: origRefs.add(new WeakReference<>(origProp)); >>

Re: [Rev 01] RFR: 8196586: Remove use of deprecated finalize methods from javafx property objects

2020-02-20 Thread Nir Lisker
On Fri, 14 Feb 2020 14:23:45 GMT, Kevin Rushforth wrote: >> This patch removes the `finalize` methods from the `Property` classes in the >> `javafx.base` module. >> >> The `{Boolean,Double,Float,Int,Long}Property` classes each have a pair of >> methods -- `asObject` and `xProperty` --

Re: [Rev 01] RFR: 8196586: Remove use of deprecated finalize methods from javafx property objects

2020-02-14 Thread Kevin Rushforth
> This patch removes the `finalize` methods from the `Property` classes in the > `javafx.base` module. > > The `{Boolean,Double,Float,Int,Long}Property` classes each have a pair of > methods -- `asObject` and `xProperty` -- that create a `Property` > object from a primitive `XProperty`