Hi,
Please review the fix approach for:
https://bugs.openjdk.java.net/browse/JDK-8195974
http://cr.openjdk.java.net/~nlisker/8195974/webrev.00/
Many details in the issue.
Thanks,
Nir
That all sounds good.
As for the packager, it will likely continue to be a source of issues
like this now that it is gone from the JDK, and isn't part of the
unbundled FX builds.
I just filed a bug [1] to remove the qualified export from
javafx.graphics to jdk.packager (and to disable
>
> There was one other place where isDebug() was called, that being the mLog
> method. Did you replace the call ti isDebug() with a direct call to
> isLoggable instead?
>
Yes, I should have been clearer: I inlined `isDebug` into `mLog`, then
commented out `isDebug` so that if someone reads the
I think it isn't worth doing anything for the packager. In any case,
since "HelloService" is a test program, I see no problem with it
continuing to use java.util.logging.
Regarding your other comment:
Thanks Murali, Iv'e also commented out isDebug() (though maybe it can
be completely
Thanks Murali, Iv'e also commented out isDebug() (though maybe it can be
completely removed, only that the commented out code relies on it).
Kevin, after this change, HelloService in the packager is the only one
requiring file handling. What is the future of the packager now? Is it
worth
Also, why is webkit.mediaplayer special in its usage of the
logger (that it requires its own property)?
That's the real question: are the needs of the WebView media component
so special that it justifies its own mechanism / property. I doubt it,
which is why removing the verbose flag
>
> Also, why is webkit.mediaplayer special in its usage of the logger (that
>> it requires its own property)?
>
>
> That's the real question: are the needs of the WebView media component so
> special that it justifies its own mechanism / property. I doubt it, which
> is why removing the verbose
On 5/2/2018 6:25 PM, Nir Lisker wrote:
Not sure what you mean by "that file".
Sorry, I meant the log/config file.
I see. This isn't something that a library like JavaFX should read.
keeping the verbose flag but putting it on a System property
Then why not get a minimum level
>
> Not sure what you mean by "that file".
Sorry, I meant the log/config file.
keeping the verbose flag but putting it on a System property
Then why not get a minimum level from a system property instead of a
general on/off flag?
Also, why is webkit.mediaplayer special in its usage of the
inline
On 5/2/2018 4:52 PM, Nir Lisker wrote:
Thanks Murali,
I won’t suggest reading level value from log/config file.
Is that file user facing? If so, wouldn't ignoring the level set in the
file break current behavior? Would there need to be follow-up changes to
this file to remove the
Thanks Murali,
I won’t suggest reading level value from log/config file.
Is that file user facing? If so, wouldn't ignoring the level set in the
file break current behavior? Would there need to be follow-up changes to
this file to remove the level setting from it?
About option (a), wouldn't
Hi Nir,
1) Regarding “verbose” flag usage:
· Currently verbose flag is used to show log Levels
(FINER/FINE/INFO/WARNING) in WCMediaPlayer & WCMediaPlayerImpl. I feel it is
not desirable to remove this flag as all these logs will start appearing now by
default.
· We
Hi Murali,
Can you have a look at https://bugs.openjdk.java.net/browse/JDK-8195974
please?
There are some usages of j.u.l in the web module I'd like your opinion on.
I'm not familiar with the intent of these pieces of code and would like to
know what the options are for advancing with this issue
13 matches
Mail list logo
