?
-- Abhinay
From: openjfx-dev on behalf of Abhinay
Agarwal
Sent: Saturday, February 8, 2020 1:15 PM
To: Kevin Rushforth ; openjfx-dev@openjdk.java.net
Subject: Re: RFR: 8228363 Fix shifts for ContextMenu shown on TOP/LEFT side
Hi Kevin,
Yes, this is actually a pre-review mail to
-dev@openjdk.java.net
Subject: Re: RFR: 8228363 Fix shifts for ContextMenu shown on TOP/LEFT side
I presume this is a "pre" review before sending out an actual review
(which the Skara tooling will do automatically when you generate a pull
request)...
My concern with thi
I presume this is a "pre" review before sending out an actual review
(which the Skara tooling will do automatically when you generate a pull
request)...
My concern with this approach is that it leaks what should be an
implementation detail into a visible property of the control (and
really,
The issue is caused because of a fix which was pushed as a part of
https://bugs.openjdk.java.net/browse/JDK-8159044
The root cause of the issue is that ContextMenuSkin#performPopupShifts doesn't
consider the cases where shiftX / shiftY can be negative, just as in case of
the example provided