Re: [Rev 04] RFR: 8234959: FXMLLoader does not populate ENGINE_SCOPE Bindings with FILENAME and ARGV

2020-03-31 Thread Rony G . Flatscher
On Tue, 31 Mar 2020 11:52:19 GMT, Ajit Ghaisas wrote: >> Rony G. Flatscher has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Remove jcheck whitespace error. > > Marked as reviewed by aghaisas (Reviewer). Kevin, Ajit, could you please /spo

Re: [Rev 04] RFR: 8234959: FXMLLoader does not populate ENGINE_SCOPE Bindings with FILENAME and ARGV

2020-03-31 Thread Ajit Ghaisas
On Wed, 25 Mar 2020 19:05:42 GMT, Rony G. Flatscher wrote: >> …9: FXMLLoader does not populate ENGINE_SCOPE Bindings with FILENAME and ARGV > > Rony G. Flatscher has updated the pull request incrementally with one > additional commit since the last revision: > > Remove jcheck whitespace erro

Re: [Rev 04] RFR: 8234959: FXMLLoader does not populate ENGINE_SCOPE Bindings with FILENAME and ARGV

2020-03-25 Thread Kevin Rushforth
On Wed, 25 Mar 2020 19:05:42 GMT, Rony G. Flatscher wrote: >> …9: FXMLLoader does not populate ENGINE_SCOPE Bindings with FILENAME and ARGV > > Rony G. Flatscher has updated the pull request incrementally with one > additional commit since the last revision: > > Remove jcheck whitespace erro

Re: [Rev 04] RFR: 8234959: FXMLLoader does not populate ENGINE_SCOPE Bindings with FILENAME and ARGV

2020-03-25 Thread Rony G . Flatscher
> …9: FXMLLoader does not populate ENGINE_SCOPE Bindings with FILENAME and ARGV Rony G. Flatscher has updated the pull request incrementally with one additional commit since the last revision: Remove jcheck whitespace error. - Changes: - all: https://git.openjdk.java.net/jfx/pu

Re: [Rev 03] RFR: 8234959: FXMLLoader does not populate ENGINE_SCOPE Bindings with FILENAME and ARGV

2020-03-25 Thread Rony G . Flatscher
> …9: FXMLLoader does not populate ENGINE_SCOPE Bindings with FILENAME and ARGV Rony G. Flatscher has updated the pull request incrementally with one additional commit since the last revision: Applying the changes according to the review. - Changes: - all: https://git.openjdk.j

Re: [Rev 02] RFR: 8234959: FXMLLoader does not populate ENGINE_SCOPE Bindings with FILENAME and ARGV

2020-03-24 Thread Rony G. Flatscher
Kevin and Ajit, thank you very much for your reviews! Will apply the changes (including changing CRLF to LF) ASAP. ---rony On 23.03.2020 22:45, Kevin Rushforth wrote: > On Sat, 21 Mar 2020 19:19:18 GMT, Kevin Rushforth wrote: > >>> Rony G. Flatscher has updated the pull request incrementally

Re: [Rev 02] RFR: 8234959: FXMLLoader does not populate ENGINE_SCOPE Bindings with FILENAME and ARGV

2020-03-23 Thread Kevin Rushforth
On Sat, 21 Mar 2020 19:19:18 GMT, Kevin Rushforth wrote: >> Rony G. Flatscher has updated the pull request incrementally with one >> additional commit since the last revision: >> >> corrected wrong test string > > The fix looks good. I left a few comments on the test. One of them is > substa

Re: [Rev 02] RFR: 8234959: FXMLLoader does not populate ENGINE_SCOPE Bindings with FILENAME and ARGV

2020-03-21 Thread Kevin Rushforth
On Thu, 27 Feb 2020 15:56:25 GMT, Rony G. Flatscher wrote: >> …9: FXMLLoader does not populate ENGINE_SCOPE Bindings with FILENAME and ARGV > > Rony G. Flatscher has updated the pull request incrementally with one > additional commit since the last revision: > > corrected wrong test string

Re: [Rev 02] RFR: 8234959: FXMLLoader does not populate ENGINE_SCOPE Bindings with FILENAME and ARGV

2020-03-20 Thread Kevin Rushforth
On Fri, 20 Mar 2020 11:28:46 GMT, Ajit Ghaisas wrote: >> Rony G. Flatscher has updated the pull request incrementally with one >> additional commit since the last revision: >> >> corrected wrong test string > > tests/system/src/testscriptapp1/java/mymod/myapp1/Util.java line 2: > >> 1: /* >>

Re: RFR: 8234959: FXMLLoader does not populate ENGINE_SCOPE Bindings with FILENAME and ARGV

2020-03-20 Thread Ajit Ghaisas
On Fri, 13 Mar 2020 15:15:39 GMT, Kevin Rushforth wrote: >> Is there anything I can do to keep the ball rolling ? > > I just need time to do final testing of this, along with the review of the > updated test. > > @aghaisas will also review. The changes look good to me. I verified that the test

Re: [Rev 02] RFR: 8234959: FXMLLoader does not populate ENGINE_SCOPE Bindings with FILENAME and ARGV

2020-03-20 Thread Ajit Ghaisas
On Thu, 27 Feb 2020 15:56:25 GMT, Rony G. Flatscher wrote: >> …9: FXMLLoader does not populate ENGINE_SCOPE Bindings with FILENAME and ARGV > > Rony G. Flatscher has updated the pull request incrementally with one > additional commit since the last revision: > > corrected wrong test string

Re: RFR: 8234959: FXMLLoader does not populate ENGINE_SCOPE Bindings with FILENAME and ARGV

2020-03-13 Thread Kevin Rushforth
On Fri, 13 Mar 2020 14:09:04 GMT, Rony G. Flatscher wrote: >> Btw, I recommend to run `sh gradlew ...` so you don't have to change the >> permission locally. > > Is there anything I can do to keep the ball rolling ? I just need time to do final testing of this, along with the review of the up

Re: RFR: 8234959: FXMLLoader does not populate ENGINE_SCOPE Bindings with FILENAME and ARGV

2020-03-13 Thread Rony G . Flatscher
On Mon, 2 Mar 2020 16:49:45 GMT, Kevin Rushforth wrote: >> Removed executable bits from gradlew (which I manually have added to become >> able to run ./gradlew) and pushed it, >> however the commit has not appeared. Not wanting to add more noise, I stop >> until advised differently. > > Btw, I

Re: RFR: 8234959: FXMLLoader does not populate ENGINE_SCOPE Bindings with FILENAME and ARGV

2020-03-02 Thread Rony G. Flatscher
Hi Kevin, On 02.03.2020 17:51, Kevin Rushforth wrote: > On Thu, 27 Feb 2020 14:36:17 GMT, Rony G. Flatscher > wrote: > >>> Overall this looks good to me. As I mentioned in PR #123 you should fold >>> that the unit test into this PR. >> Removed executable bits from gradlew (which I manually have

Re: RFR: 8234959: FXMLLoader does not populate ENGINE_SCOPE Bindings with FILENAME and ARGV

2020-03-02 Thread Kevin Rushforth
On Thu, 27 Feb 2020 14:36:17 GMT, Rony G. Flatscher wrote: >> Overall this looks good to me. As I mentioned in PR #123 you should fold >> that the unit test into this PR. > > Removed executable bits from gradlew (which I manually have added to become > able to run ./gradlew) and pushed it, how

Re: [Rev 02] RFR: 8234959: FXMLLoader does not populate ENGINE_SCOPE Bindings with FILENAME and ARGV

2020-02-27 Thread Rony G . Flatscher
> …9: FXMLLoader does not populate ENGINE_SCOPE Bindings with FILENAME and ARGV The pull request has been updated with 1 additional commit. - Added commits: - a42fed5c: corrected wrong test string Changes: - all: https://git.openjdk.java.net/jfx/pull/122/files - new: https://gi

Re: [Rev 01] RFR: 8234959: FXMLLoader does not populate ENGINE_SCOPE Bindings with FILENAME and ARGV

2020-02-27 Thread Rony G . Flatscher
> …9: FXMLLoader does not populate ENGINE_SCOPE Bindings with FILENAME and ARGV The pull request has been updated with 6 additional commits. - Added commits: - 8821d25a: Removed executable bit from gradlew as this causes an error when - 799a8148: Merge branch 'scripttest' into scri

Re: RFR: 8234959: FXMLLoader does not populate ENGINE_SCOPE Bindings with FILENAME and ARGV

2020-02-27 Thread Rony G . Flatscher
On Wed, 26 Feb 2020 23:37:11 GMT, Kevin Rushforth wrote: >> @aghaisas can you also review this? > > Overall this looks good to me. As I mentioned in PR #123 you should fold that > the unit test into this PR. Removed executable bits from gradlew (which I manually have added to become able to ru

Re: RFR: 8234959: FXMLLoader does not populate ENGINE_SCOPE Bindings with FILENAME and ARGV

2020-02-26 Thread Kevin Rushforth
On Tue, 25 Feb 2020 13:54:25 GMT, Kevin Rushforth wrote: >> Sorry, mixed up the link with the test unit WIP! :( >> >> This is the correct link with the explanatory text related to this suggested >> fix. Posted [1] which explains the problem and the suggested solution for >> discussion. >> [1]

Re: RFR: 8234959: FXMLLoader does not populate ENGINE_SCOPE Bindings with FILENAME and ARGV

2020-02-25 Thread Kevin Rushforth
On Sun, 23 Feb 2020 14:57:44 GMT, Rony G. Flatscher wrote: >> OK, forgot to submit an explanatory text related to this fix. Posted [1] >> which explains the problem and the suggested solution for discussion. >> >> - This pull request relates to: >>

Re: RFR: 8234959: FXMLLoader does not populate ENGINE_SCOPE Bindings with FILENAME and ARGV

2020-02-25 Thread Rony G . Flatscher
On Sun, 23 Feb 2020 14:54:32 GMT, Rony G. Flatscher wrote: >> …9: FXMLLoader does not populate ENGINE_SCOPE Bindings with FILENAME and ARGV > > OK, forgot to submit an explanatory text related to this fix. Posted [1] > which explains the problem and the suggested solution for discussion. > >

RFR: 8234959: FXMLLoader does not populate ENGINE_SCOPE Bindings with FILENAME and ARGV

2020-02-25 Thread Rony G . Flatscher
…9: FXMLLoader does not populate ENGINE_SCOPE Bindings with FILENAME and ARGV - Commits: - 30539592: Removed/replaced white space. - 5c33d590: fix for JDK-8234959: FXMLLoader does not populate ENGINE_SCOPE Bindings with FILENAME a

Re: RFR: 8234959: FXMLLoader does not populate ENGINE_SCOPE Bindings with FILENAME and ARGV

2020-02-25 Thread Rony G . Flatscher
On Sat, 22 Feb 2020 15:39:35 GMT, Rony G. Flatscher wrote: > …9: FXMLLoader does not populate ENGINE_SCOPE Bindings with FILENAME and ARGV OK, forgot to submit an explanatory text related to this fix. Posted [1] which explains the problem and the suggested solution for discussion. - This pul