Re: [Integrated] RFR: 8236753: Animations do not play backwards after being stopped

2020-01-24 Thread Nir Lisker
Changeset: 9ae37f1f Author:Nir Lisker Date: 2020-01-22 20:58:12 + URL: https://git.openjdk.java.net/jfx/commit/9ae37f1f 8236753: Animations do not play backwards after being stopped Reviewed-by: kcr, arapte ! modules/javafx.graphics/src/main/java/javafx/animation/Animation.ja

Re: [Integrated] RFR: 8236753: Animations do not play backwards after being stopped

2020-01-22 Thread Nir Lisker
Changeset: 9ae37f1f Author:Nir Lisker Date: 2020-01-22 20:58:12 + URL: https://git.openjdk.java.net/jfx/commit/9ae37f1f 8236753: Animations do not play backwards after being stopped Reviewed-by: kcr, arapte ! modules/javafx.graphics/src/main/java/javafx/animation/Animation.ja

Re: [Rev 01] RFR: 8236753: Animations do not play backwards after being stopped

2020-01-22 Thread Ambarish Rapte
On Wed, 22 Jan 2020 17:55:27 GMT, Nir Lisker wrote: >> The private field `lastPlayFinished` is responsible for 2 cases where an >> animation in `STOPPED` status does not play after `play()` is called if the >> rate is negative: >> >> 1. When the animation is created, it is `STOPPED` and `lastP

Re: [Rev 01] RFR: 8236753: Animations do not play backwards after being stopped

2020-01-21 Thread Kevin Rushforth
On Tue, 21 Jan 2020 19:57:56 GMT, Nir Lisker wrote: >> The private field `lastPlayFinished` is responsible for 2 cases where an >> animation in `STOPPED` status does not play after `play()` is called if the >> rate is negative: >> >> 1. When the animation is created, it is `STOPPED` and `lastP

Re: RFR: 8236753: Animations do not play backwards after being stopped

2020-01-17 Thread Nir Lisker
On Fri, 17 Jan 2020 22:48:11 GMT, Kevin Rushforth wrote: >>> So this PR may need a document change for `Animation.play()` >> >> Yes, and the docs need clarification in other places anyway. The [parent >> issue](https://bugs.openjdk.java.net/browse/JDK-8210238) from which this bug >> was isolat

Re: [Rev 01] RFR: 8236753: Animations do not play backwards after being stopped

2020-01-17 Thread Nir Lisker
> The private field `lastPlayFinished` is responsible for 2 cases where an > animation in `STOPPED` status does not play after `play()` is called if the > rate is negative: > > 1. When the animation is created, it is `STOPPED` and `lastPlayFinished` is > `false`. Setting a negative rate and cal

Re: RFR: 8236753: Animations do not play backwards after being stopped

2020-01-17 Thread Kevin Rushforth
On Thu, 16 Jan 2020 01:09:56 GMT, Nir Lisker wrote: >>> If cycleCount is set to 2 does the animation play the same number of times >>> with or without the jumpTo both before and after this change? >> >> Before the change: >> * With `jumpTo`: plays backwards 2 times. >> * Without `jumpTo`: doesn

Re: RFR: 8236753: Animations do not play backwards after being stopped

2020-01-15 Thread Nir Lisker
On Thu, 16 Jan 2020 01:06:30 GMT, Nir Lisker wrote: >> The fix looks good to me. >> After this change the steps needed for playing an `Animation` backwards will >> change. >> Earlier this was documented with `Animation.play()` API as below. >> >> - >> To play an `Animation` backward

Re: RFR: 8236753: Animations do not play backwards after being stopped

2020-01-15 Thread Nir Lisker
On Tue, 14 Jan 2020 16:50:12 GMT, Ambarish Rapte wrote: >> I should add that it will depend on whether there are any regressions. One >> thing we do need to be careful of is introducing regressions during rampdown. > > The fix looks good to me. > After this change the steps needed for playing a

Re: RFR: 8236753: Animations do not play backwards after being stopped

2020-01-14 Thread Scott Palmer
> On Jan 14, 2020, at 11:50 AM, Ambarish Rapte wrote: > > On Fri, 10 Jan 2020 00:39:53 GMT, Kevin Rushforth wrote: > >>> I'll review this next week. This seems a fine candidate for openjfx14, so >>> it (along with a couple other pending reviews that can be for 14) will be a >>> good test o

Re: RFR: 8236753: Animations do not play backwards after being stopped

2020-01-14 Thread Ambarish Rapte
On Fri, 10 Jan 2020 00:39:53 GMT, Kevin Rushforth wrote: >> I'll review this next week. This seems a fine candidate for openjfx14, so it >> (along with a couple other pending reviews that can be for 14) will be a >> good test of targeting a PR to the stabilization branch. >> >> I also request

Re: RFR: 8236753: Animations do not play backwards after being stopped

2020-01-09 Thread Kevin Rushforth
On Fri, 10 Jan 2020 00:37:58 GMT, Kevin Rushforth wrote: >> The private field `lastPlayFinished` is responsible for 2 cases where an >> animation in `STOPPED` status does not play after `play()` is called if the >> rate is negative: >> >> 1. When the animation is created, it is `STOPPED` and `

Re: RFR: 8236753: Animations do not play backwards after being stopped

2020-01-09 Thread Kevin Rushforth
On Wed, 8 Jan 2020 23:52:07 GMT, Nir Lisker wrote: > The private field `lastPlayFinished` is responsible for 2 cases where an > animation in `STOPPED` status does not play after `play()` is called if the > rate is negative: > > 1. When the animation is created, it is `STOPPED` and `lastPlayFin

RFR: 8236753: Animations do not play backwards after being stopped

2020-01-08 Thread Nir Lisker
The private field `lastPlayFinished` is responsible for 2 cases where an animation in `STOPPED` status does not play after `play()` is called if the rate is negative: 1. When the animation is created, it is `STOPPED` and `lastPlayFinished` is `false`. Setting a negative rate and calling `play()