Hi Ajit,
Kevin looked into it already yesterday. There was some problem at github at the
time I submitted the /integrate comment, which merely needs to be reissued by
me. Having been on the road I was not able to do it yesterday, will be first
thing after arriving at the office today.
Also,
On Sat, 27 Jun 2020 14:07:24 GMT, Rony G. Flatscher
wrote:
>> This PR adds a "compile" process instruction to FXML files with the optional
>> PI data "true" (default) and "false". The
>> PI data is turned into a boolean value using "Boolean.parseBoolean(String)".
>> This makes it possible to
The message from this sender included one or more files
which could not be scanned for virus detection; do not
open these files unless you are certain of the sender's intent.
--
On Sat, 27 Jun 2020 14:41:29 GMT, Kevin Rushforth
On Sat, 27 Jun 2020 14:07:24 GMT, Rony G. Flatscher
wrote:
>> This PR adds a "compile" process instruction to FXML files with the optional
>> PI data "true" (default) and "false". The
>> PI data is turned into a boolean value using "Boolean.parseBoolean(String)".
>> This makes it possible to
On Sat, 27 Jun 2020 14:41:29 GMT, Kevin Rushforth wrote:
>> Rony G. Flatscher has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Incorporating Kevin's review comments (overlooked some places).
>
> Looks good.
It seems that there is a need
On Sat, 27 Jun 2020 14:07:24 GMT, Rony G. Flatscher
wrote:
>> This PR adds a "compile" process instruction to FXML files with the optional
>> PI data "true" (default) and "false". The
>> PI data is turned into a boolean value using "Boolean.parseBoolean(String)".
>> This makes it possible to
> This PR adds a "compile" process instruction to FXML files with the optional
> PI data "true" (default) and "false". The
> PI data is turned into a boolean value using "Boolean.parseBoolean(String)".
> This makes it possible to inject the compile PI everywhere in a FXML file and
> turn on and
On Fri, 26 Jun 2020 18:38:10 GMT, Rony G. Flatscher
wrote:
>> This PR adds a "compile" process instruction to FXML files with the optional
>> PI data "true" (default) and "false". The
>> PI data is turned into a boolean value using "Boolean.parseBoolean(String)".
>> This makes it possible to
> This PR adds a "compile" process instruction to FXML files with the optional
> PI data "true" (default) and "false". The
> PI data is turned into a boolean value using "Boolean.parseBoolean(String)".
> This makes it possible to inject the compile PI everywhere in a FXML file and
> turn on and
On Thu, 25 Jun 2020 23:59:47 GMT, Kevin Rushforth wrote:
>> Rony G. Flatscher has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Incorporating Kevin's review comments (final int, fix for loop test,
>> correct formatting).
>
> The API
On Fri, 19 Jun 2020 16:04:16 GMT, Rony G. Flatscher
wrote:
>> This PR adds a "compile" process instruction to FXML files with the optional
>> PI data "true" (default) and "false". The
>> PI data is turned into a boolean value using "Boolean.parseBoolean(String)".
>> This makes it possible to
On Fri, 19 Jun 2020 15:49:43 GMT, Rony G. Flatscher
wrote:
> CSR-update: looks good!
I have moved the CSR to the "proposed" state in preparation for formal review.
-
PR: https://git.openjdk.java.net/jfx/pull/192
On Fri, 19 Jun 2020 15:49:36 GMT, Rony G. Flatscher
wrote:
>> modules/javafx.fxml/src/main/java/javafx/fxml/FXMLLoader.java line 1769:
>>
>>> 1768: try {
>>> 1769: if (isCompiled) {
>>> 1770:compiledScript.eval(localBindings);
>>
>> I think
On Fri, 19 Jun 2020 00:04:37 GMT, Kevin Rushforth wrote:
>> Rony G. Flatscher has updated the pull request with a new target base due to
>> a merge or a rebase. The pull request now
>> contains 27 commits:
>> - Updates to meet Kevin's comment in PR 192 as of May 27th.
>> - Merge
> This PR adds a "compile" process instruction to FXML files with the optional
> PI data "true" (default) and "false". The
> PI data is turned into a boolean value using "Boolean.parseBoolean(String)".
> This makes it possible to inject the compile PI everywhere in a FXML file and
> turn on and
On Thu, 4 Jun 2020 15:44:49 GMT, Rony G. Flatscher
wrote:
>> This PR adds a "compile" process instruction to FXML files with the optional
>> PI data "true" (default) and "false". The
>> PI data is turned into a boolean value using "Boolean.parseBoolean(String)".
>> This makes it possible to
On Tue, 26 May 2020 23:27:07 GMT, Kevin Rushforth wrote:
>> Rony G. Flatscher has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Reword the compile processing instructions (replace 'Hint' with 'Note:',
>> adjust text to context), remove
> This PR adds a "compile" process instruction to FXML files with the optional
> PI data "true" (default) and "false". The
> PI data is turned into a boolean value using "Boolean.parseBoolean(String)".
> This makes it possible to inject the compile PI everywhere in a FXML file and
> turn on and
On Wed, 13 May 2020 08:46:11 GMT, Rony G. Flatscher
wrote:
>> This WIP adds the ability for a fallback in case compilation of scripts
>> fails, in which case a warning gets issued
>> about this fact and evaluation of the script will be done without
>> compilation. Because of the fallback
On Wed, 13 May 2020 09:22:20 GMT, Rony G. Flatscher
wrote:
>> Doc addition for the CSR:
>> =
>> The following text was added to the [Introduction to
>>
On Tue, 12 May 2020 17:33:06 GMT, Rony G. Flatscher
wrote:
>> Suggested CSR:
>>
>> Summary
>> ===
>> Have javafx.fxml.FXMLLoader compile FXML scripts before evaluating them, if
>> the script engine
>> implements the javax.script.Compilable interface to speed up execution. In
>> case
> This WIP adds the ability for a fallback in case compilation of scripts
> fails, in which case a warning gets issued
> about this fact and evaluation of the script will be done without
> compilation. Because of the fallback scripts get
> compiled with this version by default. It extends PR 187
On Tue, 12 May 2020 16:51:08 GMT, Rony G. Flatscher
wrote:
>> I think the approach proposed in this PR is the best solution for this
>> enhancement. Go ahead and remove the `WIP` from
>> the title, and we can proceed with the review.
>> The interface and behavior change will need to be
On Sat, 9 May 2020 15:15:52 GMT, Kevin Rushforth wrote:
>> test units for: compile PI+fallback
>>
>> tests/system/src/testscriptapp2/java/mymod/myapp2/FXMLScriptDeployment2Compile_Off.java
>> ... use compile PI to set off compilation of scripts; each script code
>>
On Wed, 22 Apr 2020 16:33:47 GMT, Rony G. Flatscher
wrote:
>> This WIP adds the ability for a fallback in case compilation of scripts
>> fails, in which case a warning gets issued
>> about this fact and evaluation of the script will be done without
>> compilation. Because of the fallback
On Mon, 20 Apr 2020 12:45:30 GMT, Rony G. Flatscher
wrote:
> This WIP adds the ability for a fallback in case compilation of scripts
> fails, in which case a warning gets issued
> about this fact and evaluation of the script will be done without
> compilation. Because of the fallback scripts
This WIP adds the ability for a fallback in case compilation of scripts fails,
in which case a warning gets issued
about this fact and evaluation of the script will be done without compilation.
Because of the fallback scripts get
compiled with this version by default. It extends PR 187
TODO: ADD DESCRIPTION OF PROPOSED FIX HERE.
-
Commit messages:
- Correct error constant.
- appease the jcheck script, such that that important trailing Whitespace
error can be resolved (why would jcheck not do it automagically as well as
expanding tabs?)
- Merge master, correct
On Fri, 28 Feb 2020 17:46:58 GMT, Rony G. Flatscher
wrote:
> TODO: ADD DESCRIPTION OF PROPOSED FIX HERE.
We will need to finish the discussion on this proposed new feature on the
openjfx-dev mailing list. The PR can be used
to illustrate what you want to do, but use [this email
29 matches
Mail list logo
