Re: [Rev 02] RFR: 8241476: Linux build warning issued on updated compilers (Ubuntu 18.04.4 / 20.04)

2020-04-08 Thread Kevin Rushforth
On Sun, 29 Mar 2020 00:38:20 GMT, Thiago Milczarek Sayao wrote: >> Simple fix to remove annoying warnings. > > Thiago Milczarek Sayao has updated the pull request incrementally with one > additional commit since the last revision: > > Sep cppFlags and cFlags The build changes in

Re: [Rev 02] RFR: 8241476: Linux build warning issued on updated compilers (Ubuntu 18.04.4 / 20.04)

2020-04-07 Thread Kevin Rushforth
On Tue, 31 Mar 2020 20:45:44 GMT, Thiago Milczarek Sayao wrote: >> I took a look yesterday and came to the same conclusion that what we really >> want are separate C and C++ flags. For now, >> the only difference would be the presence or absence of >> `-Werror=implicit-function-declaration`,

Re: [Rev 02] RFR: 8241476: Linux build warning issued on updated compilers (Ubuntu 18.04.4 / 20.04)

2020-03-31 Thread Thiago Milczarek Sayao
On Thu, 26 Mar 2020 11:21:06 GMT, Kevin Rushforth wrote: >> I think it's better to split the flags between CFLAGS and CPPFLAGS (as is >> done in OpenJDK). The >> `-Werror=implicit-function-declaration` is extremely useful for C files, and >> we don't want to risk that this somehow >> got lost.

Re: [Rev 02] RFR: 8241476: Linux build warning issued on updated compilers (Ubuntu 18.04.4 / 20.04)

2020-03-28 Thread Thiago Milczarek Sayao
> Simple fix to remove annoying warnings. Thiago Milczarek Sayao has updated the pull request incrementally with one additional commit since the last revision: Sep cppFlags and cFlags - Changes: - all: https://git.openjdk.java.net/jfx/pull/150/files - new:

Re: [Rev 01] RFR: 8241476: Linux build warning issued on updated compilers (Ubuntu 18.04.4 / 20.04)

2020-03-26 Thread Kevin Rushforth
On Thu, 26 Mar 2020 08:33:29 GMT, Johan Vos wrote: >> Like this? >> >> I think all C builds are covered. Gstreamer seems to have a Makefile with >> the flags. Not sure about libxml and libxlst >> inside javafx.web. > > I think it's better to split the flags between CFLAGS and CPPFLAGS (as is

Re: [Rev 01] RFR: 8241476: Linux build warning issued on updated compilers (Ubuntu 18.04.4 / 20.04)

2020-03-26 Thread Johan Vos
On Wed, 25 Mar 2020 00:40:01 GMT, Thiago Milczarek Sayao wrote: >> The problem is that gcc, for whatever reason, started issuing a (useless) >> warning if you pass the >> `-Werror=implicit-function-declaration` option to gcc for C++ files. I don't >> like the solution of removing that flag >>

Re: [Rev 01] RFR: 8241476: Linux build warning issued on updated compilers (Ubuntu 18.04.4 / 20.04)

2020-03-24 Thread Thiago Milczarek Sayao
On Tue, 24 Mar 2020 11:45:28 GMT, Kevin Rushforth wrote: >> Thiago Milczarek Sayao has updated the pull request with a new target base >> due to a merge or a rebase. The incremental >> webrev excludes the unrelated changes brought in by the merge/rebase. The >> pull request contains five

Re: [Rev 01] RFR: 8241476: Linux build warning issued on updated compilers (Ubuntu 18.04.4 / 20.04)

2020-03-24 Thread Thiago Milczarek Sayao
> Simple fix to remove annoying warnings. Thiago Milczarek Sayao has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains five additional commits since the last

Re: RFR: 8241476: Linux build warning issued on updated compilers (Ubuntu 18.04.4 / 20.04)

2020-03-24 Thread Kevin Rushforth
On Tue, 24 Mar 2020 01:36:29 GMT, Thiago Milczarek Sayao wrote: > Simple fix to remove annoying warnings. The problem is that gcc, for whatever reason, started issuing a (useless) warning if you pass the `-Werror=implicit-function-declaration` option to gcc for C++ files. I don't like the

RFR: 8241476: Linux build warning issued on updated compilers (Ubuntu 18.04.4 / 20.04)

2020-03-23 Thread Thiago Milczarek Sayao
Simple fix to remove annoying warnings. - Commit messages: - Remove build warning - Merge pull request #7 from openjdk/master - Merge pull request #6 from openjdk/master - Merge pull request #5 from openjdk/master - Merge pull request #4 from openjdk/master Changes: