Clean backport to `jfx11u`.
-
Commit messages:
- 8242544: CMD+ENTER key event crashes the application when invoked on dialog
Changes: https://git.openjdk.java.net/jfx11u/pull/72/files
Webrev: https://webrevs.openjdk.java.net/?repo=jfx11u=72=00
Issue:
Clean backport to jfx17u. CI build passed on three platforms. Tested locally on
macOS.
-
Commit messages:
- 8242544: CMD+ENTER key event crashes the application when invoked on dialog
Changes: https://git.openjdk.java.net/jfx17u/pull/32/files
Webrev:
On Wed, 29 Dec 2021 00:44:44 GMT, Andreas Heger wrote:
> This also solves [JDK-8205915 [macOS] Accelerator assigned to button in
> dialog fires menuItem in owning
> stage](https://bugs.openjdk.java.net/browse/JDK-8205915l).
>
> I must admit that I don't have 100% insight about what actually
On Wed, 12 Jan 2022 16:56:12 GMT, Martin Fox wrote:
>> The OS crashes if the contentView of a window is set to nil while handling
>> processKeyEquivalent. With this PR we just set the contentView to a basic
>> do-nothing NSView for the interim.
>
> Martin Fox has updated the pull request
On Wed, 12 Jan 2022 18:34:19 GMT, Martin Fox wrote:
>> I don't know. I'm always skeptical of 0 size rectangles. I'd either leave it
>> as-is or maybe use a `(0,0,1,1)` rectangle.
>
> The initial size should not matter since it will be re-sized to the window's
> content bounds. But I would
On Wed, 12 Jan 2022 16:56:12 GMT, Martin Fox wrote:
>> The OS crashes if the contentView of a window is set to nil while handling
>> processKeyEquivalent. With this PR we just set the contentView to a basic
>> do-nothing NSView for the interim.
>
> Martin Fox has updated the pull request
On Wed, 12 Jan 2022 18:24:36 GMT, Kevin Rushforth wrote:
>> Martin Fox has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Releasing dummy NSView
>
> modules/javafx.graphics/src/main/native-glass/mac/GlassWindow.m line 849:
>
>> 847:
On Wed, 12 Jan 2022 18:23:20 GMT, Kevin Rushforth wrote:
>> modules/javafx.graphics/src/main/native-glass/mac/GlassWindow.m line 847:
>>
>>> 845: {
>>> 846: // If the contentView is set to nil within
>>> performKeyEquivalent: the OS will crash.
>>> 847: NSView*
On Wed, 12 Jan 2022 16:14:16 GMT, Jose Pereda wrote:
>> Martin Fox has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Releasing dummy NSView
>
> modules/javafx.graphics/src/main/native-glass/mac/GlassWindow.m line 847:
>
>> 845: {
On Wed, 12 Jan 2022 16:56:12 GMT, Martin Fox wrote:
>> The OS crashes if the contentView of a window is set to nil while handling
>> processKeyEquivalent. With this PR we just set the contentView to a basic
>> do-nothing NSView for the interim.
>
> Martin Fox has updated the pull request
> The OS crashes if the contentView of a window is set to nil while handling
> processKeyEquivalent. With this PR we just set the contentView to a basic
> do-nothing NSView for the interim.
Martin Fox has updated the pull request incrementally with one additional
commit since the last
On Wed, 12 Jan 2022 16:24:48 GMT, Kevin Rushforth wrote:
>> modules/javafx.graphics/src/main/native-glass/mac/GlassWindow.m line 848:
>>
>>> 846: // If the contentView is set to nil within
>>> performKeyEquivalent: the OS will crash.
>>> 847: NSView* dummy = [[NSView
On Wed, 12 Jan 2022 16:14:58 GMT, Jose Pereda wrote:
>> The OS crashes if the contentView of a window is set to nil while handling
>> processKeyEquivalent. With this PR we just set the contentView to a basic
>> do-nothing NSView for the interim.
>
>
On Tue, 11 Jan 2022 22:18:53 GMT, Martin Fox wrote:
> The OS crashes if the contentView of a window is set to nil while handling
> processKeyEquivalent. With this PR we just set the contentView to a basic
> do-nothing NSView for the interim.
This PR fixes the JDK-8242544 issue as intended.
On Tue, 11 Jan 2022 22:18:53 GMT, Martin Fox wrote:
> The OS crashes if the contentView of a window is set to nil while handling
> processKeyEquivalent. With this PR we just set the contentView to a basic
> do-nothing NSView for the interim.
In the interest of getting as much testing as
On Tue, 11 Jan 2022 22:18:53 GMT, Martin Fox wrote:
> The OS crashes if the contentView of a window is set to nil while handling
> processKeyEquivalent. With this PR we just set the contentView to a basic
> do-nothing NSView for the interim.
This looks good with the current tools/OS
On Tue, 11 Jan 2022 22:18:53 GMT, Martin Fox wrote:
> The OS crashes if the contentView of a window is set to nil while handling
> processKeyEquivalent. With this PR we just set the contentView to a basic
> do-nothing NSView for the interim.
The fix looks good, and as mentioned above, is
On Tue, 11 Jan 2022 22:18:53 GMT, Martin Fox wrote:
> The OS crashes if the contentView of a window is set to nil while handling
> processKeyEquivalent. With this PR we just set the contentView to a basic
> do-nothing NSView for the interim.
Note: This PR proposes an alternative fix to the
The OS crashes if the contentView of a window is set to nil while handling
processKeyEquivalent. With this PR we just set the contentView to a basic
do-nothing NSView for the interim.
-
Commit messages:
- Prevent OS crash when contentView is set to nil while processing shortcut
On Wed, 29 Dec 2021 00:44:44 GMT, Andreas Heger wrote:
> This also solves [JDK-8205915 [macOS] Accelerator assigned to button in
> dialog fires menuItem in owning
> stage](https://bugs.openjdk.java.net/browse/JDK-8205915l).
>
> I must admit that I don't have 100% insight about what actually
On Wed, 29 Dec 2021 00:44:44 GMT, Andreas Heger wrote:
> This also solves [JDK-8205915 [macOS] Accelerator assigned to button in
> dialog fires menuItem in owning
> stage](https://bugs.openjdk.java.net/browse/JDK-8205915l).
>
> I must admit that I don't have 100% insight about what actually
On Wed, 29 Dec 2021 00:44:44 GMT, Andreas Heger wrote:
> This also solves [JDK-8205915 [macOS] Accelerator assigned to button in
> dialog fires menuItem in owning
> stage](https://bugs.openjdk.java.net/browse/JDK-8205915l).
>
> I must admit that I don't have 100% insight about what actually
On Wed, 29 Dec 2021 00:44:44 GMT, Andreas Heger wrote:
> This also solves [JDK-8205915 [macOS] Accelerator assigned to button in
> dialog fires menuItem in owning
> stage](https://bugs.openjdk.java.net/browse/JDK-8205915l).
>
> I must admit that I don't have 100% insight about what actually
This also solves [JDK-8205915 [macOS] Accelerator assigned to button in dialog
fires menuItem in owning
stage](https://bugs.openjdk.java.net/browse/JDK-8205915l).
I must admit that I don't have 100% insight about what actually caused the
problems and how the event flow completely works.
In
24 matches
Mail list logo
