Re: [jfx11u] RFR: 8263760: Update gradle to version 7.0.1 [v2]

2021-08-23 Thread Kevin Rushforth
On Sun, 22 Aug 2021 11:32:58 GMT, Ambarish Rapte wrote: >> There were two minor merge conflicts in `build.gradle` and one conflict in >> `gradle/wrapper/gradle-wrapper.properties` while cherry picking the change. >> And it also required similar changes to be made for project fxpackager. The >>

Re: [jfx11u] RFR: 8263760: Update gradle to version 7.0.1 [v2]

2021-08-23 Thread Johan Vos
On Sun, 22 Aug 2021 11:32:58 GMT, Ambarish Rapte wrote: >> There were two minor merge conflicts in `build.gradle` and one conflict in >> `gradle/wrapper/gradle-wrapper.properties` while cherry picking the change. >> And it also required similar changes to be made for project fxpackager. The >>

Re: [jfx11u] RFR: 8263760: Update gradle to version 7.0.1 [v2]

2021-08-23 Thread Kevin Rushforth
On Sun, 22 Aug 2021 11:32:58 GMT, Ambarish Rapte wrote: >> There were two minor merge conflicts in `build.gradle` and one conflict in >> `gradle/wrapper/gradle-wrapper.properties` while cherry picking the change. >> And it also required similar changes to be made for project fxpackager. The >>

Re: [jfx11u] RFR: 8263760: Update gradle to version 7.0.1 [v2]

2021-08-23 Thread Kevin Rushforth
On Sun, 22 Aug 2021 11:32:58 GMT, Ambarish Rapte wrote: >> There were two minor merge conflicts in `build.gradle` and one conflict in >> `gradle/wrapper/gradle-wrapper.properties` while cherry picking the change. >> And it also required similar changes to be made for project fxpackager. The >>

Re: [jfx11u] RFR: 8263760: Update gradle to version 7.0.1 [v2]

2021-08-22 Thread Ambarish Rapte
On Fri, 20 Aug 2021 23:18:58 GMT, Kevin Rushforth wrote: >> Ambarish Rapte has updated the pull request incrementally with one >> additional commit since the last revision: >> >> use antpluginImplementation > > build.gradle line 2758: > >> 2756: >> 2757: dependencies { >> 2758:

Re: [jfx11u] RFR: 8263760: Update gradle to version 7.0.1 [v2]

2021-08-22 Thread Ambarish Rapte
> There were two minor merge conflicts in `build.gradle` and one conflict in > `gradle/wrapper/gradle-wrapper.properties` while cherry picking the change. > And it also required similar changes to be made for project fxpackager. The > [first > commit](https://github.com/openjdk/jfx11u/pull/49/c

Re: [jfx11u] RFR: 8263760: Update gradle to version 7.0.1

2021-08-20 Thread Kevin Rushforth
On Fri, 20 Aug 2021 20:13:18 GMT, Ambarish Rapte wrote: > There were two minor merge conflicts in `build.gradle` and one conflict in > `gradle/wrapper/gradle-wrapper.properties` while cherry picking the change. > And it also required similar changes to be made for project fxpackager. The > [fi

[jfx11u] RFR: 8263760: Update gradle to version 7.0.1

2021-08-20 Thread Ambarish Rapte
There were two minor merge conflicts in `build.gradle` and one conflict in `gradle/wrapper/gradle-wrapper.properties` while cherry picking the change. And it also required similar changes to be made for project fxpackager. The [first commit](https://github.com/openjdk/jfx11u/pull/49/commits/770

Re: RFR: 8263760: Update gradle to version 7.0.1 [v2]

2021-05-19 Thread Ambarish Rapte
On Thu, 13 May 2021 21:55:59 GMT, Kevin Rushforth wrote: >> This PR fixes the gradle deprecation warnings described in >> [JDK-8240336](https://bugs.openjdk.java.net/browse/JDK-8240336) and updates >> the JavaFX build to use gradle 7.0.1 as described in >> [JDK-8263760](https://bugs.openjdk.ja

Re: RFR: 8263760: Update gradle to version 7.0.1 [v2]

2021-05-18 Thread Joeri Sykora
On Thu, 13 May 2021 21:55:59 GMT, Kevin Rushforth wrote: >> This PR fixes the gradle deprecation warnings described in >> [JDK-8240336](https://bugs.openjdk.java.net/browse/JDK-8240336) and updates >> the JavaFX build to use gradle 7.0.1 as described in >> [JDK-8263760](https://bugs.openjdk.ja

Re: RFR: 8263760: Update gradle to version 7.0.1 [v2]

2021-05-16 Thread Crazyjavahacking
On Thu, 13 May 2021 21:55:59 GMT, Kevin Rushforth wrote: >> This PR fixes the gradle deprecation warnings described in >> [JDK-8240336](https://bugs.openjdk.java.net/browse/JDK-8240336) and updates >> the JavaFX build to use gradle 7.0.1 as described in >> [JDK-8263760](https://bugs.openjdk.ja

Re: RFR: 8263760: Update gradle to version 7.0.1 [v2]

2021-05-15 Thread Kevin Rushforth
On Fri, 14 May 2021 23:33:44 GMT, Scott Palmer wrote: > Isn't that just the settings for running the gradle wrapper - i.e.  it is not > setting the heap used by the gradle daemon process that will actually run the > build script? Ah yes, you are right. I just verified this with a test build. S

Re: RFR: 8263760: Update gradle to version 7.0.1 [v2]

2021-05-14 Thread Scott Palmer
On Thu, 13 May 2021 21:55:59 GMT, Kevin Rushforth wrote: >> This PR fixes the gradle deprecation warnings described in >> [JDK-8240336](https://bugs.openjdk.java.net/browse/JDK-8240336) and updates >> the JavaFX build to use gradle 7.0.1 as described in >> [JDK-8263760](https://bugs.openjdk.ja

Re: RFR: 8263760: Update gradle to version 7.0.1 [v2]

2021-05-14 Thread Kevin Rushforth
On Thu, 13 May 2021 21:55:59 GMT, Kevin Rushforth wrote: >> This PR fixes the gradle deprecation warnings described in >> [JDK-8240336](https://bugs.openjdk.java.net/browse/JDK-8240336) and updates >> the JavaFX build to use gradle 7.0.1 as described in >> [JDK-8263760](https://bugs.openjdk.ja

Re: RFR: 8263760: Update gradle to version 7.0.1

2021-05-14 Thread Crazyjavahacking
On Thu, 13 May 2021 21:18:33 GMT, Kevin Rushforth wrote: > On closer inspection, I am reverting my earlier change to `gradlew` (the one > that reverted the setting of `DEFAULT_JVM_OPTS` to a 64Mbyte heap). The > `gradle` launcher in gradle 7.0.1 also sets its `DEFAULT_JVM_OPTS` to a > 64Mbyte

Re: RFR: 8263760: Update gradle to version 7.0.1 [v2]

2021-05-13 Thread Kevin Rushforth
> This PR fixes the gradle deprecation warnings described in > [JDK-8240336](https://bugs.openjdk.java.net/browse/JDK-8240336) and updates > the JavaFX build to use gradle 7.0.1 as described in > [JDK-8263760](https://bugs.openjdk.java.net/browse/JDK-8263760). The minimum > version of gradle is

Re: RFR: 8263760: Update gradle to version 7.0.1

2021-05-13 Thread Kevin Rushforth
On Wed, 12 May 2021 14:54:09 GMT, Kevin Rushforth wrote: > This PR fixes the gradle deprecation warnings described in > [JDK-8240336](https://bugs.openjdk.java.net/browse/JDK-8240336) and updates > the JavaFX build to use gradle 7.0.1 as described in > [JDK-8263760](https://bugs.openjdk.java.n

Re: RFR: 8263760: Update gradle to version 7.0.1

2021-05-12 Thread Kevin Rushforth
On Wed, 12 May 2021 17:30:20 GMT, Crazyjavahacking wrote: >> This PR fixes the gradle deprecation warnings described in >> [JDK-8240336](https://bugs.openjdk.java.net/browse/JDK-8240336) and updates >> the JavaFX build to use gradle 7.0.1 as described in >> [JDK-8263760](https://bugs.openjdk.

RFR: 8263760: Update gradle to version 7.0.1

2021-05-12 Thread Kevin Rushforth
This PR fixes the gradle deprecation warnings described in [JDK-8240336](https://bugs.openjdk.java.net/browse/JDK-8240336) and updates the JavaFX build to use gradle 7.0.1 as described in [JDK-8263760](https://bugs.openjdk.java.net/browse/JDK-8263760). The minimum version of gradle is set to 6.

Re: RFR: 8263760: Update gradle to version 7.0.1

2021-05-12 Thread Kevin Rushforth
On Wed, 12 May 2021 17:02:27 GMT, Crazyjavahacking wrote: >> This PR fixes the gradle deprecation warnings described in >> [JDK-8240336](https://bugs.openjdk.java.net/browse/JDK-8240336) and updates >> the JavaFX build to use gradle 7.0.1 as described in >> [JDK-8263760](https://bugs.openjdk.

Re: RFR: 8263760: Update gradle to version 7.0.1

2021-05-12 Thread Crazyjavahacking
On Wed, 12 May 2021 14:54:09 GMT, Kevin Rushforth wrote: > This PR fixes the gradle deprecation warnings described in > [JDK-8240336](https://bugs.openjdk.java.net/browse/JDK-8240336) and updates > the JavaFX build to use gradle 7.0.1 as described in > [JDK-8263760](https://bugs.openjdk.java.n