Re: RFR: 8267059: Gradle :clean and :apps tasks fail on Windows if ANT_HOME contains spaces [v2]

2022-01-07 Thread Joeri Sykora
On Fri, 4 Jun 2021 05:04:17 GMT, Michael Strauß wrote: >> This PR fixes an issue when building OpenJFX on Windows and command-line >> arguments contain paths with spaces. >> >> The problem is that on Windows, `ant` is invoked via `cmd`, which leads to >> quotes being interpreted twice. This ca

Re: RFR: 8267059: Gradle :clean and :apps tasks fail on Windows if ANT_HOME contains spaces [v2]

2022-01-05 Thread Kevin Rushforth
On Fri, 4 Jun 2021 05:04:17 GMT, Michael Strauß wrote: >> This PR fixes an issue when building OpenJFX on Windows and command-line >> arguments contain paths with spaces. >> >> The problem is that on Windows, `ant` is invoked via `cmd`, which leads to >> quotes being interpreted twice. This ca

Re: RFR: 8267059: Gradle :clean and :apps tasks fail on Windows if ANT_HOME contains spaces [v2]

2022-01-05 Thread Michael Strauß
On Fri, 27 Aug 2021 13:39:13 GMT, Kevin Rushforth wrote: >> Michael Strauß has updated the pull request with a new target base due to a >> merge or a rebase. The incremental webrev excludes the unrelated changes >> brought in by the merge/rebase. The pull request contains two additional >> com

Re: RFR: 8267059: Gradle :clean and :apps tasks fail on Windows if ANT_HOME contains spaces [v2]

2021-11-03 Thread drmarmac
On Fri, 4 Jun 2021 05:04:17 GMT, Michael Strauß wrote: >> This PR fixes an issue when building OpenJFX on Windows and command-line >> arguments contain paths with spaces. >> >> The problem is that on Windows, `ant` is invoked via `cmd`, which leads to >> quotes being interpreted twice. This ca

Re: RFR: 8267059: Gradle :clean and :apps tasks fail on Windows if ANT_HOME contains spaces [v2]

2021-11-03 Thread drmarmac
On Wed, 3 Nov 2021 13:12:14 GMT, Erik Joelsson wrote: >> Michael Strauß has updated the pull request with a new target base due to a >> merge or a rebase. The incremental webrev excludes the unrelated changes >> brought in by the merge/rebase. The pull request contains two additional >> commit

Re: RFR: 8267059: Gradle :clean and :apps tasks fail on Windows if ANT_HOME contains spaces [v2]

2021-11-03 Thread Erik Joelsson
On Fri, 4 Jun 2021 05:04:17 GMT, Michael Strauß wrote: >> This PR fixes an issue when building OpenJFX on Windows and command-line >> arguments contain paths with spaces. >> >> The problem is that on Windows, `ant` is invoked via `cmd`, which leads to >> quotes being interpreted twice. This ca

Re: RFR: 8267059: Gradle :clean and :apps tasks fail on Windows if ANT_HOME contains spaces [v2]

2021-08-27 Thread Kevin Rushforth
On Fri, 4 Jun 2021 05:04:17 GMT, Michael Strauß wrote: >> This PR fixes an issue when building OpenJFX on Windows and command-line >> arguments contain paths with spaces. >> >> The problem is that on Windows, `ant` is invoked via `cmd`, which leads to >> quotes being interpreted twice. This ca

Re: RFR: 8267059: Gradle :clean and :apps tasks fail on Windows if ANT_HOME contains spaces [v2]

2021-08-12 Thread Michael Strauß
On Fri, 4 Jun 2021 18:14:50 GMT, Kevin Rushforth wrote: > > On Ubuntu 20.04 ... The :apps task fails before and after the fix > > Maybe something with the version of Java you are using? It runs fine my > system, and the GitHub actions build is fine. It turns out that I encountered the same iss

Re: RFR: 8267059: Gradle :clean and :apps tasks fail on Windows if ANT_HOME contains spaces [v2]

2021-06-04 Thread Kevin Rushforth
On Fri, 4 Jun 2021 05:04:17 GMT, Michael Strauß wrote: >> This PR fixes an issue when building OpenJFX on Windows and command-line >> arguments contain paths with spaces. >> >> The problem is that on Windows, `ant` is invoked via `cmd`, which leads to >> quotes being interpreted twice. This ca

Re: RFR: 8267059: Gradle :clean and :apps tasks fail on Windows if ANT_HOME contains spaces [v2]

2021-06-03 Thread Michael Strauß
On Fri, 4 Jun 2021 05:04:17 GMT, Michael Strauß wrote: >> This PR fixes an issue when building OpenJFX on Windows and command-line >> arguments contain paths with spaces. >> >> The problem is that on Windows, `ant` is invoked via `cmd`, which leads to >> quotes being interpreted twice. This ca

Re: RFR: 8267059: Gradle :clean and :apps tasks fail on Windows if ANT_HOME contains spaces [v2]

2021-06-03 Thread Michael Strauß
> This PR fixes an issue when building OpenJFX on Windows and command-line > arguments contain paths with spaces. > > The problem is that on Windows, `ant` is invoked via `cmd`, which leads to > quotes being interpreted twice. This can be fixed with the option `cmd /s`, > which prevents interpr

Re: RFR: 8267059: Gradle :clean and :apps tasks fail on Windows if ANT_HOME contains spaces

2021-05-13 Thread Kevin Rushforth
On Thu, 13 May 2021 00:07:15 GMT, Michael Strauß wrote: > This PR fixes an issue when building OpenJFX on Windows and command-line > arguments contain paths with spaces. > > The problem is that on Windows, `ant` is invoked via `cmd`, which leads to > quotes being interpreted twice. This can be

RFR: 8267059: Gradle :clean and :apps tasks fail on Windows if ANT_HOME contains spaces

2021-05-12 Thread Michael Strauß
This PR fixes an issue when building OpenJFX on Windows and command-line arguments contain paths with spaces. The problem is that on Windows, `ant` is invoked via `cmd`, which leads to quotes being interpreted twice. This can be fixed with the option `cmd /s`, which prevents interpreting quotes