Re: RFR: 8274066: Polygon filled outside its area when very large coordinates are used [v2]

2022-05-31 Thread Kevin Rushforth
On Wed, 25 May 2022 07:37:38 GMT, Laurent Bourgès wrote: > keep dpqs for corner cases and keep my coding life simple I think this approach is fine. Diverging the code would likely make it less stable, and you answered the question about the provenance of the code, so there's no issue there.

Re: RFR: 8274066: Polygon filled outside its area when very large coordinates are used [v2]

2022-05-25 Thread Laurent Bourgès
On Mon, 10 Jan 2022 00:04:00 GMT, Laurent Bourgès wrote: >> Changelog for this MarlinFX 0.9.4.5 release: >> >> The Marlin-renderer 0.9.4.5 release provides bug fixes on Marlin's path >> clipper: >> - improved Stroker to handle huge coordinates, up to 1E15 >> - improved PathClipFilter (filler)

Re: RFR: 8274066: Polygon filled outside its area when very large coordinates are used [v2]

2022-02-07 Thread Kevin Rushforth
On Mon, 10 Jan 2022 00:04:00 GMT, Laurent Bourgès wrote: >> Changelog for this MarlinFX 0.9.4.5 release: >> >> The Marlin-renderer 0.9.4.5 release provides bug fixes on Marlin's path >> clipper: >> - improved Stroker to handle huge coordinates, up to 1E15 >> - improved PathClipFilter (filler)

Re: RFR: 8274066: Polygon filled outside its area when very large coordinates are used [v2]

2022-02-07 Thread iaroslavski
On Mon, 10 Jan 2022 00:04:00 GMT, Laurent Bourgès wrote: >> Changelog for this MarlinFX 0.9.4.5 release: >> >> The Marlin-renderer 0.9.4.5 release provides bug fixes on Marlin's path >> clipper: >> - improved Stroker to handle huge coordinates, up to 1E15 >> - improved PathClipFilter (filler)

Re: RFR: 8274066: Polygon filled outside its area when very large coordinates are used [v2]

2022-02-05 Thread Laurent Bourgès
On Mon, 10 Jan 2022 00:04:00 GMT, Laurent Bourgès wrote: >> Changelog for this MarlinFX 0.9.4.5 release: >> >> The Marlin-renderer 0.9.4.5 release provides bug fixes on Marlin's path >> clipper: >> - improved Stroker to handle huge coordinates, up to 1E15 >> - improved PathClipFilter (filler)

Re: RFR: 8274066: Polygon filled outside its area when very large coordinates are used [v2]

2022-01-27 Thread Kevin Rushforth
On Mon, 10 Jan 2022 00:04:00 GMT, Laurent Bourgès wrote: >> Changelog for this MarlinFX 0.9.4.5 release: >> >> The Marlin-renderer 0.9.4.5 release provides bug fixes on Marlin's path >> clipper: >> - improved Stroker to handle huge coordinates, up to 1E15 >> - improved PathClipFilter (filler)

Re: RFR: 8274066: Polygon filled outside its area when very large coordinates are used [v2]

2022-01-13 Thread Laurent Bourgès
On Mon, 10 Jan 2022 00:04:00 GMT, Laurent Bourgès wrote: >> Changelog for this MarlinFX 0.9.4.5 release: >> >> The Marlin-renderer 0.9.4.5 release provides bug fixes on Marlin's path >> clipper: >> - improved Stroker to handle huge coordinates, up to 1E15 >> - improved PathClipFilter (filler)

Re: RFR: 8274066: Polygon filled outside its area when very large coordinates are used [v2]

2022-01-13 Thread Johan Vos
On Mon, 10 Jan 2022 00:04:00 GMT, Laurent Bourgès wrote: >> Changelog for this MarlinFX 0.9.4.5 release: >> >> The Marlin-renderer 0.9.4.5 release provides bug fixes on Marlin's path >> clipper: >> - improved Stroker to handle huge coordinates, up to 1E15 >> - improved PathClipFilter (filler)

Re: RFR: 8274066: Polygon filled outside its area when very large coordinates are used [v2]

2022-01-12 Thread Kevin Rushforth
On Mon, 10 Jan 2022 00:04:00 GMT, Laurent Bourgès wrote: >> Changelog for this MarlinFX 0.9.4.5 release: >> >> The Marlin-renderer 0.9.4.5 release provides bug fixes on Marlin's path >> clipper: >> - improved Stroker to handle huge coordinates, up to 1E15 >> - improved PathClipFilter (filler)

Re: RFR: 8274066: Polygon filled outside its area when very large coordinates are used

2022-01-10 Thread Laurent Bourgès
On Fri, 7 Jan 2022 23:35:37 GMT, Kevin Rushforth wrote: >> Changelog for this MarlinFX 0.9.4.5 release: >> >> The Marlin-renderer 0.9.4.5 release provides bug fixes on Marlin's path >> clipper: >> - improved Stroker to handle huge coordinates, up to 1E15 >> - improved PathClipFilter (filler)

Re: RFR: 8274066: Polygon filled outside its area when very large coordinates are used

2022-01-09 Thread Laurent Bourgès
On Fri, 7 Jan 2022 23:39:05 GMT, Laurent Bourgès wrote: > Would a targeted test for the failing case from the bug report make sense? I added the HugePolygonClipTest that fails on jdk11, 17 ... but now passes. - PR: https://git.openjdk.java.net/jfx/pull/674

Re: RFR: 8274066: Polygon filled outside its area when very large coordinates are used [v2]

2022-01-09 Thread Laurent Bourgès
> Changelog for this MarlinFX 0.9.4.5 release: > > The Marlin-renderer 0.9.4.5 release provides bug fixes on Marlin's path > clipper: > - improved Stroker to handle huge coordinates, up to 1E15 > - improved PathClipFilter (filler) to handle huge coordinates, up to 1E15 > > > This is the

Re: RFR: 8274066: Polygon filled outside its area when very large coordinates are used

2022-01-07 Thread Laurent Bourgès
On Fri, 7 Jan 2022 23:35:37 GMT, Kevin Rushforth wrote: > Would a targeted test for the failing case from the bug report make sense? I agree the rule is to have a test, I will write a basic test derived from user's case asap. - PR: https://git.openjdk.java.net/jfx/pull/674

Re: RFR: 8274066: Polygon filled outside its area when very large coordinates are used

2022-01-07 Thread Kevin Rushforth
On Wed, 17 Nov 2021 22:05:25 GMT, Laurent Bourgès wrote: > Changelog for this MarlinFX 0.9.4.5 release: > > The Marlin-renderer 0.9.4.5 release provides bug fixes on Marlin's path > clipper: > - removed simple-precision (float) variant > - improved Stroker to handle huge coordinates, up to

Re: RFR: 8274066: Polygon filled outside its area when very large coordinates are used

2022-01-07 Thread Laurent Bourgès
On Wed, 17 Nov 2021 22:05:25 GMT, Laurent Bourgès wrote: > Changelog for this MarlinFX 0.9.4.5 release: > > The Marlin-renderer 0.9.4.5 release provides bug fixes on Marlin's path > clipper: > - removed simple-precision (float) variant > - improved Stroker to handle huge coordinates, up to

Re: RFR: 8274066: Polygon filled outside its area when very large coordinates are used

2022-01-07 Thread Johan Vos
On Wed, 17 Nov 2021 22:05:25 GMT, Laurent Bourgès wrote: > Draft PR to see how big is the MarlinFX 0.9.4.5 patch (DPQS, Path clipper > fixes to handle huge coords) @bourgesl can you rename the title of this PR to 8274066: Polygon filled outside its area when very large coordinates are used

Re: RFR: 8274066: Polygon filled outside its area when very large coordinates are used

2022-01-07 Thread Laurent Bourgès
On Wed, 17 Nov 2021 22:05:25 GMT, Laurent Bourgès wrote: > Draft PR to see how big is the MarlinFX 0.9.4.5 patch (DPQS, Path clipper > fixes to handle huge coords) I will add changelog asap - PR: https://git.openjdk.java.net/jfx/pull/674

RFR: 8274066: Polygon filled outside its area when very large coordinates are used

2022-01-07 Thread Laurent Bourgès
Draft PR to see how big is the MarlinFX 0.9.4.5 patch (DPQS, Path clipper fixes to handle huge coords) - Commit messages: - fixed jcheck warning (tab) - Merge branch 'openjdk:master' into marlinFX-0.9.4.5 - minor changes (syntax, warnings) + merge with marlin 0.9.4.5 (jdk) -