Re: RFR: 8274771: Map, FlatMap and OrElse fluent bindings for ObservableValue [v5]

2022-01-27 Thread John Hendrikx
On Sun, 16 Jan 2022 22:01:33 GMT, Nir Lisker wrote: > * Most tests that I have seen in JavaFX use the assert overloads that include > a message that explains what the value should be or what it means if the > assertion failed. I don't know how much of a requirement it is. I can help > write

Re: RFR: 8274771: Map, FlatMap and OrElse fluent bindings for ObservableValue [v5]

2022-01-27 Thread John Hendrikx
On Thu, 20 Jan 2022 17:19:49 GMT, Nir Lisker wrote: >> John Hendrikx has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Fix grammar mistakes and did some small rephrases > >

Re: RFR: 8274771: Map, FlatMap and OrElse fluent bindings for ObservableValue [v5]

2022-01-27 Thread John Hendrikx
On Sun, 16 Jan 2022 12:25:13 GMT, Nir Lisker wrote: >> John Hendrikx has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Fix grammar mistakes and did some small rephrases > >

Re: RFR: 8274771: Map, FlatMap and OrElse fluent bindings for ObservableValue [v5]

2022-01-20 Thread Nir Lisker
On Mon, 10 Jan 2022 21:09:15 GMT, John Hendrikx wrote: >> This is an implementation of the proposal in >> https://bugs.openjdk.java.net/browse/JDK-8274771 that me and Nir Lisker >> (@nlisker) have been working on. It's a complete implementation including >> good test coverage. >> >> This

Re: RFR: 8274771: Map, FlatMap and OrElse fluent bindings for ObservableValue [v5]

2022-01-16 Thread Nir Lisker
On Mon, 10 Jan 2022 21:09:15 GMT, John Hendrikx wrote: >> This is an implementation of the proposal in >> https://bugs.openjdk.java.net/browse/JDK-8274771 that me and Nir Lisker >> (@nlisker) have been working on. It's a complete implementation including >> good test coverage. >> >> This

Re: RFR: 8274771: Map, FlatMap and OrElse fluent bindings for ObservableValue [v5]

2022-01-10 Thread John Hendrikx
> This is an implementation of the proposal in > https://bugs.openjdk.java.net/browse/JDK-8274771 that me and Nir Lisker > (@nlisker) have been working on. It's a complete implementation including > good test coverage. > > This was based on https://github.com/openjdk/jfx/pull/434 but with a