On Thu, 27 Jan 2022 15:21:33 GMT, Marius Hanl wrote:
>> just for reference - found the source of my [faintly
>> remember](https://github.com/openjdk/jfx/pull/337/files/8a6fc1cf6cad2c453de17b71777ddd63fadb539e#r510975640)
>
> I see. Unfortunately though that was not done consistently during the
On Thu, 27 Jan 2022 12:46:19 GMT, Jeanette Winzenburg
wrote:
>> ah okay. Was just confusing for me since I never read that and I think some
>> recent PRs still had this pattern, e.g. also the touch table scrolling PR I
>> had a look at yesterday.
>>
>> Maybe for future it makes sense to have
On Thu, 27 Jan 2022 11:42:28 GMT, Marius Hanl wrote:
>>> Hm, is this really needed?
>>
>> yes, IMO, we want the exact same cleanup for passing/failing tests. So
>> either dispose is required always (then need to make sure it's called on
>> failure) or not required always (then all its calls
On Thu, 27 Jan 2022 10:18:31 GMT, Jeanette Winzenburg
wrote:
>> Hm, is this really needed? Not sure, are there any side effects by the
>> `StageLoader` like this when a test failed?
>> Just asking since the `StageLoader` is used a lot like this.
>> And since the tests normally run green unless
On Wed, 26 Jan 2022 20:14:37 GMT, Marius Hanl wrote:
> Hm, is this really needed?
yes, IMO, we want the exact same cleanup for passing/failing tests. So either
dispose is required always (then need to make sure it's called on failure) or
not required always (then all its calls would be
On Tue, 25 Jan 2022 13:45:54 GMT, Jeanette Winzenburg
wrote:
>> Marius Hanl has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> 8277122: Added test for setting a negative divider position + improved
>> readability
>
>
On Tue, 25 Jan 2022 13:38:53 GMT, Jeanette Winzenburg
wrote:
>> Marius Hanl has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> 8277122: Added test for setting a negative divider position + improved
>> readability
>
>
On Mon, 22 Nov 2021 14:03:56 GMT, Marius Hanl wrote:
>> When a divider is moved via drag or code it will call **requestLayout()**
>> for the **SplitPane**.
>> While this is fine, it is also called when the
>> **SplitPaneSkin#layoutChildren(..)** method is repositioning the divider.
>>
>> This
> When a divider is moved via drag or code it will call **requestLayout()** for
> the **SplitPane**.
> While this is fine, it is also called when the
> **SplitPaneSkin#layoutChildren(..)** method is repositioning the divider.
>
> This makes no sense since we are currently layouting everything,
