On Thu, 12 Jan 2023 03:08:30 GMT, Michael Strauß wrote:
> When a scene graph contains multiple nested focused nodes (this can happen
> with `TableView` and other controls), the `focusWithin` bits that are cleared
> when a focused node is de-focused must only be cleared when there is no other
>
When a scene graph contains multiple nested focused nodes (this can happen with
`TableView` and other controls), the `focusWithin` bits that are cleared when a
focused node is de-focused must only be cleared when there is no other nested
node in the scene graph that would also cause `focusWithin
On Wed, 11 Jan 2023 23:04:15 GMT, Kevin Rushforth wrote:
> I'll need a bit more time to run CI test builds again. I'm thinking it might
> be better to get this in early in JavaFX 21 rather than late in JavaFX 20
> anyway.
I agree, especially considering the change required for JDK 17 GA. Besid
On Wed, 11 Jan 2023 14:58:07 GMT, Jay Bhaskar wrote:
>> Roman Marchenko has updated the pull request with a new target base due to a
>> merge or a rebase. The pull request now contains one commit:
>>
>> Fixed the opacity issue
>
> The patch looks ok, as [GraphicsContextJava.h] needs to inheri
On Wed, 11 Jan 2023 18:58:44 GMT, Roman Marchenko
wrote:
>> There was refactoring in WebKit's GraphicsContext class (nativecode)
>> https://github.com/WebKit/WebKit/commit/1733b8bc3dff7595ab8e42561fc0f20a2b8fee63
>>
>>
>> GraphicsContextJava's methods begin/endPlatformTransparencyLayers were
On Tue, 10 Jan 2023 18:30:48 GMT, John Neffenger wrote:
>> This pull request allows for reproducible builds of JavaFX on Linux, macOS,
>> and Windows by defining the `SOURCE_DATE_EPOCH` environment variable. For
>> example, the following commands create a reproducible build:
>>
>>
>> $ export
On Tue, 3 Jan 2023 00:21:53 GMT, John Neffenger wrote:
>> This pull request allows for reproducible builds of JavaFX on Linux, macOS,
>> and Windows by defining the `SOURCE_DATE_EPOCH` environment variable. For
>> example, the following commands create a reproducible build:
>>
>>
>> $ export
On Wed, 11 Jan 2023 09:22:07 GMT, Florian Kirmaier
wrote:
>> This PR fixes the leak in the mac system menu bar.
>>
>> Inside the native code, NewGlobalRef is called for the callable.
>> Which makes it into a "GC-Root" until DeleteGlobalRef is called.
>>
>> The DeleteGlobalRef is never called f
> There was refactoring in WebKit's GraphicsContext class (nativecode)
> https://github.com/WebKit/WebKit/commit/1733b8bc3dff7595ab8e42561fc0f20a2b8fee63
>
>
> GraphicsContextJava's methods begin/endPlatformTransparencyLayers weren't
> adapted after GraphicsContext's refactoring integration in
> There was refactoring in WebKit's GraphicsContext class (nativecode)
> https://github.com/WebKit/WebKit/commit/1733b8bc3dff7595ab8e42561fc0f20a2b8fee63
>
>
> GraphicsContextJava's methods begin/endPlatformTransparencyLayers weren't
> adapted after GraphicsContext's refactoring integration in
On Wed, 11 Jan 2023 16:24:04 GMT, Kevin Rushforth wrote:
>> Roman Marchenko has updated the pull request with a new target base due to a
>> merge or a rebase. The pull request now contains one commit:
>>
>> Fixed the opacity issue
>
> I might add it elsewhere (either to a different test class
> There was refactoring in WebKit's GraphicsContext class (nativecode)
> https://github.com/WebKit/WebKit/commit/1733b8bc3dff7595ab8e42561fc0f20a2b8fee63
>
>
> GraphicsContextJava's methods begin/endPlatformTransparencyLayers weren't
> adapted after GraphicsContext's refactoring integration in
On Sun, 25 Dec 2022 04:04:40 GMT, Nir Lisker wrote:
>> Refactoring and renaming changes to some of the D3D pipeline files and a few
>> changes on the Java side. These are various "leftovers" from previous issues
>> that we didn't want to touch at the time in order to confine the scope of
>> th
On Wed, 11 Jan 2023 15:54:25 GMT, John Hendrikx wrote:
> Here is one that passed with the old version, which highlights the standard
> gotcha's of all uses of weak references:
>
> ```
> @Test
> public void testWeakRefDoesntDisappearUnexpectedly() {
> List changes = new ArrayList<>();
>
>
As a reminder, JavaFX 20 RDP1 starts tomorrow, January 12th. I will fork
the 'jfx20' branch at 16:00 UTC (it might be 15 or 20 minutes after
that, but don't count on it).
-- Kevin
On 12/19/2022 12:10 PM, Kevin Rushforth wrote:
As a reminder, Rampdown Phase 1 (RDP1) for JavaFX 20 starts on Janu
On Wed, 11 Jan 2023 07:50:39 GMT, Roman Marchenko
wrote:
>> There was refactoring in WebKit's GraphicsContext class (nativecode)
>> https://github.com/WebKit/WebKit/commit/1733b8bc3dff7595ab8e42561fc0f20a2b8fee63
>>
>>
>> GraphicsContextJava's methods begin/endPlatformTransparencyLayers were
On Wed, 11 Jan 2023 07:50:39 GMT, Roman Marchenko
wrote:
>> There was refactoring in WebKit's GraphicsContext class (nativecode)
>> https://github.com/WebKit/WebKit/commit/1733b8bc3dff7595ab8e42561fc0f20a2b8fee63
>>
>>
>> GraphicsContextJava's methods begin/endPlatformTransparencyLayers were
On Wed, 11 Jan 2023 13:09:37 GMT, Florian Kirmaier
wrote:
> > Should I expect x here to be unreferenced? No, that's how properties work,
> > b will keep its reference to x.
>
> No, x is not dereferenced. But you should expect that a is no longer
> referencing b, but both a and b are referenci
On Wed, 11 Jan 2023 15:47:38 GMT, Roman Marchenko
wrote:
> > @wkia Would it be possible to provide a unit test that fails before and
> > passes after this fix?
>
> @kevinrushforth I will try, I guess it will take time.
If it ends up being too difficult or time-consuming, it could be done in a
On Wed, 11 Jan 2023 07:49:50 GMT, Roman Marchenko
wrote:
>> There was refactoring in WebKit's GraphicsContext class (nativecode)
>> https://github.com/WebKit/WebKit/commit/1733b8bc3dff7595ab8e42561fc0f20a2b8fee63
>>
>>
>> GraphicsContextJava's methods begin/endPlatformTransparencyLayers were
On Tue, 3 Jan 2023 06:37:14 GMT, John Neffenger wrote:
> I just discovered that the `--date` argument for the `jmod` tool was
> back-ported to JDK 17, so I didn't need to wait for JDK 19 after all! Oh well.
Actually, it turns out I did have to wait for JDK 19 after all. Before reaching
version
On Wed, 11 Jan 2023 14:58:07 GMT, Jay Bhaskar wrote:
>> Roman Marchenko has updated the pull request with a new target base due to a
>> merge or a rebase. The pull request now contains one commit:
>>
>> Fixed the opacity issue
>
> The patch looks ok, as [GraphicsContextJava.h] needs to inheri
On Wed, 11 Jan 2023 07:50:39 GMT, Roman Marchenko
wrote:
>> There was refactoring in WebKit's GraphicsContext class (nativecode)
>> https://github.com/WebKit/WebKit/commit/1733b8bc3dff7595ab8e42561fc0f20a2b8fee63
>>
>>
>> GraphicsContextJava's methods begin/endPlatformTransparencyLayers were
On Tue, 10 Jan 2023 22:43:30 GMT, Nir Lisker wrote:
> > Btw, I can confirm that yes, this fixed it for me. Specifically, commit
> > [55fe2dc](https://github.com/openjdk/jfx/commit/55fe2dc7371f6dcb12c414c5d672728e47e9c504)
> > has resolved my issue.
>
> If you have time, it would be interesting
On Wed, 11 Jan 2023 07:50:39 GMT, Roman Marchenko
wrote:
>> There was refactoring in WebKit's GraphicsContext class (nativecode)
>> https://github.com/WebKit/WebKit/commit/1733b8bc3dff7595ab8e42561fc0f20a2b8fee63
>>
>>
>> GraphicsContextJava's methods begin/endPlatformTransparencyLayers were
On Wed, 11 Jan 2023 11:11:09 GMT, John Hendrikx wrote:
> Should I expect x here to be unreferenced? No, that's how properties work, b
> will keep its reference to x.
No, x is not dereferenced. But you should expect that a is no longer
referencing b, but both a and b are referencing x.
But I d
On Tue, 10 Jan 2023 18:30:48 GMT, John Neffenger wrote:
>> This pull request allows for reproducible builds of JavaFX on Linux, macOS,
>> and Windows by defining the `SOURCE_DATE_EPOCH` environment variable. For
>> example, the following commands create a reproducible build:
>>
>>
>> $ export
On Wed, 11 Jan 2023 07:49:50 GMT, Roman Marchenko
wrote:
> force-pushed to trigger the tests.
In the future, you can just push an empty commit.
-
PR: https://git.openjdk.org/jfx/pull/992
On Wed, 11 Jan 2023 07:50:39 GMT, Roman Marchenko
wrote:
>> There was refactoring in WebKit's GraphicsContext class (nativecode)
>> https://github.com/WebKit/WebKit/commit/1733b8bc3dff7595ab8e42561fc0f20a2b8fee63
>>
>>
>> GraphicsContextJava's methods begin/endPlatformTransparencyLayers were
On Fri, 19 Aug 2022 10:40:01 GMT, Florian Kirmaier
wrote:
>> Making the initial listener of the ListProperty weak fixes the problem.
>> The same is fixed for Set and Map.
>> Due to a smart implementation, this is done without any performance drawback.
>> (The trick is to have an object, which is
On Thu, 5 Jan 2023 16:15:38 GMT, Michael Strauß wrote:
>> I've tested this version with explicit GC, and it still worked. So i guess
>> it's stable.
>>
>> Ok, so now there are multiple Solutions:
>>
>> 1. Revert to the previous version, and remove the WeakReference again.
>> 2. Add an explicit
> This PR fixes the leak in the mac system menu bar.
>
> Inside the native code, NewGlobalRef is called for the callable.
> Which makes it into a "GC-Root" until DeleteGlobalRef is called.
>
> The DeleteGlobalRef is never called for the MenuEntry, if it's removed from
> the menu without removing
32 matches
Mail list logo
