On Mon, 25 Mar 2024 22:36:48 GMT, Andy Goryachev wrote:
>> Further changes to the MonkeyTester application:
>>
>> - remember split pane divider ✔
>> - use 'private' instead of 'protected' in many cases ✔
>> - added more scripts to the 'writing systems' text sample ✔
>> - added RTL window
On Tue, 26 Mar 2024 21:27:49 GMT, drmarmac wrote:
>> This PR extends the range of hi-res images that are loaded via naming
>> convention, now including scale factors higher than `@2x`.
>> Supporting these is already being
>>
On Tue, 26 Mar 2024 21:32:16 GMT, Andy Goryachev wrote:
> > * Use modulo arithmetic to compute the value (what this PR proposed)
> > * Don't process the increment at all (i.e., treat it as an out-of-range
> > request and do nothing)
>
> 3. fall back to amountToStepBy=1
>
> try this: integer
On Sun, 24 Mar 2024 15:11:16 GMT, drmarmac wrote:
> This PR should fix the issue and cover all relevant cases with new tests.
>
> Note: This involves a small behavior change, as can be seen in
> dblSpinner_testWrapAround_decrement_twoSteps() in SpinnerTest.java:749. With
> this change the
> This PR extends the range of hi-res images that are loaded via naming
> convention, now including scale factors higher than `@2x`.
> Supporting these is already being
> [recommended](https://developer.apple.com/design/human-interface-guidelines/images#Best-practices)
> for some platforms.
>
On Fri, 22 Mar 2024 16:17:29 GMT, drmarmac wrote:
> This PR extends the range of hi-res images that are loaded via naming
> convention, now including scale factors higher than `@2x`.
> Supporting these is already being
>
On Sun, 24 Mar 2024 15:11:16 GMT, drmarmac wrote:
> This PR should fix the issue and cover all relevant cases with new tests.
>
> Note: This involves a small behavior change, as can be seen in
> dblSpinner_testWrapAround_decrement_twoSteps() in SpinnerTest.java:749. With
> this change the
On Tue, 26 Mar 2024 20:25:19 GMT, Andy Goryachev wrote:
> The real issue is when we have wrapAround enabled and either a large
> amountToStepBy or the argument for increase/decrease exceeding the (max -
> min) value. This simply makes no sense, and the modulo arithmetic produces,
> in my
On Tue, 26 Mar 2024 20:49:00 GMT, Marius Hanl wrote:
> Yes, it should!
Thank you so much for the code and explanations!
I'll try to do a formal review tomorrow, using Labeled.truncated as a test bed.
-
PR Comment: https://git.openjdk.org/jfx/pull/1422#issuecomment-2021457118
On Tue, 26 Mar 2024 20:47:37 GMT, Marius Hanl wrote:
>> In https://github.com/openjdk/jfx/pull/1405, I identified some shortcomings
>> of the stub font implementation. As I don't want to clutter the PR with
>> that, I decided to cherrypick the improvements I did to a new ticket and PR.
>>
>>
On Tue, 26 Mar 2024 20:25:07 GMT, Marius Hanl wrote:
>> I am not sure why this is needed here, so my concern stems from the fact
>> that `ceil()` might introduce a large bias (0.01 -> 1.0), and `rnd()`
>> _seems_ to be a better choice.
>>
>> But then again, ceil() or rnd() might be a
On Mon, 25 Mar 2024 23:00:25 GMT, Marius Hanl wrote:
>> modules/javafx.graphics/src/test/java/test/com/sun/javafx/pgstub/StubFontLoader.java
>> line 76:
>>
>>> 74: FontHelper.setNativeFont(font, nativeFont,
>>> font.getName(), "Amble LtCn", "Regular");
>>> 75:
On Tue, 26 Mar 2024 20:40:11 GMT, Andy Goryachev wrote:
> If I write a test that uses the StubToolkit, one that requires some kind of
> font metrics - would that work? Will I get some kind of semi-valid values for
> preferred width of a text (Text, Labeled, etc.), or I cannot really rely on
>
> In https://github.com/openjdk/jfx/pull/1405, I identified some shortcomings
> of the stub font implementation. As I don't want to clutter the PR with that,
> I decided to cherrypick the improvements I did to a new ticket and PR.
>
> The current implementation has the following shortcomings:
>
On Thu, 21 Mar 2024 22:06:42 GMT, Marius Hanl wrote:
> In https://github.com/openjdk/jfx/pull/1405, I identified some shortcomings
> of the stub font implementation. As I don't want to clutter the PR with that,
> I decided to cherrypick the improvements I did to a new ticket and PR.
>
> The
On Sun, 24 Mar 2024 15:11:16 GMT, drmarmac wrote:
> This PR should fix the issue and cover all relevant cases with new tests.
>
> Note: This involves a small behavior change, as can be seen in
> dblSpinner_testWrapAround_decrement_twoSteps() in SpinnerTest.java:749. With
> this change the
On Sun, 24 Mar 2024 15:11:16 GMT, drmarmac wrote:
> This PR should fix the issue and cover all relevant cases with new tests.
>
> Note: This involves a small behavior change, as can be seen in
> dblSpinner_testWrapAround_decrement_twoSteps() in SpinnerTest.java:749. With
> this change the
On Mon, 25 Mar 2024 23:11:12 GMT, Andy Goryachev wrote:
>> AFAIK, we do not have other tests with that problem.
>> I tried to keep the diff small, but nothing against writing a better method
>> to compare the points here with a delta.
>
> I am not sure why this is needed here, so my concern
On Fri, 22 Mar 2024 16:17:29 GMT, drmarmac wrote:
> This PR extends the range of hi-res images that are loaded via naming
> convention, now including scale factors higher than `@2x`.
> Supporting these is already being
>
On Fri, 22 Mar 2024 16:17:29 GMT, drmarmac wrote:
> This PR extends the range of hi-res images that are loaded via naming
> convention, now including scale factors higher than `@2x`.
> Supporting these is already being
>
Hi Andy
Thank you for your respond and the explanation for the observed behavior.
"Do I understand it correctly from this stackoverflow posting that the
problem is a momentary adjustment of the columns when the vertical scroll
bar appears? And that it works correctly otherwise?
Yes, it works
On Thu, 7 Mar 2024 11:47:10 GMT, Lukasz Kostyra wrote:
>> Fixed as described in the issue + added tests to check for this scenario
>> with all Transform sub classes. Since the test scenario slightly exceeding
>> the regular parametrized testing of `TransformOperationsTest` I decided to
>>
On Fri, 16 Feb 2024 22:35:49 GMT, Martin Fox wrote:
> At the end of a drag operation the Mac Glass code sends out a DRAG_DONE event
> using the operation mask tracked in the GlassDragSource to determine the
> final transfer mode. That mask is only updated when a window in the JavaFX
> app is
On Tue, 26 Mar 2024 18:26:00 GMT, Kevin Rushforth wrote:
> I'm not sure how much value there is in moving the files under a "src"
> directory
Thank you Kevin for the feedback! I had problems configuring the project with
sources being in the root, but will take another look.
-
On Fri, 23 Feb 2024 21:58:37 GMT, Michael Strauß wrote:
>> Platform preferences detection doesn't pick up effective macOS system
>> preferences if AWT owns the NSApplication and has set its NSAppearance to a
>> fixed value.
>>
>> The workaround is to set the system property
>>
On Wed, 20 Mar 2024 20:21:30 GMT, Andy Goryachev wrote:
> ## ManualTestWindow
>
> This facility provides a framework for manual tests to display test
> instructions, test pane, and Pass/Fail buttons.
>
> A simple test would look like this:
>
>
> public class SampleManualTest {
> public
On Tue, 26 Mar 2024 06:30:49 GMT, Jayathirth D V wrote:
>> This test has failed once and we are not seeing its failure after that
>> instance in our test systems.
>>
>> This test verifies whether bounds of GridPane gets updated properly on
>> adding an invisible node.
>> Initial test has 8
On Tue, 26 Mar 2024 09:59:24 GMT, Karthik P K wrote:
>> Andy Goryachev has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> spinner
>
> tests/manual/monkey/src/com/oracle/tools/fx/monkey/settings/FxSettingsSchema.java
> line 280:
>
>> 278:
On Wed, 6 Mar 2024 19:55:54 GMT, Andy Goryachev wrote:
> Adding alt-ctrl-LEFT/RIGHT (option-command-LEFT/RIGHT) key bindings to
>
> - ListView
> - TreeView
> - TableView
> - TreeTableView
>
> to support keyboard-only horizontal scrolling. The main reason for the
> change is to improve
On Thu, 21 Mar 2024 21:50:37 GMT, Andy Goryachev wrote:
> Using Eclipse IDE to remove unused imports in **demo apps** (3D, Ensemble,
> etc.) and update the copyright year to 2024. Using wildcard for more than 10
> static imports.
>
>
> --
>
> This is a trivial change (though fairly large),
Adding alt-ctrl-LEFT/RIGHT (option-command-LEFT/RIGHT) key bindings to
- ListView
- TreeView
- TableView
- TreeTableView
to support keyboard-only horizontal scrolling. The main reason for the change
is to improve accessibility.
As far as I can tell, these key combinations do not interfere
On Tue, 26 Mar 2024 16:49:58 GMT, Kevin Rushforth wrote:
> 1. Should we have at least a soft recommendation or leave it unspecified?
I would rather leave it unspecified.
My concern is that different IDEs might have different sort orders by defaul
(now or in the future) and then we have a
On Tue, 26 Mar 2024 16:38:07 GMT, Andy Goryachev wrote:
> > We should replace this with the recommended sort order.
>
> My 2 cents would be on the other side: I would strongly recommend **against**
> enforcing a specific order, especially since it causes no issues. We should
> avoid
On Tue, 26 Mar 2024 16:32:41 GMT, Kevin Rushforth wrote:
> We should replace this with the recommended sort order.
My 2 cents would be on the other side: I would strongly recommend **against**
enforcing a specific order, especially since it causes no issues. We should
avoid wildcards, yes
On Sun, 24 Mar 2024 15:10:22 GMT, drmarmac wrote:
> This PR removes potentially incorrect usages of Stream.peek().
> The changed code should be covered by the tests that are already present.
modules/javafx.controls/src/main/java/javafx/scene/control/ControlUtils.java
line 176:
> 174:
On Thu, 21 Mar 2024 21:50:37 GMT, Andy Goryachev wrote:
> Using Eclipse IDE to remove unused imports in **demo apps** (3D, Ensemble,
> etc.) and update the copyright year to 2024. Using wildcard for more than 10
> static imports.
>
>
> --
>
> This is a trivial change (though fairly large),
On Tue, 26 Mar 2024 16:16:37 GMT, Kevin Rushforth wrote:
>> this is how the IDE formatter is currently configured - it should not
>> matter, especially since it dos not use wildcards (except for static
>> imports).
>
> While it doesn't matter from a correctness point of view, if we are going
On Thu, 21 Mar 2024 22:35:22 GMT, Andy Goryachev wrote:
>> apps/samples/Ensemble8/src/app/java/ensemble/samplepage/Description.java
>> line 55:
>>
>>> 53: import ensemble.SampleInfo;
>>> 54: import ensemble.SampleInfo.URL;
>>> 55: import ensemble.generated.Samples;
>>
>> I see that
On Tue, 26 Mar 2024 07:01:02 GMT, Hima Bindu Meda wrote:
>> Andy Goryachev has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> removed swing file
>
>
On Tue, 26 Mar 2024 06:30:49 GMT, Jayathirth D V wrote:
>> This test has failed once and we are not seeing its failure after that
>> instance in our test systems.
>>
>> This test verifies whether bounds of GridPane gets updated properly on
>> adding an invisible node.
>> Initial test has 8
Hi there.
Thank you for bringing this up in the mailing list (we **do not** monitor
stackoverflow).
Do I understand it correctly from this stackoverflow posting that the problem
is a momentary adjustment of the columns when the vertical scroll bar appears?
And that it works correctly
On Fri, 22 Mar 2024 16:17:29 GMT, drmarmac wrote:
> This PR extends the range of hi-res images that are loaded via naming
> convention, now including scale factors higher than `@2x`.
> Supporting these is already being
>
On Fri, 22 Mar 2024 16:17:29 GMT, drmarmac wrote:
> This PR extends the range of hi-res images that are loaded via naming
> convention, now including scale factors higher than `@2x`.
> Supporting these is already being
>
Please see this Stack Overflow post where I have tried my best to document
what is going on:
https://stackoverflow.com/questions/77369768/javafx-tableview-text-in-the-cells-of-the-columns-seems-to-jump
Seems to be an issue with CONSTRAINED_RESIZE_POLICY_ALL_COLUMNS when
drawing the table for the
On Mon, 15 Jan 2024 08:31:59 GMT, Florian Kirmaier
wrote:
>> As seen in the unit test of the PR, when we click on the area above/below
>> the scrollbar the position jumps - but the jump is now not always consistent.
>> In the current version on the last cell - the UI always jumps to the top.
On Mon, 15 Jan 2024 08:31:59 GMT, Florian Kirmaier
wrote:
>> As seen in the unit test of the PR, when we click on the area above/below
>> the scrollbar the position jumps - but the jump is now not always consistent.
>> In the current version on the last cell - the UI always jumps to the top.
On Mon, 25 Mar 2024 22:36:48 GMT, Andy Goryachev wrote:
>> Further changes to the MonkeyTester application:
>>
>> - remember split pane divider ✔
>> - use 'private' instead of 'protected' in many cases ✔
>> - added more scripts to the 'writing systems' text sample ✔
>> - added RTL window
On Fri, 22 Mar 2024 16:11:52 GMT, Andy Goryachev wrote:
>> Using Eclipse IDE to remove unused imports **javafx.web** module, and update
>> the copyright year to 2024. Using wildcard for more than 10 static imports.
>>
>>
>> --
>>
>> This is a trivial change, 1 reviewer is probably enough.
>
On Fri, 22 Mar 2024 16:11:52 GMT, Andy Goryachev wrote:
>> Using Eclipse IDE to remove unused imports **javafx.web** module, and update
>> the copyright year to 2024. Using wildcard for more than 10 static imports.
>>
>>
>> --
>>
>> This is a trivial change, 1 reviewer is probably enough.
>
> This test has failed once and we are not seeing its failure after that
> instance in our test systems.
>
> This test verifies whether bounds of GridPane gets updated properly on adding
> an invisible node.
> Initial test has 8 nodes in GridPane and then we update it with another node
> with
On Mon, 25 Mar 2024 16:40:56 GMT, Andy Goryachev wrote:
>> This test has failed once and we are not seeing its failure after that
>> instance in our test systems.
>>
>> This test verifies whether bounds of GridPane gets updated properly on
>> adding an invisible node.
>> Initial test has 8
On Mon, 25 Mar 2024 14:26:10 GMT, Kevin Rushforth wrote:
>> This test has failed once and we are not seeing its failure after that
>> instance in our test systems.
>>
>> This test verifies whether bounds of GridPane gets updated properly on
>> adding an invisible node.
>> Initial test has 8
52 matches
Mail list logo
