Re: RFR: 8092272: [D3D 3D] Need a robust 3D states management for texture [v2]

2025-07-18 Thread Nir Lisker
On Sat, 19 Jul 2025 00:34:46 GMT, Xavier Pedraza wrote: > Paying a visit here after writing [this SO > answer](https://stackoverflow.com/a/79706844/10808904), any reason this PR > died? Appreciate any and all responses. The PR is not really dead, it's hibernating :) The reason is that there's

Re: RFR: 8092272: [D3D 3D] Need a robust 3D states management for texture [v2]

2025-07-18 Thread Xavier Pedraza
On Fri, 10 Nov 2023 23:39:21 GMT, Nir Lisker wrote: >> Moves the filter setting of the samplers from the device parameters >> configuration to the use-site, allowing for dynamic changes in the sampler. >> This PR does internal plumbing work only to bring it close to the ES2 >> pipeline. A foll

Re: RFR: 8271024: Implement macOS Metal Rendering Pipeline [v8]

2025-07-18 Thread Kevin Rushforth
On Fri, 18 Jul 2025 17:54:46 GMT, Ambarish Rapte wrote: >> Good catch. I think this should throw a `RuntimeException` of some sort. > > We throw an InternalError from MTLResourceFactory.createStockShader() if > shader creation fails. For matching changed here to use InternalError. If not > Ok,

Re: RFR: 8324941: POC for Headless platform for JavaFX [v4]

2025-07-18 Thread Andy Goryachev
On Fri, 18 Jul 2025 07:34:01 GMT, Johan Vos wrote: > Do you refer to the Node.snapshot()? In my case, it was Scene::snapshot(), but basically the question is where the screen size has any effect? Robot? It does not seem to impact Scene::snapshot. (I've used the standalone Monkey Tester wit

Re: RFR: 8271024: Implement macOS Metal Rendering Pipeline [v8]

2025-07-18 Thread Andy Goryachev
On Fri, 18 Jul 2025 18:08:34 GMT, Andy Goryachev wrote: >> Changed accordingly and included another check to verify if the `val` is >> already a power of two. > > This code (in my experience) is easy to get wrong. > Could we add some tests, to verify that > - values within the allowed range (sma

Re: RFR: 8271024: Implement macOS Metal Rendering Pipeline [v8]

2025-07-18 Thread Andy Goryachev
On Fri, 18 Jul 2025 17:54:11 GMT, Ambarish Rapte wrote: >> modules/javafx.graphics/src/main/java/com/sun/prism/mtl/MTLResourceFactory.java >> line 75: >> >>> 73: i *= 2; >>> 74: } >>> 75: return i; >> >> interesting... would `1 << val` be simpler (barring overflow)

Re: RFR: 8271024: Implement macOS Metal Rendering Pipeline [v8]

2025-07-18 Thread Ambarish Rapte
On Wed, 16 Jul 2025 19:44:29 GMT, Kevin Rushforth wrote: >> modules/javafx.graphics/src/main/java/com/sun/prism/mtl/MTLShader.java line >> 57: >> >>> 55: shaderMap.put(fragmentFunctionName, this); >>> 56: } else { >>> 57: throw new AssertionError("Failed to creat

Re: RFR: 8271024: Implement macOS Metal Rendering Pipeline [v8]

2025-07-18 Thread Ambarish Rapte
On Wed, 16 Jul 2025 19:02:32 GMT, Andy Goryachev wrote: > first batch of comments (java), mostly questions and minor suggestions. will > review the native code next. Thanks for the review Andy... I addressed most of the comments, but a few which are existing code for es2 pipeline and metal cod

Re: RFR: 8271024: Implement macOS Metal Rendering Pipeline [v9]

2025-07-18 Thread Ambarish Rapte
> ### Description > This is the implementation of new graphics rendering pipeline for JavaFX > using Metal APIs on MacOS. > We released two Early Access (EA) builds and have reached a stage where it is > ready to be integrated. > Default rendering pipeline on macOS has not been changed by this PR

Re: RFR: 8324941: POC for Headless platform for JavaFX [v9]

2025-07-18 Thread Johan Vos
On Tue, 15 Jul 2025 01:11:14 GMT, Kevin Rushforth wrote: > Even if this remains a testing feature, how should it eventually be > configured? Using system properties? Some sort of config file? Something else? This was discussed in a number of comments as well, and the suggested approach is to l

Re: RFR: 8324941: POC for Headless platform for JavaFX [v9]

2025-07-18 Thread Johan Vos
On Wed, 16 Jul 2025 01:56:21 GMT, John Hendrikx wrote: > > > The first question is: Does this have any use case beyond testing? > > > > > > Good question, and the answer is "Yes, absolutely". One of the main drivers > > for this was a project where PDF prints need to be generated server-side,

Re: RFR: 8324941: POC for Headless platform for JavaFX [v10]

2025-07-18 Thread Johan Vos
> After spending a year in the sandbox repository, the Headless Platform is now > ready to be reviewed in the main repository. > > ### the Headless Platform > The Headless Platform is a top-level com.sun.glass.ui platform that replaces > the second-level Monocle-Headless subplatform, that is par

Re: RFR: 8324941: POC for Headless platform for JavaFX [v9]

2025-07-18 Thread Johan Vos
On Mon, 14 Jul 2025 22:17:56 GMT, Kevin Rushforth wrote: >> Johan Vos has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Specify A as a double. > > modules/javafx.graphics/src/main/java/com/sun/glass/ui/headless/HeadlessApplication.java >

Re: RFR: 8324941: POC for Headless platform for JavaFX [v4]

2025-07-18 Thread Johan Vos
On Fri, 27 Jun 2025 20:38:56 GMT, Andy Goryachev wrote: > Question: While the screen size is limited in this version to 1000x1000, the > size of the snapshot exceeds that. Is that expected? Good question. Do you refer to the Node.snapshot()? The definition of "screen size" is a bit vague on hea

Re: RFR: 8324941: POC for Headless platform for JavaFX [v4]

2025-07-18 Thread Johan Vos
On Fri, 27 Jun 2025 19:12:32 GMT, Andy Goryachev wrote: >> Johan Vos has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Process reviewer comments > > modules/javafx.graphics/src/main/java/com/sun/glass/ui/headless/HeadlessRobot.java > line

Re: RFR: 8324941: POC for Headless platform for JavaFX [v4]

2025-07-18 Thread Johan Vos
On Fri, 27 Jun 2025 19:08:48 GMT, Andy Goryachev wrote: >> Johan Vos has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Process reviewer comments > > modules/javafx.graphics/src/main/java/com/sun/glass/ui/headless/HeadlessRobot.java > line