Re: [External] : Re: FX 24.0.2 Some wav sounds don't play

2025-08-08 Thread Andy Goryachev
Created https://bugs.openjdk.org/browse/JDK-8365173 If these files are unencumbered by licensing, I can attach them to the ticket. -andy From: Dan Howard Date: Friday, August 8, 2025 at 08:43 To: Andy Goryachev , openjfx-dev Subject: [External] : Re: FX 24.0.2 Some wav sounds don't

Re: FX 24.0.2 Some wav sounds don't play

2025-08-08 Thread Andy Goryachev
Can you post a link? -andy From: openjfx-dev on behalf of Dan Howard Date: Friday, August 8, 2025 at 04:13 To: openjfx-dev Subject: FX 24.0.2 Some wav sounds don't play Hi all, Has anyone see this issue? FX version 24.0.2 Windows 11 Version 10.0.26100 Build 26100 wav file 88kbps, 1 channe

Re: RFR: 8364825: Skip failing MenuDoubleShortcutTest [v2]

2025-08-07 Thread Andy Goryachev
On Thu, 7 Aug 2025 17:45:40 GMT, Ziad El Midaoui wrote: >> Skipping failing `MenuDoubleShortcutTest#nonMacMenuBarComesBeforeScene()` > > Ziad El Midaoui has updated the pull request incrementally with one > additional commit since the last revision: > > Minor update to MenuDoubleShortcutTest

Re: RFR: 8364825: Skip failing MenuDoubleShortcutTest on Linux

2025-08-07 Thread Andy Goryachev
On Thu, 7 Aug 2025 16:07:05 GMT, Ziad El Midaoui wrote: > Skipping failing `MenuDoubleShortcutTest#nonMacMenuBarComesBeforeScene()` tests/system/src/test/java/test/robot/javafx/scene/MenuDoubleShortcutTest.java line 108: > 106: // On platforms other than Mac the menu bar should process the

Re: RFR: 8271024: Implement macOS Metal Rendering Pipeline [v22]

2025-08-07 Thread Andy Goryachev
On Thu, 7 Aug 2025 15:26:22 GMT, Nir Lisker wrote: > How widespread are the cases of unused Java fields/methods/classes that are > used in the native code? Probably a few cases. The main benefit is maintainability in the long run. - PR Comment: https://git.openjdk.org/jfx/pull/18

Re: RFR: 8271024: Implement macOS Metal Rendering Pipeline [v22]

2025-08-07 Thread Andy Goryachev
On Thu, 7 Aug 2025 05:01:51 GMT, Ambarish Rapte wrote: >> ### Description >> This is the implementation of new graphics rendering pipeline for JavaFX >> using Metal APIs on MacOS. >> We released two Early Access (EA) builds and have reached a stage where it >> is ready to be integrated. >> Defa

Re: RFR: 8355990: [macOS] Restoring a maximized stage does not update the window size [v2]

2025-08-06 Thread Andy Goryachev
nux) > > tests/system/src/test/java/test/javafx/stage/RestoreStagePositionTest.java > line 130: > >> 128: >> 129: Util.runAndWait(() -> stage.setMaximized(true)); >> 130: Util.waitForIdle(stage.getScene()); > > I know that @andy-goryachev

Re: RichTextArea feedback and suggestions

2025-08-05 Thread Andy Goryachev
Responding to your earlier message, and thanks again for trying RichTextArea/CodeArea out and giving the feedback! #1 Created ticket for the cursor issue: https://bugs.openjdk.org/browse/JDK-8364777 #2 CodeArea has the font property, which is styleable. Use the same CSS as TextArea: -fx-font

Re: RFR: 8271024: Implement macOS Metal Rendering Pipeline [v21]

2025-08-05 Thread Andy Goryachev
On Tue, 5 Aug 2025 18:07:04 GMT, Ambarish Rapte wrote: >> ### Description >> This is the implementation of new graphics rendering pipeline for JavaFX >> using Metal APIs on MacOS. >> We released two Early Access (EA) builds and have reached a stage where it >> is ready to be integrated. >> Defa

Re: RFR: 8343956: Focus delegation API [v3]

2025-08-04 Thread Andy Goryachev
nce the last revision: > > Avoid variable reassignment > _Mailing list message from [Andy Goryachev](mailto:andy.goryac...@oracle.com) > on [openjfx-dev](mailto:openjfx-...@mail.openjdk.org):_ > > My Swing is a bit rusty now, but I think it managed to handle geometry-

Re: RichTextArea feedback and suggestions

2025-08-04 Thread Andy Goryachev
Thank you for trying out the RichTextArea and the kind words! Your feedback is invaluable. Yes, we want to create the JSB tickets for the actual bugs. Please allow me some time to get back to you. Thanks, -andy From: openjfx-dev on behalf of mkpaz Date: Saturday, August 2, 2025 at 09:42

Re: RFR: 8343956: Focus delegation API [v3]

2025-08-01 Thread Andy Goryachev
te: > _Mailing list message from [Andy Goryachev](mailto:andy.goryac...@oracle.com) > on [openjfx-dev](mailto:openjfx-...@mail.openjdk.org):_ > > I think I narrowed down my objection to this proposal. My main problem with > it is that it tries to add properties to the wrong entity (Node)

Re: RFR: 8343956: Focus delegation API [v3]

2025-08-01 Thread Andy Goryachev
Cleaned up the Focus Traversal Policy proposal a bit, see https://github.com/andy-goryachev-oracle/Test/blob/main/doc/FocusTraversal/FocusTraversalPolicy.md . My problem with the Focus Delegation proposal is that it tries, as you put it, to span different levels of abstraction, in my view

Re: RFR: 8271024: Implement macOS Metal Rendering Pipeline [v15]

2025-08-01 Thread Andy Goryachev
On Fri, 1 Aug 2025 17:09:58 GMT, Ambarish Rapte wrote: >> ### Description >> This is the implementation of new graphics rendering pipeline for JavaFX >> using Metal APIs on MacOS. >> We released two Early Access (EA) builds and have reached a stage where it >> is ready to be integrated. >> Defa

Re: RFR: 8271024: Implement macOS Metal Rendering Pipeline [v15]

2025-08-01 Thread Andy Goryachev
On Fri, 1 Aug 2025 17:09:58 GMT, Ambarish Rapte wrote: >> ### Description >> This is the implementation of new graphics rendering pipeline for JavaFX >> using Metal APIs on MacOS. >> We released two Early Access (EA) builds and have reached a stage where it >> is ready to be integrated. >> Defa

Re: RFR: 8271024: Implement macOS Metal Rendering Pipeline [v15]

2025-08-01 Thread Andy Goryachev
On Fri, 1 Aug 2025 17:09:58 GMT, Ambarish Rapte wrote: >> ### Description >> This is the implementation of new graphics rendering pipeline for JavaFX >> using Metal APIs on MacOS. >> We released two Early Access (EA) builds and have reached a stage where it >> is ready to be integrated. >> Defa

Re: RFR: 8271024: Implement macOS Metal Rendering Pipeline [v8]

2025-08-01 Thread Andy Goryachev
On Fri, 1 Aug 2025 15:19:59 GMT, Kevin Rushforth wrote: >> Yes, Changed the order. Any resources being used by MTLCommandQueue are made >> resident, so the resources would stay alive even if MTLResourceFactory is >> disposed. but the earlier order was incorrect. > > Normally, this would be the

Re: RFR: 8355990: [macOS] Restoring a maximized stage does not update the window size [v2]

2025-07-31 Thread Andy Goryachev
ted if the user manipulates the window manually. > > Martin Fox has updated the pull request incrementally with one additional > commit since the last revision: > > Cleaned up diff against master. Tighted up system test (tested on Windows > and Linux)

Re: RFR: 8271024: Implement macOS Metal Rendering Pipeline [v13]

2025-07-31 Thread Andy Goryachev
On Thu, 31 Jul 2025 10:16:50 GMT, Ambarish Rapte wrote: >> ### Description >> This is the implementation of new graphics rendering pipeline for JavaFX >> using Metal APIs on MacOS. >> We released two Early Access (EA) builds and have reached a stage where it >> is ready to be integrated. >> Def

Re: RFR: 8360886: Cmd + plus shortcut does not work reliably [v2]

2025-07-31 Thread Andy Goryachev
On Mon, 7 Jul 2025 16:59:13 GMT, Martin Fox wrote: >> The Mac platform code figures out where characters are on the keyboard as >> the user types. The character table is updated on every key press by calling >> a registerKeyEvent: in GlassApplication. This character table is used to >> resolve

Re: RFR: 8359599: Calling refresh() for all virtualized controls recreates all cells instead of refreshing the cells

2025-07-31 Thread Andy Goryachev
On Sun, 15 Jun 2025 14:23:27 GMT, Marius Hanl wrote: > When calling `refresh()` on virtualized Controls (`ListView`, `TreeView`, > `TableView`, `TreeTableView`), all cells will be recreated completely, > instead of just refreshing them. > > This is because `recreateCells()` of the `VirtualFlow

[jfx25] Integrated: 8364049: ToolBar shows overflow menu with fractional scale

2025-07-31 Thread Andy Goryachev
On Thu, 31 Jul 2025 19:27:51 GMT, Andy Goryachev wrote: > A clean backport of #1856 . > > This is a very localized fix for the issue described in > https://bugs.openjdk.org/browse/JDK-8364049 which resulted from comparing > snapped and non-snapped values. The issue seems to h

[jfx25] RFR: 8364049: ToolBar shows overflow menu with fractional scale

2025-07-31 Thread Andy Goryachev
A clean backport of #1856 . This is a very localized fix for the issue described in https://bugs.openjdk.org/browse/JDK-8364049 which resulted from comparing snapped and non-snapped values. The issue seems to happen only with fractional scale, that is, on Windows at 125%, 150%, 175% etc. scales

Integrated: 8364049: ToolBar shows overflow menu with fractional scale

2025-07-31 Thread Andy Goryachev
On Fri, 25 Jul 2025 17:13:30 GMT, Andy Goryachev wrote: > This is a very localized fix for the issue described in > https://bugs.openjdk.org/browse/JDK-8364049 which resulted from comparing > snapped and non-snapped values. The issue seems to happen only with > fractional scale,

Re: RFR: 8364049: ToolBar shows overflow menu with fractional scale

2025-07-31 Thread Andy Goryachev
On Mon, 28 Jul 2025 13:10:36 GMT, Kevin Rushforth wrote: >> This is a very localized fix for the issue described in >> https://bugs.openjdk.org/browse/JDK-8364049 which resulted from comparing >> snapped and non-snapped values. The issue seems to happen only with >> fractional scale, that is,

Re: RFR: 8364049: ToolBar shows overflow menu with fractional scale [v3]

2025-07-31 Thread Andy Goryachev
On Thu, 31 Jul 2025 01:00:12 GMT, Michael Strauß wrote: > Here's a test Many thanks! The key difference seems to be the binding of the scale properties. - PR Comment: https://git.openjdk.org/jfx/pull/1856#issuecomment-3140501179

Re: RFR: 8364049: ToolBar shows overflow menu with fractional scale [v4]

2025-07-31 Thread Andy Goryachev
gt; 417, 425, 436, 530, and so on. > > I decided not to fix the snapping for the purpose of making this PR narrow in > scope with the goal to backport it to jfx25, but I did want to describe the > issue. Andy Goryachev has updated the pull request incrementally with one addition

Re: JavaFX TextInputControl private access yet supposed to be overrided problem

2025-07-30 Thread Andy Goryachev
Dear Tom: Anything not public or protected is considered an implementation detail, inaccessible to the application by design. There are many reasons for hiding the implementation detail, for example, any changes or bug fixes that do not change the public APIs can be done without breaking the e

Re: RFR: 8343956: Focus delegation API [v3]

2025-07-30 Thread Andy Goryachev
most important feature that would be added is enabling ability to plug in a custom traversal policy that can address any application-level requirements with relative ease. What do you think? -andy References [0] https://github.com/andy-goryachev-oracle/Test/blob/main/doc/FocusTraversal

Re: RFR: 8355990: [macOS] Restoring a maximized stage does not update the window size

2025-07-30 Thread Andy Goryachev
On Tue, 29 Jul 2025 14:45:36 GMT, Martin Fox wrote: > This PR fixes numerous bugs in the handling of setMaximized() on macOS and > also cleans up some issues seen when the user changes the maximized state > manually. > > - After setMaximized(false) a notifyResize event was never sent so the wi

Re: RFR: 8364049: ToolBar shows overflow menu with fractional scale [v3]

2025-07-30 Thread Andy Goryachev
On Wed, 30 Jul 2025 18:52:20 GMT, Andy Goryachev wrote: >> This is a very localized fix for the issue described in >> https://bugs.openjdk.org/browse/JDK-8364049 which resulted from comparing >> snapped and non-snapped values. The issue seems to happen only with >> f

Re: RFR: 8271024: Implement macOS Metal Rendering Pipeline [v12]

2025-07-30 Thread Andy Goryachev
On Wed, 30 Jul 2025 10:00:56 GMT, Ambarish Rapte wrote: >> ### Description >> This is the implementation of new graphics rendering pipeline for JavaFX >> using Metal APIs on MacOS. >> We released two Early Access (EA) builds and have reached a stage where it >> is ready to be integrated. >> Def

Re: RFR: 8271024: Implement macOS Metal Rendering Pipeline [v11]

2025-07-30 Thread Andy Goryachev
On Fri, 25 Jul 2025 22:09:41 GMT, Nir Lisker wrote: >> all right, so we probably want to leave the project config as is, and this >> manual change is a one-off. Do you mind listing the changes here for future >> reference? > > I just looked at which .java files are not on the classpath and pul

Re: RFR: 8364049: ToolBar shows overflow menu with fractional scale [v3]

2025-07-30 Thread Andy Goryachev
gt; 417, 425, 436, 530, and so on. > > I decided not to fix the snapping for the purpose of making this PR narrow in > scope with the goal to backport it to jfx25, but I did want to describe the > issue. Andy Goryachev has updated the pull request incrementally with one additional co

Re: RFR: 8364049: ToolBar shows overflow menu with fractional scale [v2]

2025-07-30 Thread Andy Goryachev
On Wed, 30 Jul 2025 18:06:29 GMT, Michael Strauß wrote: >> Yes, but I wanted to do a very localized fix, to be included in jfx25. >> There are many places where we should be more careful with snapping >> mentioned in description, and I suspect even more elsewhere. >> >> I am still not sure wh

Re: RFR: 8364049: ToolBar shows overflow menu with fractional scale [v2]

2025-07-30 Thread Andy Goryachev
On Wed, 30 Jul 2025 16:34:22 GMT, Michael Strauß wrote: >> Andy Goryachev has updated the pull request with a new target base due to a >> merge or a rebase. The incremental webrev excludes the unrelated changes >> brought in by the merge/rebase. The pull request conta

Re: [jfx25] RFR: 8364088: ToolBarSkin: NPE in select()

2025-07-29 Thread Andy Goryachev
On Tue, 29 Jul 2025 20:45:04 GMT, Andy Goryachev wrote: > Fixed an NPE in the ToolBar. thanks for a quick review! - PR Comment: https://git.openjdk.org/jfx/pull/1861#issuecomment-3134054753

[jfx25] Integrated: 8364088: ToolBarSkin: NPE in select()

2025-07-29 Thread Andy Goryachev
On Tue, 29 Jul 2025 20:45:04 GMT, Andy Goryachev wrote: > Fixed an NPE in the ToolBar. This pull request has now been integrated. Changeset: a0c0920d Author: Andy Goryachev URL: https://git.openjdk.org/jfx/commit/a0c0920d92eeb6608c80bf3779def90adfcca756 Stats: 4 lines in 1 f

[jfx25] RFR: 8364088: ToolBarSkin: NPE in select()

2025-07-29 Thread Andy Goryachev
Fixed an NPE in the ToolBar. - Commit messages: - Backport 450ca6da16c5299d9792d01009a4400daa87ce6a Changes: https://git.openjdk.org/jfx/pull/1861/files Webrev: https://webrevs.openjdk.org/?repo=jfx&pr=1861&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8364088 Stats: 4 l

Re: RFR: 8364088: ToolBarSkin: NPE in select()

2025-07-29 Thread Andy Goryachev
On Fri, 25 Jul 2025 22:32:36 GMT, Andy Goryachev wrote: > Fixed an NPE in the ToolBar, looks like a corner case. I just really dislike these small issues (and I too like to add random stuff to the toolbars). - PR Comment: https://git.openjdk.org/jfx/pull/1857#issuecomm

Re: RFR: 8364049: ToolBar shows overflow menu with fractional scale [v2]

2025-07-29 Thread Andy Goryachev
gt; 417, 425, 436, 530, and so on. > > I decided not to fix the snapping for the purpose of making this PR narrow in > scope with the goal to backport it to jfx25, but I did want to describe the > issue. Andy Goryachev has updated the pull request with a new target base due to a me

Re: RFR: 8364088: ToolBarSkin: NPE in select()

2025-07-29 Thread Andy Goryachev
On Fri, 25 Jul 2025 22:32:36 GMT, Andy Goryachev wrote: > Fixed an NPE in the ToolBar, looks like a corner case. @kevinrushforth I think we should backport this to 25, along with #1856 . what do you think? is this the right command: `/ backport :jfx25` ? - PR Comment: ht

Re: RFR: 8364049: ToolBar shows overflow menu with fractional scale

2025-07-29 Thread Andy Goryachev
On Fri, 25 Jul 2025 17:13:30 GMT, Andy Goryachev wrote: > This is a very localized fix for the issue described in > https://bugs.openjdk.org/browse/JDK-8364049 which resulted from comparing > snapped and non-snapped values. The issue seems to happen only with > fractional scale,

Integrated: 8364088: ToolBarSkin: NPE in select()

2025-07-29 Thread Andy Goryachev
On Fri, 25 Jul 2025 22:32:36 GMT, Andy Goryachev wrote: > Fixed an NPE in the ToolBar, looks like a corner case. This pull request has now been integrated. Changeset: 450ca6da Author: Andy Goryachev URL: https://git.openjdk.org/jfx/commit/450ca6da16c5299d9792d01009a4400daa87c

Re: RFR: 8341286: TreeView: visual artifacts when setting new root with null value [v3]

2025-07-29 Thread Andy Goryachev
On Tue, 29 Jul 2025 15:51:50 GMT, Ziad El Midaoui wrote: >> The issue is that when we use null value for root item in a TreeView and >> then expand the root or change it dynamically there are phantom disclosure >> nodes that appear incorrectly. >> The issue was caused by this line `if (getSki

Re: RFR: 8358092: Create accessibility protocol implementation that covers various type of menu items

2025-07-29 Thread Andy Goryachev
On Fri, 25 Jul 2025 23:32:04 GMT, Alexander Zuev wrote: > Initial implementation. Note that second level menu navigation with the > non-system menus does not work but it was not working with the current > implementation so i am raising a new bug for tracking that but that can not > be a showst

Re: RFR: 8364088: ToolBarSkin: NPE in select()

2025-07-29 Thread Andy Goryachev
On Fri, 25 Jul 2025 22:32:36 GMT, Andy Goryachev wrote: > Fixed an NPE in the ToolBar, looks like a corner case. > Is this unit-testable? > Any minimal test case? Github ate my previous response! Restoring from memory. The bug came out of testing JDK-8364049. I could not create a

Re: RFR: 8341286: TreeView: visual artifacts when setting new root with null value [v2]

2025-07-29 Thread Andy Goryachev
On Tue, 29 Jul 2025 11:32:00 GMT, Ziad El Midaoui wrote: >> The issue is that when we use null value for root item in a TreeView and >> then expand the root or change it dynamically there are phantom disclosure >> nodes that appear incorrectly. >> The issue was caused by this line `if (getSki

Re: RFR: 8358092: Create accessibility protocol implementation that covers various type of menu items

2025-07-28 Thread Andy Goryachev
On Fri, 25 Jul 2025 23:32:04 GMT, Alexander Zuev wrote: > Initial implementation. Note that second level menu navigation with the > non-system menus does not work but it was not working with the current > implementation so i am raising a new bug for tracking that but that can not > be a showst

Re: RFR: 8364088: ToolBarSkin: NPE in select()

2025-07-28 Thread Andy Goryachev
On Sat, 26 Jul 2025 02:03:26 GMT, Michael Strauß wrote: > Is this unit-testable? I would say it's probably not worth it, but I'll try come up with a headless test. I certainly don't want a headful test for what looks like a programmer's oversight. - PR Comment: https://git.openj

Re: RFR: 8341286: TreeView: visual artifacts when setting new root with null value

2025-07-28 Thread Andy Goryachev
On Mon, 30 Jun 2025 21:49:22 GMT, Ziad El Midaoui wrote: > Fix for phantom disclosure nodes appearing when root is null modules/javafx.controls/src/main/java/javafx/scene/control/skin/TreeCellSkin.java line 363: > 361: private void updateDisclosureNode() { > 362: //JDK-8341281 : R

Re: RFR: 8341286: TreeView: visual artifacts when setting new root with null value

2025-07-28 Thread Andy Goryachev
On Mon, 30 Jun 2025 21:49:22 GMT, Ziad El Midaoui wrote: > Fix for phantom disclosure nodes appearing when root is null Hmm, I am not sure this is the right solution: remember, the tree works just fine if you change the root in the form of `TreeItem<>(new Entry(null))`, but breaks when you se

Re: RFR: 8324941: POC for Headless platform for JavaFX [v14]

2025-07-28 Thread Andy Goryachev
On Mon, 28 Jul 2025 15:13:07 GMT, Johan Vos wrote: >> After spending a year in the sandbox repository, the Headless Platform is >> now ready to be reviewed in the main repository. >> >> ### the Headless Platform >> The Headless Platform is a top-level com.sun.glass.ui platform that replaces >>

Re: RFR: 8324941: POC for Headless platform for JavaFX [v13]

2025-07-28 Thread Andy Goryachev
On Mon, 28 Jul 2025 11:38:26 GMT, Johan Vos wrote: >> After spending a year in the sandbox repository, the Headless Platform is >> now ready to be reviewed in the main repository. >> >> ### the Headless Platform >> The Headless Platform is a top-level com.sun.glass.ui platform that replaces >>

RFR: 8364088: ToolBarSkin: NPE in select()

2025-07-25 Thread Andy Goryachev
Fixed an NPE in the ToolBar, looks like a corner case. - Commit messages: - npe Changes: https://git.openjdk.org/jfx/pull/1857/files Webrev: https://webrevs.openjdk.org/?repo=jfx&pr=1857&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8364088 Stats: 4 lines in 1 file chang

Re: RFR: 8271024: Implement macOS Metal Rendering Pipeline [v11]

2025-07-25 Thread Andy Goryachev
On Fri, 25 Jul 2025 21:12:05 GMT, Nir Lisker wrote: >> We might, at some point, but my question is about .classpath files probably. >> I don't see MSLBackend.java as being on the source path, which makes me >> think you have a different setup, and I'd like to know the difference. >> >> Speaki

Re: RFR: 8271024: Implement macOS Metal Rendering Pipeline [v11]

2025-07-25 Thread Andy Goryachev
On Fri, 25 Jul 2025 20:55:11 GMT, Nir Lisker wrote: >> This means your Eclipse configuration differs from mine. Should we pull >> your configuration changes to this PR? > > I commented on all the places where Eclipse gives a warning in this PR. Do > you want me to upload the compiler settings?

Re: RFR: 8271024: Implement macOS Metal Rendering Pipeline [v11]

2025-07-25 Thread Andy Goryachev
On Fri, 25 Jul 2025 15:50:35 GMT, Nir Lisker wrote: >> Ambarish Rapte has updated the pull request with a new target base due to a >> merge or a rebase. The incremental webrev excludes the unrelated changes >> brought in by the merge/rebase. The pull request contains 12 additional >> commits s

RFR: 8364049: ToolBar shows overflow menu with fractional scale

2025-07-25 Thread Andy Goryachev
This is a very localized fix for the issue described in https://bugs.openjdk.org/browse/JDK-8364049 which resulted from comparing snapped and non-snapped values. The issue seems to happen only with fractional scale, that is, on Windows at 125%, 150%, 175% etc. scales. While looking at the `Too

Re: RFR: 8359601: Fix window button states of an extended stage [v6]

2025-07-23 Thread Andy Goryachev
On Sat, 21 Jun 2025 23:37:13 GMT, Michael Strauß wrote: >> The window button states (disabled/hidden) of extended stages with a >> `HeaderButtonOverlay` or custom header buttons are inconsistent with what we >> would expect from the OS (Windows and Linux). To figure out what we would >> expect

Re: RFR: 8271024: Implement macOS Metal Rendering Pipeline [v11]

2025-07-23 Thread Andy Goryachev
On Tue, 22 Jul 2025 17:00:25 GMT, Ambarish Rapte wrote: >> ### Description >> This is the implementation of new graphics rendering pipeline for JavaFX >> using Metal APIs on MacOS. >> We released two Early Access (EA) builds and have reached a stage where it >> is ready to be integrated. >> Def

Re: RFR: 8362873: Regression in BorderPane after JDK-8350149

2025-07-22 Thread Andy Goryachev
On Tue, 22 Jul 2025 00:05:35 GMT, John Hendrikx wrote: > This PR fixes a regression introduced in #1723 > > It reverts the changes made in the BorderPaneTest with new comments > explaining why the values are what they are. It only fixes the regression > that was introduced, but it can be said

Re: [jfx25u] RFR: 8362896: Change JavaFX release version to 25.0.1 in jfx25u

2025-07-21 Thread Andy Goryachev
On Mon, 21 Jul 2025 16:46:36 GMT, Kevin Rushforth wrote: > Updates for the beginning of the 25.0.1 release. the branches look correct. - Marked as reviewed by angorya (Reviewer). PR Review: https://git.openjdk.org/jfx25u/pull/1#pullrequestreview-3038975245

Re: RFR: 8324941: POC for Headless platform for JavaFX [v4]

2025-07-18 Thread Andy Goryachev
y Tester with an auto snapshot added, see https://github.com/andy-goryachev-oracle/MonkeyTest/tree/headless ) - PR Comment: https://git.openjdk.org/jfx/pull/1836#issuecomment-3090503734

Re: RFR: 8271024: Implement macOS Metal Rendering Pipeline [v8]

2025-07-18 Thread Andy Goryachev
On Fri, 18 Jul 2025 18:08:34 GMT, Andy Goryachev wrote: >> Changed accordingly and included another check to verify if the `val` is >> already a power of two. > > This code (in my experience) is easy to get wrong. > Could we add some tests, to verify that > - values

Re: RFR: 8271024: Implement macOS Metal Rendering Pipeline [v8]

2025-07-18 Thread Andy Goryachev
On Fri, 18 Jul 2025 17:54:11 GMT, Ambarish Rapte wrote: >> modules/javafx.graphics/src/main/java/com/sun/prism/mtl/MTLResourceFactory.java >> line 75: >> >>> 73: i *= 2; >>> 74: } >>> 75: return i; >> >> interesting... would `1 << val` be simpler (barring overflow)

Re: RFR: 8353599: TabPaneSkin: add 'menuGraphicFactory' property [v5]

2025-07-17 Thread Andy Goryachev
; tabPane.getTabs().addAll(tab1, tab2); > > TabPaneSkin skin = new TabPaneSkin(tabPane); > // set overflow menu factory with the same method as was used to > create the tabs > skin.setMenuGraphicFactory(this::createGraphic); > tabPane.setSkin(skin

Integrated: 8355774: RichTextArea: provide mechanism for CSS styling of highlights

2025-07-17 Thread Andy Goryachev
On Wed, 7 May 2025 22:57:34 GMT, Andy Goryachev wrote: > Adding missing APIs related to styling the highlights with CSS: > > ![Screenshot 2025-05-07 at 15 08 > 53](https://github.com/user-attachments/assets/e37062b4-9804-40a7-872d-830fe0f584c1) > > >

Re: RFR: 8314482: TextFlow: TabStopPolicy [v10]

2025-07-17 Thread Andy Goryachev
On Tue, 15 Jul 2025 17:32:31 GMT, Andy Goryachev wrote: >> # Tab Stop Policy >> >> Andy Goryachev >> >> >> >> >> ## Summary >> >> Introduce a `tabStopPolicy` property in the `TextFlow` class which, when >> set, overri

Integrated: 8314482: TextFlow: TabStopPolicy

2025-07-17 Thread Andy Goryachev
On Wed, 26 Mar 2025 14:41:51 GMT, Andy Goryachev wrote: > # Tab Stop Policy > > Andy Goryachev > > > > > ## Summary > > Introduce a `tabStopPolicy` property in the `TextFlow` class which, when set, > overrides the existing `tabSize` > value and provides

Re: RFR: 8271024: Implement macOS Metal Rendering Pipeline [v8]

2025-07-16 Thread Andy Goryachev
On Tue, 15 Jul 2025 05:41:32 GMT, Ambarish Rapte wrote: >> ### Description >> This is the implementation of new graphics rendering pipeline for JavaFX >> using Metal APIs on MacOS. >> We released two Early Access (EA) builds and have reached a stage where it >> is ready to be integrated. >> Def

Re: RFR: 8271024: Implement macOS Metal Rendering Pipeline [v6]

2025-07-16 Thread Andy Goryachev
On Wed, 16 Jul 2025 05:37:27 GMT, Ambarish Rapte wrote: > this seems WebView specific I agree. - PR Comment: https://git.openjdk.org/jfx/pull/1824#issuecomment-3079932276

Re: RFR: 8271024: Implement macOS Metal Rendering Pipeline [v8]

2025-07-16 Thread Andy Goryachev
On Tue, 15 Jul 2025 05:41:32 GMT, Ambarish Rapte wrote: >> ### Description >> This is the implementation of new graphics rendering pipeline for JavaFX >> using Metal APIs on MacOS. >> We released two Early Access (EA) builds and have reached a stage where it >> is ready to be integrated. >> Def

Re: RFR: 8271024: Implement macOS Metal Rendering Pipeline [v8]

2025-07-16 Thread Andy Goryachev
On Tue, 15 Jul 2025 05:41:32 GMT, Ambarish Rapte wrote: >> ### Description >> This is the implementation of new graphics rendering pipeline for JavaFX >> using Metal APIs on MacOS. >> We released two Early Access (EA) builds and have reached a stage where it >> is ready to be integrated. >> Def

Re: RFR: 8141391: Manual JFXPanel DnD test doesn't work [v3]

2025-07-16 Thread Andy Goryachev
On Tue, 15 Jul 2025 03:38:20 GMT, Prasanta Sadhukhan wrote: >> Issue is when `JFXPanel `is used to embed some JavaFX components and when we >> drag something from swing or an external application and try to drop on a >> JavaFX component inside the JFXPanel, it doesn't accept the drop showing

Re: RFR: 8314482: TextFlow: TabStopPolicy [v10]

2025-07-15 Thread Andy Goryachev
On Tue, 15 Jul 2025 17:32:31 GMT, Andy Goryachev wrote: >> # Tab Stop Policy >> >> Andy Goryachev >> >> >> >> >> ## Summary >> >> Introduce a `tabStopPolicy` property in the `TextFlow` class which, when >> set, overri

Re: RFR: 8354539: [macOS] ComboBox and Spinner disable system menu bar shortcuts [v2]

2025-07-15 Thread Andy Goryachev
On Mon, 14 Jul 2025 19:58:22 GMT, Martin Fox wrote: >> The Mac platform code sends a KeyEvent into the scene graph and if the event >> is not consumed it gets sent on to the system menu. But ComboBox and Spinner >> always consume the original event and fire a copy which the system menu >> igno

Re: RFR: 8354539: [macOS] ComboBox and Spinner disable system menu bar shortcuts [v2]

2025-07-15 Thread Andy Goryachev
On Mon, 14 Jul 2025 19:58:22 GMT, Martin Fox wrote: >> The Mac platform code sends a KeyEvent into the scene graph and if the event >> is not consumed it gets sent on to the system menu. But ComboBox and Spinner >> always consume the original event and fire a copy which the system menu >> igno

Re: RFR: 8141391: DnD doesn't work for JFXPanel [v3]

2025-07-15 Thread Andy Goryachev
On Tue, 15 Jul 2025 03:38:20 GMT, Prasanta Sadhukhan wrote: >> Issue is when `JFXPanel `is used to embed some JavaFX components and when we >> drag something from swing or an external application and try to drop on a >> JavaFX component inside the JFXPanel, it doesn't accept the drop showing

Re: RFR: 8314482: TextFlow: TabStopPolicy [v9]

2025-07-15 Thread Andy Goryachev
On Fri, 11 Jul 2025 22:42:23 GMT, Andy Goryachev wrote: >> # Tab Stop Policy >> >> Andy Goryachev >> >> >> >> >> ## Summary >> >> Introduce a `tabStopPolicy` property in the `TextFlow` class which, when >> set, overri

Re: RFR: 8314482: TextFlow: TabStopPolicy [v10]

2025-07-15 Thread Andy Goryachev
> # Tab Stop Policy > > Andy Goryachev > > > > > ## Summary > > Introduce a `tabStopPolicy` property in the `TextFlow` class which, when set, > overrides the existing `tabSize` > value and provides consistent way of setting tab stops at the paragraph &

Re: [jfx24u] RFR: 8361887: Create release notes for JavaFX 24.0.2 [v2]

2025-07-15 Thread Andy Goryachev
On Tue, 15 Jul 2025 13:49:28 GMT, Kevin Rushforth wrote: >> Release notes for JavaFX 24.0.2. >> >> Notes to reviewers: >> >> I used the following filter to pick the issues: >> >> https://bugs.openjdk.org/issues/?filter=47734 >> >> The original filter, with the backport IDs, is here: >> >> ht

Re: RFR: 8362079: Change JavaFX release version to 26

2025-07-14 Thread Andy Goryachev
On Mon, 14 Jul 2025 14:18:07 GMT, Kevin Rushforth wrote: > Bump the version number of JavaFX to 26. I will integrate this to master as > part of forking the jfx25 stabilization branch, which is scheduled for > Thursday, July 17, 2025 at 16:00 UTC. changes are in the same places as in #1673 --

Re: RFR: 8359598: [TestBug] VirtualFlowTestUtils should not create a temporary Stage [v2]

2025-07-14 Thread Andy Goryachev
On Sat, 12 Jul 2025 10:35:23 GMT, Marius Hanl wrote: >> Currently, the VirtualFlowTestUtils used ONLY for tests has many utility >> methods to get and do something with the VirtualFlow of Virtualized Controls. >> >> It has one flaw: It may creates a temporary Stage with the StageLoader, when >

Re: RFR: 8314482: TextFlow: TabStopPolicy [v9]

2025-07-11 Thread Andy Goryachev
> # Tab Stop Policy > > Andy Goryachev > > > > > ## Summary > > Introduce a `tabStopPolicy` property in the `TextFlow` class which, when set, > overrides the existing `tabSize` > value and provides consistent way of setting tab stops at the paragraph &

Integrated: 8357594: Additional geometry-based Text/TextFlow APIs

2025-07-11 Thread Andy Goryachev
On Tue, 27 May 2025 18:48:45 GMT, Andy Goryachev wrote: > ## Summary > This change adds new methods to the `TextFlow` which work correctly in the > presence of non-empty insets (borders/padding). For backward compatibility, > the old buggy methods are getting deprecated (not for re

Re: RFR: 8141391: DnD doesn't work for JFXPanel

2025-07-11 Thread Andy Goryachev
On Fri, 11 Jul 2025 16:48:41 GMT, Prasanta Sadhukhan wrote: >> Yes, this the wrong approach. The javafx.swing module does not (and should >> not) depend on javafx.controls. Drag and Drop is a scene graph operation and >> can be targeted to any node, even nodes that are not Controls. > > a) Yes

Re: RFR: 8141391: DnD doesn't work for JFXPanel

2025-07-11 Thread Andy Goryachev
On Fri, 11 Jul 2025 04:17:24 GMT, Prasanta Sadhukhan wrote: > Issue is when `JFXPanel `is used to embed some JavaFX components and when we > drag something from swing or an external application and try to drop on a > JavaFX component inside the JFXPanel, it doesn't accept the drop showing > "

Re: RFR: 8361713: JavaFX API docs overview is missing an intro section [v3]

2025-07-11 Thread Andy Goryachev
On Fri, 11 Jul 2025 15:11:27 GMT, Kevin Rushforth wrote: >> This PR adds an introductory section to the JavaFX API docs similar to that >> of the JDK docs. >> >> Compare the [JavaFX 24 API >> docs](https://download.java.net/java/GA/javafx24/docs/api/index.html) with >> the [JDK 24 API >> doc

Re: RFR: 8357594: Additional geometry-based Text/TextFlow APIs [v6]

2025-07-11 Thread Andy Goryachev
ey Tester using the following branch (in the Text and TextFlow pages): > > https://github.com/andy-goryachev-oracle/MonkeyTest/tree/text.insets.corrected Andy Goryachev has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains 76 commi

Re: RFR: 8361713: JavaFX API docs overview is missing an intro section [v2]

2025-07-11 Thread Andy Goryachev
On Fri, 11 Jul 2025 14:17:07 GMT, Kevin Rushforth wrote: >> This PR adds an introductory section to the JavaFX API docs similar to that >> of the JDK docs. >> >> Compare the [JavaFX 24 API >> docs](https://download.java.net/java/GA/javafx24/docs/api/index.html) with >> the [JDK 24 API >> doc

Re: RFR: 8271024: Implement macOS Metal Rendering Pipeline [v6]

2025-07-10 Thread Andy Goryachev
On Wed, 2 Jul 2025 07:53:24 GMT, Ambarish Rapte wrote: >> ### Description >> This is the implementation of new graphics rendering pipeline for JavaFX >> using Metal APIs on MacOS. >> We released two Early Access (EA) builds and have reached a stage where it >> is ready to be integrated. >> Defa

Re: RFR: 8271024: Implement macOS Metal Rendering Pipeline

2025-07-10 Thread Andy Goryachev
ance except a few that fall a little short on different hardwares. >> These will be addressed separately (there are open bugs already filed) >> >> ### Note to reviewers : >> - Providing `-Dprism.order=mtl` option is a must for testing the Metal >> pipeline >&g

Re: RFR: 8359598: [TestBug] VirtualFlowTestUtils should not create a temporary Stage

2025-07-10 Thread Andy Goryachev
On Sun, 15 Jun 2025 13:56:05 GMT, Marius Hanl wrote: > Currently, the VirtualFlowTestUtils used ONLY for tests has many utility > methods to get and do something with the VirtualFlow of Virtualized Controls. > > It has one flaw: It may creates a temporary Stage with the StageLoader, when > the

Re: RFR: 8359598: [TestBug] VirtualFlowTestUtils should not create a temporary Stage

2025-07-10 Thread Andy Goryachev
On Wed, 18 Jun 2025 10:43:38 GMT, Marius Hanl wrote: >> modules/javafx.controls/src/test/java/test/com/sun/javafx/scene/control/infrastructure/VirtualFlowTestUtils.java >> line 349: >> >>> 347: flow = (VirtualFlow)control.lookup("#virtual-flow"); >>> 348: >>> 349: if (sl != nul

Re: RFR: 8357714: AudioClip.play crash on macOS when loading resource from jar [v3]

2025-07-10 Thread Andy Goryachev
On Thu, 10 Jul 2025 07:45:26 GMT, Johan Vos wrote: >> After JDK-8287822 (https://bugs.openjdk.org/browse/JDK-8287822), mpeg file >> content is no longer played via GSTPlatform but via OSXPlatform. >> We need to correctly handle data in case the source is a file inside a jar, >> in which case C

Re: RFR: 8357714: AudioClip.play crash on macOS when loading resource from jar [v3]

2025-07-10 Thread Andy Goryachev
On Thu, 10 Jul 2025 07:45:26 GMT, Johan Vos wrote: >> After JDK-8287822 (https://bugs.openjdk.org/browse/JDK-8287822), mpeg file >> content is no longer played via GSTPlatform but via OSXPlatform. >> We need to correctly handle data in case the source is a file inside a jar, >> in which case C

Re: RFR: 8357714: AudioClip.play crash on macOS when loading resource from jar [v3]

2025-07-10 Thread Andy Goryachev
On Thu, 10 Jul 2025 07:45:26 GMT, Johan Vos wrote: >> After JDK-8287822 (https://bugs.openjdk.org/browse/JDK-8287822), mpeg file >> content is no longer played via GSTPlatform but via OSXPlatform. >> We need to correctly handle data in case the source is a file inside a jar, >> in which case C

Re: RFR: 8357714: AudioClip.play crash on macOS when loading resource from jar [v3]

2025-07-10 Thread Andy Goryachev
On Thu, 10 Jul 2025 07:45:26 GMT, Johan Vos wrote: >> After JDK-8287822 (https://bugs.openjdk.org/browse/JDK-8287822), mpeg file >> content is no longer played via GSTPlatform but via OSXPlatform. >> We need to correctly handle data in case the source is a file inside a jar, >> in which case C

Re: RFR: 8357714: AudioClip.play crash on macOS when loading resource from jar [v3]

2025-07-10 Thread Andy Goryachev
On Thu, 10 Jul 2025 07:45:26 GMT, Johan Vos wrote: >> After JDK-8287822 (https://bugs.openjdk.org/browse/JDK-8287822), mpeg file >> content is no longer played via GSTPlatform but via OSXPlatform. >> We need to correctly handle data in case the source is a file inside a jar, >> in which case C

  1   2   3   4   5   6   7   8   9   10   >