On Thu, 13 Jun 2024 10:25:15 GMT, Jose Pereda wrote:
>> Johan Vos has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Add more type info
>
> modules/javafx.graphics/src/shims/java/com/sun/javafx/tk/quantum/Gl
On Tue, 12 Dec 2023 07:05:49 GMT, Ambarish Rapte wrote:
>> Johan Vos has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> process reviewers comments
>
> Looks all good to me.
> Is it possible to add an auto
> A listener was added but never removed.
> This patch removes the listener when the menu it links to is cleared. Fix for
> https://bugs.openjdk.org/browse/JDK-8319779
Johan Vos has updated the pull request incrementally with two additional
commits since the last revision:
- pro
> A listener was added but never removed.
> This patch removes the listener when the menu it links to is cleared. Fix for
> https://bugs.openjdk.org/browse/JDK-8319779
Johan Vos has updated the pull request with a new target base due to a merge or
a rebase. The pull request now co
On Wed, 13 Dec 2023 09:20:12 GMT, Jose Pereda wrote:
>> Johan Vos has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> process reviewers comments
>
> About adding an automated test, the lea
Hi Christopher,
The question about Windows. AArch64 increasingly pops up. We did some local
tests, and the basis modules builds out-of-the-box, but media and web
modules require more work.
It's definitely helpful that there are GA runners for it now -- although
the GA is just a basic check.
It
On Tue, 4 Jun 2024 17:39:04 GMT, Johan Vos wrote:
> 8332539: Update libxml2 to 2.12.7
This pull request has now been integrated.
Changeset: 1d2bc14d
Author: Johan Vos
URL:
https://git.openjdk.org/jfx21u/commit/1d2bc14df14d09a921194b273249e394fb1012ff
Stats: 67 lines in 9 fi
On Tue, 4 Jun 2024 17:39:07 GMT, Johan Vos wrote:
> 8332539: Update libxml2 to 2.12.7
This pull request has now been integrated.
Changeset: 14575c54
Author: Johan Vos
URL:
https://git.openjdk.org/jfx17u/commit/14575c54a2b665384bbf4d81a1e2672912691562
Stats: 67 lines in 9 fi
8332539: Update libxml2 to 2.12.7
-
Commit messages:
- Backport dedcf1d236b5429dcf3c42f5fd1095b28d5da063
Changes: https://git.openjdk.org/jfx21u/pull/60/files
Webrev: https://webrevs.openjdk.org/?repo=jfx21u=60=00
Issue: https://bugs.openjdk.org/browse/JDK-8332539
Stats: 67
8332539: Update libxml2 to 2.12.7
-
Commit messages:
- Backport dedcf1d236b5429dcf3c42f5fd1095b28d5da063
Changes: https://git.openjdk.org/jfx17u/pull/192/files
Webrev: https://webrevs.openjdk.org/?repo=jfx17u=192=00
Issue: https://bugs.openjdk.org/browse/JDK-8332539
Stats: 67
On Tue, 4 Jun 2024 14:18:04 GMT, Johan Vos wrote:
> 8331748: Update libxml2 to 2.12.6
This pull request has now been integrated.
Changeset: 1dfcbed2
Author: Johan Vos
URL:
https://git.openjdk.org/jfx17u/commit/1dfcbed2f5586c3efceed4c95ebec3d23ee99573
Stats: 24912 lines in
On Tue, 4 Jun 2024 14:19:52 GMT, Johan Vos wrote:
> 8331748: Update libxml2 to 2.12.6
This pull request has now been integrated.
Changeset: f8e75ca6
Author: Johan Vos
URL:
https://git.openjdk.org/jfx21u/commit/f8e75ca6b9fc2005285f76fe958c589cb9a328c3
Stats: 24912 lines in
On Tue, 4 Jun 2024 14:36:16 GMT, Johan Vos wrote:
> 8332328: [GHA] GitHub Actions build fails on Linux: unable to find gcc-13
This pull request has now been integrated.
Changeset: 3a7cad84
Author: Johan Vos
URL:
https://git.openjdk.org/jfx17u/com
On Tue, 4 Jun 2024 14:35:28 GMT, Johan Vos wrote:
> 8332328: [GHA] GitHub Actions build fails on Linux: unable to find gcc-13
This pull request has now been integrated.
Changeset: 20866584
Author: Johan Vos
URL:
https://git.openjdk.org/jfx21u/com
8331748: Update libxml2 to 2.12.6
-
Commit messages:
- Backport 97b1402501983f121f75c24a510f466837fa2ecc
Changes: https://git.openjdk.org/jfx17u/pull/190/files
Webrev: https://webrevs.openjdk.org/?repo=jfx17u=190=00
Issue: https://bugs.openjdk.org/browse/JDK-8331748
Stats:
8332328: [GHA] GitHub Actions build fails on Linux: unable to find gcc-13
-
Commit messages:
- Backport d7ab55184f757a614f9fc8f191c3c5794a16cc88
Changes: https://git.openjdk.org/jfx17u/pull/191/files
Webrev: https://webrevs.openjdk.org/?repo=jfx17u=191=00
Issue:
8332328: [GHA] GitHub Actions build fails on Linux: unable to find gcc-13
-
Commit messages:
- Backport d7ab55184f757a614f9fc8f191c3c5794a16cc88
Changes: https://git.openjdk.org/jfx21u/pull/59/files
Webrev: https://webrevs.openjdk.org/?repo=jfx21u=59=00
Issue:
8331748: Update libxml2 to 2.12.6
-
Commit messages:
- Backport 97b1402501983f121f75c24a510f466837fa2ecc
Changes: https://git.openjdk.org/jfx21u/pull/58/files
Webrev: https://webrevs.openjdk.org/?repo=jfx21u=58=00
Issue: https://bugs.openjdk.org/browse/JDK-8331748
Stats:
Yes, that is why I filed https://bugs.openjdk.org/browse/JDK-8333147
(which hints at a fix:
Instead of `classifier "$t.name"` we should now use `archiveClassifier.set(
t.name)`
)
- Johan
On Wed, May 29, 2024 at 4:58 PM John Neffenger wrote:
> On 5/29/24 12:19 AM, Joeri Sykora wrote:
> > maven
On Wed, 22 May 2024 15:50:46 GMT, Florian Kirmaier
wrote:
>> As seen in the unit test of the PR, when we click on the area above/below
>> the scrollbar the position jumps - but the jump is now not always consistent.
>> In the current version on the last cell - the UI always jumps to the top.
On Tue, 21 May 2024 22:32:21 GMT, Kevin Rushforth wrote:
>> Update the code review guidelines for JavaFX.
>>
>> The JavaFX
>> [CONTRIBUTING](https://github.com/kevinrushforth/jfx/blob/8332313-contributing/CONTRIBUTING.md)
>> guidelines includes guidance for creating, reviewing, and
On Tue, 21 May 2024 21:55:30 GMT, Kevin Rushforth wrote:
> @johanvos added a question in the CSR about this last part:
>
> > I understand and agree with the goal behind this.
> > I'm a bit confused though about the following: "...but it does not
> > necessarily have to be the same value." ->
On Wed, 15 May 2024 21:57:23 GMT, Kevin Rushforth wrote:
>> CONTRIBUTING.md line 233:
>>
>>> 231: * Don't worry too much about import order. Try not to change it but
>>> don't worry about fighting your IDE to stop it from doing so.
>>> 232:
>>> 233: New code should be formatted consistently
On Wed, 15 May 2024 19:39:10 GMT, Kevin Rushforth wrote:
>> README-code-reviews.md line 66:
>>
>>> 64: * Focus first on substantive comments rather than stylistic comments
>>> 65: * Consider the risk of regression
>>> 66: * Consider any compatibility concerns
>>
>> regression and compatibility
On Thu, 9 May 2024 19:48:19 GMT, Johan Vos wrote:
>> A listener was added but never removed.
>> This patch removes the listener when the menu it links to is cleared. Fix
>> for https://bugs.openjdk.org/browse/JDK-8319779
>
> Johan Vos has updated the pull reques
On Thu, 9 May 2024 17:45:39 GMT, Andy Goryachev wrote:
> > the idea about mapping scroll events to the top/bottom of a cell is hinted
> > in the code though
>
> could you please point to these places?
I'm not sure I understand the question, as this is exactly what the PR is
doing. The
On Tue, 14 May 2024 13:23:06 GMT, Kevin Rushforth wrote:
> @johanvos do you also want to review or is Joeri's review OK?
In Joeri I trust :)
-
PR Comment: https://git.openjdk.org/jfx/pull/1454#issuecomment-2110380422
On Tue, 14 May 2024 05:21:37 GMT, Hima Bindu Meda wrote:
> Updated libxml to v2.12.6. Verified build and sanity testing on all
> platforms. No issue seen
@tiainen can you do a build/review?
-
PR Comment: https://git.openjdk.org/jfx/pull/1453#issuecomment-2109378318
> A listener was added but never removed.
> This patch removes the listener when the menu it links to is cleared. Fix for
> https://bugs.openjdk.org/browse/JDK-8319779
Johan Vos has updated the pull request incrementally with one additional commit
since the last revision:
Add more
> A listener was added but never removed.
> This patch removes the listener when the menu it links to is cleared. Fix for
> https://bugs.openjdk.org/browse/JDK-8319779
Johan Vos has updated the pull request incrementally with one additional commit
since the last revision:
Add type i
> A listener was added but never removed.
> This patch removes the listener when the menu it links to is cleared. Fix for
> https://bugs.openjdk.org/browse/JDK-8319779
Johan Vos has updated the pull request with a new target base due to a merge or
a rebase. The pull request now co
On Thu, 9 May 2024 14:49:26 GMT, Florian Kirmaier wrote:
>> As seen in the unit test of the PR, when we click on the area above/below
>> the scrollbar the position jumps - but the jump is now not always consistent.
>> In the current version on the last cell - the UI always jumps to the top. In
On Tue, 7 May 2024 09:39:23 GMT, Florian Kirmaier wrote:
>> As seen in the unit test of the PR, when we click on the area above/below
>> the scrollbar the position jumps - but the jump is now not always consistent.
>> In the current version on the last cell - the UI always jumps to the top. In
On Tue, 7 May 2024 09:39:23 GMT, Florian Kirmaier wrote:
>> As seen in the unit test of the PR, when we click on the area above/below
>> the scrollbar the position jumps - but the jump is now not always consistent.
>> In the current version on the last cell - the UI always jumps to the top. In
Hi,
I did some more work on the JavaFX Headless platform that is available in
[1] and I am using it to run the systemtests. I am not yet running the
robot-based systemtests, but there is already some robot code in the
Headless platform.
The other systemtests are going pretty well. On my linux,
On Wed, Apr 24, 2024 at 3:14 PM Kevin Rushforth
wrote:
> > There are a number of ways to solve this, e.g.
> > * get rid of the separate shutdown procedure in the system tests.
>
> The utility was added to have a consistent way to shut down the
> platform, so it would seem a shame to remove it.
While working on the systemtests for the Headless platform, I noticed
timing issues with the Marlin QPath Test. Those have nothing to do with
Marlin, but rather with the lifecycle. After the test ran,
`test.util.Shutdown` is invoked (not on the JavaFX app thread). I noticed
that this caused a
Hi,
When building WebKit from the sources, the perl script that invokes the
cmake/make build (build-webkit) will by default set the number of build
threads to the number of available cores.
This is often a bad idea, e.g. with 20 cores and 32GB this leads to a
freeze of the system.
As far as I
On Fri, 19 Apr 2024 13:32:14 GMT, Johan Vos wrote:
> Increase JavaFX release version to 17.0.12
This pull request has now been integrated.
Changeset: 685b18e3
Author: Johan Vos
URL:
https://git.openjdk.org/jfx17u/commit/685b18e3625019307d437e38964a0e83ff26b801
Stats: 2 li
On Fri, 19 Apr 2024 13:29:07 GMT, Johan Vos wrote:
> Increase JavaFX release version
This pull request has now been integrated.
Changeset: 9a5ff29a
Author: Johan Vos
URL:
https://git.openjdk.org/jfx21u/commit/9a5ff29ac8f7906280912fbff2a5f5cc4fba999f
Stats: 2 lines in 2 fi
Increase JavaFX release version to 17.0.12
-
Commit messages:
- Increase JavaFX release version to 17.0.12
Changes: https://git.openjdk.org/jfx17u/pull/189/files
Webrev: https://webrevs.openjdk.org/?repo=jfx17u=189=00
Issue: https://bugs.openjdk.org/browse/JDK-8330682
Stats:
On Fri, 19 Apr 2024 13:29:07 GMT, Johan Vos wrote:
> Increase JavaFX release version
Reviewers: @jperedadnr
-
PR Comment: https://git.openjdk.org/jfx21u/pull/56#issuecomment-2066600419
Increase JavaFX release version
-
Commit messages:
- Increase JavaFX release version to 21.0.4
Changes: https://git.openjdk.org/jfx21u/pull/56/files
Webrev: https://webrevs.openjdk.org/?repo=jfx21u=56=00
Issue: https://bugs.openjdk.org/browse/JDK-8330683
Stats: 2 lines in 2
On Thu, 18 Apr 2024 17:57:42 GMT, Oliver Kopp wrote:
> Based on my experience, I would create a test for `WinTextRangeProvider`
> directly and supply some values to it to check that the "right" branches are
> covered.
Based on what I see from the stacktrace, this sounds good. We now know that
On Tue, 16 Apr 2024 14:20:48 GMT, Johan Vos wrote:
> Almost clean merge of April CPU content into jfx17u:master
This pull request has now been integrated.
Changeset: fe602e27
Author: Johan Vos
URL:
https://git.openjdk.org/jfx17u/commit/fe602e27226000cd9f51299c0edc6fa63d2db680
St
> Almost clean merge of April CPU content into jfx17u:master
Johan Vos has updated the pull request with a new target base due to a merge or
a rebase. The incremental webrev excludes the unrelated changes brought in by
the merge/rebase.
-
Changes:
- all: https://git.openjdk.
> Clean merge of April CPU content into jfx21u
Johan Vos has updated the pull request with a new target base due to a merge or
a rebase. The incremental webrev excludes the unrelated changes brought in by
the merge/rebase.
-
Changes:
- all: https://git.openjdk.org/jfx21u/pull
On Tue, 16 Apr 2024 14:18:57 GMT, Johan Vos wrote:
> Clean merge of April CPU content into jfx21u
This pull request has now been integrated.
Changeset: f26b3506
Author: Johan Vos
URL:
https://git.openjdk.org/jfx21u/commit/f26b3506a96d2c09a3304948555ee487f0746a9c
Stats: 592 li
On Tue, 16 Apr 2024 14:11:34 GMT, Kevin Rushforth wrote:
> Clean merge of April CPU content into `jfx22u:master`.
>
> Reviewer: @johanvos
Marked as reviewed by jvos (Reviewer).
-
PR Review: https://git.openjdk.org/jfx22u/pull/26#pullrequestreview-2003809471
On Fri, 5 Apr 2024 18:40:38 GMT, Kevin Rushforth wrote:
> Release notes for JavaFX 22.0.1.
>
> Notes to reviewers:
>
> I used the following filter to pick the issues:
>
> https://bugs.openjdk.org/issues/?filter=45526
>
> The original filter, with the backport IDs, is here:
>
>
Clean merge of April CPU content into jfx21u
-
Commit messages:
- 8322236: Build failure after JDK-8313064
- 8313064: General enhancements of image handling
- 8313040: Enhanced Font handling
- 8313072: Enhanced handling of Fonts
- 8320441: Additonal fix for JDK-8313032
-
Almost clean merge of April CPU content into jfx17u:master
-
Commit messages:
- 8322236: Build failure after JDK-8313064
- 8313064: General enhancements of image handling
- 8313040: Enhanced Font handling
- 8313072: Enhanced handling of Fonts
- 8320441: Additonal fix for
On Tue, 16 Apr 2024 14:10:43 GMT, Kevin Rushforth wrote:
> Clean merge of April CPU content into `jfx:master`.
>
> Reviewer: @johanvos
Marked as reviewed by jvos (Reviewer).
-
PR Review: https://git.openjdk.org/jfx/pull/1441#pullrequestreview-2003793361
On Mon, 15 Jan 2024 08:31:59 GMT, Florian Kirmaier
wrote:
>> As seen in the unit test of the PR, when we click on the area above/below
>> the scrollbar the position jumps - but the jump is now not always consistent.
>> In the current version on the last cell - the UI always jumps to the top.
M Marius Hanl wrote:
>
>> I agree that this a nice feature, especially for headless tests as you
>> also mentioned.
>> Really looking forward to this feature.
>>
>> - Marius
>>
>> *Gesendet:* Dienstag, 30. Januar 2024 um 12:46 Uhr
>> *Von:* &
On Mon, 15 Jan 2024 08:31:59 GMT, Florian Kirmaier
wrote:
>> As seen in the unit test of the PR, when we click on the area above/below
>> the scrollbar the position jumps - but the jump is now not always consistent.
>> In the current version on the last cell - the UI always jumps to the top.
On Mon, 15 Jan 2024 08:31:59 GMT, Florian Kirmaier
wrote:
>> As seen in the unit test of the PR, when we click on the area above/below
>> the scrollbar the position jumps - but the jump is now not always consistent.
>> In the current version on the last cell - the UI always jumps to the top.
On Mon, 15 Jan 2024 08:31:59 GMT, Florian Kirmaier
wrote:
>> As seen in the unit test of the PR, when we click on the area above/below
>> the scrollbar the position jumps - but the jump is now not always consistent.
>> In the current version on the last cell - the UI always jumps to the top.
On Mon, 11 Mar 2024 15:18:51 GMT, eduardsdv wrote:
>> modules/javafx.controls/src/main/java/javafx/scene/control/skin/VirtualFlow.java
>> line 1556:
>>
>>> 1554: if (targetCell != null) {
>>> 1555: if (targetIndex < 0) {
>>> 1556: T cell =
On Fri, 15 Mar 2024 16:36:57 GMT, Kevin Rushforth wrote:
> This is a necessary backport of the JavaFX 22 release notes to the `jfx22`
> branch.
>
> NOTE: We will _not_ tag `jfx22` nor rebuild JavaFX 22 as a result of this
> commit.
Marked as reviewed by jvos (Reviewer).
-
PR
On Wed, 13 Mar 2024 23:15:05 GMT, Kevin Rushforth wrote:
> Release notes for the JavaFX 22 release. This will first go into `master` and
> then be backported to the `jfx22` branch so it will be available in that
> branch when JavaFX 22 is published, and from there also synced into the
>
bility for a future JavaFX release? AFAIK the last JavaFX release with
> this platform supported on Monocle was JavaFX 18.
>
> Thanks,
> Craig
>
> On Fri, Jun 9, 2023 at 9:30 AM Johan Vos wrote:
>
>> The monocle classes are not included in the default
>> d
On Tue, 12 Mar 2024 09:27:37 GMT, Johan Vos wrote:
> 8322795: CSS performance regression up to 10x
This pull request has now been integrated.
Changeset: c2600685
Author: Johan Vos
URL:
https://git.openjdk.org/jfx21u/commit/c2600685dbba9f33e01b9b0fcf2346df9b5e0011
Stats: 6 li
8322795: CSS performance regression up to 10x
-
Commit messages:
- Backport 1dff7a1618a945a9a10ad2168f78aad3658e91a9
Changes: https://git.openjdk.org/jfx21u/pull/54/files
Webrev: https://webrevs.openjdk.org/?repo=jfx21u=54=00
Issue: https://bugs.openjdk.org/browse/JDK-8322795
On Wed, 3 Jan 2024 01:14:13 GMT, John Hendrikx wrote:
> The regression is caused by the `Collections.unmodifiableSet` wrapper not
> being recognized by `BitSet`, and a fall back is done to a less optimized
> version of `containsAll`.
>
> As this is a regression fix, I've kept the fix as small
On Fri, 8 Mar 2024 10:18:21 GMT, Johan Vos wrote:
> Hi all,
>
> This pull request contains a backport of commit 64af9875 from the openjdk/jfx
> repository.
>
> The commit being backported was authored by Hima Bindu Meda on 7 Mar 2024 and
> was reviewed by Kevin Rush
Hi all,
This pull request contains a backport of commit 64af9875 from the openjdk/jfx
repository.
The commit being backported was authored by Hima Bindu Meda on 7 Mar 2024 and
was reviewed by Kevin Rushforth and Jose Pereda.
Thanks!
-
Commit messages:
- Backport
On Fri, 8 Mar 2024 10:13:27 GMT, Johan Vos wrote:
> Hi all,
>
> This pull request contains a backport of commit 64af9875 from the openjdk/jfx
> repository.
>
> The commit being backported was authored by Hima Bindu Meda on 7 Mar 2024 and
> was reviewed by Kevin Rush
Hi all,
This pull request contains a backport of commit 64af9875 from the openjdk/jfx
repository.
The commit being backported was authored by Hima Bindu Meda on 7 Mar 2024 and
was reviewed by Kevin Rushforth and Jose Pereda.
Thanks!
-
Commit messages:
- Backport
On Fri, 8 Mar 2024 10:09:53 GMT, Johan Vos wrote:
> 8325258: Additional WebKit 617.1 fixes from WebKitGTK 2.42.5
This pull request has now been integrated.
Changeset: eb922637
Author: Johan Vos
URL:
https://git.openjdk.org/jfx17u/commit/eb9226375bdaa2edc0976d51f34337721ef0c9bb
St
8325258: Additional WebKit 617.1 fixes from WebKitGTK 2.42.5
-
Commit messages:
- Backport a7f6de8d13fd7a7e37ca80b28badcb24566153d8
Changes: https://git.openjdk.org/jfx17u/pull/186/files
Webrev: https://webrevs.openjdk.org/?repo=jfx17u=186=00
Issue:
On Fri, 8 Mar 2024 10:03:29 GMT, Johan Vos wrote:
> 8325258: Additional WebKit 617.1 fixes from WebKitGTK 2.42.5
This pull request has now been integrated.
Changeset: b0ed455c
Author: Johan Vos
URL:
https://git.openjdk.org/jfx21u/commit/b0ed455c3bdb60b18427f568c609a89a8e88b4ed
St
8325258: Additional WebKit 617.1 fixes from WebKitGTK 2.42.5
-
Commit messages:
- Backport a7f6de8d13fd7a7e37ca80b28badcb24566153d8
Changes: https://git.openjdk.org/jfx21u/pull/52/files
Webrev: https://webrevs.openjdk.org/?repo=jfx21u=52=00
Issue:
On Fri, 8 Mar 2024 10:01:26 GMT, Johan Vos wrote:
> 8324337: Cherry-pick WebKit 617.1 stabilization fixes
This pull request has now been integrated.
Changeset: 426f4eb0
Author: Johan Vos
URL:
https://git.openjdk.org/jfx17u/commit/426f4eb0001e9d1c747df0951446030c3d0adcec
St
8324337: Cherry-pick WebKit 617.1 stabilization fixes
-
Commit messages:
- Backport 52840a17dee6a92fb9b1f3ff1b314b0ae228b95f
Changes: https://git.openjdk.org/jfx17u/pull/185/files
Webrev: https://webrevs.openjdk.org/?repo=jfx17u=185=00
Issue:
On Fri, 8 Mar 2024 09:29:55 GMT, Johan Vos wrote:
> 8324337: Cherry-pick WebKit 617.1 stabilization fixes
This pull request has now been integrated.
Changeset: eec2c96b
Author: Johan Vos
URL:
https://git.openjdk.org/jfx21u/commit/eec2c96b8d35b65d6090496451114b00c9ecd3ca
St
8324337: Cherry-pick WebKit 617.1 stabilization fixes
-
Commit messages:
- Backport 52840a17dee6a92fb9b1f3ff1b314b0ae228b95f
Changes: https://git.openjdk.org/jfx21u/pull/51/files
Webrev: https://webrevs.openjdk.org/?repo=jfx21u=51=00
Issue:
On Fri, 8 Mar 2024 09:09:37 GMT, Johan Vos wrote:
> Hi all,
>
> This pull request contains a backport of commit 8114559e from the openjdk/jfx
> repository.
>
> The commit being backported was authored by Johan Vos on 4 Mar 2024 and was
> reviewed by Kevin Rushforth.
&g
Hi all,
This pull request contains a backport of commit 8114559e from the openjdk/jfx
repository.
The commit being backported was authored by Johan Vos on 4 Mar 2024 and was
reviewed by Kevin Rushforth.
Thanks!
-
Commit messages:
- Backport
On Thu, 7 Mar 2024 11:28:01 GMT, Johan Vos wrote:
> Almost clean backport of JDK-8318386.
> The original patch contains a fix to gstaacparse.c which is not in jfx17u
> because it does not have JDK-8277309 (JDK-8277309)
This pull request has now been integrated.
Changeset: 349224
On Thu, 7 Mar 2024 11:32:29 GMT, Johan Vos wrote:
> Hi all,
>
> This pull request contains a backport of commit
> [ba79e081](https://github.com/openjdk/jfx/commit/ba79e081547b7f15697bfaaac42ec2de1971935a)
> from the [openjdk/jfx](https://git.openjdk.org/jfx) repository.
>
On Thu, 7 Mar 2024 11:03:42 GMT, Johan Vos wrote:
> Hi all,
>
> This pull request contains a backport of commit
> [ba79e081](https://github.com/openjdk/jfx/commit/ba79e081547b7f15697bfaaac42ec2de1971935a)
> from the [openjdk/jfx](https://git.openjdk.org/jfx) repository.
>
On Tue, 5 Mar 2024 16:44:55 GMT, Johan Vos wrote:
> 8327177: macOS: wrong GlobalRef deleted in GlassMenu
This pull request has now been integrated.
Changeset: d70fa5f1
Author: Johan Vos
URL:
https://git.openjdk.org/jfx22u/commit/d70fa5f160c5a90f4c704ad514921d5421291bbf
Stats:
> Almost clean backport of JDK-8318386.
> The original patch contains a fix to gstaacparse.c which is not in jfx17u
> because it does not have JDK-8277309 (JDK-8277309)
Johan Vos has updated the pull request with a new target base due to a merge or
a rebase. The incremental webrev
Bindu Meda on 16 Jan 2024
> and was reviewed by Joeri Sykora and Kevin Rushforth.
>
> Thanks!
Johan Vos has updated the pull request with a new target base due to a merge or
a rebase. The incremental webrev excludes the unrelated changes brought in by
the merge/rebase. The pull r
On Thu, 7 Mar 2024 13:17:00 GMT, Johan Vos wrote:
> 8282386: JavaFX media stubs rely on libav.org
This pull request has now been integrated.
Changeset: 9ac6fa52
Author: Johan Vos
URL:
https://git.openjdk.org/jfx17u/commit/9ac6fa5295af8e157c6d1ee8a75393731a426ee4
Stats: 21 li
8282386: JavaFX media stubs rely on libav.org
-
Commit messages:
- Backport 357cd8563bd6ca47afd28dd1481afbe2d2458827
Changes: https://git.openjdk.org/jfx17u/pull/183/files
Webrev: https://webrevs.openjdk.org/?repo=jfx17u=183=00
Issue: https://bugs.openjdk.org/browse/JDK-8282386
Hi all,
This pull request contains a backport of commit
[ba79e081](https://github.com/openjdk/jfx/commit/ba79e081547b7f15697bfaaac42ec2de1971935a)
from the [openjdk/jfx](https://git.openjdk.org/jfx) repository.
The commit being backported was authored by Hima Bindu Meda on 16 Jan 2024 and
was
On Tue, 5 Mar 2024 16:46:28 GMT, Johan Vos wrote:
> 8327177: macOS: wrong GlobalRef deleted in GlassMenu
This pull request has now been integrated.
Changeset: 98293abf
Author: Johan Vos
URL:
https://git.openjdk.org/jfx21u/commit/98293abf8e9aa5db28d776c0391b46d1bf0951af
Stats:
Almost clean backport of JDK-8318386.
The original patch contains a fix to gstaacparse.c which is not in jfx17u
because it does not have JDK-8277309 (JDK-8277309)
-
Commit messages:
- Backport 606878af275dbad551a10653c92a2deef61c10cd
Changes:
Hi all,
This pull request contains a backport of commit
[ba79e081](https://github.com/openjdk/jfx/commit/ba79e081547b7f15697bfaaac42ec2de1971935a)
from the [openjdk/jfx](https://git.openjdk.org/jfx) repository.
The commit being backported was authored by Hima Bindu Meda on 16 Jan 2024 and
was
On Wed, 6 Mar 2024 12:20:12 GMT, Johan Vos wrote:
> 8271398: GTK3 drag view image swaps red and blue color channels
This pull request has now been integrated.
Changeset: af405910
Author: Johan Vos
URL:
https://git.openjdk.org/jfx17u/commit/af4059107850e8c3d974753add6e666f1dd52
8271398: GTK3 drag view image swaps red and blue color channels
-
Commit messages:
- Backport b2ecfacf0d8c9512d0b4cc13c1ac6c104a20f396
Changes: https://git.openjdk.org/jfx17u/pull/180/files
Webrev: https://webrevs.openjdk.org/?repo=jfx17u=180=00
Issue:
> A listener was added but never removed.
> This patch removes the listener when the menu it links to is cleared. Fix for
> https://bugs.openjdk.org/browse/JDK-8319779
Johan Vos has updated the pull request incrementally with one additional commit
since the last revision:
Remove
On Wed, 6 Mar 2024 07:59:10 GMT, Johan Vos wrote:
>> A listener was added but never removed.
>> This patch removes the listener when the menu it links to is cleared. Fix
>> for https://bugs.openjdk.org/browse/JDK-8319779
>
> Johan Vos has updated the pull reques
> A listener was added but never removed.
> This patch removes the listener when the menu it links to is cleared. Fix for
> https://bugs.openjdk.org/browse/JDK-8319779
Johan Vos has updated the pull request incrementally with one additional commit
since the last revision:
Ignore tes
On Tue, 5 Mar 2024 16:47:45 GMT, Kevin Rushforth wrote:
> Now that the last of the javadoc warnings are fixed or suppressed, it is time
> to enable `-Werror` so that new javadoc warnings don't creep into our code
> base. The GHA run was successful.
>
> You can see the `-Werror` doing its job
8327177: macOS: wrong GlobalRef deleted in GlassMenu
-
Commit messages:
- Backport 8114559ed666fe272d238cdf1e531e5d8ec6
Changes: https://git.openjdk.org/jfx21u/pull/49/files
Webrev: https://webrevs.openjdk.org/?repo=jfx21u=49=00
Issue:
8327177: macOS: wrong GlobalRef deleted in GlassMenu
-
Commit messages:
- Backport 8114559ed666fe272d238cdf1e531e5d8ec6
Changes: https://git.openjdk.org/jfx22u/pull/16/files
Webrev: https://webrevs.openjdk.org/?repo=jfx22u=16=00
Issue:
On Mon, 15 Jan 2024 08:31:59 GMT, Florian Kirmaier
wrote:
>> As seen in the unit test of the PR, when we click on the area above/below
>> the scrollbar the position jumps - but the jump is now not always consistent.
>> In the current version on the last cell - the UI always jumps to the top.
1 - 100 of 562 matches
Mail list logo
