On Fri, 9 Feb 2024 16:02:19 GMT, Andy Goryachev wrote:
>> Kevin Rushforth has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Address review feedback
>
> tests/system/src/test/java/test/robot/javafx/scene/TransparentLCDTest.java
> line 69:
On Fri, 9 Feb 2024 14:29:18 GMT, Kevin Rushforth wrote:
>> JavaFX LCD text rendering (aka sub-pixel antialiasing) uses a pixel shader
>> and alpha blending. The alpha channel is used is ways that interfere with
>> its use for transparency. The existing logic checks that the current blend
>> eq
On Fri, 9 Feb 2024 15:58:12 GMT, Kevin Rushforth wrote:
>> tests/system/src/test/java/test/robot/javafx/scene/TransparentLCDTest.java
>> line 81:
>>
>>> 79: // color, or in the middle of the text fill area, where we expect
>>> to find
>>> 80: // the unadjusted text color.
>>> 81: p
On Fri, 9 Feb 2024 15:53:20 GMT, Andy Goryachev wrote:
>> Kevin Rushforth has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Address review feedback
>
> tests/system/src/test/java/test/robot/javafx/scene/TransparentLCDTest.java
> line 67:
On Fri, 9 Feb 2024 14:29:18 GMT, Kevin Rushforth wrote:
>> JavaFX LCD text rendering (aka sub-pixel antialiasing) uses a pixel shader
>> and alpha blending. The alpha channel is used is ways that interfere with
>> its use for transparency. The existing logic checks that the current blend
>> eq
On Fri, 9 Feb 2024 14:29:18 GMT, Kevin Rushforth wrote:
>> JavaFX LCD text rendering (aka sub-pixel antialiasing) uses a pixel shader
>> and alpha blending. The alpha channel is used is ways that interfere with
>> its use for transparency. The existing logic checks that the current blend
>> eq
On Fri, 9 Feb 2024 13:09:23 GMT, John Hendrikx wrote:
>> Kevin Rushforth has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Address review feedback
>
> modules/javafx.graphics/src/main/java/com/sun/prism/sw/SWGraphics.java line
> 664:
>
>
> JavaFX LCD text rendering (aka sub-pixel antialiasing) uses a pixel shader
> and alpha blending. The alpha channel is used is ways that interfere with its
> use for transparency. The existing logic checks that the current blend
> equation is SRC_OVER and that the surface is opaque, and that we
