Re: RFR: 8325073: javadoc warnings: missing @param tags and other issues [v3]

2024-03-01 Thread Andy Goryachev
On Fri, 1 Mar 2024 15:53:21 GMT, Andy Goryachev wrote: >> This change brings the number of javadoc warnings back to 91 (to be fixed in >> [JDK-8270996](https://bugs.openjdk.org/browse/JDK-8270996)) >> >> - adds missing information in `@param` tags >> - adds

Re: RFR: 8325073: javadoc warnings: missing @param tags and other issues [v3]

2024-03-01 Thread Ambarish Rapte
On Fri, 1 Mar 2024 15:53:21 GMT, Andy Goryachev wrote: >> This change brings the number of javadoc warnings back to 91 (to be fixed in >> [JDK-8270996](https://bugs.openjdk.org/browse/JDK-8270996)) >> >> - adds missing information in `@param` tags >> - adds

Re: RFR: 8325073: javadoc warnings: missing @param tags and other issues [v3]

2024-03-01 Thread Kevin Rushforth
On Fri, 1 Mar 2024 15:53:21 GMT, Andy Goryachev wrote: >> This change brings the number of javadoc warnings back to 91 (to be fixed in >> [JDK-8270996](https://bugs.openjdk.org/browse/JDK-8270996)) >> >> - adds missing information in `@param` tags >> - adds

Re: RFR: 8325073: javadoc warnings: missing @param tags and other issues [v2]

2024-03-01 Thread Andy Goryachev
On Fri, 1 Mar 2024 03:40:57 GMT, Ambarish Rapte wrote: > there is no empty line between the description and `@param` it makes no difference in the generated javadoc output. I've made the changes anyway, for the developers' sake. - PR Comment:

Re: RFR: 8325073: javadoc warnings: missing @param tags and other issues [v3]

2024-03-01 Thread Andy Goryachev
> This change brings the number of javadoc warnings back to 91 (to be fixed in > [JDK-8270996](https://bugs.openjdk.org/browse/JDK-8270996)) > > - adds missing information in `@param` tags > - adds `@SuppressWarnings("doclint:missing")` to `Skinnable` to silence the > warning due to

Re: RFR: 8325073: javadoc warnings: missing @param tags and other issues [v2]

2024-03-01 Thread Kevin Rushforth
On Fri, 1 Mar 2024 00:22:05 GMT, Andy Goryachev wrote: >> This change brings the number of javadoc warnings back to 91 (to be fixed in >> [JDK-8270996](https://bugs.openjdk.org/browse/JDK-8270996)) >> >> - adds missing information in `@param` tags >> - adds

Re: RFR: 8325073: javadoc warnings: missing @param tags and other issues [v2]

2024-02-29 Thread Ambarish Rapte
On Fri, 1 Mar 2024 00:22:05 GMT, Andy Goryachev wrote: >> This change brings the number of javadoc warnings back to 91 (to be fixed in >> [JDK-8270996](https://bugs.openjdk.org/browse/JDK-8270996)) >> >> - adds missing information in `@param` tags >> - adds

Re: RFR: 8325073: javadoc warnings: missing @param tags and other issues [v2]

2024-02-29 Thread Andy Goryachev
> This change brings the number of javadoc warnings back to 91 (to be fixed in > [JDK-8270996](https://bugs.openjdk.org/browse/JDK-8270996)) > > - adds missing information in `@param` tags > - adds `@SuppressWarnings("doclint:missing")` to `Skinnable` to silence the > warning due to

Re: RFR: 8325073: javadoc warnings: missing @param tags and other issues

2024-02-29 Thread Andy Goryachev
On Thu, 29 Feb 2024 00:07:37 GMT, Kevin Rushforth wrote: >> This change brings the number of javadoc warnings back to 91 (to be fixed in >> [JDK-8270996](https://bugs.openjdk.org/browse/JDK-8270996)) >> >> - adds missing information in `@param` tags >> - adds

Re: RFR: 8325073: javadoc warnings: missing @param tags and other issues

2024-02-29 Thread Kevin Rushforth
On Wed, 28 Feb 2024 21:48:38 GMT, Andy Goryachev wrote: > This change brings the number of javadoc warnings back to 91 (to be fixed in > [JDK-8270996](https://bugs.openjdk.org/browse/JDK-8270996)) > > - adds missing information in `@param` tags > - adds `@SuppressWarnings("doclint:missing")`

Re: RFR: 8325073: javadoc warnings: missing @param tags and other issues

2024-02-29 Thread Andy Goryachev
On Wed, 28 Feb 2024 21:48:38 GMT, Andy Goryachev wrote: > This change brings the number of javadoc warnings back to 91 (to be fixed in > [JDK-8270996](https://bugs.openjdk.org/browse/JDK-8270996)) > > - adds missing information in `@param` tags > - adds `@SuppressWarnings("doclint:missing")`

Re: RFR: 8325073: javadoc warnings: missing @param tags and other issues

2024-02-28 Thread Kevin Rushforth
On Wed, 28 Feb 2024 21:48:38 GMT, Andy Goryachev wrote: > Q: Does this PR need a CSR? Not if all of the changes are just clarification or documenting missing parameters. - PR Comment: https://git.openjdk.org/jfx/pull/1384#issuecomment-1970132810

RFR: 8325073: javadoc warnings: missing @param tags and other issues

2024-02-28 Thread Andy Goryachev
This change brings the number of javadoc warnings back to 91 (to be fixed in [JDK-8270996](https://bugs.openjdk.org/browse/JDK-8270996)) - adds missing information in `@param` tags - adds `@SuppressWarnings("doclint:missing")` to `Skinnable` to silence the warning due to