Re: [jfx23u] RFR: 8337481: File API: file.name contains path instead of name

2024-09-04 Thread duke
On Wed, 4 Sep 2024 12:30:43 GMT, Oliver Schmidtmer wrote: > Clean backport of JDK-8337481 @Schmidor Your change (at version a3db959ad2d9422b1e8da9b75c18a0586a35c0ba) is now ready to be sponsored by a Committer. - PR Comment: https://git.openjdk.org/jfx23u/pull/19#issuecomment-23

[jfx23u] RFR: 8337481: File API: file.name contains path instead of name

2024-09-04 Thread Oliver Schmidtmer
Clean backport of JDK-8337481 - Commit messages: - Backport ca70a07b3ee712b1d06baf8a3901e6ae96070124 Changes: https://git.openjdk.org/jfx23u/pull/19/files Webrev: https://webrevs.openjdk.org/?repo=jfx23u&pr=19&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8337481 Stats:

Re: RFR: 8337481: File API: file.name contains path instead of name [v3]

2024-08-30 Thread duke
On Fri, 30 Aug 2024 11:34:56 GMT, Oliver Schmidtmer wrote: >> FileSystemJava had no valid implementation for pathFileName since the >> function was renamed from pathGetFileName to pathFileName in the >> FileSystem.h from WebKit > > Oliver Schmidtmer has updated the pull request incrementally wi

Re: RFR: 8337481: File API: file.name contains path instead of name [v3]

2024-08-30 Thread Hima Bindu Meda
On Fri, 30 Aug 2024 11:34:56 GMT, Oliver Schmidtmer wrote: >> FileSystemJava had no valid implementation for pathFileName since the >> function was renamed from pathGetFileName to pathFileName in the >> FileSystem.h from WebKit > > Oliver Schmidtmer has updated the pull request incrementally wi

Re: RFR: 8337481: File API: file.name contains path instead of name [v3]

2024-08-30 Thread Ambarish Rapte
On Fri, 30 Aug 2024 11:34:56 GMT, Oliver Schmidtmer wrote: >> FileSystemJava had no valid implementation for pathFileName since the >> function was renamed from pathGetFileName to pathFileName in the >> FileSystem.h from WebKit > > Oliver Schmidtmer has updated the pull request incrementally wi

Re: RFR: 8337481: File API: file.name contains path instead of name [v2]

2024-08-30 Thread Oliver Schmidtmer
On Fri, 30 Aug 2024 08:18:28 GMT, Ambarish Rapte wrote: >> Oliver Schmidtmer has updated the pull request incrementally with one >> additional commit since the last revision: >> >> add test > > modules/javafx.web/src/test/java/test/javafx/scene/web/FileTest.java line 94: > >> 92: });

Re: RFR: 8337481: File API: file.name contains path instead of name [v2]

2024-08-30 Thread Oliver Schmidtmer
On Fri, 30 Aug 2024 08:18:08 GMT, Ambarish Rapte wrote: >> Oliver Schmidtmer has updated the pull request incrementally with one >> additional commit since the last revision: >> >> add test > > modules/javafx.web/src/main/native/Source/WTF/wtf/java/FileSystemJava.cpp > line 276: > >> 274: }

Re: RFR: 8337481: File API: file.name contains path instead of name [v3]

2024-08-30 Thread Oliver Schmidtmer
> FileSystemJava had no valid implementation for pathFileName since the > function was renamed from pathGetFileName to pathFileName in the FileSystem.h > from WebKit Oliver Schmidtmer has updated the pull request incrementally with one additional commit since the last revision: Requested cha

Re: RFR: 8337481: File API: file.name contains path instead of name [v2]

2024-08-30 Thread Ambarish Rapte
On Thu, 29 Aug 2024 14:11:01 GMT, Oliver Schmidtmer wrote: >> FileSystemJava had no valid implementation for pathFileName since the >> function was renamed from pathGetFileName to pathFileName in the >> FileSystem.h from WebKit > > Oliver Schmidtmer has updated the pull request incrementally wi

Re: RFR: 8337481: File API: file.name contains path instead of name [v2]

2024-08-29 Thread Kevin Rushforth
On Thu, 29 Aug 2024 14:11:01 GMT, Oliver Schmidtmer wrote: >> FileSystemJava had no valid implementation for pathFileName since the >> function was renamed from pathGetFileName to pathFileName in the >> FileSystem.h from WebKit > > Oliver Schmidtmer has updated the pull request incrementally wi

Re: RFR: 8337481: File API: file.name contains path instead of name [v2]

2024-08-29 Thread Kevin Rushforth
On Thu, 29 Aug 2024 14:11:01 GMT, Oliver Schmidtmer wrote: >> FileSystemJava had no valid implementation for pathFileName since the >> function was renamed from pathGetFileName to pathFileName in the >> FileSystem.h from WebKit > > Oliver Schmidtmer has updated the pull request incrementally wi

Re: RFR: 8337481: File API: file.name contains path instead of name [v2]

2024-08-29 Thread Oliver Schmidtmer
> FileSystemJava had no valid implementation for pathFileName since the > function was renamed from pathGetFileName to pathFileName in the FileSystem.h > from WebKit Oliver Schmidtmer has updated the pull request incrementally with one additional commit since the last revision: add test ---

RFR: 8337481: File API: file.name contains path instead of name

2024-08-29 Thread Oliver Schmidtmer
FileSystemJava had no valid implementation for pathFileName since the function was renamed from pathGetFileName to pathFileName in the FileSystem.h from WebKit - Commit messages: - 8337481 Fix FileSystemJava.pathFileName Changes: https://git.openjdk.org/jfx/pull/1551/files Webrev