On Mon, 21 Nov 2022 17:03:54 GMT, Andy Goryachev wrote:
> This comment might be out of place, but since we started fixing raw type use
> may be you could take a look at it? I know it's in javafx.graphics, so not
> technically a part of this PR, but It's pretty weird. Bringing it up here
>
On Mon, 21 Nov 2022 20:46:57 GMT, Andy Goryachev wrote:
>> I only fixed the warnings listed in the ticket :)
>
> but the ticket specifies (javafx.)base, right?
let's create a followup ticket - the messed up statements in Disposer and
especially in PrismFontFactory:1401 are worrying.
cc:
On Mon, 21 Nov 2022 11:53:30 GMT, John Hendrikx wrote:
> - Remove unsupported/unnecessary SuppressWarning annotations
> - Remove reduntant type specifications (use diamond operator)
> - Remove unused or duplicate imports
> - Remove unnecessary casts (type is already correct type or can be
On Mon, 21 Nov 2022 20:42:51 GMT, John Hendrikx wrote:
>> many of those ^^ appear to be bugs.
>
> I didn't fix all problems, only the easy non-controversial ones. Things that
> might actually be bugs require more careful review and so are best saved for
> smaller PR's IMHO.
>
> This is
On Mon, 21 Nov 2022 16:57:30 GMT, Andy Goryachev wrote:
> One suggestion I'd like to make is to publish the Compiler Errors/Warnings
> configuration for Eclipse. I have a set of screenshots that produce a 0
> err/warn count with the current master. Eclipse also seem to provide a way to
>
On Mon, 21 Nov 2022 20:26:54 GMT, Andy Goryachev wrote:
>> Cool. My eclipse finds other places which do look like a bug - see
>> disposed:65
>> It is in the base - why isn't it this PR?
>
> full list
>
>
> Description ResourceLocation
> Empty control-flow statement
On Mon, 21 Nov 2022 20:25:06 GMT, Andy Goryachev wrote:
>> Yes, `potential programming problems / empty statement`. It can sometimes
>> point to a mistake where a semi colon is used just before a block.
>
> Cool. My eclipse finds other places which do look like a bug - see
> disposed:65
> It
On Mon, 21 Nov 2022 19:53:59 GMT, John Hendrikx wrote:
>> modules/javafx.base/src/main/java/javafx/beans/property/IntegerPropertyBase.java
>> line 56:
>>
>>> 54:
>>> 55: private int value;
>>> 56: private ObservableIntegerValue observable = null;;
>>
>> is there an Eclipse warning
On Mon, 21 Nov 2022 11:53:30 GMT, John Hendrikx wrote:
> - Remove unsupported/unnecessary SuppressWarning annotations
> - Remove reduntant type specifications (use diamond operator)
> - Remove unused or duplicate imports
> - Remove unnecessary casts (type is already correct type or can be
On Mon, 21 Nov 2022 19:58:31 GMT, John Hendrikx wrote:
>> This is in the test shims, so not public API.
>
> Shims are not public as far as I know.
you are right. I just looked at the package "package javafx.event;" and said
hmmm...
-
PR: https://git.openjdk.org/jfx/pull/957
On Mon, 21 Nov 2022 19:32:01 GMT, Kevin Rushforth wrote:
>> modules/javafx.base/src/test/java/test/util/memory/JMemoryBuddy.java line
>> 123:
>>
>>> 121:
>>> 122: if (weakReference.get() == null && counter < steps / 3) {
>>> 123: int percentageUsed = (steps - counter) /
On Mon, 21 Nov 2022 19:26:48 GMT, Kevin Rushforth wrote:
>> modules/javafx.base/src/shims/java/javafx/event/EventTypeShim.java line 30:
>>
>>> 28: import java.util.List;
>>> 29:
>>> 30: public class EventTypeShim {
>>
>> this changes public API surface, does it not?
>
> This is in the test
On Mon, 21 Nov 2022 17:29:42 GMT, Andy Goryachev wrote:
>> - Remove unsupported/unnecessary SuppressWarning annotations
>> - Remove reduntant type specifications (use diamond operator)
>> - Remove unused or duplicate imports
>> - Remove unnecessary casts (type is already correct type or can be
On Mon, 21 Nov 2022 17:20:43 GMT, Andy Goryachev wrote:
>> - Remove unsupported/unnecessary SuppressWarning annotations
>> - Remove reduntant type specifications (use diamond operator)
>> - Remove unused or duplicate imports
>> - Remove unnecessary casts (type is already correct type or can be
On Mon, 21 Nov 2022 19:11:16 GMT, Andy Goryachev wrote:
>> - Remove unsupported/unnecessary SuppressWarning annotations
>> - Remove reduntant type specifications (use diamond operator)
>> - Remove unused or duplicate imports
>> - Remove unnecessary casts (type is already correct type or can be
On Mon, 21 Nov 2022 17:35:08 GMT, Andy Goryachev wrote:
>> - Remove unsupported/unnecessary SuppressWarning annotations
>> - Remove reduntant type specifications (use diamond operator)
>> - Remove unused or duplicate imports
>> - Remove unnecessary casts (type is already correct type or can be
On Mon, 21 Nov 2022 11:53:30 GMT, John Hendrikx wrote:
> - Remove unsupported/unnecessary SuppressWarning annotations
> - Remove reduntant type specifications (use diamond operator)
> - Remove unused or duplicate imports
> - Remove unnecessary casts (type is already correct type or can be
On Mon, 21 Nov 2022 11:53:30 GMT, John Hendrikx wrote:
> - Remove unsupported/unnecessary SuppressWarning annotations
> - Remove reduntant type specifications (use diamond operator)
> - Remove unused or duplicate imports
> - Remove unnecessary casts (type is already correct type or can be
On Mon, 21 Nov 2022 11:53:30 GMT, John Hendrikx wrote:
> - Remove unsupported/unnecessary SuppressWarning annotations
> - Remove reduntant type specifications (use diamond operator)
> - Remove unused or duplicate imports
> - Remove unnecessary casts (type is already correct type or can be
On Mon, 21 Nov 2022 11:53:30 GMT, John Hendrikx wrote:
> - Remove unsupported/unnecessary SuppressWarning annotations
> - Remove reduntant type specifications (use diamond operator)
> - Remove unused or duplicate imports
> - Remove unnecessary casts (type is already correct type or can be
On Mon, 21 Nov 2022 15:19:24 GMT, Kevin Rushforth wrote:
> The main thing to be careful of is that we don't touch any public API
> signatures, since some of these sort of automated changes can have impact
> that we would need to consider.
This set of warnings doesn't change method signatures.
On Mon, 21 Nov 2022 11:53:30 GMT, John Hendrikx wrote:
> - Remove unsupported/unnecessary SuppressWarning annotations
> - Remove reduntant type specifications (use diamond operator)
> - Remove unused or duplicate imports
> - Remove unnecessary casts (type is already correct type or can be
On Mon, 21 Nov 2022 11:53:30 GMT, John Hendrikx wrote:
> - Remove unsupported/unnecessary SuppressWarning annotations
> - Remove reduntant type specifications (use diamond operator)
> - Remove unused or duplicate imports
> - Remove unnecessary casts (type is already correct type or can be
On Mon, 21 Nov 2022 11:53:30 GMT, John Hendrikx wrote:
> - Remove unsupported/unnecessary SuppressWarning annotations
> - Remove reduntant type specifications (use diamond operator)
> - Remove unused or duplicate imports
> - Remove unnecessary casts (type is already correct type or can be
- Remove unsupported/unnecessary SuppressWarning annotations
- Remove reduntant type specifications (use diamond operator)
- Remove unused or duplicate imports
- Remove unnecessary casts (type is already correct type or can be autoboxed)
- Remove unnecessary semi-colons (at end of class
25 matches
Mail list logo
