On Sun, 11 Dec 2022 14:30:22 GMT, John Hendrikx wrote:
>> - Added generics (to package private or internal classes only)
>> - Minor clean-ups of code I touched (naming)
>> - Fixed incorrect use of generics
>> - Fixed raw type warnings
>>
>> Note: some raw types have leaked into public API.
On Sun, 11 Dec 2022 14:30:22 GMT, John Hendrikx wrote:
>> - Added generics (to package private or internal classes only)
>> - Minor clean-ups of code I touched (naming)
>> - Fixed incorrect use of generics
>> - Fixed raw type warnings
>>
>> Note: some raw types have leaked into public API.
> - Added generics (to package private or internal classes only)
> - Minor clean-ups of code I touched (naming)
> - Fixed incorrect use of generics
> - Fixed raw type warnings
>
> Note: some raw types have leaked into public API. These could be fixed
> without incompatibilities. For specifics
On Sat, 10 Dec 2022 21:55:03 GMT, Nir Lisker wrote:
>> John Hendrikx has updated the pull request incrementally with three
>> additional commits since the last revision:
>>
>> - Adjusted ReadOnlyListProperty#equals to be a bit more modern Java
>> - Remove SuppressWarnings in
On Sat, 10 Dec 2022 08:23:07 GMT, John Hendrikx wrote:
>> - Added generics (to package private or internal classes only)
>> - Minor clean-ups of code I touched (naming)
>> - Fixed incorrect use of generics
>> - Fixed raw type warnings
>>
>> Note: some raw types have leaked into public API.
On Sat, 10 Dec 2022 13:39:42 GMT, Nir Lisker wrote:
> On another note, I'm looking at ListExpression's add and other modifying
> methods. It's calling EMPTY_LIST.add(element) where ObservableList EMPTY_LIST
> = FXCollections.emptyObservableList();. Wouldn't that throw an exception
> since
On Sat, 10 Dec 2022 08:18:34 GMT, John Hendrikx wrote:
>>> So... it's also a list.
>>
>> I think it's a big mess, you can already see that in the hierarchy,
>> extending both `ObservableObjectValue>` (which is
>> `ObservableValue`) but also being a `ObservableList`. One or the
>> other is
> - Added generics (to package private or internal classes only)
> - Minor clean-ups of code I touched (naming)
> - Fixed incorrect use of generics
> - Fixed raw type warnings
>
> Note: some raw types have leaked into public API. These could be fixed
> without incompatibilities. For specifics
On Thu, 8 Dec 2022 19:38:02 GMT, Nir Lisker wrote:
>> John Hendrikx has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Revert renames in Disposer
>
> modules/javafx.base/src/main/java/com/sun/javafx/property/adapter/PropertyDescriptor.java
On Sat, 10 Dec 2022 08:03:27 GMT, John Hendrikx wrote:
>> I was just going to write that now that I look at it, this is a list
>> comparison according to `List::equals`. No need to redo the whole logic..
>>
>> About the validity of the comparison, `ReadOnlyListProperty` also implements
>>
On Fri, 9 Dec 2022 20:19:57 GMT, Nir Lisker wrote:
> So... it's also a list.
I think it's a big mess, you can already see that in the hierarchy, extending
both `ObservableObjectValue>` (which is `ObservableValue`)
but also being a `ObservableList`. One or the other is going to break;
either
On Fri, 9 Dec 2022 20:11:24 GMT, John Hendrikx wrote:
>> I suggest the following method:
>>
>>
>> @Override
>> public boolean equals(Object obj) {
>> if (this == obj) {
>> return true;
>> }
>> if (!(obj instanceof List otherList)) {
>>
On Fri, 9 Dec 2022 18:40:09 GMT, Nir Lisker wrote:
>> It also removes the need for the `SuppressWarnings` here.
>
> I suggest the following method:
>
>
> @Override
> public boolean equals(Object obj) {
> if (this == obj) {
> return true;
> }
> if
On Fri, 9 Dec 2022 18:06:21 GMT, Nir Lisker wrote:
> I see that you moved the generic type declarations from the inner classes to
> the outer ones. I wasn't getting any raw type warnings on these. What
> requires these?
I checked, it's not strictly required. I tried to make all of these
On Fri, 9 Dec 2022 18:35:57 GMT, John Hendrikx wrote:
>> It's safe as you're never actually using the type `E`, but I suppose the 2nd
>> list can also be `List` as only `equals` is called on it. The 2nd
>> `ListIterator` would then also be `ListIterator`.
>>
>> Casting to a specific generic
On Fri, 9 Dec 2022 18:35:28 GMT, John Hendrikx wrote:
>> modules/javafx.base/src/main/java/javafx/beans/property/ReadOnlyListProperty.java
>> line 119:
>>
>>> 117:
>>> 118: @SuppressWarnings("unchecked")
>>> 119: final List list = (List)obj; // safe cast as elements
>>> are
On Fri, 9 Dec 2022 17:47:33 GMT, Nir Lisker wrote:
>> John Hendrikx has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Revert renames in Disposer
>
> modules/javafx.base/src/main/java/javafx/beans/property/ReadOnlyListProperty.java
> line
On Thu, 8 Dec 2022 14:21:45 GMT, John Hendrikx wrote:
>> - Added generics (to package private or internal classes only)
>> - Minor clean-ups of code I touched (naming)
>> - Fixed incorrect use of generics
>> - Fixed raw type warnings
>>
>> Note: some raw types have leaked into public API.
On Thu, 8 Dec 2022 14:21:45 GMT, John Hendrikx wrote:
>> - Added generics (to package private or internal classes only)
>> - Minor clean-ups of code I touched (naming)
>> - Fixed incorrect use of generics
>> - Fixed raw type warnings
>>
>> Note: some raw types have leaked into public API.
On Wed, 7 Dec 2022 15:08:00 GMT, Nir Lisker wrote:
>> modules/javafx.base/src/main/java/com/sun/javafx/property/adapter/Disposer.java
>> line 47:
>>
>>> 45: public class Disposer implements Runnable {
>>> 46: private static final ReferenceQueue QUEUE = new
>>> ReferenceQueue<>();
>>> 47:
> - Added generics (to package private or internal classes only)
> - Minor clean-ups of code I touched (naming)
> - Fixed incorrect use of generics
> - Fixed raw type warnings
>
> Note: some raw types have leaked into public API. These could be fixed
> without incompatibilities. For specifics
On Wed, 7 Dec 2022 13:25:47 GMT, Kevin Rushforth wrote:
>> - Added generics (to package private or internal classes only)
>> - Minor clean-ups of code I touched (naming)
>> - Fixed incorrect use of generics
>> - Fixed raw type warnings
>>
>> Note: some raw types have leaked into public API.
On Tue, 6 Dec 2022 18:12:39 GMT, John Hendrikx wrote:
> - Added generics (to package private or internal classes only)
> - Minor clean-ups of code I touched (naming)
> - Fixed incorrect use of generics
> - Fixed raw type warnings
>
> Note: some raw types have leaked into public API. These
- Added generics (to package private or internal classes only)
- Minor clean-ups of code I touched (naming)
- Fixed incorrect use of generics
- Fixed raw type warnings
Note: some raw types have leaked into public API. These could be fixed without
incompatibilities. For specifics see
On Tue, 6 Dec 2022 18:12:39 GMT, John Hendrikx wrote:
> - Added generics (to package private or internal classes only)
> - Minor clean-ups of code I touched (naming)
> - Fixed incorrect use of generics
> - Fixed raw type warnings
>
> Note: some raw types have leaked into public API. These
25 matches
Mail list logo
