Re: RFR: 8306021: Add event handler management to EventTarget [v5]

2023-06-12 Thread Kevin Rushforth
On Mon, 12 Jun 2023 18:17:17 GMT, Michael Strauß wrote: >> This PR adds the following methods to the `EventTarget` interface: >> 1. `addEventHandler` >> 2. `removeEventHandler` >> 3. `addEventFilter` >> 4. `removeEventFilter` > > Michael Strauß has updated the pull request incrementally with two

Re: RFR: 8306021: Add event handler management to EventTarget [v5]

2023-06-12 Thread John Hendrikx
On Mon, 12 Jun 2023 18:17:17 GMT, Michael Strauß wrote: >> This PR adds the following methods to the `EventTarget` interface: >> 1. `addEventHandler` >> 2. `removeEventHandler` >> 3. `addEventFilter` >> 4. `removeEventFilter` > > Michael Strauß has updated the pull request incrementally with two

Re: RFR: 8306021: Add event handler management to EventTarget [v5]

2023-06-12 Thread Marius Hanl
On Mon, 12 Jun 2023 18:17:17 GMT, Michael Strauß wrote: >> This PR adds the following methods to the `EventTarget` interface: >> 1. `addEventHandler` >> 2. `removeEventHandler` >> 3. `addEventFilter` >> 4. `removeEventFilter` > > Michael Strauß has updated the pull request incrementally with two

Re: RFR: 8306021: Add event handler management to EventTarget [v5]

2023-06-12 Thread Andy Goryachev
On Mon, 12 Jun 2023 18:17:17 GMT, Michael Strauß wrote: >> This PR adds the following methods to the `EventTarget` interface: >> 1. `addEventHandler` >> 2. `removeEventHandler` >> 3. `addEventFilter` >> 4. `removeEventFilter` > > Michael Strauß has updated the pull request incrementally with two

Re: RFR: 8306021: Add event handler management to EventTarget [v5]

2023-06-12 Thread Nir Lisker
On Mon, 12 Jun 2023 18:17:17 GMT, Michael Strauß wrote: >> This PR adds the following methods to the `EventTarget` interface: >> 1. `addEventHandler` >> 2. `removeEventHandler` >> 3. `addEventFilter` >> 4. `removeEventFilter` > > Michael Strauß has updated the pull request incrementally with two

Re: RFR: 8306021: Add event handler management to EventTarget [v5]

2023-06-12 Thread Michael Strauß
> This PR adds the following methods to the `EventTarget` interface: > 1. `addEventHandler` > 2. `removeEventHandler` > 3. `addEventFilter` > 4. `removeEventFilter` Michael Strauß has updated the pull request incrementally with two additional commits since the last revision: - added tests - Co

Re: RFR: 8306021: Add event handler management to EventTarget [v4]

2023-06-09 Thread Kevin Rushforth
On Mon, 17 Apr 2023 06:00:19 GMT, Michael Strauß wrote: >> This PR adds the following methods to the `EventTarget` interface: >> 1. `addEventHandler` >> 2. `removeEventHandler` >> 3. `addEventFilter` >> 4. `removeEventFilter` > > Michael Strauß has updated the pull request incrementally with one

Re: RFR: 8306021: Add event handler management to EventTarget [v4]

2023-05-12 Thread Michael Strauß
On Fri, 12 May 2023 20:39:16 GMT, Andy Goryachev wrote: > I think CSR needs to be out of Draft status to move this PR along. I changed the status to Proposed. - PR Comment: https://git.openjdk.org/jfx/pull/1090#issuecomment-1546273668

Re: RFR: 8306021: Add event handler management to EventTarget [v4]

2023-05-12 Thread Andy Goryachev
On Mon, 17 Apr 2023 06:00:19 GMT, Michael Strauß wrote: >> This PR adds the following methods to the `EventTarget` interface: >> 1. `addEventHandler` >> 2. `removeEventHandler` >> 3. `addEventFilter` >> 4. `removeEventFilter` > > Michael Strauß has updated the pull request incrementally with one

Re: RFR: 8306021: Add event handler management to EventTarget [v4]

2023-05-12 Thread Andy Goryachev
On Mon, 17 Apr 2023 06:00:19 GMT, Michael Strauß wrote: >> This PR adds the following methods to the `EventTarget` interface: >> 1. `addEventHandler` >> 2. `removeEventHandler` >> 3. `addEventFilter` >> 4. `removeEventFilter` > > Michael Strauß has updated the pull request incrementally with one

Re: RFR: 8306021: Add event handler management to EventTarget [v4]

2023-05-11 Thread Marius Hanl
On Mon, 17 Apr 2023 06:00:19 GMT, Michael Strauß wrote: >> This PR adds the following methods to the `EventTarget` interface: >> 1. `addEventHandler` >> 2. `removeEventHandler` >> 3. `addEventFilter` >> 4. `removeEventFilter` > > Michael Strauß has updated the pull request incrementally with one

Re: RFR: 8306021: Add event handler management to EventTarget [v4]

2023-04-20 Thread Andy Goryachev
On Mon, 17 Apr 2023 06:00:19 GMT, Michael Strauß wrote: >> This PR adds the following methods to the `EventTarget` interface: >> 1. `addEventHandler` >> 2. `removeEventHandler` >> 3. `addEventFilter` >> 4. `removeEventFilter` > > Michael Strauß has updated the pull request incrementally with one

Re: RFR: 8306021: Add event handler management to EventTarget [v4]

2023-04-17 Thread Marius Hanl
On Mon, 17 Apr 2023 06:00:19 GMT, Michael Strauß wrote: >> This PR adds the following methods to the `EventTarget` interface: >> 1. `addEventHandler` >> 2. `removeEventHandler` >> 3. `addEventFilter` >> 4. `removeEventFilter` > > Michael Strauß has updated the pull request incrementally with one

Re: RFR: 8306021: Add event handler management to EventTarget [v4]

2023-04-17 Thread John Hendrikx
On Mon, 17 Apr 2023 06:00:19 GMT, Michael Strauß wrote: >> This PR adds the following methods to the `EventTarget` interface: >> 1. `addEventHandler` >> 2. `removeEventHandler` >> 3. `addEventFilter` >> 4. `removeEventFilter` > > Michael Strauß has updated the pull request incrementally with one

Re: RFR: 8306021: Add event handler management to EventTarget [v4]

2023-04-16 Thread Nir Lisker
On Mon, 17 Apr 2023 06:00:19 GMT, Michael Strauß wrote: >> This PR adds the following methods to the `EventTarget` interface: >> 1. `addEventHandler` >> 2. `removeEventHandler` >> 3. `addEventFilter` >> 4. `removeEventFilter` > > Michael Strauß has updated the pull request incrementally with one

Re: RFR: 8306021: Add event handler management to EventTarget [v4]

2023-04-16 Thread Michael Strauß
> This PR adds the following methods to the `EventTarget` interface: > 1. `addEventHandler` > 2. `removeEventHandler` > 3. `addEventFilter` > 4. `removeEventFilter` Michael Strauß has updated the pull request incrementally with one additional commit since the last revision: doc changes --

Re: RFR: 8306021: Add event handler management to EventTarget [v2]

2023-04-16 Thread Michael Strauß
On Mon, 17 Apr 2023 05:05:48 GMT, Nir Lisker wrote: >> I don't know what "visual events" are, maybe input events? >> Anyway, the added value of this entire javadoc seems to be rather low, I'm >> inclined to just remove it entirely. >> >> By the way, there's a great documentation of the JavaFX e

Re: RFR: 8306021: Add event handler management to EventTarget [v2]

2023-04-16 Thread Nir Lisker
On Mon, 17 Apr 2023 04:51:03 GMT, Michael Strauß wrote: > I don't know what "visual events" are, maybe input events? I thought something like that too, including scroll and touch events. Maybe @kevinrushforth knows. > Anyway, the added value of this entire javadoc seems to be rather low, I'm

Re: RFR: 8306021: Add event handler management to EventTarget [v2]

2023-04-16 Thread Michael Strauß
On Mon, 17 Apr 2023 03:08:27 GMT, Nir Lisker wrote: >> Michael Strauß has updated the pull request incrementally with one >> additional commit since the last revision: >> >> revert a change in Menu > > modules/javafx.controls/src/main/java/javafx/scene/control/TableColumnBase.java > line 738

Re: RFR: 8306021: Add event handler management to EventTarget [v3]

2023-04-16 Thread Michael Strauß
> This PR adds the following methods to the `EventTarget` interface: > 1. `addEventHandler` > 2. `removeEventHandler` > 3. `addEventFilter` > 4. `removeEventFilter` Michael Strauß has updated the pull request incrementally with one additional commit since the last revision: doc changes --

Re: RFR: 8306021: Add event handler management to EventTarget [v2]

2023-04-16 Thread Nir Lisker
On Sat, 15 Apr 2023 18:01:28 GMT, Michael Strauß wrote: >> This PR adds the following methods to the `EventTarget` interface: >> 1. `addEventHandler` >> 2. `removeEventHandler` >> 3. `addEventFilter` >> 4. `removeEventFilter` > > Michael Strauß has updated the pull request incrementally with one

Re: RFR: 8306021: Add event handler management to EventTarget [v2]

2023-04-16 Thread John Hendrikx
On Sat, 15 Apr 2023 18:01:28 GMT, Michael Strauß wrote: >> This PR adds the following methods to the `EventTarget` interface: >> 1. `addEventHandler` >> 2. `removeEventHandler` >> 3. `addEventFilter` >> 4. `removeEventFilter` > > Michael Strauß has updated the pull request incrementally with one

Re: RFR: 8306021: Add event handler management to EventTarget [v2]

2023-04-15 Thread Michael Strauß
On Sat, 15 Apr 2023 18:01:28 GMT, Michael Strauß wrote: >> This PR adds the following methods to the `EventTarget` interface: >> 1. `addEventHandler` >> 2. `removeEventHandler` >> 3. `addEventFilter` >> 4. `removeEventFilter` > > Michael Strauß has updated the pull request incrementally with one

Re: RFR: 8306021: Add event handler management to EventTarget [v2]

2023-04-15 Thread Michael Strauß
> This PR adds the following methods to the `EventTarget` interface: > 1. `addEventHandler` > 2. `removeEventHandler` > 3. `addEventFilter` > 4. `removeEventFilter` Michael Strauß has updated the pull request incrementally with one additional commit since the last revision: revert a change in

Re: RFR: 8306021: Add event handler management to EventTarget

2023-04-15 Thread John Hendrikx
On Wed, 12 Apr 2023 18:19:11 GMT, Michael Strauß wrote: > This PR adds the following methods to the `EventTarget` interface: > 1. `addEventHandler` > 2. `removeEventHandler` > 3. `addEventFilter` > 4. `removeEventFilter` I checked everything, and didn't see any problems; looks good! ---

Re: RFR: 8306021: Add event handler management to EventTarget

2023-04-14 Thread Michael Strauß
On Wed, 12 Apr 2023 18:19:11 GMT, Michael Strauß wrote: > This PR adds the following methods to the `EventTarget` interface: > 1. `addEventHandler` > 2. `removeEventHandler` > 3. `addEventFilter` > 4. `removeEventFilter` This PR assumes that changing the first method signature to the second is a

Re: RFR: 8306021: Add event handler management to EventTarget

2023-04-14 Thread Kevin Rushforth
On Wed, 12 Apr 2023 18:19:11 GMT, Michael Strauß wrote: > This PR adds the following methods to the `EventTarget` interface: > 1. `addEventHandler` > 2. `removeEventHandler` > 3. `addEventFilter` > 4. `removeEventFilter` If we proceed with this, we will need a CSR that documents the incompatibi