[11] Review request: 8087581: Headless Monocle causes core dump when rendering javafx.scene.text.Text

2018-02-28 Thread Alex Kashchenko
Hi OpenJFX developers, issue: https://bugs.openjdk.java.net/browse/JDK-8087581 webrev: http://cr.openjdk.java.net/~akasko/ojfx/8087581/webrev.01/ I am working on windows builds at Red Hat, and some time ago stumbled upon the windows-only font-related crash inside directwrite.cpp. Crash was

Re: Update on enabling JavaFX to work with OpenJDK builds

2018-02-28 Thread Paul Ray Russell
"I mentioned our intention to make it easier for OpenJFX to be built, tested, and run with OpenJDK builds that don't already contain javafx.* modules." +1 Great

Re: Update on enabling JavaFX to work with OpenJDK builds

2018-02-28 Thread Kevin Rushforth
This seems reasonable to me as well: integrating the JavaFX modules into whatever dependency manager you are using seems like a good thing. -- Kevin Johan Vos wrote: Hi Michael, The second question is what I think should be the default. This is similar to Java EE ^^^ EE4J Jakarta

Re: Update on enabling JavaFX to work with OpenJDK builds

2018-02-28 Thread Michael Paus
Hi Kevin, thank you for the update. I appreciate this work very much because I think it is utterly important for JavaFX. While reading the past messages again I was wondering whether this will also address the following two questions. 1. Will there be a way to determine at program start-up

Re: Repositories, AdoptOpenJDK and github

2018-02-28 Thread Laurent Bourgès
Johan, I am following the long discussion and I mostly agree what was said. Maybe it is time to start working on github on few minor / trivial bugs... to test all the new process. I propose to extract few JBS bugs (small) with high ROI (agile /scrum approach) and create shadow copies into github

Re: Update on enabling JavaFX to work with OpenJDK builds

2018-02-28 Thread Michael Paus
I think this feature would be nice to have but I doubt that it is simple to achieve because JavaFX may or may not already be included in the JDK against which you build and on which your project later runs. There needs to be a strategy how to handle all the resulting corner cases. Am 28.02.18

Re: Repositories, AdoptOpenJDK and github

2018-02-28 Thread Johan Vos
I agree with this approach. Having a small number of JBS bugs that are low hanging fruit will be good to see how the flow works. Eugene created an easy one: https://bugs.openjdk.java.net/browse/JDK-8198795 - Johan On Wed, Feb 28, 2018 at 9:52 AM Laurent Bourgès wrote: