Re: Gradle wrappers

As long as it is optional, this seems like a fine idea. When we explored it before, there was some concern about checking in the gradlew.jar file to the repo -- we would need to get additional third-party legal approval -- so I would need to check on that before this can be merged to the

[11] RFR : JDK-8195800 : Eliminate dependency on sun.reflect.misc in javafx modules

Hi Kevin, Alan & Mandy, Request you to review this fix: Webrev: http://cr.openjdk.java.net/~arapte/fx/8195800/webrev.00/ JBS: https://bugs.openjdk.java.net/browse/JDK-8195800 Regards, Ambarish

Re: JDK-8130379: Enhance the Bounds class with getCenter method

Hi Kevin, I didn't see any opinions after a week. Please look at the webrev for: https://bugs.openjdk.java.net/browse/JDK-8130379 http://cr.openjdk.java.net/~nlisker/8130379/webrev.00/ I'm still slightly in favor of having the 2D and 3D center methods, but the webrev does not contain them.

Re: Proposal For Inclusion of Robot and ParametersImpl in the Public API

Ping :) On Mon, Jan 8, 2018 at 4:28 PM, Kevin Rushforth wrote: > I'll take a look some time after RDP2 of JDK 10. > > > -- Kevin > > > Michael Ennen wrote: > > Hey Kevin, > > Hope you had a good holiday. Hopefully you will get some time in the > coming weeks > to

Re: [11] RFR : JDK-8195800 : Eliminate dependency on sun.reflect.misc in javafx modules

On 3/19/18 7:10 AM, Ambarish Rapte wrote: Hi Kevin, Alan & Mandy,     Request you to review this fix:     Webrev: http://cr.openjdk.java.net/~arapte/fx/8195800/webrev.00/     JBS:

Re: [11] RFR : JDK-8195800 : Eliminate dependency on sun.reflect.misc in javafx modules

This looks good to me, too, with one comment: The three new files have DOS line endings. Please convert to UNIX-style line endings, else it will fail jcheck (and fail the tools/scripts/checkWhiteSpace). -- Kevin mandy chung wrote: On 3/19/18 7:10 AM, Ambarish Rapte wrote: Hi Kevin,

Gradle wrappers

Hi, Using Gradle wrappers has been discussed a number of times, but there was never a clear resolution afaik. Andres opened an issue for using gradle wrappers: https://github.com/javafxports/openjdk-jfx/issues/23 I personally like gradle wrappers myself, it makes it easier to automate builds