[11] Review request : JDK-8185854 : [JavaFX 9] NPE on non-editable ComboBox in TabPane with custom Skin

Hi, Please review below fix. Bug : https://bugs.openjdk.java.net/browse/JDK-8185854 Fix : http://cr.openjdk.java.net/~aghaisas/fx/8185854/webrev.0/ Request you to review. Regards, Ajit

Re: OpenJFX GitHub mirror

Any further comments on this? If not, then I propose we start using the JBS label: github-bug To identify JBS issues that are linked to guthub issues and/or PRs -- Kevin Nir Lisker wrote: I think that the labels should be succinct, so one label should suffice. Either github-link or githu

Re: OpenJFX GitHub mirror

+1 On Wed, Apr 4, 2018 at 3:30 PM Kevin Rushforth wrote: > Any further comments on this? If not, then I propose we start using the > JBS label: > > github-bug > > To identify JBS issues that are linked to guthub issues and/or PRs > > -- Kevin > > > Nir Lisker wrote: > > I think that the labe

CSSParser Color.parse() for unexpected CSS properties

Hi all, (first post). I was profiling our PROD JavaFX application recently I discovered something rather peculiar in the CSSParser. (jdk1.8.0_151) I noticed several hundred IllegalArgumentExceptions on the JavaApplicationThread where for various unrelated css properties the CSSParser is trying to

Re: CSSParser Color.parse() for unexpected CSS properties

The parser doesn't have any concept of what the property is or value it might have. This allows the addition of new properties (such as an user might add for their own CSS styles) without having to modify the parser to handle them. On 4/4/18 10:03 AM, Matthew Elliot wrote: Hi all, (first pos

Re: CSSParser Color.parse() for unexpected CSS properties

Hi David, thanks for the quick response, the parser does seem to have knowledge of the property and values as in the method ... ParsedValueImpl valueFor(String property, Term root, CSSLexer lexer) throws ParseException {} it looks for particular properties for parsing... e.g. } else if ("-fx-bac

Re: CSSParser Color.parse() for unexpected CSS properties

On 4/4/18 10:44 AM, Matthew Elliot wrote: Hi David, thanks for the quick response, the parser does seem to have knowledge of the property and values as in the method ... ParsedValueImpl valueFor(String property, Term root, CSSLexer lexer)throws ParseException {} it looks for particular propert

Re: CSSParser Color.parse() for unexpected CSS properties

Hey David, thanks. I have filed a bug via the Oracle website. internal review ID : 9053225 Hopefully this was correct as it was also my first time. Matt On 4 April 2018 at 17:21, David Grieve wrote: > On 4/4/18 10:44 AM, Matthew Elliot wrote: > > Hi David, thanks for the quick response, the p

Re: CSSParser Color.parse() for unexpected CSS properties

Hi Matt, Thank you for filing this bug. Can you provide a standalone test case that reproduces this (a .java and a .css file), so we can attach it to the bug? Our WebBugs triage engineer will ask for this, and it will save time if you can provide it now. Otherwise the bug report looks fine.

Re: OpenJFX GitHub mirror

github-bug is fine by me. What about external links, name them or leave them as URLs? On Wed, Apr 4, 2018, 16:43 Johan Vos wrote: > +1 > > On Wed, Apr 4, 2018 at 3:30 PM Kevin Rushforth > wrote: > >> Any further comments on this? If not, then I propose we start using the >> JBS label: >> >>

Re: OpenJFX GitHub mirror

I don't have a strong preference. The URL contains either "issue" or "pull" already, so there should be no confusion if we just use the URL. -- Kevin Nir Lisker wrote: github-bug is fine by me. What about external links, name them or leave them as URLs? On Wed, Apr 4, 2018, 16:43 Johan Vos

RE: Add missing styleable properties to ImageView?

I'd say position, size, color, etc are all part of the design and CSS is about design so this type of properties should be accessible via CSS. I don't see why JavaFX should be any different from the web CSS, in this respect. There's something I'd like to bring to your attention, we already have

gradle :web:test fails

I'm running :web:test in revision 10889 and getting the following failing test: test.javafx.scene.web.MiscellaneousTest > testUserAgentString FAILED java.lang.AssertionError: UserAgentString does not contain JavaFX/11 at org.junit.Assert.fail(Assert.java:91) at org.junit.Assert

Re: JDK-8199560: Dynamic evaluation for binding.When

I don't see any opinions, so should I investigate option 2? - Nir On Thu, Mar 29, 2018 at 4:36 AM, Kevin Rushforth wrote: > Breaking existing apps is the one thing I worried about with the > suggestion of doing it without API changes. So to summarize I think there > are three possiblities: > >

RE: gradle :web:test fails

Hi Lisker, Can you print the value of useragentString ? Looks like you are using fxversion as 11 (you can print this value from System.getProperty("javafx.runtime.version");) but the useragentstring does not contain 11. final WebView webView = new WebView(); final WebEngine webEngine = webV

RE: CFV: New OpenJFX Committer: Rajath Kamath

Vote: Yes -Original Message- From: Guru Sent: Tuesday, April 03, 2018 2:12 PM To: Kevin Rushforth Cc: openjfx-dev@openjdk.java.net Subject: Re: CFV: New OpenJFX Committer: Rajath Kamath Vote: YES > On 29-Mar-2018, at 10:12 PM, Kevin Rushforth > wrote: > > I hereby nominate Rajath Ka

RE: gradle :web:test fails

Hi Lisker, +one more point: I think you are not compiling webkit . The command "gradle :web:test" picks the webkit dll from JDK (which can have older versions like 10 / 9) . You can compile webkit with command " gradle -PCOMPILE_WEBKIT=true :web:test" and in this case webkit dll will be pic