Re: [Rev 02] RFR: 8200224: Multiple press event when JFXPanel gains focus

2019-11-26 Thread Florian Kirmaier
On Wed, 13 Nov 2019 21:53:13 GMT, Kevin Rushforth wrote: > On Tue, 12 Nov 2019 10:23:16 GMT, Florian Kirmaier > wrote: > >> The pull request has been updated with additional changes. >> >> >> >> Added commits: >> - 5cd96a56: JDK-8200224 >> >> Changes: >> - all:

Re: RFR: 8193445: JavaFX CSS is applied redundantly leading to significant performance degradation

2019-11-26 Thread Geoff
On Tue, 26 Nov 2019 09:22:02 GMT, Ajit Ghaisas wrote: > On Tue, 26 Nov 2019 09:22:01 GMT, David Grieve wrote: > >> On Tue, 26 Nov 2019 09:22:01 GMT, Ajit Ghaisas wrote: >> >>> On Tue, 19 Nov 2019 14:29:16 GMT, David Grieve >>> wrote: >>> On Tue, 19 Nov 2019 10:48:52 GMT, Ajit Ghaisas

Re: RFR: 8200224: Multiple press event when JFXPanel gains focus

2019-11-26 Thread Kevin Rushforth
On Tue, 29 Oct 2019 11:27:35 GMT, Florian Kirmaier wrote: > Original PR: https://github.com/javafxports/openjdk-jfx/pull/591 > > A side effect of JDK-8200224 is, that the first click on a JFXPanel is always > a double click. > The cause for JDK-8200224 is the fix for JDK-8087914 (Clicking on

Re: RFR: 8200224: Multiple press event when JFXPanel gains focus

2019-11-26 Thread Kevin Rushforth
On Tue, 26 Nov 2019 09:23:59 GMT, Florian Kirmaier wrote: > On Wed, 13 Nov 2019 22:11:14 GMT, Kevin Rushforth wrote: > >> On Wed, 13 Nov 2019 01:17:44 GMT, Kevin Rushforth wrote: >> >>> On Tue, 12 Nov 2019 10:35:36 GMT, Florian Kirmaier >>> wrote: >>> On Wed, 6 Nov 2019 08:30:47

Re: [Rev 03] RFR: 8200224: Multiple press event when JFXPanel gains focus

2019-11-26 Thread Kevin Rushforth
On Tue, 26 Nov 2019 09:23:58 GMT, Florian Kirmaier wrote: > The pull request has been updated with a complete new set of changes > (possibly due to a rebase). > > > > Commits: > - 44774dfb: JDK-8200224 > - d1309fb6: JDK-8200224 > - 53a66b8f: JDK-8200224 > - 0be3cb5b:

Re: [Rev 03] RFR: 8200224: Multiple press event when JFXPanel gains focus

2019-11-26 Thread Florian Kirmaier
The pull request has been updated with a complete new set of changes (possibly due to a rebase). Commits: - 44774dfb: JDK-8200224 - d1309fb6: JDK-8200224 - 53a66b8f: JDK-8200224 - 0be3cb5b: JDK-8200224 - 03b59288: Merge branch 'master' of https://github.com/openjdk/jfx

Re: RFR: 8193445: JavaFX CSS is applied redundantly leading to significant performance degradation

2019-11-26 Thread Ajit Ghaisas
On Tue, 19 Nov 2019 14:29:16 GMT, David Grieve wrote: > On Tue, 19 Nov 2019 10:48:52 GMT, Ajit Ghaisas wrote: > >> On Fri, 15 Nov 2019 09:14:04 GMT, Ajit Ghaisas wrote: >> >>> On Thu, 14 Nov 2019 18:33:05 GMT, Kevin Rushforth wrote: >>> On Tue, 12 Nov 2019 16:45:04 GMT, Ajit Ghaisas

Re: RFR: 8193445: JavaFX CSS is applied redundantly leading to significant performance degradation

2019-11-26 Thread Ajit Ghaisas
On Tue, 26 Nov 2019 09:22:02 GMT, Geoff wrote: > On Tue, 26 Nov 2019 09:22:02 GMT, Ajit Ghaisas wrote: > >> On Tue, 26 Nov 2019 09:22:01 GMT, David Grieve wrote: >> >>> On Tue, 26 Nov 2019 09:22:01 GMT, Ajit Ghaisas wrote: >>> On Tue, 19 Nov 2019 14:29:16 GMT, David Grieve

Re: RFR: 8193445: JavaFX CSS is applied redundantly leading to significant performance degradation

2019-11-26 Thread Kevin Rushforth
On Tue, 12 Nov 2019 16:45:04 GMT, Ajit Ghaisas wrote: > **Issue :** > https://bugs.openjdk.java.net/browse/JDK-8193445 > > **Background :** > The CSS performance improvement done in > [JDK-8151756](https://bugs.openjdk.java.net/browse/JDK-8151756) had to be > backed out due to functional

Re: [Approved] RFR: 8193445: JavaFX CSS is applied redundantly leading to significant performance degradation

2019-11-26 Thread David Grieve
On Tue, 12 Nov 2019 16:45:04 GMT, Ajit Ghaisas wrote: > **Issue :** > https://bugs.openjdk.java.net/browse/JDK-8193445 > > **Background :** > The CSS performance improvement done in > [JDK-8151756](https://bugs.openjdk.java.net/browse/JDK-8151756) had to be > backed out due to functional

Re: RFR: 8193445: JavaFX CSS is applied redundantly leading to significant performance degradation

2019-11-26 Thread Ajit Ghaisas
On Tue, 26 Nov 2019 09:22:01 GMT, David Grieve wrote: > On Tue, 26 Nov 2019 09:22:01 GMT, Ajit Ghaisas wrote: > >> On Tue, 19 Nov 2019 14:29:16 GMT, David Grieve >> wrote: >> >>> On Tue, 19 Nov 2019 10:48:52 GMT, Ajit Ghaisas wrote: >>> On Fri, 15 Nov 2019 09:14:04 GMT, Ajit Ghaisas

Re: RFR: 8193445: JavaFX CSS is applied redundantly leading to significant performance degradation

2019-11-26 Thread David Grieve
On Tue, 26 Nov 2019 09:22:01 GMT, Ajit Ghaisas wrote: > On Tue, 19 Nov 2019 14:29:16 GMT, David Grieve > wrote: > >> On Tue, 19 Nov 2019 10:48:52 GMT, Ajit Ghaisas wrote: >> >>> On Fri, 15 Nov 2019 09:14:04 GMT, Ajit Ghaisas wrote: >>> On Thu, 14 Nov 2019 18:33:05 GMT, Kevin

Re: [Rev 01] RFR: 8193445: JavaFX CSS is applied redundantly leading to significant performance degradation

2019-11-26 Thread Ajit Ghaisas
The pull request has been updated with additional changes. Added commits: - 2054da4c: Address review comments on test - 4dade6e5: Simpler fix + System test corrections - bd4a306a: Revert commit1 and commit 2 Changes: - all: https://git.openjdk.java.net/jfx/pull/34/files

Re: [Rev 03] RFR: 8200224: Multiple press event when JFXPanel gains focus

2019-11-26 Thread Florian Kirmaier
On Tue, 26 Nov 2019 09:24:01 GMT, Kevin Rushforth wrote: > On Tue, 26 Nov 2019 09:23:58 GMT, Florian Kirmaier > wrote: > >> The pull request has been updated with a complete new set of changes >> (possibly due to a rebase). >> >> >> >> Commits: >> - 44774dfb: JDK-8200224

Re: RFR: 8200224: Multiple press event when JFXPanel gains focus

2019-11-26 Thread Florian Kirmaier
On Tue, 26 Nov 2019 09:24:01 GMT, Kevin Rushforth wrote: > On Tue, 29 Oct 2019 11:27:35 GMT, Florian Kirmaier > wrote: > >> Original PR: https://github.com/javafxports/openjdk-jfx/pull/591 >> >> A side effect of JDK-8200224 is, that the first click on a JFXPanel is >> always a double click.

Re: RFR: 8193445: JavaFX CSS is applied redundantly leading to significant performance degradation

2019-11-26 Thread Sverre Moe
On Tue, 26 Nov 2019 09:22:04 GMT, Kevin Rushforth wrote: > On Tue, 12 Nov 2019 16:45:04 GMT, Ajit Ghaisas wrote: > >> **Issue :** >> https://bugs.openjdk.java.net/browse/JDK-8193445 >> >> **Background :** >> The CSS performance improvement done in >>

Re: RFR: 8200224: Multiple press event when JFXPanel gains focus

2019-11-26 Thread Kevin Rushforth
On Tue, 26 Nov 2019 13:06:38 GMT, Florian Kirmaier wrote: > On Tue, 26 Nov 2019 09:24:01 GMT, Kevin Rushforth wrote: > >> On Tue, 29 Oct 2019 11:27:35 GMT, Florian Kirmaier >> wrote: >> >>> Original PR: https://github.com/javafxports/openjdk-jfx/pull/591 >>> >>> A side effect of

Re: [Rev 04] RFR: 8200224: Multiple press event when JFXPanel gains focus

2019-11-26 Thread Florian Kirmaier
The pull request has been updated with additional changes. Added commits: - 24385eb8: JDK-8200224 - e0829ad3: JDK-8200224 - c190384f: JDK-8200224 - 17b458b1: JDK-8200224 Changes: - all: https://git.openjdk.java.net/jfx/pull/25/files - new:

RFR: 8196587: Remove use of deprecated finalize method from JPEGImageLoader

2019-11-26 Thread Ambarish Rapte
The finalize() method is deprecated in JDK9. See [Java 9 deprecated features](https://www.oracle.com/technetwork/java/javase/9-deprecated-features-3745636.html). And so the JPEGImageLoader.finalize() method should be removed. The change is, 1. Remove finalize method from JPEGImageLoader class.

Re: RFR: 8196587: Remove use of deprecated finalize method from JPEGImageLoader

2019-11-26 Thread Kevin Rushforth
On Tue, 26 Nov 2019 15:16:38 GMT, Ambarish Rapte wrote: > The finalize() method is deprecated in JDK9. See [Java 9 deprecated > features](https://www.oracle.com/technetwork/java/javase/9-deprecated-features-3745636.html). > And so the JPEGImageLoader.finalize() method should be removed. > >

Re: [Rev 02] RFR: 8130738: TextFlow's tab width is static

2019-11-26 Thread Scott Palmer
The pull request has been updated with a complete new set of changes (possibly due to a rebase). Commits: - 254c40de: Merge remote-tracking branch 'upstream/master' - a670c4f8: 8130738: TextFlow's tab width is static - 68d221c7: 8130738: TextFlow's tab width is static

Re: [Approved] RFR: 8193445: JavaFX CSS is applied redundantly leading to significant performance degradation

2019-11-26 Thread Kevin Rushforth
On Tue, 26 Nov 2019 09:22:01 GMT, Ajit Ghaisas wrote: > The pull request has been updated with additional changes. > > > > Added commits: > - 2054da4c: Address review comments on test > - 4dade6e5: Simpler fix + System test corrections > - bd4a306a: Revert commit1 and

Re: RFR: 8130738: TextFlow's tab width is static

2019-11-26 Thread Scott Palmer
On Thu, 7 Nov 2019 14:56:58 GMT, Kevin Rushforth wrote: > On Wed, 6 Nov 2019 19:11:48 GMT, Scott Palmer wrote: > >> Added tabSize property to Text and TextFlow and -fx-tab-size CSS attribute >> to both. TextFlow's tab size overrides that of contained Text nodes. >> >> >>

Re: RFR: 8130738: TextFlow's tab width is static

2019-11-26 Thread Kevin Rushforth
On Tue, 26 Nov 2019 18:40:10 GMT, Scott Palmer wrote: > On Thu, 7 Nov 2019 14:56:58 GMT, Kevin Rushforth wrote: > >> On Wed, 6 Nov 2019 19:11:48 GMT, Scott Palmer wrote: >> >>> Added tabSize property to Text and TextFlow and -fx-tab-size CSS attribute >>> to both. TextFlow's tab size

Re: [Rev 02] RFR: 8130738: TextFlow's tab width is static

2019-11-26 Thread Phil Race
On Tue, 26 Nov 2019 17:26:33 GMT, Scott Palmer wrote: > The pull request has been updated with a complete new set of changes > (possibly due to a rebase). > > > > Commits: > - 254c40de: Merge remote-tracking branch 'upstream/master' > - a670c4f8: 8130738: TextFlow's tab

Re: [Integrated] RFR: 8230610: Upgrade GStreamer to the latest 1.16.1

2019-11-26 Thread Alexander Matveev
Changeset: 798afbca Author:Alexander Matveev Date: 2019-11-26 22:33:00 + URL: https://git.openjdk.java.net/jfx/commit/798afbca 8230610: Upgrade GStreamer to version 1.16.1 8230609: Upgrade glib to version 2.62.2 Reviewed-by: kcr, jvos !

Re: [Integrated] RFR: 8193445: JavaFX CSS is applied redundantly leading to significant performance degradation

2019-11-26 Thread Ajit Ghaisas
Changeset: 83eb0a7c Author:Ajit Ghaisas Date: 2019-11-27 07:05:15 + URL: https://git.openjdk.java.net/jfx/commit/83eb0a7c 8193445: JavaFX CSS is applied redundantly leading to significant performance degradation Reviewed-by: kcr, dgrieve !

Re: [Rev 04] RFR: 8200224: Multiple press event when JFXPanel gains focus

2019-11-26 Thread Prasanta Sadhukhan
On Tue, 26 Nov 2019 13:06:36 GMT, Florian Kirmaier wrote: > The pull request has been updated with additional changes. > > > > Added commits: > - 24385eb8: JDK-8200224 > - e0829ad3: JDK-8200224 > - c190384f: JDK-8200224 > - 17b458b1: JDK-8200224 > > Changes: > - all:

Re: [Approved] RFR: 8200224: Multiple press event when JFXPanel gains focus

2019-11-26 Thread Kevin Rushforth
On Tue, 26 Nov 2019 13:06:36 GMT, Florian Kirmaier wrote: > The pull request has been updated with additional changes. > > > > Added commits: > - 24385eb8: JDK-8200224 > - e0829ad3: JDK-8200224 > - c190384f: JDK-8200224 > - 17b458b1: JDK-8200224 > > Changes: > - all:

Re: [Rev 02] RFR: 8130738: TextFlow's tab width is static

2019-11-26 Thread Kevin Rushforth
On Tue, 26 Nov 2019 17:26:33 GMT, Scott Palmer wrote: > The pull request has been updated with a complete new set of changes > (possibly due to a rebase). > > > > Commits: > - 254c40de: Merge remote-tracking branch 'upstream/master' > - a670c4f8: 8130738: TextFlow's tab

Re: RFR: 8130738: Add tabSize property to Text and TextFlow

2019-11-26 Thread Scott Palmer
On Tue, 26 Nov 2019 18:48:38 GMT, Kevin Rushforth wrote: > On Tue, 26 Nov 2019 18:40:10 GMT, Scott Palmer wrote: > >> On Thu, 7 Nov 2019 14:56:58 GMT, Kevin Rushforth wrote: >> >>> On Wed, 6 Nov 2019 19:11:48 GMT, Scott Palmer wrote: >>> Added tabSize property to Text and TextFlow and

Re: RFR: 8130738: Add tabSize property to Text and TextFlow

2019-11-26 Thread Kevin Rushforth
On Wed, 27 Nov 2019 01:17:42 GMT, Scott Palmer wrote: > On Tue, 26 Nov 2019 18:48:38 GMT, Kevin Rushforth wrote: > >> On Tue, 26 Nov 2019 18:40:10 GMT, Scott Palmer wrote: >> >>> On Thu, 7 Nov 2019 14:56:58 GMT, Kevin Rushforth wrote: >>> On Wed, 6 Nov 2019 19:11:48 GMT, Scott Palmer

Re: [Approved] RFR: 8200224: Multiple press event when JFXPanel gains focus

2019-11-26 Thread Prasanta Sadhukhan
On Tue, 26 Nov 2019 13:06:36 GMT, Florian Kirmaier wrote: > The pull request has been updated with additional changes. > > > > Added commits: > - 24385eb8: JDK-8200224 > - e0829ad3: JDK-8200224 > - c190384f: JDK-8200224 > - 17b458b1: JDK-8200224 > > Changes: > - all: