On 23.01.2020 18:09, Anthony Vanelverdinghe wrote:
> On 22/01/2020 18:52, Rony G. Flatscher wrote:
... cut ...
>> Maybe one more question: there would be an optimization possible by
>> compiling scripts for script
>> engines that have the javax.script.Compilable interface implemented and use
>>
This PR defines a pre-processor in the phong frag files to avoid inline
declaration of #extension when several frags are combined that leads to the
error:
syntax error: #extension must always be before any non-preprocessor tokens
-
Commits:
- 14ccbe6a: Define pre-processor in
On Fri, 24 Jan 2020 14:41:00 GMT, Guru Hb wrote:
>> Previous commits in this pull request have been removed, probably due to a
>> force push. The incremental views will show differences compared to the
>> previous content of the PR.
>
> Marked as reviewed by ghb (Reviewer).
@effad you can
The Skara team has implemented SKARA-217 [1] to allow for increasing the
number of reviewers before it will mark a PR as ready for integration.
Starting from now, any "R"eviewer (that is, someone with a Reviewer role
in the OpenJFX Project) can indicate that a PR needs 2 reviewers (or
perhaps
On Fri, 17 Jan 2020 23:18:28 GMT, Kevin Rushforth wrote:
>> Previous commits in this pull request have been removed, probably due to a
>> force push. The incremental views will show differences compared to the
>> previous content of the PR.
>
> Looks good to me.
>
> @guruhb can you re-review
On Fri, 24 Jan 2020 14:41:11 GMT, Robert Lichtenberger
wrote:
>> As documented in JDK-8236912, WebView did not check whether the idMap really
>> contained a mapping for the given button, making it prone to errors, when
>> things are extended (as has happened here).
>>
>> The fix consists of
Changeset: da99e248
Author:Kevin Rushforth
Date: 2020-01-24 16:54:57 +
URL: https://git.openjdk.java.net/jfx/commit/da99e248
8237823: Mark TextTest.testTabSize as unstable
Reviewed-by: prr
! modules/javafx.graphics/src/test/java/test/javafx/scene/text/TextTest.java
Check if the glyph will fit before trying to cache it.
-
Commits:
- fbfb2473: 8237833: Check glyph size before adding to glyph texture cache
Changes: https://git.openjdk.java.net/jfx/pull/96/files
Webrev: https://webrevs.openjdk.java.net/jfx/96/webrev.00
Issue:
On Fri, 24 Jan 2020 15:12:50 GMT, Kevin Rushforth wrote:
> Fix for [JDK-8237823](https://bugs.openjdk.java.net/browse/JDK-8237823).
>
> The javafx.graphics unit test `TextTest.testTabSize` fails intermittently --
> see [JDK-8236728](https://bugs.openjdk.java.net/browse/JDK-8236728).
>
> This
Just filed a RFE with the following information:
* Component:
o JavaFX
* Subcomponent:
o fxml: JavaFX FXML
* Synopsis:
o "FXMLLoader: if script engines implement javax.script.Compilabel
compile scripts"
* Descriptions:
o "FXMLLoader is able to execute scripts
Thank you for filing this enhancement request. As an enhancement it
should be discussed on this list before proceeding with a pull request
(although a "WIP" or Draft PR can be used to illustrate the concept).
For my part, this seems like a reasonable enhancement, as long as there
are no
Hi Rony,
This bug was transferred to the JDK project on 28-Nov-2019. I don't know
why you didn't get an email at that time, but I will inquire of the team
who processes incoming bugs.
Also, I'll keep an eye out for the RFE you filed today, and let you know
when it is transferred in case
On Fri, 24 Jan 2020 16:26:38 GMT, Frederic Thevenet
wrote:
>> Here are the results when running JavaFX 14-ea+7.
>> The columns of the table correspond the width of the target snapshot, while
>> the rows correspond to the height and the content of the cells is the
>> average time* spent (in
On Fri, 24 Jan 2020 16:03:39 GMT, Frederic Thevenet
wrote:
>> I've put together a small benchmark to measure the time it takes to
>> snapshots into images of sizes varying from 1024*1024 to 8192*8192, by
>> increment of 1024 in each dimension, which you can find here:
>>
Changeset: 9ae37f1f
Author:Nir Lisker
Date: 2020-01-22 20:58:12 +
URL: https://git.openjdk.java.net/jfx/commit/9ae37f1f
8236753: Animations do not play backwards after being stopped
Reviewed-by: kcr, arapte
!
… the available font data.
-
Commits:
- 059ec788: 8237782: Only read advances up to the minimum of the numHorMetrics
or the available font data.
Changes: https://git.openjdk.java.net/jfx/pull/95/files
Webrev: https://webrevs.openjdk.java.net/jfx/95/webrev.00
Issue:
On Fri, 24 Jan 2020 15:43:25 GMT, Robert Lichtenberger
wrote:
>> Test simulates a single mouse-released event.
>> Fix simply guards against the null case.
>
> The pull request has been updated with 1 additional commit.
This is a simple enough change that 1 reviewer will suffice -- @arapte
On Tue, 21 Jan 2020 21:53:29 GMT, Kevin Rushforth wrote:
>>>
>>>
>>> Looks good to me.
>>> Below is just an observation about time taken by the API,
>>> Platform: Windows10, `maxTextureSize`: 4096
>>> For a snapshot of (4096 * n, 4096 * n): each call to `doSnapshotTile()`
>>> takes ~100 ms,
Fix for [JDK-8237823](https://bugs.openjdk.java.net/browse/JDK-8237823).
The javafx.graphics unit test `TextTest.testTabSize` fails intermittently --
see [JDK-8236728](https://bugs.openjdk.java.net/browse/JDK-8236728).
This PR marks `TextTest.testTabSize` as unstable, meaning it will not be run
On Fri, 24 Jan 2020 16:34:29 GMT, Nir Lisker wrote:
>> And here are the results with the change in this PR, on the same machine
>> under Windows 10:
>>
>> || 1024 |2048 |3072 |4096 |5120 |6144 |7168 |8192 |
>> |---|---|---|---|---|---|---|---|---|
>> | 1024 | 6.957774 | 10.461498 |
Changeset: da99e248
Author:Kevin Rushforth
Date: 2020-01-24 16:54:57 +
URL: https://git.openjdk.java.net/jfx/commit/da99e248
8237823: Mark TextTest.testTabSize as unstable
Reviewed-by: prr
! modules/javafx.graphics/src/test/java/test/javafx/scene/text/TextTest.java
On Fri, 24 Jan 2020 15:55:50 GMT, Frederic Thevenet
wrote:
>> I haven't done any testing yet, but I have two comments on the patch:
>>
>> 1. Using the clamped texture size as the upper limit is the right thing to
>> do, but `Prism.maxTexture` isn't guaranteed to be that size. The
>>
On Fri, 24 Jan 2020 15:12:50 GMT, Kevin Rushforth wrote:
> Fix for [JDK-8237823](https://bugs.openjdk.java.net/browse/JDK-8237823).
>
> The javafx.graphics unit test `TextTest.testTabSize` fails intermittently --
> see [JDK-8236728](https://bugs.openjdk.java.net/browse/JDK-8236728).
>
> This
On Fri, 24 Jan 2020 16:55:47 GMT, Frederic Thevenet
wrote:
>>> Here are the results when running JavaFX 14-ea+7.
>>> The columns of the table correspond the width of the target snapshot, while
>>> the rows correspond to the height and the content of the cells is the
>>> average time* spent
Hi everyone,
I’m new to the list, so by way of a short introduction, I’ve been working with
JavaFX for the last 4 years developing a commodities trading risk management
system from the ground up for a software company I co-founded in London. All
our code is written in Scala, the functional
25 matches
Mail list logo
